direct-cli 0.2.4__tar.gz → 0.2.5__tar.gz

{direct_cli-0.2.4 → direct_cli-0.2.5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: direct-cli
-Version: 0.2.4
+Version: 0.2.5
 Summary: Command-line interface for Yandex Direct API
 Author: axisrow
 License: MIT

{direct_cli-0.2.4 → direct_cli-0.2.5}/direct_cli/commands/adextensions.py

@@ -68,11 +68,14 @@ def get(ctx, ids, types, limit, fetch_all, output_format, output, fields):
 @click.option(
     "--type",
     "ext_type",
-    required=True,
     help=(
-        "Extension type (UX hint — Callout, Sitelinks, Vcard, …). "
-        "Not sent to the API; the API derives the type from the nested "
-        "field name inside --json."
+        "Legacy UX hint; NOT forwarded to the API. The Yandex Direct "
+        "API derives the extension type from the nested field name "
+        "inside --json (Callout / Sitelinks / Vcard / ...), so the "
+        "only flag that actually matters is --json.  Previously this "
+        "option was required=True but silently discarded, which "
+        "forced every caller to pass a value that did nothing.  See "
+        "axisrow/direct-cli#25."
     ),
 )
 @click.option("--json", "extra_json", required=True, help="Extension data in JSON")
@@ -88,7 +91,7 @@ def add(ctx, ext_type, extra_json, dry_run):
     ``{"Type": ext_type, ...}`` and the sandbox rejected the extra
     key as ``unknown parameter Type``.
     """
-    _ = ext_type  # consumed only for argument validation / UX clarity
+    _ = ext_type  # intentionally unused — kept as UX hint only
     try:
         ext_data = json.loads(extra_json)
 

{direct_cli-0.2.4 → direct_cli-0.2.5}/direct_cli/commands/adgroups.py

@@ -84,7 +84,18 @@ def get(
 @adgroups.command()
 @click.option("--name", required=True, help="Ad group name")
 @click.option("--campaign-id", required=True, type=int, help="Campaign ID")
-@click.option("--type", "group_type", default="TEXT_AD_GROUP", help="Ad group type")
+@click.option(
+    "--type",
+    "group_type",
+    default="TEXT_AD_GROUP",
+    help=(
+        "Ad group type (case-insensitive). The Yandex Direct API derives "
+        "the group type from nested objects (MobileAppAdGroup / "
+        "DynamicTextAdGroup / SmartAdGroup / ...), not from a top-level "
+        "Type discriminator. Convenience flags only build a TEXT_AD_GROUP; "
+        "for other types pass the matching nested object via --json."
+    ),
+)
 @click.option("--region-ids", help="Comma-separated region IDs")
 @click.option("--json", "extra_json", help="Additional JSON parameters")
 @click.option("--dry-run", is_flag=True, help="Show request without sending")
@@ -96,12 +107,21 @@ def add(ctx, name, campaign_id, group_type, region_ids, extra_json, dry_run):
         # AdGroupAddItem — the group type is inferred from the presence of
         # MobileAppAdGroup / DynamicTextAdGroup / SmartAdGroup / etc.
         # sub-objects, exactly like Ads (see fix in commands/ads.py).
-        # The --type CLI option is preserved for backward compatibility but
-        # is no longer forwarded to the API; users wanting non-text group
-        # types must pass the matching sub-object via --json.
+        # Previously --type was accepted but silently discarded — users
+        # passing --type MOBILE_APP_AD_GROUP got a TEXT_AD_GROUP with no
+        # warning.  Now we normalize case and fail loudly if the caller
+        # asks for anything except TEXT_AD_GROUP.  See axisrow/direct-cli#23.
         # Refs: https://yandex.ru/dev/direct/doc/ref-v5/adgroups/add.html
+        group_type_norm = (group_type or "TEXT_AD_GROUP").upper().replace("-", "_")
+
+        if group_type_norm != "TEXT_AD_GROUP" and not extra_json:
+            raise click.UsageError(
+                f"--type {group_type} requires --json with the "
+                f"ad-group-type-specific nested object "
+                f"(e.g. DynamicTextAdGroup, SmartAdGroup, MobileAppAdGroup)."
+            )
+
         adgroup_data = {"Name": name, "CampaignId": campaign_id}
-        _ = group_type  # acknowledged-but-unused
 
         if region_ids:
             adgroup_data["RegionIds"] = parse_ids(region_ids)
@@ -125,6 +145,8 @@ def add(ctx, name, campaign_id, group_type, region_ids, extra_json, dry_run):
         result = client.adgroups().post(data=body)
         format_output(result().extract(), "json", None)
 
+    except click.UsageError:
+        raise
     except Exception as e:
         print_error(str(e))
         raise click.Abort()

{direct_cli-0.2.4 → direct_cli-0.2.5}/direct_cli/commands/ads.py

@@ -107,20 +107,47 @@ def get(
 
 @ads.command()
 @click.option("--adgroup-id", required=True, type=int, help="Ad group ID")
-@click.option("--type", "ad_type", default="TEXT_AD", help="Ad type")
-@click.option("--title", help="Ad title")
-@click.option("--text", help="Ad text")
-@click.option("--href", help="Ad URL")
+@click.option(
+    "--type",
+    "ad_type",
+    default="TEXT_AD",
+    help=(
+        "Ad type (case-insensitive). The convenience flags "
+        "--title/--text/--href only build a payload for TEXT_AD. "
+        "For other ad types (e.g. TEXT_IMAGE_AD, MOBILE_APP_AD) "
+        "pass the nested object via --json."
+    ),
+)
+@click.option("--title", help="Ad title (TEXT_AD only)")
+@click.option("--text", help="Ad text (TEXT_AD only)")
+@click.option("--href", help="Ad URL (TEXT_AD only)")
 @click.option("--json", "extra_json", help="Additional JSON parameters")
 @click.option("--dry-run", is_flag=True, help="Show request without sending")
 @click.pass_context
 def add(ctx, adgroup_id, ad_type, title, text, href, extra_json, dry_run):
     """Add new ad"""
     try:
+        # Normalize --type so case variants and hyphen forms (``text_ad``,
+        # ``text-ad``) behave the same as ``TEXT_AD``.  Without this
+        # normalization, the previous implementation silently dropped
+        # --title/--text/--href for any value other than the exact
+        # string ``"TEXT_AD"`` and the API responded with the very
+        # misleading ``5008 None of the required fields were sent``
+        # error — see axisrow/direct-cli#21.
+        ad_type_norm = (ad_type or "TEXT_AD").upper().replace("-", "_")
+        has_convenience_flags = any([title, text, href])
+
+        if ad_type_norm != "TEXT_AD" and has_convenience_flags:
+            raise click.UsageError(
+                f"--type {ad_type} does not support --title/--text/--href "
+                f"(these convenience flags only build a TEXT_AD payload). "
+                f"Pass the nested ad object via --json, or use --type TEXT_AD."
+            )
+
         ad_data = {"AdGroupId": adgroup_id}
 
-        if ad_type == "TEXT_AD":
-            ad_data["TextAd"] = {}
+        if ad_type_norm == "TEXT_AD" and has_convenience_flags:
+            ad_data["TextAd"] = {"Mobile": "NO"}
             if title:
                 ad_data["TextAd"]["Title"] = title
             if text:
@@ -147,6 +174,8 @@ def add(ctx, adgroup_id, ad_type, title, text, href, extra_json, dry_run):
         result = client.ads().post(data=body)
         format_output(result().extract(), "json", None)
 
+    except click.UsageError:
+        raise
     except Exception as e:
         print_error(str(e))
         raise click.Abort()

{direct_cli-0.2.4 → direct_cli-0.2.5}/direct_cli/commands/audiencetargets.py

@@ -84,7 +84,7 @@ def add(ctx, adgroup_id, retargeting_list_id, bid, extra_json, dry_run):
             "RetargetingListId": retargeting_list_id,
         }
 
-        if bid:
+        if bid is not None:
             target_data["Bid"] = int(bid * 1000000)
 
         if extra_json:

{direct_cli-0.2.4 → direct_cli-0.2.5}/direct_cli/commands/bidmodifiers.py

@@ -136,14 +136,20 @@ def add(ctx, campaign_id, adgroup_id, modifier_type, value, extra_json, dry_run)
     """
     try:
         if (campaign_id is None) == (adgroup_id is None):
-            raise click.ClickException(
+            raise click.UsageError(
                 "Exactly one of --campaign-id or --adgroup-id is required"
             )
 
         nested_key = _BIDMODIFIER_TYPE_TO_NESTED[modifier_type.upper()]
         nested = {"BidModifier": value}
         if extra_json:
-            nested.update(json.loads(extra_json))
+            extra = json.loads(extra_json)
+            if not isinstance(extra, dict):
+                raise click.UsageError(
+                    "--json must be a JSON object (dict), "
+                    f"got {type(extra).__name__}"
+                )
+            nested.update(extra)
 
         modifier_data = {nested_key: nested}
         if campaign_id is not None:
@@ -166,31 +172,103 @@ def add(ctx, campaign_id, adgroup_id, modifier_type, value, extra_json, dry_run)
         result = client.bidmodifiers().post(data=body)
         format_output(result().extract(), "json", None)
 
+    except click.UsageError:
+        raise
     except Exception as e:
         print_error(str(e))
         raise click.Abort()
 
 
 @bidmodifiers.command()
-@click.option("--campaign-id", required=True, type=int, help="Campaign ID")
+@click.option(
+    "--id",
+    "modifier_id",
+    type=int,
+    help=(
+        "Existing BidModifier ID to update. This is the shape Yandex "
+        "Direct's ``bidmodifiers/set`` method actually supports — pass "
+        "the Id of a modifier created via ``bidmodifiers add`` and the "
+        "new ``--value``. Mutually exclusive with --campaign-id/--type."
+    ),
+)
+@click.option(
+    "--campaign-id",
+    type=int,
+    help=(
+        "Campaign ID (legacy path, broken by design — kept for "
+        "backwards compatibility and regression coverage; the API "
+        "rejects this shape with ``required field Id is omitted``). "
+        "Use --id for real updates."
+    ),
+)
 @click.option(
     "--type",
     "modifier_type",
-    required=True,
-    help="Modifier type (DEMOGRAPHICS, MOBILE, etc.)",
+    type=click.Choice(sorted(_BIDMODIFIER_TYPE_TO_NESTED.keys()), case_sensitive=False),
+    help=(
+        "Modifier category (legacy path). Uses the same enum as "
+        "``bidmodifiers add`` (MOBILE_ADJUSTMENT / DEMOGRAPHICS_ADJUSTMENT "
+        "/ ...), case-insensitive."
+    ),
 )
 @click.option("--value", type=float, required=True, help="Modifier value")
 @click.option("--json", "extra_json", help="Additional JSON parameters")
 @click.option("--dry-run", is_flag=True, help="Show request without sending")
 @click.pass_context
-def set(ctx, campaign_id, modifier_type, value, extra_json, dry_run):
-    """Set bid modifier"""
+def set(ctx, modifier_id, campaign_id, modifier_type, value, extra_json, dry_run):
+    """Set (update) an existing bid modifier
+
+    The Yandex Direct API's ``bidmodifiers/set`` method updates existing
+    modifiers by ``Id``. The correct payload shape is simply::
+
+        {"BidModifiers": [{"Id": <long>, "BidModifier": <value>}]}
+
+    To create a new modifier, use ``bidmodifiers add`` instead.
+
+    This CLI command supports two shapes:
+
+    1. **Correct shape** — pass ``--id`` + ``--value``. The request
+       body becomes exactly ``{"Id": ..., "BidModifier": ...}`` and is
+       accepted by the API.
+
+    2. **Legacy shape** (broken by design) — pass ``--campaign-id`` +
+       ``--type`` + ``--value``. The request body is
+       ``{"CampaignId": ..., "Type": ..., "BidModifier": ...}`` and the
+       API rejects it with ``required field Id is omitted``. This path
+       is preserved so the existing regression cassette in
+       ``TestWriteBidModifiersSet.test_set_without_id_is_rejected``
+       keeps passing; it also gives a clear deprecation signal to
+       callers who land on this command by mistake.
+    """
     try:
-        modifier_data = {
-            "CampaignId": campaign_id,
-            "Type": modifier_type,
-            "BidModifier": value,
-        }
+        # Validate the mutex up front.
+        if modifier_id is not None and (
+            campaign_id is not None or modifier_type is not None
+        ):
+            raise click.UsageError(
+                "--id is mutually exclusive with --campaign-id/--type. "
+                "Use --id + --value for the correct bidmodifiers/set shape."
+            )
+
+        if modifier_id is None and (campaign_id is None or modifier_type is None):
+            raise click.UsageError(
+                "Provide either --id (preferred) or both --campaign-id "
+                "and --type (legacy)."
+            )
+
+        if modifier_id is not None:
+            # Correct API shape: Id + BidModifier. Nothing else.
+            modifier_data = {"Id": modifier_id, "BidModifier": value}
+        else:
+            # Legacy broken-by-design path — kept for backwards
+            # compatibility with the existing regression test.  The
+            # click.Choice above has already validated/normalized
+            # modifier_type, so we forward it unchanged.
+            modifier_data = {
+                "CampaignId": campaign_id,
+                "Type": modifier_type,
+                "BidModifier": value,
+            }
 
         if extra_json:
             extra = json.loads(extra_json)
@@ -211,29 +289,52 @@ def set(ctx, campaign_id, modifier_type, value, extra_json, dry_run):
         result = client.bidmodifiers().post(data=body)
         format_output(result().extract(), "json", None)
 
+    except click.UsageError:
+        raise
     except Exception as e:
         print_error(str(e))
         raise click.Abort()
 
 
 @bidmodifiers.command()
-@click.option("--id", "modifier_id", required=True, type=int, help="Modifier ID")
+@click.option("--campaign-id", type=int, help="Campaign ID (mutually exclusive with --adgroup-id)")
+@click.option("--adgroup-id", type=int, help="Ad group ID (mutually exclusive with --campaign-id)")
+@click.option(
+    "--type",
+    "modifier_type",
+    required=True,
+    type=click.Choice([
+        "DEMOGRAPHICS_ADJUSTMENT",
+        "RETARGETING_ADJUSTMENT",
+        "REGIONAL_ADJUSTMENT",
+        "SERP_LAYOUT_ADJUSTMENT",
+        "INCOME_GRADE_ADJUSTMENT",
+    ], case_sensitive=False),
+    help="Adjustment type to toggle",
+)
 @click.option("--enabled/--disabled", "enabled", default=True, help="Enable or disable")
 @click.option("--dry-run", is_flag=True, help="Show request without sending")
 @click.pass_context
-def toggle(ctx, modifier_id, enabled, dry_run):
-    """Toggle bid modifier state"""
+def toggle(ctx, campaign_id, adgroup_id, modifier_type, enabled, dry_run):
+    """Toggle bid modifier state (enable/disable by type)"""
     try:
+        if not campaign_id and not adgroup_id:
+            raise click.UsageError("Either --campaign-id or --adgroup-id is required.")
+        if campaign_id and adgroup_id:
+            raise click.UsageError("Use either --campaign-id or --adgroup-id, not both.")
+
+        item = {
+            "Type": modifier_type.upper(),
+            "Enabled": "YES" if enabled else "NO",
+        }
+        if campaign_id:
+            item["CampaignId"] = campaign_id
+        else:
+            item["AdGroupId"] = adgroup_id
+
         body = {
-            "method": "set",
-            "params": {
-                "BidModifiers": [
-                    {
-                        "Id": modifier_id,
-                        "Enabled": "YES" if enabled else "NO",
-                    }
-                ]
-            },
+            "method": "toggle",
+            "params": {"BidModifierToggleItems": [item]},
         }
 
         if dry_run:
@@ -249,6 +350,8 @@ def toggle(ctx, modifier_id, enabled, dry_run):
         result = client.bidmodifiers().post(data=body)
         format_output(result().extract(), "json", None)
 
+    except click.UsageError:
+        raise
     except Exception as e:
         print_error(str(e))
         raise click.Abort()

{direct_cli-0.2.4 → direct_cli-0.2.5}/direct_cli/commands/bids.py

@@ -70,17 +70,17 @@ def get(
 
 
 @bids.command()
-@click.option("--campaign-id", required=True, type=int, help="Campaign ID")
+@click.option("--keyword-id", required=True, type=int, help="Keyword ID")
 @click.option("--bid", type=float, help="Bid amount")
 @click.option("--json", "extra_json", help="Additional JSON parameters")
 @click.option("--dry-run", is_flag=True, help="Show request without sending")
 @click.pass_context
-def set(ctx, campaign_id, bid, extra_json, dry_run):
+def set(ctx, keyword_id, bid, extra_json, dry_run):
     """Set bids"""
     try:
-        bid_data = {"CampaignId": campaign_id}
+        bid_data = {"KeywordId": keyword_id}
 
-        if bid:
+        if bid is not None:
             bid_data["Bid"] = int(bid * 1000000)
 
         if extra_json:

{direct_cli-0.2.4 → direct_cli-0.2.5}/direct_cli/commands/campaigns.py

@@ -81,7 +81,17 @@ def get(ctx, ids, status, types, limit, fetch_all, output_format, output, fields
 @campaigns.command()
 @click.option("--name", required=True, help="Campaign name")
 @click.option("--start-date", required=True, help="Start date (YYYY-MM-DD)")
-@click.option("--type", "campaign_type", default="TEXT_CAMPAIGN", help="Campaign type")
+@click.option(
+    "--type",
+    "campaign_type",
+    default="TEXT_CAMPAIGN",
+    help=(
+        "Campaign type (case-insensitive). Convenience flags only build "
+        "a TEXT_CAMPAIGN payload; for other types "
+        "(MOBILE_APP_CAMPAIGN, DYNAMIC_TEXT_CAMPAIGN, ...) pass the "
+        "matching nested object via --json."
+    ),
+)
 @click.option("--budget", type=int, help="Daily budget in currency units")
 @click.option("--end-date", help="End date (YYYY-MM-DD)")
 @click.option("--json", "extra_json", help="Additional JSON parameters")
@@ -90,17 +100,30 @@ def get(ctx, ids, status, types, limit, fetch_all, output_format, output, fields
 def add(ctx, name, start_date, campaign_type, budget, end_date, extra_json, dry_run):
     """Add new campaign"""
     try:
-        campaign_data = {
-            "Name": name,
-            "StartDate": start_date,
-            "TextCampaign": {
+        # Normalize --type so ``text_campaign`` / ``text-campaign`` /
+        # ``TEXT-CAMPAIGN`` all map to ``TEXT_CAMPAIGN``.  Previously any
+        # non-default value was silently dropped and the CLI hard-coded
+        # ``TextCampaign`` regardless — see axisrow/direct-cli#23.
+        campaign_type_norm = (
+            (campaign_type or "TEXT_CAMPAIGN").upper().replace("-", "_")
+        )
+
+        campaign_data = {"Name": name, "StartDate": start_date}
+
+        if campaign_type_norm == "TEXT_CAMPAIGN":
+            campaign_data["TextCampaign"] = {
                 "BiddingStrategy": {
                     "Search": {"BiddingStrategyType": "HIGHEST_POSITION"},
                     "Network": {"BiddingStrategyType": "SERVING_OFF"},
                 },
                 "Settings": [],
-            },
-        }
+            }
+        elif not extra_json:
+            raise click.UsageError(
+                f"--type {campaign_type} requires --json with the "
+                f"campaign-type-specific nested object "
+                f"(e.g. DynamicTextCampaign, SmartCampaign, MobileAppCampaign)."
+            )
 
         if budget:
             campaign_data["DailyBudget"] = {
@@ -130,6 +153,8 @@ def add(ctx, name, start_date, campaign_type, budget, end_date, extra_json, dry_
         result = client.campaigns().post(data=body)
         format_output(result().extract(), "json", None)
 
+    except click.UsageError:
+        raise
     except Exception as e:
         print_error(str(e))
         raise click.Abort()

{direct_cli-0.2.4 → direct_cli-0.2.5}/direct_cli/commands/feeds.py

@@ -79,14 +79,30 @@ def add(ctx, name, url, extra_json, dry_run):
     URL).  Pass ``--json`` to override for file feeds or business feeds.
     """
     try:
+        # Detect the --url / --json UrlFeed collision up front.  Without
+        # this check, ``feed_data.update(extra)`` below would silently
+        # replace the ``UrlFeed`` object built from --url with whatever
+        # the caller passed in --json, and the --url value would vanish
+        # from the request — see axisrow/direct-cli#23.
+        extra = json.loads(extra_json) if extra_json else {}
+        if not isinstance(extra, dict):
+            raise click.UsageError(
+                "--json must be a JSON object (dict), "
+                f"got {type(extra).__name__}"
+            )
+        if "UrlFeed" in extra:
+            raise click.UsageError(
+                "Pass the feed URL via exactly one of --url or "
+                "--json '{\"UrlFeed\":{...}}', not both."
+            )
+
         feed_data = {
             "Name": name,
             "SourceType": "URL",
             "UrlFeed": {"Url": url},
         }
 
-        if extra_json:
-            extra = json.loads(extra_json)
+        if extra:
             feed_data.update(extra)
 
         body = {"method": "add", "params": {"Feeds": [feed_data]}}
@@ -104,6 +120,8 @@ def add(ctx, name, url, extra_json, dry_run):
         result = client.feeds().post(data=body)
         format_output(result().extract(), "json", None)
 
+    except click.UsageError:
+        raise
     except Exception as e:
         print_error(str(e))
         raise click.Abort()
@@ -119,17 +137,31 @@ def add(ctx, name, url, extra_json, dry_run):
 def update(ctx, feed_id, name, url, extra_json, dry_run):
     """Update feed"""
     try:
+        # Mirror of the --url / --json UrlFeed collision check in
+        # ``add`` — see axisrow/direct-cli#23.  Without it, --url would
+        # be silently replaced by a UrlFeed object in --json.
+        extra = json.loads(extra_json) if extra_json else {}
+        if not isinstance(extra, dict):
+            raise click.UsageError(
+                "--json must be a JSON object (dict), "
+                f"got {type(extra).__name__}"
+            )
+        if url and "UrlFeed" in extra:
+            raise click.UsageError(
+                "Pass the feed URL via exactly one of --url or "
+                "--json '{\"UrlFeed\":{...}}', not both."
+            )
+
         feed_data = {"Id": feed_id}
 
         if name:
             feed_data["Name"] = name
         if url:
             feed_data["UrlFeed"] = {"Url": url}
-        if extra_json:
-            extra = json.loads(extra_json)
+        if extra:
             feed_data.update(extra)
         if len(feed_data) == 1:
-            raise click.ClickException(
+            raise click.UsageError(
                 "Provide at least one of --name, --url, or --json for update"
             )
 
@@ -148,6 +180,8 @@ def update(ctx, feed_id, name, url, extra_json, dry_run):
         result = client.feeds().post(data=body)
         format_output(result().extract(), "json", None)
 
+    except click.UsageError:
+        raise
     except Exception as e:
         print_error(str(e))
         raise click.Abort()

{direct_cli-0.2.4 → direct_cli-0.2.5}/direct_cli/commands/keywordbids.py

@@ -81,9 +81,9 @@ def set(ctx, keyword_id, search_bid, network_bid, extra_json, dry_run):
     try:
         bid_data = {"KeywordId": keyword_id}
 
-        if search_bid:
+        if search_bid is not None:
             bid_data["SearchBid"] = int(search_bid * 1000000)
-        if network_bid:
+        if network_bid is not None:
             bid_data["NetworkBid"] = int(network_bid * 1000000)
 
         if extra_json:

{direct_cli-0.2.4 → direct_cli-0.2.5}/direct_cli/commands/keywords.py

@@ -106,9 +106,9 @@ def add(
     try:
         keyword_data = {"AdGroupId": adgroup_id, "Keyword": keyword}
 
-        if bid:
+        if bid is not None:
             keyword_data["Bid"] = int(bid * 1000000)
-        if context_bid:
+        if context_bid is not None:
             keyword_data["ContextBid"] = int(context_bid * 1000000)
         if user_param_1:
             keyword_data["UserParam1"] = user_param_1

{direct_cli-0.2.4 → direct_cli-0.2.5}/direct_cli/commands/reports.py

@@ -28,7 +28,11 @@ def reports():
     "--type",
     "report_type",
     required=True,
-    help="Report type (CAMPAIGN_PERFORMANCE_REPORT, etc.)",
+    type=click.Choice(REPORT_TYPES, case_sensitive=False),
+    help=(
+        "Report type (case-insensitive). Validated against the official "
+        "Yandex Direct report-type enum — see axisrow/direct-cli#25."
+    ),
 )
 @click.option("--from", "date_from", required=True, help="Start date (YYYY-MM-DD)")
 @click.option("--to", "date_to", required=True, help="End date (YYYY-MM-DD)")
@@ -43,7 +47,6 @@ def reports():
     help="Output format (json/table/csv/tsv)",
 )
 @click.option("--output", help="Output file")
-@click.option("--mode", default="auto", help="Processing mode (online/offline/auto)")
 @click.pass_context
 def get(
     ctx,
@@ -56,9 +59,15 @@ def get(
     adgroup_ids,
     output_format,
     output,
-    mode,
 ):
-    """Get report"""
+    """Get report
+
+    The underlying ``create_client`` uses processing mode ``auto``
+    — previously the CLI also exposed a ``--mode`` option that was
+    declared but never read in the function body, silently dropping
+    any value the user passed.  That dead option was removed in
+    axisrow/direct-cli#25.
+    """
     try:
         client = create_client(
             token=ctx.obj.get("token"),

{direct_cli-0.2.4 → direct_cli-0.2.5}/direct_cli/commands/retargeting.py

@@ -66,10 +66,26 @@ def get(ctx, ids, types, limit, fetch_all, output_format, output, fields):
         raise click.Abort()
 
 
+#: Valid ``RetargetingListAddItem.Type`` values per Yandex Direct API docs
+#: (ref-v5/retargetinglists/add).  The API defaults to ``RETARGETING`` when
+#: ``Type`` is omitted, so the CLI follows the same default.
+_RETARGETING_LIST_TYPES = ["RETARGETING", "AUDIENCE"]
+
+
 @retargeting.command()
 @click.option("--name", required=True, help="List name")
 @click.option(
-    "--type", "list_type", required=True, help="List type (AUDIENCE_SEGMENT, etc.)"
+    "--type",
+    "list_type",
+    default="RETARGETING",
+    type=click.Choice(_RETARGETING_LIST_TYPES, case_sensitive=False),
+    help=(
+        "Retargeting list type (case-insensitive). Yandex Direct accepts "
+        "only RETARGETING (default — Metrica goals/segments + Audience "
+        "segments, usable in text & image / mobile-app campaigns) or "
+        "AUDIENCE (any goals/segments, usable in display campaigns). "
+        "See axisrow/direct-cli#25."
+    ),
 )
 @click.option("--json", "extra_json", help="Additional JSON parameters")
 @click.option("--dry-run", is_flag=True, help="Show request without sending")
@@ -77,6 +93,9 @@ def get(ctx, ids, types, limit, fetch_all, output_format, output, fields):
 def add(ctx, name, list_type, extra_json, dry_run):
     """Add new retargeting list"""
     try:
+        # click.Choice normalizes the case when case_sensitive=False but
+        # leaves the original casing of the canonical choice; pass it
+        # through unchanged.
         list_data = {"Name": name, "Type": list_type}
 
         if extra_json: