diffimpactscout 0.2.0__tar.gz → 0.4.0__tar.gz

{diffimpactscout-0.2.0/src/diffimpactscout.egg-info → diffimpactscout-0.4.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: diffimpactscout
-Version: 0.2.0
+Version: 0.4.0
 Summary: Incremental pre-push guard and AST blast-radius impact analyzer for git repositories.
 Author: DiffImpactScout contributors
 License: MIT
@@ -66,11 +66,11 @@ diffimpactscout guard
 # 3. Analyze the blast radius of your change
 diffimpactscout impact
 
-# 4. Run the guard automatically on every push
+# 4. Install the pre-push hook (guard + impact report by default)
 diffimpactscout install-hooks
 ```
 
-`init` accepts `--profile generic|django|fastapi|python|frontend` to seed profile-appropriate settings. `install-hooks` detects the stack automatically (see [Supported setups](#supported-setups)).
+`init` accepts `--profile generic|django|fastapi|python|frontend` to seed profile-appropriate settings. `install-hooks` detects the stack automatically (see [Supported setups](#supported-setups)) and, unless the config's `mode` says otherwise, the hook runs both the guard and the impact report on every push.
 
 ## Supported setups
 
@@ -120,15 +120,29 @@ Analyzes the blast radius of the change-set. In an interactive terminal it print
 | `--fast` | Skip template and frontend scanning; limit Python scanning to the changed files plus import-linked files. |
 | `--json` | Emit the report as JSON (`{changed_count, rows, unresolved}`) instead of a markdown table. |
 
+### `diffimpactscout guard-and-impact-check`
+
+Runs the `guard` checks first, then always falls through to the `impact` blast-radius report so the developer sees the guard verdict and the affected areas together. This is the default pre-push hook scope, so one push runs the whole workflow. The command exits non-zero when the guard blocks in strict mode (or when impact is set to block), so a failing guard still surfaces the impact report but the push is rejected.
+
+| Flag | Description |
+| --- | --- |
+| `--staged` | Restrict both the guard and the impact analysis to staged files. |
+| `--fast` | Passes through to `impact` (skip template/frontend scanning). |
+| `--json` | Passes through to `impact` (emit the report as JSON). |
+
+### `diffimpactscout dependency-check`
+
+Verifies that every external tool referenced by the configured guard checks is on `PATH` (`ruff`, `eslint`, `prettier`). Missing tools print an install hint and exit `1`; a clean run prints an OK banner and exits `0`. `install-hooks` also runs a non-blocking version of this check after installing a hook, warning about missing tools only when stdin is a terminal.
+
 ### `diffimpactscout check CHECK_ID [files...]`
 
 Runs a single check by id (see [Checks reference](#checks-reference)). With no file arguments it runs against the change-set.
 
 ### `diffimpactscout install-hooks`
 
-Installs a `pre-push` git hook that runs `diffimpactscout guard` on push.
+Installs a `pre-push` git hook that runs the configured hook scope on push: `diffimpactscout guard-and-impact-check` by default (guard checks then the impact blast-radius report), or `diffimpactscout guard` when `mode` is `pre-push`.
 
-On first run the command detects the stack, prints a preview of the `.diffimpactscout.json` it would write, and (when stdin is a terminal) asks for confirmation. Answer `n` to override profile, blocking mode, extra checks, and impact. Use `--yes` in CI to skip prompts, `--profile` and `--blocking` to pre-select settings, and `--reconfigure` to rewrite an existing config. Without `--reconfigure` an existing config is left untouched.
+On first run the command detects the stack, prints a preview of the `.diffimpactscout.json` it would write, and (when stdin is a terminal) asks for confirmation. Answer `n` to override profile, blocking mode, extra checks, impact, and the hook scope (mode). Use `--yes` in CI to skip prompts, `--profile` and `--blocking` to pre-select settings, and `--reconfigure` to rewrite an existing config. Without `--reconfigure` an existing config is left untouched (and its mode is reused for the hook).
 
 | Flag | Description |
 | --- | --- |
@@ -139,6 +153,8 @@ On first run the command detects the stack, prints a preview of the `.diffimpact
 | `--force` | Overwrite an existing `pre-push` hook that DiffImpactScout did not install. |
 | `--uninstall` | Remove the DiffImpactScout `pre-push` hook. |
 
+After a hook is installed a non-blocking dependency check runs: tools referenced by the guard checks (`ruff`, `eslint`, `prettier`) that are missing on `PATH` are reported with install hints, so e.g. a first-time `ruff` install is prompted instead of silently degrading the checks.
+
 ### `diffimpactscout --version`
 
 Prints the installed version.
@@ -150,7 +166,7 @@ DiffImpactScout is configured by a `.diffimpactscout.json` file in the repositor
 ```json
 {
   "version": 1,
-  "mode": "pre-push",
+  "mode": "guard-and-impact-check",
   "ignore_paths": [
     "**/node_modules/**",
     "**/venv/**",
@@ -189,6 +205,7 @@ DiffImpactScout is configured by a `.diffimpactscout.json` file in the repositor
 
 | Section | Key | Meaning |
 | --- | --- | --- |
+| top-level | `mode` | Hook scope: `guard-and-impact-check` (default, runs the guard then the impact report on every push) or `pre-push` (guard only). |
 | top-level | `ignore_paths` | Glob patterns (matching any path suffix) excluded from all checks and from impact scanning. |
 | top-level | `use_gitignore` | When `true`, also excludes paths ignored by `git check-ignore`. |
 | `guard` | `checks` | Ordered list of check entries; each `{"id": ...}` may add `args`, `blocking`, and `always_block` overrides. |
@@ -226,12 +243,12 @@ External checks run `command` (each `{file}` placeholder is replaced with the fi
 
 ## Pre-push hook
 
-`diffimpactscout install-hooks` writes a `pre-push` hook that runs `diffimpactscout guard` on every push.
+`diffimpactscout install-hooks` writes a `pre-push` hook that runs the configured hook scope on every push — `guard-and-impact-check` by default (guard checks plus the impact report), `guard` only when `mode` is `pre-push`.
 
 - The hook directory is resolved from `git rev-parse --git-common-dir` and honors `core.hooksPath`.
 - The hook script is marked with `# diffimpactscout pre-push hook`. On `--uninstall` (or a re-install with `--force`), only a hook carrying this marker is touched.
 - If a `pre-push` hook already exists without the marker, installation refuses with a `use --force to overwrite` message.
-- The hook runs `diffimpactscout guard`; if the tool is not found, it prints a notice and exits `0`, so pushes are never blocked by a missing install.
+- If the tool is not found, the hook prints a notice and exits `0`, so pushes are never blocked by a missing install.
 - Because the guard is warn-by-default, an installed hook reports issues without blocking the push unless you enable strict mode.
 
 ### Environment variables
@@ -248,7 +265,7 @@ External checks run `command` (each `{file}` placeholder is replaced with the fi
 The `impact` command answers: if I push these changes, what else could break?
 
 1. It parses the change-set (`git diff --find-renames`) and extracts the Python entities you added, removed, or renamed: classes, functions, methods, module fields, and class fields.
-2. It builds an AST symbol map of every tracked Python file in the repo (skipping excluded paths), cached in `impact.cache_file`, and finds every reference to the changed symbols. Lookup kind follows the entity: class fields match attribute loads, methods match name and attribute loads, functions/classes also match imports.
+2. It builds an AST symbol map of every tracked Python file in the repo (skipping excluded paths), cached in `impact.cache_file`, and finds every reference to the changed symbols. Lookup kind follows the entity: class fields match attribute loads, methods match name and attribute loads, functions/classes also match imports. To keep the blast radius honest, entities are scoped to the diff hunks that actually changed (a one-line tweak inside a large function does not report the whole function), and same-name references in other files are only reported when the file imports the name from the changed module (`views.orders` counts, a bare `orders` in an unrelated file does not).
 3. Depending on the profile it extracts routes:
    - `django`: `path()`/`re_path()`/`url()` entries in `urls_globs` that carry a `name=`.
    - `fastapi`: `get`/`post`/`put`/`delete`/`patch`/`options` decorators on `router`/`app`-style objects in `urls_globs`.

{diffimpactscout-0.2.0 → diffimpactscout-0.4.0}/README.md

@@ -49,11 +49,11 @@ diffimpactscout guard
 # 3. Analyze the blast radius of your change
 diffimpactscout impact
 
-# 4. Run the guard automatically on every push
+# 4. Install the pre-push hook (guard + impact report by default)
 diffimpactscout install-hooks
 ```
 
-`init` accepts `--profile generic|django|fastapi|python|frontend` to seed profile-appropriate settings. `install-hooks` detects the stack automatically (see [Supported setups](#supported-setups)).
+`init` accepts `--profile generic|django|fastapi|python|frontend` to seed profile-appropriate settings. `install-hooks` detects the stack automatically (see [Supported setups](#supported-setups)) and, unless the config's `mode` says otherwise, the hook runs both the guard and the impact report on every push.
 
 ## Supported setups
 
@@ -103,15 +103,29 @@ Analyzes the blast radius of the change-set. In an interactive terminal it print
 | `--fast` | Skip template and frontend scanning; limit Python scanning to the changed files plus import-linked files. |
 | `--json` | Emit the report as JSON (`{changed_count, rows, unresolved}`) instead of a markdown table. |
 
+### `diffimpactscout guard-and-impact-check`
+
+Runs the `guard` checks first, then always falls through to the `impact` blast-radius report so the developer sees the guard verdict and the affected areas together. This is the default pre-push hook scope, so one push runs the whole workflow. The command exits non-zero when the guard blocks in strict mode (or when impact is set to block), so a failing guard still surfaces the impact report but the push is rejected.
+
+| Flag | Description |
+| --- | --- |
+| `--staged` | Restrict both the guard and the impact analysis to staged files. |
+| `--fast` | Passes through to `impact` (skip template/frontend scanning). |
+| `--json` | Passes through to `impact` (emit the report as JSON). |
+
+### `diffimpactscout dependency-check`
+
+Verifies that every external tool referenced by the configured guard checks is on `PATH` (`ruff`, `eslint`, `prettier`). Missing tools print an install hint and exit `1`; a clean run prints an OK banner and exits `0`. `install-hooks` also runs a non-blocking version of this check after installing a hook, warning about missing tools only when stdin is a terminal.
+
 ### `diffimpactscout check CHECK_ID [files...]`
 
 Runs a single check by id (see [Checks reference](#checks-reference)). With no file arguments it runs against the change-set.
 
 ### `diffimpactscout install-hooks`
 
-Installs a `pre-push` git hook that runs `diffimpactscout guard` on push.
+Installs a `pre-push` git hook that runs the configured hook scope on push: `diffimpactscout guard-and-impact-check` by default (guard checks then the impact blast-radius report), or `diffimpactscout guard` when `mode` is `pre-push`.
 
-On first run the command detects the stack, prints a preview of the `.diffimpactscout.json` it would write, and (when stdin is a terminal) asks for confirmation. Answer `n` to override profile, blocking mode, extra checks, and impact. Use `--yes` in CI to skip prompts, `--profile` and `--blocking` to pre-select settings, and `--reconfigure` to rewrite an existing config. Without `--reconfigure` an existing config is left untouched.
+On first run the command detects the stack, prints a preview of the `.diffimpactscout.json` it would write, and (when stdin is a terminal) asks for confirmation. Answer `n` to override profile, blocking mode, extra checks, impact, and the hook scope (mode). Use `--yes` in CI to skip prompts, `--profile` and `--blocking` to pre-select settings, and `--reconfigure` to rewrite an existing config. Without `--reconfigure` an existing config is left untouched (and its mode is reused for the hook).
 
 | Flag | Description |
 | --- | --- |
@@ -122,6 +136,8 @@ On first run the command detects the stack, prints a preview of the `.diffimpact
 | `--force` | Overwrite an existing `pre-push` hook that DiffImpactScout did not install. |
 | `--uninstall` | Remove the DiffImpactScout `pre-push` hook. |
 
+After a hook is installed a non-blocking dependency check runs: tools referenced by the guard checks (`ruff`, `eslint`, `prettier`) that are missing on `PATH` are reported with install hints, so e.g. a first-time `ruff` install is prompted instead of silently degrading the checks.
+
 ### `diffimpactscout --version`
 
 Prints the installed version.
@@ -133,7 +149,7 @@ DiffImpactScout is configured by a `.diffimpactscout.json` file in the repositor
 ```json
 {
   "version": 1,
-  "mode": "pre-push",
+  "mode": "guard-and-impact-check",
   "ignore_paths": [
     "**/node_modules/**",
     "**/venv/**",
@@ -172,6 +188,7 @@ DiffImpactScout is configured by a `.diffimpactscout.json` file in the repositor
 
 | Section | Key | Meaning |
 | --- | --- | --- |
+| top-level | `mode` | Hook scope: `guard-and-impact-check` (default, runs the guard then the impact report on every push) or `pre-push` (guard only). |
 | top-level | `ignore_paths` | Glob patterns (matching any path suffix) excluded from all checks and from impact scanning. |
 | top-level | `use_gitignore` | When `true`, also excludes paths ignored by `git check-ignore`. |
 | `guard` | `checks` | Ordered list of check entries; each `{"id": ...}` may add `args`, `blocking`, and `always_block` overrides. |
@@ -209,12 +226,12 @@ External checks run `command` (each `{file}` placeholder is replaced with the fi
 
 ## Pre-push hook
 
-`diffimpactscout install-hooks` writes a `pre-push` hook that runs `diffimpactscout guard` on every push.
+`diffimpactscout install-hooks` writes a `pre-push` hook that runs the configured hook scope on every push — `guard-and-impact-check` by default (guard checks plus the impact report), `guard` only when `mode` is `pre-push`.
 
 - The hook directory is resolved from `git rev-parse --git-common-dir` and honors `core.hooksPath`.
 - The hook script is marked with `# diffimpactscout pre-push hook`. On `--uninstall` (or a re-install with `--force`), only a hook carrying this marker is touched.
 - If a `pre-push` hook already exists without the marker, installation refuses with a `use --force to overwrite` message.
-- The hook runs `diffimpactscout guard`; if the tool is not found, it prints a notice and exits `0`, so pushes are never blocked by a missing install.
+- If the tool is not found, the hook prints a notice and exits `0`, so pushes are never blocked by a missing install.
 - Because the guard is warn-by-default, an installed hook reports issues without blocking the push unless you enable strict mode.
 
 ### Environment variables
@@ -231,7 +248,7 @@ External checks run `command` (each `{file}` placeholder is replaced with the fi
 The `impact` command answers: if I push these changes, what else could break?
 
 1. It parses the change-set (`git diff --find-renames`) and extracts the Python entities you added, removed, or renamed: classes, functions, methods, module fields, and class fields.
-2. It builds an AST symbol map of every tracked Python file in the repo (skipping excluded paths), cached in `impact.cache_file`, and finds every reference to the changed symbols. Lookup kind follows the entity: class fields match attribute loads, methods match name and attribute loads, functions/classes also match imports.
+2. It builds an AST symbol map of every tracked Python file in the repo (skipping excluded paths), cached in `impact.cache_file`, and finds every reference to the changed symbols. Lookup kind follows the entity: class fields match attribute loads, methods match name and attribute loads, functions/classes also match imports. To keep the blast radius honest, entities are scoped to the diff hunks that actually changed (a one-line tweak inside a large function does not report the whole function), and same-name references in other files are only reported when the file imports the name from the changed module (`views.orders` counts, a bare `orders` in an unrelated file does not).
 3. Depending on the profile it extracts routes:
    - `django`: `path()`/`re_path()`/`url()` entries in `urls_globs` that carry a `name=`.
    - `fastapi`: `get`/`post`/`put`/`delete`/`patch`/`options` decorators on `router`/`app`-style objects in `urls_globs`.

{diffimpactscout-0.2.0 → diffimpactscout-0.4.0}/setup.py

@@ -7,7 +7,7 @@ with io.open("README.md", encoding="utf-8") as fh:
 
 setup(
     name="diffimpactscout",
-    version="0.2.0",
+    version="0.4.0",
     description="Incremental pre-push guard and AST blast-radius impact analyzer for git repositories.",
     long_description=long_description,
     long_description_content_type="text/markdown",

{diffimpactscout-0.2.0 → diffimpactscout-0.4.0}/src/diffimpactscout/__init__.py

@@ -1,3 +1,3 @@
 """diffimpactscout: incremental pre-push guard and AST blast-radius impact analyzer."""
 
-__version__ = "0.2.0"
+__version__ = "0.4.0"

{diffimpactscout-0.2.0 → diffimpactscout-0.4.0}/src/diffimpactscout/base.py

@@ -2,13 +2,55 @@
 
 Example: when the repo has an upstream/sprint/12 ref, diffs are measured
 against it instead of origin/master.
+
+================================================================================
+ARCHITECTURAL OVERVIEW: 2-DOT TREE DIFF FOR INCREMENTAL CHECKS
+================================================================================
+
+Why a 2-dot tree diff (`git diff <anchor> HEAD`):
+
+In standard Git workflows a 3-dot diff (`git diff <anchor>...HEAD`) computes
+changes relative to the common merge-base ancestor of the two tips. Whenever a
+developer syncs their branch with upstream (merge, rebase, or squash), the
+merge-base moves and the 3-dot range silently grows to include every commit
+introduced by upstream since the branch diverged. Every pre-existing upstream
+violation (a stale trailing space, a long line, an old lint error) then shows up
+as a "new" issue in the pre-push guard, producing false positives the developer
+did not author and cannot reasonably fix in that push.
+
+A 2-dot tree diff (`git diff <anchor> HEAD`, no `...`) compares the exact
+filesystem snapshot ("tree") of the resolved upstream anchor directly against
+the `HEAD` tree. Consequences:
+
+  1. Zero Upstream Blame: any file or line that exists byte-identically in the
+     anchor tree contributes no diff entries. Only files and lines actually
+     added or changed by the developer are passed to the checks.
+  2. Sync Agnostic: behaves identically whether the branch was synced with
+     `git merge`, `git rebase`, or `git merge --squash`, because it never walks
+     commit ancestry, only the two tip trees.
+  3. Shallow-Clone Safe: computing the name-only diff needs just the two tip
+     trees (plus any blobs referenced in the range), so it works on shallow
+     clones that lack full commit history.
+
+Sprint branch resolution:
+
+In sprint-based development models (e.g. custom in-house platforms) work is
+branched from active
+sprint branches such as `refs/remotes/upstream/sprint/33.1` rather than from
+`master`. The resolver inspects `refs/remotes/upstream/master` plus the top
+`DEFAULT_MAX_SPRINT_CANDIDATES` (5) most recent sprint branches sorted by
+committer date, and picks the candidate whose tree is closest to `HEAD` (the
+fewest changed files on a `--diff-filter=ACMRT` name-only diff). The closest
+tree means the smallest honest change-set, which is what incremental checks
+want to target.
+================================================================================
 """
 
 import diffimpactscout.gitrun as gitrun
 
 MASTER_REF = "refs/remotes/upstream/master"
 SPRINT_PREFIX = "sprint/"
-DEFAULT_MAX_SPRINT_CANDIDATES = 10
+DEFAULT_MAX_SPRINT_CANDIDATES = 5
 REMOTE_FALLBACKS = ("main", "master", "develop")
 
 
@@ -16,7 +58,7 @@ def resolve_change_base(root, limit=DEFAULT_MAX_SPRINT_CANDIDATES):
     """Return the remote ref closest to HEAD, or None.
 
     `limit` caps how many `sprint/*` refs are considered: only the
-    `limit` (default 10) most-recent ones by committer date, unlike the
+    `limit` (default 5) most-recent ones by committer date, unlike the
     bash original dev_base.sh which considered every sprint branch.
     """
     for remote in _remote_order(root):

{diffimpactscout-0.2.0 → diffimpactscout-0.4.0}/src/diffimpactscout/checks/base.py

@@ -97,7 +97,9 @@ class ExternalCheck(Check):
                 output = (out or err).decode("utf-8", errors="replace").strip()
                 if not output:
                     output = "exit code %s" % proc.returncode
-                issues.append(CheckIssue(".", 0, 0, self.id, output))
+                else:
+                    output = "%s (exit code %s)" % (output, proc.returncode)
+                issues.append(CheckIssue(".", None, None, self.id, output))
             return CheckResult(issues=issues, fixed=fixed, skipped=skipped, warned=warned)
         for path in files or []:
             argv = self._argv_for(path)
@@ -116,7 +118,9 @@ class ExternalCheck(Check):
                 output = (out or err).decode("utf-8", errors="replace").strip()
                 if not output:
                     output = "exit code %s" % proc.returncode
-                issues.append(CheckIssue(path, 0, 0, self.id, output))
+                else:
+                    output = "%s (exit code %s)" % (output, proc.returncode)
+                issues.append(CheckIssue(path, None, None, self.id, output))
         return CheckResult(issues=issues, fixed=fixed, skipped=skipped, warned=warned)
 
 
@@ -151,7 +155,7 @@ class CheckContext(object):
 
 
 class CheckIssue(object):
-    def __init__(self, path, line, column, code, message):
+    def __init__(self, path, line=None, column=None, code=None, message=None):
         self.path = path
         self.line = line
         self.column = column
@@ -159,13 +163,13 @@ class CheckIssue(object):
         self.message = message
 
     def format(self):
-        return "%s:%s:%s: %s %s" % (
-            self.path,
-            self.line,
-            self.column,
-            self.code,
-            self.message,
-        )
+        if self.line is None and self.column is None:
+            location = self.path
+        else:
+            line = "-" if self.line is None else str(self.line)
+            column = "-" if self.column is None else str(self.column)
+            location = "%s:%s:%s" % (self.path, line, column)
+        return "%s: %s %s" % (location, self.code, self.message)
 
 
 class CheckResult(object):

{diffimpactscout-0.2.0 → diffimpactscout-0.4.0}/src/diffimpactscout/checks/eslint.py

@@ -155,8 +155,8 @@ class EslintCheck(Check):
                     issues.append(
                         CheckIssue(
                             path,
-                            line or 0,
-                            column or 0,
+                            line,
+                            column,
                             rule_id or self.id,
                             message.get("message") or "",
                         )

{diffimpactscout-0.2.0 → diffimpactscout-0.4.0}/src/diffimpactscout/checks/prettier.py

@@ -93,8 +93,8 @@ class PrettierCheck(Check):
             issues.append(
                 CheckIssue(
                     path,
-                    0,
-                    0,
+                    None,
+                    None,
                     self.id,
                     "%s is not formatted. Fix with: npx prettier --write %s"
                     % (path, path),

{diffimpactscout-0.2.0 → diffimpactscout-0.4.0}/src/diffimpactscout/checks/repo_checks.py

@@ -1,11 +1,14 @@
-"""Repo-wide checks for oversized files and leaked private keys.
+"""Repo-wide checks for oversized files, leaked private keys, and case-colliding file paths.
 
-Example: a 300 MB binary is flagged with a git-lfs hint, and any file
-containing a private key block always blocks the push.
+Example: a 300 MB binary is flagged with a git-lfs hint, any file
+containing a private key block always blocks the push, and a pushed
+`FILE.TXT` colliding with a tracked `file.txt` is flagged because the two
+names clobber each other on case-insensitive filesystems (macOS, Windows).
 """
 
 import os
 
+import diffimpactscout.gitrun as gitrun
 from diffimpactscout.checks.base import (
     Check,
     CheckIssue,
@@ -23,6 +26,33 @@ PRIVATE_KEY_MARKERS = (
 )
 
 
+@register
+class CaseConflictCheck(Check):
+    id = "repo/case-conflict"
+    scoped = "files"
+
+    def run(self, context, files):
+        tracked = gitrun.git_nul(["ls-files", "-z"], context.root)
+        by_lower = {}
+        for path in tracked:
+            by_lower.setdefault(path.lower(), []).append(path)
+        issues = []
+        for path in files or []:
+            for other in by_lower.get(path.lower(), ()):
+                if other != path:
+                    issues.append(
+                        CheckIssue(
+                            path,
+                            None,
+                            None,
+                            self.id,
+                            "case conflict detected with %s" % other,
+                        )
+                    )
+                    break
+        return CheckResult(issues=issues)
+
+
 @register
 class LargeFilesCheck(Check):
     id = "repo/large-files"
@@ -61,8 +91,8 @@ class LargeFilesCheck(Check):
                 issues.append(
                     CheckIssue(
                         path,
-                        0,
-                        0,
+                        None,
+                        None,
                         self.id,
                         "file size %d kB exceeds limit of %d kB; consider git lfs"
                         % (size_kb, self.max_kb),
@@ -89,7 +119,7 @@ class PrivateKeyCheck(Check):
             for marker in PRIVATE_KEY_MARKERS:
                 if marker in data:
                     issues.append(
-                        CheckIssue(path, 0, 0, self.id, "private key detected")
+                        CheckIssue(path, None, None, self.id, "private key detected")
                     )
                     break
         return CheckResult(issues=issues)

{diffimpactscout-0.2.0 → diffimpactscout-0.4.0}/src/diffimpactscout/checks/ruff.py

@@ -157,8 +157,8 @@ class RuffCheck(Check):
                 issues.append(
                     CheckIssue(
                         path,
-                        row or 0,
-                        location.get("column") or 0,
+                        row,
+                        location.get("column"),
                         violation.get("code") or self.id,
                         violation.get("message") or "",
                     )
@@ -215,8 +215,8 @@ class RuffFormatCheck(Check):
             issues.append(
                 CheckIssue(
                     path,
-                    0,
-                    0,
+                    None,
+                    None,
                     self.id,
                     "formatting issue in changed lines:\n%s\nFix with: ruff format %s"
                     % (_truncate(kept), path),

{diffimpactscout-0.2.0 → diffimpactscout-0.4.0}/src/diffimpactscout/checks/syntax.py

@@ -7,6 +7,7 @@ merge conflict, and a dev-added invalid JSON file is flagged.
 import ast
 import json
 import os
+import warnings
 
 from diffimpactscout.checks.base import (
     Check,
@@ -38,8 +39,8 @@ class JsonSyntaxCheck(Check):
                 issues.append(
                     CheckIssue(
                         path,
-                        getattr(exc, "lineno", 0) or 0,
-                        getattr(exc, "colno", 0) or 0,
+                        getattr(exc, "lineno", None),
+                        getattr(exc, "colno", None),
                         self.id,
                         "invalid JSON: %s" % exc,
                     )
@@ -64,13 +65,15 @@ class AstSyntaxCheck(Check):
             except OSError:
                 continue
             try:
-                ast.parse(data.decode("utf-8-sig"), filename=path)
+                with warnings.catch_warnings():
+                    warnings.simplefilter("ignore", SyntaxWarning)
+                    ast.parse(data.decode("utf-8-sig"), filename=path)
             except SyntaxError as exc:
                 issues.append(
                     CheckIssue(
                         path,
-                        exc.lineno or 0,
-                        exc.offset or 0,
+                        exc.lineno,
+                        exc.offset,
                         self.id,
                         "invalid python syntax: %s" % (exc.msg or "syntax error"),
                     )
@@ -78,7 +81,11 @@ class AstSyntaxCheck(Check):
             except ValueError as exc:
                 issues.append(
                     CheckIssue(
-                        path, 0, 0, self.id, "invalid python source: %s" % exc
+                        path,
+                        None,
+                        None,
+                        self.id,
+                        "invalid python source: %s" % exc,
                     )
                 )
         return CheckResult(issues=issues)
@@ -111,7 +118,7 @@ class MergeConflictCheck(Check):
                 line = lines[lineno - 1]
                 if self._is_marker(line):
                     issues.append(
-                        CheckIssue(path, lineno, 0, self.id, "conflict marker found")
+                        CheckIssue(path, lineno, None, self.id, "conflict marker found")
                     )
         return CheckResult(issues=issues)