diffimpactscout 0.1.0__tar.gz → 0.3.0__tar.gz

{diffimpactscout-0.1.0/src/diffimpactscout.egg-info → diffimpactscout-0.3.0}/PKG-INFO

@@ -1,10 +1,10 @@
 Metadata-Version: 2.4
 Name: diffimpactscout
-Version: 0.1.0
+Version: 0.3.0
 Summary: Incremental pre-push guard and AST blast-radius impact analyzer for git repositories.
 Author: DiffImpactScout contributors
 License: MIT
-Requires-Python: >=3.6
+Requires-Python: >=3.8
 Description-Content-Type: text/markdown
 License-File: LICENSE
 Dynamic: author
@@ -30,7 +30,7 @@ An incremental pre-push guard and AST blast-radius impact analyzer for git repos
 - Python AST symbol map: detects changed classes, functions, methods, module fields, and class fields, including deletions and renames.
 - Cross-layer impact linking: Python symbols to Django `{% url %}` template tags and frontend `http.get()/post()`-style calls.
 - Symbol cache (`.impact_analysis_cache.json`) so repeated runs skip unchanged files.
-- Profiles for `plain`, `django`, and `fastapi` projects.
+- Profiles for `generic`, `django`, `fastapi`, `python`, and `frontend` projects.
 - Configurable pre-push hook installation that never silently clobbers an existing hook.
 
 ## Core idea
@@ -50,7 +50,7 @@ The change-set also handles the full breadth of realistic push shapes: direct pu
 pip install diffimpactscout
 ```
 
-The package is pure Python (standard library only at runtime) and requires Python 3.6 or newer and the `git` CLI on `PATH`.
+The package is pure Python (standard library only at runtime) and requires Python 3.8 or newer and the `git` CLI on `PATH`.
 
 Optional tools are only needed for the checks that use them: `ruff`, `eslint` (via `npx`), and `prettier` (via `npx`). If one is missing, the affected check emits a warning and the guard continues; it never blocks a push because a tool is absent.
 
@@ -70,7 +70,21 @@ diffimpactscout impact
 diffimpactscout install-hooks
 ```
 
-`init` accepts `--profile plain|django|fastapi` to seed profile-appropriate settings.
+`init` accepts `--profile generic|django|fastapi|python|frontend` to seed profile-appropriate settings. `install-hooks` detects the stack automatically (see [Supported setups](#supported-setups)).
+
+## Supported setups
+
+`install-hooks` detects the project stack on first run and writes a `.diffimpactscout.json` that fits it:
+
+| Detection signal | Profile | Guard checks | Impact globs |
+| --- | --- | --- | --- |
+| `manage.py` + `settings.py`/`wsgi.py` | django | default + `ruff`, `ruff-format` | urls, templates, frontend |
+| `fastapi` in deps or `main.py` | fastapi | default + `ruff`, `ruff-format` | `**/*.py` routes + frontend globs |
+| `package.json` + `src`/`app` `*.ts`/`*.js` | frontend | default + `eslint`, `prettier` | templates + frontend globs |
+| `*.py` present | python | default + `ruff`, `ruff-format` | Python module references |
+| anything else (or no signal) | generic | default from `init` | none |
+
+Other ecosystems (Go, Rust, Java, Ruby, ...) are detected and reported as "planned for future releases" in the preview; the generic profile still installs the universal guard checks. Add a language linter with an [external check](#configuration).
 
 ## Commands
 
@@ -82,7 +96,7 @@ Writes a `.diffimpactscout.json` into the current directory. If the file already
 
 | Flag | Description |
 | --- | --- |
-| `--profile {plain,django,fastapi}` | Seed defaults from the named profile (default: `plain`). |
+| `--profile {generic,django,fastapi,python,frontend}` | Seed defaults from the named profile (default: `generic`). |
 
 ### `diffimpactscout guard`
 
@@ -114,8 +128,14 @@ Runs a single check by id (see [Checks reference](#checks-reference)). With no f
 
 Installs a `pre-push` git hook that runs `diffimpactscout guard` on push.
 
+On first run the command detects the stack, prints a preview of the `.diffimpactscout.json` it would write, and (when stdin is a terminal) asks for confirmation. Answer `n` to override profile, blocking mode, extra checks, and impact. Use `--yes` in CI to skip prompts, `--profile` and `--blocking` to pre-select settings, and `--reconfigure` to rewrite an existing config. Without `--reconfigure` an existing config is left untouched.
+
 | Flag | Description |
 | --- | --- |
+| `--profile {generic,django,fastapi,python,frontend}` | Pre-select the setup profile; skips the stack question. |
+| `--blocking {warn,strict}` | Blocking mode for guard checks (default: `warn`). |
+| `--yes`, `-y` | Accept defaults and skip prompts (non-interactive). |
+| `--reconfigure` | Rewrite an existing `.diffimpactscout.json`. |
 | `--force` | Overwrite an existing `pre-push` hook that DiffImpactScout did not install. |
 | `--uninstall` | Remove the DiffImpactScout `pre-push` hook. |
 
@@ -156,7 +176,7 @@ DiffImpactScout is configured by a `.diffimpactscout.json` file in the repositor
     "blocking": "warn"
   },
   "impact": {
-    "profile": "plain",
+    "profile": "generic",
     "urls_globs": [],
     "template_globs": [],
     "frontend_globs": [],
@@ -173,7 +193,7 @@ DiffImpactScout is configured by a `.diffimpactscout.json` file in the repositor
 | top-level | `use_gitignore` | When `true`, also excludes paths ignored by `git check-ignore`. |
 | `guard` | `checks` | Ordered list of check entries; each `{"id": ...}` may add `args`, `blocking`, and `always_block` overrides. |
 | `guard` | `blocking` | `"warn"` (default) or `"strict"`. In strict mode every check marked blocking can fail the run. |
-| `impact` | `profile` | `plain`, `django`, or `fastapi`; selects route extraction plus default globs. |
+| `impact` | `profile` | `generic`, `django`, or `fastapi`; selects route extraction plus default globs. |
 | `impact` | `urls_globs` / `template_globs` / `frontend_globs` | Glob patterns for route files, Django templates, and frontend sources. |
 | `impact` | `cache_file` | Path of the symbol cache (relative to the repo root). |
 | `impact` | `fast_mode`, `threads` | Reserved defaults from `init`; fast mode is currently selected with the `impact --fast` flag. |
@@ -188,9 +208,11 @@ External checks run `command` (each `{file}` placeholder is replaced with the fi
 
 ### Profiles
 
-- `plain`: no route or cross-layer globs; impact analysis reports only Python references.
+- `generic`: no route or cross-layer globs; impact analysis reports only Python references.
+- `python`: same impact globs as `generic`; guard checks append `ruff` and `ruff-format`.
 - `django`: route files `**/urls.py`, templates `**/templates/**/*.html`, frontend `**/src/**/*.ts` and `**/app/**/*.js`; guard checks append `ruff` and `ruff-format`.
 - `fastapi`: routes extracted from `**/*.py`, same frontend globs; guard checks append `ruff` and `ruff-format`.
+- `frontend`: template globs `**/*.html` and frontend globs `**/src/**/*.ts` and `**/app/**/*.js`; guard checks append `eslint` and `prettier`.
 
 ### Blocking behavior
 
@@ -284,7 +306,7 @@ All checks are incremental: file-scoped checks run on files in the change-set, a
 
 ## Requirements
 
-- Python 3.6 or newer.
+- Python 3.8 or newer.
 - Standard library only at runtime; no third-party dependencies.
 - The `git` CLI on `PATH`.
 - Optional: `ruff`, `eslint`, and `prettier` for their respective checks (missing tools degrade to warnings).

{diffimpactscout-0.1.0 → diffimpactscout-0.3.0}/README.md

@@ -13,7 +13,7 @@ An incremental pre-push guard and AST blast-radius impact analyzer for git repos
 - Python AST symbol map: detects changed classes, functions, methods, module fields, and class fields, including deletions and renames.
 - Cross-layer impact linking: Python symbols to Django `{% url %}` template tags and frontend `http.get()/post()`-style calls.
 - Symbol cache (`.impact_analysis_cache.json`) so repeated runs skip unchanged files.
-- Profiles for `plain`, `django`, and `fastapi` projects.
+- Profiles for `generic`, `django`, `fastapi`, `python`, and `frontend` projects.
 - Configurable pre-push hook installation that never silently clobbers an existing hook.
 
 ## Core idea
@@ -33,7 +33,7 @@ The change-set also handles the full breadth of realistic push shapes: direct pu
 pip install diffimpactscout
 ```
 
-The package is pure Python (standard library only at runtime) and requires Python 3.6 or newer and the `git` CLI on `PATH`.
+The package is pure Python (standard library only at runtime) and requires Python 3.8 or newer and the `git` CLI on `PATH`.
 
 Optional tools are only needed for the checks that use them: `ruff`, `eslint` (via `npx`), and `prettier` (via `npx`). If one is missing, the affected check emits a warning and the guard continues; it never blocks a push because a tool is absent.
 
@@ -53,7 +53,21 @@ diffimpactscout impact
 diffimpactscout install-hooks
 ```
 
-`init` accepts `--profile plain|django|fastapi` to seed profile-appropriate settings.
+`init` accepts `--profile generic|django|fastapi|python|frontend` to seed profile-appropriate settings. `install-hooks` detects the stack automatically (see [Supported setups](#supported-setups)).
+
+## Supported setups
+
+`install-hooks` detects the project stack on first run and writes a `.diffimpactscout.json` that fits it:
+
+| Detection signal | Profile | Guard checks | Impact globs |
+| --- | --- | --- | --- |
+| `manage.py` + `settings.py`/`wsgi.py` | django | default + `ruff`, `ruff-format` | urls, templates, frontend |
+| `fastapi` in deps or `main.py` | fastapi | default + `ruff`, `ruff-format` | `**/*.py` routes + frontend globs |
+| `package.json` + `src`/`app` `*.ts`/`*.js` | frontend | default + `eslint`, `prettier` | templates + frontend globs |
+| `*.py` present | python | default + `ruff`, `ruff-format` | Python module references |
+| anything else (or no signal) | generic | default from `init` | none |
+
+Other ecosystems (Go, Rust, Java, Ruby, ...) are detected and reported as "planned for future releases" in the preview; the generic profile still installs the universal guard checks. Add a language linter with an [external check](#configuration).
 
 ## Commands
 
@@ -65,7 +79,7 @@ Writes a `.diffimpactscout.json` into the current directory. If the file already
 
 | Flag | Description |
 | --- | --- |
-| `--profile {plain,django,fastapi}` | Seed defaults from the named profile (default: `plain`). |
+| `--profile {generic,django,fastapi,python,frontend}` | Seed defaults from the named profile (default: `generic`). |
 
 ### `diffimpactscout guard`
 
@@ -97,8 +111,14 @@ Runs a single check by id (see [Checks reference](#checks-reference)). With no f
 
 Installs a `pre-push` git hook that runs `diffimpactscout guard` on push.
 
+On first run the command detects the stack, prints a preview of the `.diffimpactscout.json` it would write, and (when stdin is a terminal) asks for confirmation. Answer `n` to override profile, blocking mode, extra checks, and impact. Use `--yes` in CI to skip prompts, `--profile` and `--blocking` to pre-select settings, and `--reconfigure` to rewrite an existing config. Without `--reconfigure` an existing config is left untouched.
+
 | Flag | Description |
 | --- | --- |
+| `--profile {generic,django,fastapi,python,frontend}` | Pre-select the setup profile; skips the stack question. |
+| `--blocking {warn,strict}` | Blocking mode for guard checks (default: `warn`). |
+| `--yes`, `-y` | Accept defaults and skip prompts (non-interactive). |
+| `--reconfigure` | Rewrite an existing `.diffimpactscout.json`. |
 | `--force` | Overwrite an existing `pre-push` hook that DiffImpactScout did not install. |
 | `--uninstall` | Remove the DiffImpactScout `pre-push` hook. |
 
@@ -139,7 +159,7 @@ DiffImpactScout is configured by a `.diffimpactscout.json` file in the repositor
     "blocking": "warn"
   },
   "impact": {
-    "profile": "plain",
+    "profile": "generic",
     "urls_globs": [],
     "template_globs": [],
     "frontend_globs": [],
@@ -156,7 +176,7 @@ DiffImpactScout is configured by a `.diffimpactscout.json` file in the repositor
 | top-level | `use_gitignore` | When `true`, also excludes paths ignored by `git check-ignore`. |
 | `guard` | `checks` | Ordered list of check entries; each `{"id": ...}` may add `args`, `blocking`, and `always_block` overrides. |
 | `guard` | `blocking` | `"warn"` (default) or `"strict"`. In strict mode every check marked blocking can fail the run. |
-| `impact` | `profile` | `plain`, `django`, or `fastapi`; selects route extraction plus default globs. |
+| `impact` | `profile` | `generic`, `django`, or `fastapi`; selects route extraction plus default globs. |
 | `impact` | `urls_globs` / `template_globs` / `frontend_globs` | Glob patterns for route files, Django templates, and frontend sources. |
 | `impact` | `cache_file` | Path of the symbol cache (relative to the repo root). |
 | `impact` | `fast_mode`, `threads` | Reserved defaults from `init`; fast mode is currently selected with the `impact --fast` flag. |
@@ -171,9 +191,11 @@ External checks run `command` (each `{file}` placeholder is replaced with the fi
 
 ### Profiles
 
-- `plain`: no route or cross-layer globs; impact analysis reports only Python references.
+- `generic`: no route or cross-layer globs; impact analysis reports only Python references.
+- `python`: same impact globs as `generic`; guard checks append `ruff` and `ruff-format`.
 - `django`: route files `**/urls.py`, templates `**/templates/**/*.html`, frontend `**/src/**/*.ts` and `**/app/**/*.js`; guard checks append `ruff` and `ruff-format`.
 - `fastapi`: routes extracted from `**/*.py`, same frontend globs; guard checks append `ruff` and `ruff-format`.
+- `frontend`: template globs `**/*.html` and frontend globs `**/src/**/*.ts` and `**/app/**/*.js`; guard checks append `eslint` and `prettier`.
 
 ### Blocking behavior
 
@@ -267,7 +289,7 @@ All checks are incremental: file-scoped checks run on files in the change-set, a
 
 ## Requirements
 
-- Python 3.6 or newer.
+- Python 3.8 or newer.
 - Standard library only at runtime; no third-party dependencies.
 - The `git` CLI on `PATH`.
 - Optional: `ruff`, `eslint`, and `prettier` for their respective checks (missing tools degrade to warnings).

{diffimpactscout-0.1.0 → diffimpactscout-0.3.0}/setup.py

@@ -7,13 +7,13 @@ with io.open("README.md", encoding="utf-8") as fh:
 
 setup(
     name="diffimpactscout",
-    version="0.1.0",
+    version="0.3.0",
     description="Incremental pre-push guard and AST blast-radius impact analyzer for git repositories.",
     long_description=long_description,
     long_description_content_type="text/markdown",
     license="MIT",
     author="DiffImpactScout contributors",
-    python_requires=">=3.6",
+    python_requires=">=3.8",
     packages=find_packages("src"),
     package_dir={"": "src"},
     package_data={"diffimpactscout": ["profiles/*.json"]},

{diffimpactscout-0.1.0 → diffimpactscout-0.3.0}/src/diffimpactscout/__init__.py

@@ -1,3 +1,3 @@
 """diffimpactscout: incremental pre-push guard and AST blast-radius impact analyzer."""
 
-__version__ = "0.1.0"
+__version__ = "0.3.0"

{diffimpactscout-0.1.0 → diffimpactscout-0.3.0}/src/diffimpactscout/base.py

@@ -2,13 +2,54 @@
 
 Example: when the repo has an upstream/sprint/12 ref, diffs are measured
 against it instead of origin/master.
+
+================================================================================
+ARCHITECTURAL OVERVIEW: 2-DOT TREE DIFF FOR INCREMENTAL CHECKS
+================================================================================
+
+Why a 2-dot tree diff (`git diff <anchor> HEAD`):
+
+In standard Git workflows a 3-dot diff (`git diff <anchor>...HEAD`) computes
+changes relative to the common merge-base ancestor of the two tips. Whenever a
+developer syncs their branch with upstream (merge, rebase, or squash), the
+merge-base moves and the 3-dot range silently grows to include every commit
+introduced by upstream since the branch diverged. Every pre-existing upstream
+violation (a stale trailing space, a long line, an old lint error) then shows up
+as a "new" issue in the pre-push guard, producing false positives the developer
+did not author and cannot reasonably fix in that push.
+
+A 2-dot tree diff (`git diff <anchor> HEAD`, no `...`) compares the exact
+filesystem snapshot ("tree") of the resolved upstream anchor directly against
+the `HEAD` tree. Consequences:
+
+  1. Zero Upstream Blame: any file or line that exists byte-identically in the
+     anchor tree contributes no diff entries. Only files and lines actually
+     added or changed by the developer are passed to the checks.
+  2. Sync Agnostic: behaves identically whether the branch was synced with
+     `git merge`, `git rebase`, or `git merge --squash`, because it never walks
+     commit ancestry, only the two tip trees.
+  3. Shallow-Clone Safe: computing the name-only diff needs just the two tip
+     trees (plus any blobs referenced in the range), so it works on shallow
+     clones that lack full commit history.
+
+Sprint branch resolution:
+
+In sprint-based development models (e.g. Contify) work is branched from active
+sprint branches such as `refs/remotes/upstream/sprint/33.1` rather than from
+`master`. The resolver inspects `refs/remotes/upstream/master` plus the top
+`DEFAULT_MAX_SPRINT_CANDIDATES` (5) most recent sprint branches sorted by
+committer date, and picks the candidate whose tree is closest to `HEAD` (the
+fewest changed files on a `--diff-filter=ACMRT` name-only diff). The closest
+tree means the smallest honest change-set, which is what incremental checks
+want to target.
+================================================================================
 """
 
 import diffimpactscout.gitrun as gitrun
 
 MASTER_REF = "refs/remotes/upstream/master"
 SPRINT_PREFIX = "sprint/"
-DEFAULT_MAX_SPRINT_CANDIDATES = 10
+DEFAULT_MAX_SPRINT_CANDIDATES = 5
 REMOTE_FALLBACKS = ("main", "master", "develop")
 
 
@@ -16,7 +57,7 @@ def resolve_change_base(root, limit=DEFAULT_MAX_SPRINT_CANDIDATES):
     """Return the remote ref closest to HEAD, or None.
 
     `limit` caps how many `sprint/*` refs are considered: only the
-    `limit` (default 10) most-recent ones by committer date, unlike the
+    `limit` (default 5) most-recent ones by committer date, unlike the
     bash original dev_base.sh which considered every sprint branch.
     """
     for remote in _remote_order(root):

{diffimpactscout-0.1.0 → diffimpactscout-0.3.0}/src/diffimpactscout/checks/base.py

@@ -97,7 +97,9 @@ class ExternalCheck(Check):
                 output = (out or err).decode("utf-8", errors="replace").strip()
                 if not output:
                     output = "exit code %s" % proc.returncode
-                issues.append(CheckIssue(".", 0, 0, self.id, output))
+                else:
+                    output = "%s (exit code %s)" % (output, proc.returncode)
+                issues.append(CheckIssue(".", None, None, self.id, output))
             return CheckResult(issues=issues, fixed=fixed, skipped=skipped, warned=warned)
         for path in files or []:
             argv = self._argv_for(path)
@@ -116,7 +118,9 @@ class ExternalCheck(Check):
                 output = (out or err).decode("utf-8", errors="replace").strip()
                 if not output:
                     output = "exit code %s" % proc.returncode
-                issues.append(CheckIssue(path, 0, 0, self.id, output))
+                else:
+                    output = "%s (exit code %s)" % (output, proc.returncode)
+                issues.append(CheckIssue(path, None, None, self.id, output))
         return CheckResult(issues=issues, fixed=fixed, skipped=skipped, warned=warned)
 
 
@@ -151,7 +155,7 @@ class CheckContext(object):
 
 
 class CheckIssue(object):
-    def __init__(self, path, line, column, code, message):
+    def __init__(self, path, line=None, column=None, code=None, message=None):
         self.path = path
         self.line = line
         self.column = column
@@ -159,13 +163,13 @@ class CheckIssue(object):
         self.message = message
 
     def format(self):
-        return "%s:%s:%s: %s %s" % (
-            self.path,
-            self.line,
-            self.column,
-            self.code,
-            self.message,
-        )
+        if self.line is None and self.column is None:
+            location = self.path
+        else:
+            line = "-" if self.line is None else str(self.line)
+            column = "-" if self.column is None else str(self.column)
+            location = "%s:%s:%s" % (self.path, line, column)
+        return "%s: %s %s" % (location, self.code, self.message)
 
 
 class CheckResult(object):

{diffimpactscout-0.1.0 → diffimpactscout-0.3.0}/src/diffimpactscout/checks/eslint.py

@@ -155,8 +155,8 @@ class EslintCheck(Check):
                     issues.append(
                         CheckIssue(
                             path,
-                            line or 0,
-                            column or 0,
+                            line,
+                            column,
                             rule_id or self.id,
                             message.get("message") or "",
                         )

{diffimpactscout-0.1.0 → diffimpactscout-0.3.0}/src/diffimpactscout/checks/prettier.py

@@ -93,8 +93,8 @@ class PrettierCheck(Check):
             issues.append(
                 CheckIssue(
                     path,
-                    0,
-                    0,
+                    None,
+                    None,
                     self.id,
                     "%s is not formatted. Fix with: npx prettier --write %s"
                     % (path, path),

{diffimpactscout-0.1.0 → diffimpactscout-0.3.0}/src/diffimpactscout/checks/repo_checks.py

@@ -1,11 +1,14 @@
-"""Repo-wide checks for oversized files and leaked private keys.
+"""Repo-wide checks for oversized files, leaked private keys, and case-colliding file paths.
 
-Example: a 300 MB binary is flagged with a git-lfs hint, and any file
-containing a private key block always blocks the push.
+Example: a 300 MB binary is flagged with a git-lfs hint, any file
+containing a private key block always blocks the push, and a pushed
+`FILE.TXT` colliding with a tracked `file.txt` is flagged because the two
+names clobber each other on case-insensitive filesystems (macOS, Windows).
 """
 
 import os
 
+import diffimpactscout.gitrun as gitrun
 from diffimpactscout.checks.base import (
     Check,
     CheckIssue,
@@ -23,6 +26,33 @@ PRIVATE_KEY_MARKERS = (
 )
 
 
+@register
+class CaseConflictCheck(Check):
+    id = "repo/case-conflict"
+    scoped = "files"
+
+    def run(self, context, files):
+        tracked = gitrun.git_nul(["ls-files", "-z"], context.root)
+        by_lower = {}
+        for path in tracked:
+            by_lower.setdefault(path.lower(), []).append(path)
+        issues = []
+        for path in files or []:
+            for other in by_lower.get(path.lower(), ()):
+                if other != path:
+                    issues.append(
+                        CheckIssue(
+                            path,
+                            None,
+                            None,
+                            self.id,
+                            "case conflict detected with %s" % other,
+                        )
+                    )
+                    break
+        return CheckResult(issues=issues)
+
+
 @register
 class LargeFilesCheck(Check):
     id = "repo/large-files"
@@ -61,8 +91,8 @@ class LargeFilesCheck(Check):
                 issues.append(
                     CheckIssue(
                         path,
-                        0,
-                        0,
+                        None,
+                        None,
                         self.id,
                         "file size %d kB exceeds limit of %d kB; consider git lfs"
                         % (size_kb, self.max_kb),
@@ -89,7 +119,7 @@ class PrivateKeyCheck(Check):
             for marker in PRIVATE_KEY_MARKERS:
                 if marker in data:
                     issues.append(
-                        CheckIssue(path, 0, 0, self.id, "private key detected")
+                        CheckIssue(path, None, None, self.id, "private key detected")
                     )
                     break
         return CheckResult(issues=issues)

{diffimpactscout-0.1.0 → diffimpactscout-0.3.0}/src/diffimpactscout/checks/ruff.py

@@ -18,6 +18,21 @@ from diffimpactscout.checks.base import (
 _HUNK_RE = re.compile(r"^@@ -(\d+)(?:,(\d+))? \+(\d+)(?:,(\d+))? @@")
 
 
+def _split_hunks(text):
+    hunks = []
+    current = []
+    for line in text.split("\n"):
+        if line.startswith("@@"):
+            if current:
+                hunks.append("\n".join(current))
+            current = [line]
+        else:
+            current.append(line)
+    if current:
+        hunks.append("\n".join(current))
+    return hunks
+
+
 def _truncate(text, limit=30):
     lines = text.split("\n")
     if len(lines) <= limit:
@@ -55,7 +70,7 @@ def _filter_diff_by_lines(diff, changed):
         i += 1
     out = list(header)
     body = "\n".join(lines[i:])
-    for hunk in re.split(r"(?=^@@)", body, flags=re.MULTILINE):
+    for hunk in _split_hunks(body):
         if not hunk.startswith("@@"):
             continue
         m = _HUNK_RE.match(hunk)
@@ -142,8 +157,8 @@ class RuffCheck(Check):
                 issues.append(
                     CheckIssue(
                         path,
-                        row or 0,
-                        location.get("column") or 0,
+                        row,
+                        location.get("column"),
                         violation.get("code") or self.id,
                         violation.get("message") or "",
                     )
@@ -200,8 +215,8 @@ class RuffFormatCheck(Check):
             issues.append(
                 CheckIssue(
                     path,
-                    0,
-                    0,
+                    None,
+                    None,
                     self.id,
                     "formatting issue in changed lines:\n%s\nFix with: ruff format %s"
                     % (_truncate(kept), path),

{diffimpactscout-0.1.0 → diffimpactscout-0.3.0}/src/diffimpactscout/checks/syntax.py

@@ -38,8 +38,8 @@ class JsonSyntaxCheck(Check):
                 issues.append(
                     CheckIssue(
                         path,
-                        getattr(exc, "lineno", 0) or 0,
-                        getattr(exc, "colno", 0) or 0,
+                        getattr(exc, "lineno", None),
+                        getattr(exc, "colno", None),
                         self.id,
                         "invalid JSON: %s" % exc,
                     )
@@ -69,8 +69,8 @@ class AstSyntaxCheck(Check):
                 issues.append(
                     CheckIssue(
                         path,
-                        exc.lineno or 0,
-                        exc.offset or 0,
+                        exc.lineno,
+                        exc.offset,
                         self.id,
                         "invalid python syntax: %s" % (exc.msg or "syntax error"),
                     )
@@ -78,7 +78,11 @@ class AstSyntaxCheck(Check):
             except ValueError as exc:
                 issues.append(
                     CheckIssue(
-                        path, 0, 0, self.id, "invalid python source: %s" % exc
+                        path,
+                        None,
+                        None,
+                        self.id,
+                        "invalid python source: %s" % exc,
                     )
                 )
         return CheckResult(issues=issues)
@@ -111,7 +115,7 @@ class MergeConflictCheck(Check):
                 line = lines[lineno - 1]
                 if self._is_marker(line):
                     issues.append(
-                        CheckIssue(path, lineno, 0, self.id, "conflict marker found")
+                        CheckIssue(path, lineno, None, self.id, "conflict marker found")
                     )
         return CheckResult(issues=issues)