devlaunch 0.0.15__tar.gz → 0.0.16__tar.gz

{devlaunch-0.0.15 → devlaunch-0.0.16}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: devlaunch
-Version: 0.0.15
+Version: 0.0.16
 Summary: DevLaunch - A streamlined CLI for devpod workspaces
 Project-URL: Source, https://github.com/blooop/devlaunch
 Project-URL: Home, https://github.com/blooop/devlaunch
@@ -267,6 +267,11 @@ something to be spent on whatever the image ships. Check a workspace with:
 dl <workspace> -- gh auth status
 ```
 
+If no token can be found, `dl` warns on stderr and opens the workspace anyway rather
+than failing — and the warning names the config directory `gh` consulted, because the
+usual cause is a shell that scoped `XDG_CONFIG_HOME` somewhere `gh` has no login,
+not a host that is actually logged out.
+
 ### Who gets the token
 
 Everything running in the container does — including a `postCreateCommand` from a

{devlaunch-0.0.15 → devlaunch-0.0.16}/README.md

@@ -245,6 +245,11 @@ something to be spent on whatever the image ships. Check a workspace with:
 dl <workspace> -- gh auth status
 ```
 
+If no token can be found, `dl` warns on stderr and opens the workspace anyway rather
+than failing — and the warning names the config directory `gh` consulted, because the
+usual cause is a shell that scoped `XDG_CONFIG_HOME` somewhere `gh` has no login,
+not a host that is actually logged out.
+
 ### Who gets the token
 
 Everything running in the container does — including a `postCreateCommand` from a

{devlaunch-0.0.15 → devlaunch-0.0.16}/devlaunch/gh_auth.py

@@ -27,6 +27,8 @@ import subprocess
 import tempfile
 from typing import Dict, Iterator, List, Optional, Tuple
 
+from devlaunch.xdg import config_home
+
 # The variable set inside the container. gh consults it before its config file.
 TOKEN_VAR = "GH_TOKEN"
 
@@ -74,14 +76,31 @@ def _token_from_gh_cli() -> Optional[str]:
             timeout=_GH_TIMEOUT_SECONDS,
         )
     except (OSError, subprocess.SubprocessError) as e:
-        logging.debug("Could not read a GitHub token from gh: %s", e)
+        logging.warning(
+            "Could not read a GitHub token from gh (%s), so this workspace opens "
+            "without a GitHub login.",
+            e,
+        )
         return None
     if result.returncode != 0:
-        logging.debug("gh auth token exited %s; no GitHub auth to forward", result.returncode)
+        # Name the config dir: a run that scoped XDG_CONFIG_HOME to a scratch
+        # directory hides the host's gh login, so gh refuses even though the user
+        # is logged in, and `gh auth login` is exactly the wrong remedy for it.
+        logging.warning(
+            "gh auth token exited %s, so this workspace opens without a GitHub login. "
+            "gh read its config from %s -- if you are logged in on this host, that "
+            "directory is the thing to check before `gh auth login`.",
+            result.returncode,
+            config_home(),
+        )
         return None
-    # Never log the value itself, only whether it was usable.
+    # Never log the value itself, only whether it was usable: what gh printed may
+    # be a malformed credential, and a warning is not a place to put one.
     if not _is_token(result.stdout.strip()):
-        logging.debug("gh auth token printed something that is not a token; ignoring it")
+        logging.warning(
+            "gh auth token printed something that is not a token, so this workspace "
+            "opens without a GitHub login."
+        )
         return None
     return result.stdout.strip()
 
@@ -112,13 +131,21 @@ def _stage_token_file(token: str) -> Optional[str]:
     try:
         fd, path = tempfile.mkstemp(prefix="devlaunch-gh-", suffix=".env")
     except OSError as e:
-        logging.debug("Could not create a file to pass the GitHub token to devpod: %s", e)
+        logging.warning(
+            "Could not create a file to pass the GitHub token to devpod (%s), so this "
+            "workspace opens without a GitHub login.",
+            e,
+        )
         return None
     try:
         with os.fdopen(fd, "w") as handle:
             handle.write(f"{TOKEN_VAR}={token}\n")
     except OSError as e:
-        logging.debug("Could not write the GitHub token for devpod: %s", e)
+        logging.warning(
+            "Could not write the GitHub token for devpod (%s), so this workspace "
+            "opens without a GitHub login.",
+            e,
+        )
         with contextlib.suppress(OSError):
             os.unlink(path)
         return None

{devlaunch-0.0.15 → devlaunch-0.0.16}/devlaunch/worktree/config.py

@@ -7,6 +7,8 @@ from typing import Dict, Optional, Union
 
 import tomli
 
+from devlaunch.xdg import config_home
+
 
 def _get_cache_base() -> Path:
     """Get the base cache directory, honoring XDG_CACHE_HOME."""
@@ -86,8 +88,7 @@ class WorktreeConfig:
 
 def get_config_path() -> Path:
     """Get the path to the config file."""
-    config_dir = Path(os.environ.get("XDG_CONFIG_HOME", Path.home() / ".config"))
-    return config_dir / "devlaunch" / "config.toml"
+    return config_home() / "devlaunch" / "config.toml"
 
 
 def load_config() -> Dict:

devlaunch-0.0.16/devlaunch/xdg.py

@@ -0,0 +1,21 @@
+"""Where the XDG base directories point on this machine.
+
+Two unrelated places ask for the config home: the worktree loader, which reads
+`config.toml` under it, and the gh-token warning, which names it so a user whose
+shell scoped the variable can see why `gh auth token` refused. Those two have to
+agree -- a warning that names one directory while the loader reads another is
+worse than no warning -- so they share the answer rather than each spelling it.
+"""
+
+import os
+from pathlib import Path
+
+
+def config_home() -> Path:
+    """`$XDG_CONFIG_HOME`, or the `~/.config` the spec falls back to.
+
+    An empty value counts as unset, which is what the XDG basedir spec says and
+    what a shell exporting the variable with no value means. Reading it any other
+    way resolves the config path relative to the working directory instead.
+    """
+    return Path(os.environ.get("XDG_CONFIG_HOME") or Path.home() / ".config")

{devlaunch-0.0.15 → devlaunch-0.0.16}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "devlaunch"
-version = "0.0.15"
+version = "0.0.16"
 authors = [{ name = "Austin Gregg-Smith", email = "blooop@gmail.com" }]
 description = "DevLaunch - A streamlined CLI for devpod workspaces"
 readme = "README.md"