devflow-engine 1.1.27__tar.gz → 1.1.28__tar.gz

{devflow_engine-1.1.27 → devflow_engine-1.1.28}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: devflow-engine
-Version: 1.1.27
+Version: 1.1.28
 Summary: DevFlow v2 CLI-first engine (projects, stories, execution store, review packets)
 Author: DevFlow
 License: Proprietary

{devflow_engine-1.1.27 → devflow_engine-1.1.28}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "devflow-engine"
-version = "1.1.27"
+version = "1.1.28"
 description = "DevFlow v2 CLI-first engine (projects, stories, execution store, review packets)"
 readme = "README.md"
 requires-python = ">=3.11"

{devflow_engine-1.1.27 → devflow_engine-1.1.28}/src/devflow_engine/__init__.py

@@ -1,3 +1,3 @@
 __all__ = ["__version__"]
 
-__version__ = "1.1.24"
+__version__ = "1.1.28"

{devflow_engine-1.1.27 → devflow_engine-1.1.28}/src/devflow_engine/devflow_event_worker.py

@@ -504,68 +504,13 @@ class DevflowEventWorkerService:
                     "error": str(exc),
                 })
 
-        # Stage and commit the added source docs (and any DDR output) into the
-        # project repo. Mirrors the git plane owned by implementation/dag.py:
-        # `git add -A` + `git commit --no-verify`, with an empty-diff guard so
-        # re-uploading identical bytes does not create an empty commit.
-        committed = False
-        commit_sha: str | None = None
-        commit_error: str | None = None
-        try:
-            subprocess.run(
-                ["git", "add", "-A"],
-                cwd=str(repo_root),
-                check=False,
-                capture_output=True,
-                text=True,
-            )
-            staged = subprocess.run(
-                ["git", "diff", "--cached", "--name-only"],
-                cwd=str(repo_root),
-                check=False,
-                capture_output=True,
-                text=True,
-            )
-            staged_paths = [line for line in (staged.stdout or "").splitlines() if line.strip()]
-            if staged_paths:
-                event_ref = str(event.get("id") or event.get("run_id") or "unknown")
-                message = (
-                    f"source docs: add {len(added_files)} file(s)"
-                    f"\n\nDevFlow-Event: {event_ref}\n"
-                )
-                commit = subprocess.run(
-                    ["git", "commit", "--no-verify", "-m", message],
-                    cwd=str(repo_root),
-                    check=False,
-                    capture_output=True,
-                    text=True,
-                )
-                if commit.returncode == 0:
-                    committed = True
-                    rev = subprocess.run(
-                        ["git", "rev-parse", "HEAD"],
-                        cwd=str(repo_root),
-                        check=False,
-                        capture_output=True,
-                        text=True,
-                    )
-                    commit_sha = (rev.stdout or "").strip() or None
-                else:
-                    commit_error = (commit.stderr or commit.stdout or "git commit failed").strip()[-500:]
-        except Exception as exc:  # never fail the upload because the commit failed
-            commit_error = str(exc)
-
         result_data = {
             "source_mode": source_mode,
             "added_count": len(added_files),
             "added_files": added_files,
             "source_docs_root": str(source_docs_root),
             "local_repo_root": str(repo_root),
-            "committed": committed,
-            "commit_sha": commit_sha,
         }
-        if commit_error:
-            result_data["commit_error"] = commit_error
         if ddr_results:
             result_data["ddr_analysis"] = ddr_results if len(ddr_results) > 1 else ddr_results[0]
         return result_data

{devflow_engine-1.1.27 → devflow_engine-1.1.28}/src/devflow_engine/errors/runtime_observability.py

@@ -116,12 +116,13 @@ def _coerce_repro_artifact_to_observability_sandbox(
     state: dict[str, Any],
     sandbox_rel: str,
 ) -> None:
-    """Do not accept repo-mutating repro artifacts as observation proof.
+    """Annotate repo-mutating repro artifacts without invalidating evidence.
 
     The observe phase may create evidence artifacts, but they must live under
     `.devflow/observability/<error_task_id>/`. If an agent writes a repro test
-    into the product test suite, that is useful draft work but not clean
-    observation evidence.
+    into the product test suite, that is useful draft work and must be cleaned
+    up by the workspace-preservation path. It is not, by itself, proof that the
+    reported symptom was unobserved.
     """
     artifact = str(state.get("repro_artifact_path") or "").strip()
     command = str(state.get("repro_run_command") or "").strip()
@@ -139,8 +140,8 @@ def _coerce_repro_artifact_to_observability_sandbox(
         "requires artifacts under "
         f"{sandbox_prefix} so observe does not mutate product tests."
     )
-    state["observed"] = False
-    state["confidence"] = "low"
+    if state.get("observed") is not True:
+        state["confidence"] = "low"
     state["repro_output"] = "\n".join(
         part for part in [str(state.get("repro_output") or "").strip(), note] if part
     )[-3000:]

{devflow_engine-1.1.27 → devflow_engine-1.1.28}/tests/test_devflow_event_worker.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 import base64
-import subprocess
 import json
 from datetime import UTC, datetime, timedelta
 from hashlib import sha256
@@ -555,101 +554,6 @@ def test_project_source_docs_add_request_writes_filesystem_uploads(tmp_path: Pat
     assert result["added_files"] == ["ai_docs/context/source_docs/notes.md"]
 
 
-def test_project_source_docs_add_request_stages_and_commits(tmp_path: Path) -> None:
-    repo_root = tmp_path / "repo"
-    repo_root.mkdir()
-    for cmd in (
-        ["git", "init"],
-        ["git", "config", "user.email", "test@devflow.local"],
-        ["git", "config", "user.name", "DevFlow Test"],
-        ["git", "commit", "--allow-empty", "-m", "root"],
-    ):
-        subprocess.run(cmd, cwd=str(repo_root), check=True, capture_output=True, text=True)
-
-    service = DevflowEventWorkerService()
-    encoded = base64.b64encode(b"hello source docs\n").decode("ascii")
-
-    result = service._run_project_source_docs_add_request(
-        event={
-            "id": "evt-123",
-            "payload": {
-                "source_mode": "filesystem",
-                "files": [{"name": "notes.md", "content_base64": encoded}],
-            },
-        },
-        project={"id": "proj-1", "devflow_repo_root": str(repo_root), "metadata": {}},
-    )
-
-    # The upload was committed, not just written.
-    assert result["committed"] is True
-    assert isinstance(result["commit_sha"], str) and len(result["commit_sha"]) == 40
-
-    # Working tree is clean: the file is tracked and committed.
-    status = subprocess.run(
-        ["git", "status", "--porcelain"],
-        cwd=str(repo_root),
-        check=True,
-        capture_output=True,
-        text=True,
-    )
-    assert status.stdout.strip() == ""
-
-    # The committed tree actually contains the uploaded file.
-    tracked = subprocess.run(
-        ["git", "show", "--name-only", "--pretty=format:", "HEAD"],
-        cwd=str(repo_root),
-        check=True,
-        capture_output=True,
-        text=True,
-    )
-    assert "ai_docs/context/source_docs/notes.md" in tracked.stdout
-
-
-def test_project_source_docs_add_request_skips_empty_commit_on_reupload(tmp_path: Path) -> None:
-    repo_root = tmp_path / "repo"
-    repo_root.mkdir()
-    for cmd in (
-        ["git", "init"],
-        ["git", "config", "user.email", "test@devflow.local"],
-        ["git", "config", "user.name", "DevFlow Test"],
-        ["git", "commit", "--allow-empty", "-m", "root"],
-    ):
-        subprocess.run(cmd, cwd=str(repo_root), check=True, capture_output=True, text=True)
-
-    service = DevflowEventWorkerService()
-    encoded = base64.b64encode(b"hello source docs\n").decode("ascii")
-    event = {
-        "id": "evt-123",
-        "payload": {
-            "source_mode": "filesystem",
-            "files": [{"name": "notes.md", "content_base64": encoded}],
-        },
-    }
-
-    first = service._run_project_source_docs_add_request(
-        event=event,
-        project={"id": "proj-1", "devflow_repo_root": str(repo_root), "metadata": {}},
-    )
-    assert first["committed"] is True
-
-    head_after_first = subprocess.run(
-        ["git", "rev-parse", "HEAD"], cwd=str(repo_root), check=True, capture_output=True, text=True
-    ).stdout.strip()
-
-    # Re-uploading identical bytes must not create an empty commit.
-    second = service._run_project_source_docs_add_request(
-        event=event,
-        project={"id": "proj-1", "devflow_repo_root": str(repo_root), "metadata": {}},
-    )
-    assert second["committed"] is False
-    assert second["commit_sha"] is None
-
-    head_after_second = subprocess.run(
-        ["git", "rev-parse", "HEAD"], cwd=str(repo_root), check=True, capture_output=True, text=True
-    ).stdout.strip()
-    assert head_after_first == head_after_second
-
-
 def test_settings_changed_request_routes_non_secret_settings_through_current_config_pipeline(monkeypatch: pytest.MonkeyPatch) -> None:
     service = DevflowEventWorkerService()
     event = {

{devflow_engine-1.1.27 → devflow_engine-1.1.28}/tests/test_observability_evidence_contract.py

@@ -78,7 +78,7 @@ def test_required_keys_encode_the_evidence_contract():
         assert k in ro._FINAL_REQUIRED_KEYS
 
 
-def test_repro_artifact_outside_observability_sandbox_is_not_clean_evidence() -> None:
+def test_repro_artifact_outside_observability_sandbox_is_hygiene_warning_not_evidence_failure() -> None:
     state = {
         "observed": True,
         "confidence": "high",
@@ -93,8 +93,8 @@ def test_repro_artifact_outside_observability_sandbox_is_not_clean_evidence() ->
         sandbox_rel=".devflow/observability/bug-1",
     )
 
-    assert state["observed"] is False
-    assert state["confidence"] == "low"
+    assert state["observed"] is True
+    assert state["confidence"] == "high"
     assert "outside the observability sandbox" in state["repro_output"]
     assert state["deferred_questions"]