dbt-altertable 0.2.2__tar.gz → 0.2.4__tar.gz

{dbt_altertable-0.2.2 → dbt_altertable-0.2.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dbt-altertable
-Version: 0.2.2
+Version: 0.2.4
 Summary: DBT adapter for Altertable
 Project-URL: Homepage, https://github.com/altertable-ai/dbt-altertable
 Project-URL: Repository, https://github.com/altertable-ai/dbt-altertable
@@ -22,7 +22,7 @@ Classifier: Programming Language :: Python :: 3.13
 Classifier: Topic :: Database
 Classifier: Topic :: Software Development :: Libraries :: Python Modules
 Requires-Python: >=3.10
-Requires-Dist: altertable-flightsql>=0.2.1
+Requires-Dist: altertable-flightsql>=0.3.1
 Requires-Dist: dbt-adapters<2.0,>=1.5
 Requires-Dist: dbt-core<2.0,>=1.8
 Requires-Dist: pyarrow>=14
@@ -30,11 +30,14 @@ Provides-Extra: dev
 Requires-Dist: conventional-pre-commit>=4.4; extra == 'dev'
 Requires-Dist: pre-commit>=4.0; extra == 'dev'
 Requires-Dist: pytest-mock>=3.10.0; extra == 'dev'
+Requires-Dist: pytest-xdist>=3.7; extra == 'dev'
 Requires-Dist: pytest>=7.0.0; extra == 'dev'
 Requires-Dist: ruff>=0.15.11; extra == 'dev'
 Requires-Dist: ty>=0.0.32; extra == 'dev'
 Provides-Extra: integration
 Requires-Dist: testcontainers>=4.0.0; extra == 'integration'
+Provides-Extra: metricflow
+Requires-Dist: dbt-metricflow>=0.12.0; extra == 'metricflow'
 Description-Content-Type: text/markdown
 
 # dbt-altertable

{dbt_altertable-0.2.2 → dbt_altertable-0.2.4}/dbt/adapters/altertable/__init__.py

@@ -1,9 +1,14 @@
+import contextlib
+
 from dbt.adapters.base import AdapterPlugin
 
 from dbt.adapters.altertable.credentials import AltertableCredentials
 from dbt.adapters.altertable.impl import AltertableAdapter
 from dbt.include import altertable
 
+with contextlib.suppress(ModuleNotFoundError):
+    from dbt.adapters.altertable import metricflow as _  # noqa: F401
+
 __all__ = ["AltertableAdapter", "AltertableCredentials", "Plugin"]
 
 Plugin = AdapterPlugin(

dbt_altertable-0.2.4/dbt/adapters/altertable/__version__.py

@@ -0,0 +1 @@
+version = "0.2.4"  # x-release-please-version

{dbt_altertable-0.2.2 → dbt_altertable-0.2.4}/dbt/adapters/altertable/connections.py

@@ -1,3 +1,4 @@
+import threading
 from collections.abc import Iterator, Mapping, Sequence
 from contextlib import contextmanager
 from datetime import date, datetime
@@ -265,8 +266,7 @@ class AltertableConnection:
         return AltertableCursor(self._client)
 
     def close(self) -> None:
-        """Close the connection."""
-        self._client.close()
+        pass
 
     def commit(self) -> None:
         """Commit current transaction (no-op for now as we use auto-commit)."""
@@ -277,6 +277,9 @@ class AltertableConnection:
 
 class AltertableConnectionManager(SQLConnectionManager):
     TYPE = "altertable"
+    _client_lock: threading.Lock = threading.Lock()
+    _shared_client: altertable_flightsql.Client | None = None
+    _shared_credentials_key: tuple | None = None
 
     @classmethod
     def data_type_code_to_name(cls, type_code: Any) -> str:
@@ -301,6 +304,23 @@ class AltertableConnectionManager(SQLConnectionManager):
     def cancel(self, connection: Connection) -> None:
         logger.debug(f"Attempting to cancel connection: {connection.name}")
 
+    def begin(self):
+        connection = self.get_thread_connection()
+        connection.transaction_open = True
+        return connection
+
+    def commit(self):
+        connection = self.get_thread_connection()
+        connection.transaction_open = False
+        return connection
+
+    def release(self) -> None:
+        with self.lock:
+            conn = self.get_if_exists()
+            if conn is None:
+                return
+        conn.transaction_open = False
+
     @classmethod
     def open(cls, connection: Connection) -> Connection:
         if connection.state == ConnectionState.OPEN:
@@ -320,16 +340,28 @@ class AltertableConnectionManager(SQLConnectionManager):
 
     @classmethod
     def _connect_client(cls, credentials: AltertableCredentials) -> "AltertableConnection":
-        client = altertable_flightsql.Client(
-            username=credentials.username,
-            password=credentials.password,
-            catalog=None,
-            schema=None,
-            host=credentials.host,
-            port=credentials.port,
-            tls=credentials.tls,
+        key = (
+            credentials.username,
+            credentials.password,
+            credentials.host,
+            credentials.port,
+            credentials.database,
+            credentials.schema,
+            credentials.tls,
         )
-        return AltertableConnection(client)
+        with cls._client_lock:
+            if cls._shared_client is None or cls._shared_credentials_key != key:
+                cls._shared_client = altertable_flightsql.Client(
+                    username=credentials.username,
+                    password=credentials.password,
+                    catalog=credentials.database,
+                    schema=credentials.schema,
+                    host=credentials.host,
+                    port=credentials.port,
+                    tls=credentials.tls,
+                )
+                cls._shared_credentials_key = key
+        return AltertableConnection(cls._shared_client)
 
     @classmethod
     def get_response(cls, cursor: AltertableCursor) -> AdapterResponse:

{dbt_altertable-0.2.2 → dbt_altertable-0.2.4}/dbt/adapters/altertable/impl.py

@@ -1,3 +1,6 @@
+import os
+
+from dbt.adapters.base import available
 from dbt.adapters.sql import SQLAdapter
 
 from dbt.adapters.altertable.connections import AltertableConnectionManager
@@ -9,3 +12,7 @@ class AltertableAdapter(SQLAdapter):
     @classmethod
     def date_function(cls) -> str:
         return "now()"
+
+    @available
+    def get_seed_file_path(self, model) -> str:
+        return os.path.join(model["root_path"], model["original_file_path"])

dbt_altertable-0.2.4/dbt/adapters/altertable/metricflow.py

@@ -0,0 +1,22 @@
+from __future__ import annotations
+
+from dbt_metricflow.cli.dbt_connectors.adapter_backed_client import AdapterBackedSqlClient
+from metricflow.protocols.sql_client import SqlEngine
+from metricflow.sql.render.duckdb_renderer import DuckDbSqlPlanRenderer
+
+# dbt-metricflow only accepts a hardcoded list of 7 adapters and crashes on anything else.
+# This patch intercepts the initialization and tells it to use DuckDB's SQL renderer,
+# since Altertable runs on DuckLake which uses DuckDB SQL dialect.
+_original_init = AdapterBackedSqlClient.__init__
+
+
+def _patched_init(self, adapter) -> None:
+    if adapter.type() == "altertable":
+        self._adapter = adapter
+        self._sql_engine_type = SqlEngine.DUCKDB
+        self._sql_plan_renderer = DuckDbSqlPlanRenderer()
+    else:
+        _original_init(self, adapter)
+
+
+AdapterBackedSqlClient.__init__ = _patched_init  # ty: ignore[invalid-assignment]

{dbt_altertable-0.2.2 → dbt_altertable-0.2.4}/dbt/include/altertable/macros/persist_docs.sql

@@ -32,6 +32,15 @@
   one statement per round-trip; the outer run_query then receives an empty string and skips.
 #}
 {% macro altertable__alter_column_comment(relation, column_dict) -%}
+  {# Altertable does not support COMMENT ON COLUMN for views (relation-level COMMENT ON VIEW is supported). #}
+  {%- if relation.is_view and column_dict | length > 0 -%}
+    {%- do exceptions.raise_compiler_error(
+      "The Altertable engine does not support COMMENT ON COLUMN for views (relation-level comments are supported). "
+      ~ "Disable column persistence for this model with persist_docs: {columns: false}, "
+      ~ "or remove column description entries from its schema YAML. "
+      ~ "Relation: " ~ relation.render()
+    ) -%}
+  {%- endif -%}
   {%- set existing_columns = adapter.get_columns_in_relation(relation) | map(attribute="name") | list -%}
   {%- set existing_lower_map = {} -%}
   {%- for col in existing_columns -%}

{dbt_altertable-0.2.2 → dbt_altertable-0.2.4}/dbt/include/altertable/macros/seed.sql

@@ -8,7 +8,7 @@
 {% endmacro %}
 
 {% macro altertable__load_csv_rows(model, agate_table) %}
-    {% if config.get('fast', true) %}
+    {% if config.get('fast', false) %}
         {% set seed_file_path = adapter.get_seed_file_path(model) %}
         {% set delimiter = config.get('delimiter', ',') %}
         {% set sql %}

{dbt_altertable-0.2.2 → dbt_altertable-0.2.4}/pyproject.toml

@@ -29,14 +29,18 @@ classifiers = [
 dependencies = [
     "dbt-core>=1.8,<2.0",
     "dbt-adapters>=1.5,<2.0",
-    "altertable-flightsql>=0.2.1",
+    "altertable-flightsql>=0.3.1",
     "pyarrow>=14",
 ]
 
 [project.optional-dependencies]
+metricflow = [
+    "dbt-metricflow>=0.12.0",
+]
 dev = [
     "pytest>=7.0.0",
     "pytest-mock>=3.10.0",
+    "pytest-xdist>=3.7",
     "ruff>=0.15.11",
     "ty>=0.0.32",
     "pre-commit>=4.0",

dbt_altertable-0.2.2/dbt/adapters/altertable/__version__.py

@@ -1 +0,0 @@
-version = "0.2.2"  # x-release-please-version