dbdicom 0.3.7__tar.gz → 0.3.8__tar.gz

{dbdicom-0.3.7/src/dbdicom.egg-info → dbdicom-0.3.8}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dbdicom
-Version: 0.3.7
+Version: 0.3.8
 Summary: A pythonic interface for reading and writing DICOM databases
 Author-email: Steven Sourbron <s.sourbron@sheffield.ac.uk>, Ebony Gunwhy <e.gunwhy@sheffield.ac.uk>
 Project-URL: Homepage, https://openmiblab.github.io/dbdicom/

{dbdicom-0.3.7 → dbdicom-0.3.8}/pyproject.toml

@@ -7,7 +7,7 @@ requires = ['setuptools>=61.2']
 
 [project]
 name = "dbdicom"
-version = "0.3.7"
+version = "0.3.8"
 dependencies = [ 
     "tqdm",
     "importlib-resources",

{dbdicom-0.3.7 → dbdicom-0.3.8}/src/dbdicom/api.py

@@ -198,19 +198,20 @@ def move(from_entity:list, to_entity:list):
     dbd.delete(from_entity)
     dbd.close()
 
-def split_series(series:list, attr:Union[str, tuple])->dict:
+def split_series(series:list, attr:Union[str, tuple], key=None)->list:
     """
     Split a series into multiple series
     
     Args:
         series (list): series to split.
-        attr (str or tuple): dicom attribute to split the series by.  
+        attr (str or tuple): dicom attribute to split the series by. 
+        key (function): split by by key(attr) 
     Returns:
-        dict: dictionary with keys the unique values found (ascending) 
-        and as values the series corresponding to that value.     
+        list: list of two-element tuples, where the first element is
+        is the value and the second element is the series corresponding to that value.      
     """
     dbd = open(series[0])
-    split_series = dbd.split_series(series, attr)
+    split_series = dbd.split_series(series, attr, key)
     dbd.close()
     return split_series
 

{dbdicom-0.3.7 → dbdicom-0.3.8}/src/dbdicom/dataset.py

@@ -344,10 +344,24 @@ def format_value(value, VR=None, tag=None):
             #return value[:64]
     if VR == 'TM':
         return variables.seconds_to_str(value)
+    if VR == 'DA':
+        if not is_valid_dicom_date(value):
+            return '99991231'
     
     return value
 
 
+
+def is_valid_dicom_date(da_str: str) -> bool:
+    if not isinstance(da_str, str) or len(da_str) != 8 or not da_str.isdigit():
+        return False
+    try:
+        datetime.strptime(da_str, "%Y%m%d")
+        return True
+    except ValueError:
+        return False
+
+
 def check_value(value, tag):
 
     # If the change below is made (TM, DA, DT) then this needs to 

{dbdicom-0.3.7 → dbdicom-0.3.8}/src/dbdicom/dbd.py

@@ -3,6 +3,7 @@ from datetime import datetime
 import json
 from typing import Union
 import zipfile
+import re
 
 from tqdm import tqdm
 import numpy as np
@@ -651,37 +652,43 @@ class DataBaseDicom():
         self.delete(from_entity)
         return self
     
-    def split_series(self, series:list, attr:Union[str, tuple]) -> dict:
+    def split_series(self, series:list, attr:Union[str, tuple], key=None) -> list:
         """
         Split a series into multiple series
         
         Args:
             series (list): series to split.
             attr (str or tuple): dicom attribute to split the series by. 
+            key (function): split by by key(attr)
         Returns:
-            dict: dictionary with keys the unique values found (ascending) 
-            and as values the series corresponding to that value.         
+            list: list of two-element tuples, where the first element is
+            is the value and the second element is the series corresponding to that value.         
         """
 
         # Find all values of the attr and list files per value
         all_files = register.files(self.register, series)
-        files = {}
+        files = []
+        values = []
         for f in tqdm(all_files, desc=f'Reading {attr}'):
             ds = dbdataset.read_dataset(f)
             v = dbdataset.get_values(ds, attr)
-            if v in files:
-                files[v].append(f)
+            if key is not None:
+                v = key(v)
+            if v in values:
+                index = values.index(v)
+                files[index].append(f)
             else:
-                files[v] = [f]
+                values.append(v)
+                files.append([f])
 
         # Copy the files for each value (sorted) to new series
-        values = sorted(list(files.keys()))
-        split_series = {}
-        for v in tqdm(values, desc='Writing new series'):
+        split_series = []
+        for index, v in tqdm(enumerate(values), desc='Writing new series'):
             series_desc = series[-1] if isinstance(series, str) else series[-1][0]
-            series_v = series[:3] + [f'{series_desc}_{attr}_{v}']
-            self._files_to_series(files[v], series_v)
-            split_series[v] = series_v
+            series_desc = clean_folder_name(f'{series_desc}_{attr}_{v}')
+            series_v = series[:3] + [(series_desc, 0)]
+            self._files_to_series(files[index], series_v)
+            split_series.append((v, series_v))
         return split_series
 
 
@@ -910,6 +917,29 @@ class DataBaseDicom():
 
 
 
+def clean_folder_name(name, replacement="", max_length=255):
+    # Strip leading/trailing whitespace
+    name = name.strip()
+
+    # Replace invalid characters (Windows, macOS, Linux-safe)
+    illegal_chars = r'[<>:"/\\|?*\[\]\x00-\x1F\x7F]'
+    name = re.sub(illegal_chars, replacement, name)
+
+    # Replace reserved Windows names
+    reserved = {
+        "CON", "PRN", "AUX", "NUL",
+        *(f"COM{i}" for i in range(1, 10)),
+        *(f"LPT{i}" for i in range(1, 10))
+    }
+    name_upper = name.upper().split(".")[0]  # Just base name
+    if name_upper in reserved:
+        name = f"{name}_folder"
+
+    # Truncate to max length (common max: 255 bytes)
+    return name[:max_length] or "folder"
+
+
+
 def infer_slice_spacing(vols):
     # In case spacing between slices is not (correctly) encoded in 
     # DICOM it can be inferred from the slice locations.

{dbdicom-0.3.7 → dbdicom-0.3.8/src/dbdicom.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dbdicom
-Version: 0.3.7
+Version: 0.3.8
 Summary: A pythonic interface for reading and writing DICOM databases
 Author-email: Steven Sourbron <s.sourbron@sheffield.ac.uk>, Ebony Gunwhy <e.gunwhy@sheffield.ac.uk>
 Project-URL: Homepage, https://openmiblab.github.io/dbdicom/