dayhoff-tools 1.4.7__tar.gz → 1.4.8__tar.gz

{dayhoff_tools-1.4.7 → dayhoff_tools-1.4.8}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: dayhoff-tools
-Version: 1.4.7
+Version: 1.4.8
 Summary: Common tools for all the repos at Dayhoff Labs
 Author: Daniel Martin-Alarcon
 Author-email: dma@dayhofflabs.com

{dayhoff_tools-1.4.7 → dayhoff_tools-1.4.8}/dayhoff_tools/cli/engine_commands.py

@@ -1618,33 +1618,12 @@ def attach_studio(
                 console.print("[red]❌ Failed to start engine[/red]")
                 raise typer.Exit(1)
             console.print("[green]✓ Engine started[/green]")
-            console.print("Waiting for engine to be ready...")
-            # Wait until the engine is fully running & marked ready (max 5 min)
-            console.print("Waiting for engine to be ready (this can take a couple of minutes)…")
-            # Progress classes already imported at module level – do not re-import to avoid UnboundLocalError
-
-            with Progress(SpinnerColumn(), TimeElapsedColumn(), TextColumn("[progress.description]{task.description}"), transient=True) as prog:
-                prog.add_task("Awaiting engine readiness…", total=None)
-                max_attempts = 30  # 30 × 10 s  ≈ 5 min
-                for _ in range(max_attempts):
-                    time.sleep(10)
-
-                    status_resp = make_api_request("GET", f"/engines/{engine['instance_id']}")
-                    if status_resp.status_code != 200:
-                        continue
-
-                    detailed = status_resp.json().get("engine", {})
-                    state_ok = detailed.get("state", "").lower() == "running"
-                    ready_ok = detailed.get("ready") is True
-
-                    if state_ok and ready_ok:
-                        break
-                else:
-                    console.print("[yellow]Engine is still starting up. If attachment fails, wait a little longer and retry.[/yellow]")
+            # No further waiting here – attachment attempts below handle retry logic while the
+            # engine finishes booting.
         else:
             raise typer.Exit(1)
 
-    # Get SSH key
+    # Retrieve SSH public key (required for authorised_keys provisioning)
     try:
         public_key = get_ssh_public_key()
     except FileNotFoundError as e:
@@ -1655,34 +1634,80 @@ def attach_studio(
 
     with Progress(
         SpinnerColumn(),
+        TimeElapsedColumn(),
         TextColumn("[progress.description]{task.description}"),
         transient=True,
-    ) as progress:
-        task = progress.add_task("Attaching studio...", total=100)
+    ) as prog:
+        task = prog.add_task("Attaching studio (engine is still booting)…", total=None)
+        ATTEMPT_LIMIT = 40  # ~6-7 min max (40 × 10 s)
+        RETRY_DELAY = 10
+        for attempt in range(ATTEMPT_LIMIT):
+            success, error_msg = _attempt_studio_attach(studio, engine, target_user, public_key)
 
-        response = make_api_request(
-            "POST",
-            f"/studios/{studio['studio_id']}/attach",
-            json_data={
-                "vm_id": engine["instance_id"],
-                "user": target_user,  # Use target_user instead of username
-                "public_key": public_key,
-            },
-        )
+            if success:
+                break  # success!
+
+            # Update spinner description with attempt number
+            prog.update(task, description=f"Attaching studio (engine is still booting)… {attempt+1}/{ATTEMPT_LIMIT}")
+
+            if error_msg:
+                console.print(f"[red]❌ Failed to attach studio: {error_msg}[/red]")
+                return
+
+            time.sleep(RETRY_DELAY)
+
+        else:
+            console.print("[yellow]Engine is still starting up – please retry in a minute.[/yellow]")
+            return
+
+    # Successful attach path
+    console.print(f"[green]✓ Studio attached successfully![/green]")
 
-        progress.update(task, completed=100)
+    # Update SSH config - use target_user for the connection
+    update_ssh_config_entry(engine["name"], engine["instance_id"], target_user)
+    console.print(f"[green]✓ SSH config updated[/green]")
+    console.print(f"\nConnect with: [cyan]ssh {engine['name']}[/cyan]")
+    console.print(f"Files are at: [cyan]/studios/{target_user}[/cyan]")
+
+
+def _attempt_studio_attach(studio, engine, target_user, public_key):
+    response = make_api_request(
+        "POST",
+        f"/studios/{studio['studio_id']}/attach",
+        json_data={
+            "vm_id": engine["instance_id"],
+            "user": target_user,
+            "public_key": public_key,
+        },
+    )
 
     if response.status_code == 200:
-        console.print(f"[green]✓ Studio attached successfully![/green]")
+        return True, None
 
-        # Update SSH config - use target_user for the connection
-        update_ssh_config_entry(engine["name"], engine["instance_id"], target_user)
-        console.print(f"[green]✓ SSH config updated[/green]")
-        console.print(f"\nConnect with: [cyan]ssh {engine['name']}[/cyan]")
-        console.print(f"Files are at: [cyan]/studios/{target_user}[/cyan]")
+    # --- determine if we should retry ---
+    recoverable = False
+    if response.status_code in (409, 503):
+        recoverable = True
     else:
+        err_msg = response.json().get("error", "").lower()
+        RECOVERABLE_PATTERNS = [
+            "not ready",
+            "still starting",
+            "initializing",
+            "failed to mount",
+            "device busy",
+            "not available",
+        ]
+        if any(p in err_msg for p in RECOVERABLE_PATTERNS):
+            recoverable = True
+
+    if not recoverable:
+        # fatal – abort immediately and show message
         error = response.json().get("error", "Unknown error")
-        console.print(f"[red]❌ Failed to attach studio: {error}[/red]")
+        return False, error
+
+    # otherwise wait and retry
+    return False, None
 
 
 @studio_app.command("detach")

{dayhoff_tools-1.4.7 → dayhoff_tools-1.4.8}/pyproject.toml

@@ -5,7 +5,7 @@ build-backend = "poetry.core.masonry.api"
 
 [project]
 name = "dayhoff-tools"
-version = "1.4.7"
+version = "1.4.8"
 description = "Common tools for all the repos at Dayhoff Labs"
 authors = [
     {name = "Daniel Martin-Alarcon", email = "dma@dayhofflabs.com"}