datalegion-cli 1.3.0__tar.gz → 1.3.1__tar.gz

{datalegion_cli-1.3.0 → datalegion_cli-1.3.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: datalegion-cli
-Version: 1.3.0
+Version: 1.3.1
 Summary: CLI for the Data Legion API — agent-friendly, fully async
 Project-URL: Homepage, https://www.datalegion.ai
 Project-URL: Documentation, https://www.datalegion.ai/docs
@@ -104,7 +104,7 @@ datalegion-cli login --team-id 7     # when your account has several teams
 datalegion-cli login --no-browser    # headless: prints the link to open on another device
 ```
 
-The key belongs to this machine (named after its hostname, or `--device <name>`). Signing in again replaces it, and you can disconnect it from Connected Apps in the dashboard.
+The key belongs to this machine, named with a random id (`cli-` plus 8 hex characters) that the CLI generates on first login and keeps in its config, so nothing about the machine (such as its hostname) is sent. Pass `--device <name>` for a readable label instead. Signing in again replaces it, and you can disconnect it from Connected Apps in the dashboard.
 
 Or set an API key yourself (stored encrypted on disk):
 

{datalegion_cli-1.3.0 → datalegion_cli-1.3.1}/README.md

@@ -70,7 +70,7 @@ datalegion-cli login --team-id 7     # when your account has several teams
 datalegion-cli login --no-browser    # headless: prints the link to open on another device
 ```
 
-The key belongs to this machine (named after its hostname, or `--device <name>`). Signing in again replaces it, and you can disconnect it from Connected Apps in the dashboard.
+The key belongs to this machine, named with a random id (`cli-` plus 8 hex characters) that the CLI generates on first login and keeps in its config, so nothing about the machine (such as its hostname) is sent. Pass `--device <name>` for a readable label instead. Signing in again replaces it, and you can disconnect it from Connected Apps in the dashboard.
 
 Or set an API key yourself (stored encrypted on disk):
 

{datalegion_cli-1.3.0 → datalegion_cli-1.3.1}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "datalegion-cli"
-version = "1.3.0"
+version = "1.3.1"
 description = "CLI for the Data Legion API — agent-friendly, fully async"
 readme = "README.md"
 requires-python = ">=3.11"

{datalegion_cli-1.3.0 → datalegion_cli-1.3.1}/src/datalegion_cli/config.py

@@ -27,6 +27,7 @@ _DEFAULTS: dict[str, object] = {
     "api_key": "",
     "default_output": "json",  # json | table | raw
     "install_method": "",  # brew | github | git | pip
+    "device_id": "",  # random name for this machine's login key (see login.new_device_id)
 }
 
 # Fields that are stored encrypted on disk

{datalegion_cli-1.3.0 → datalegion_cli-1.3.1}/src/datalegion_cli/login.py

@@ -12,8 +12,8 @@ from __future__ import annotations
 
 import asyncio
 import os
-import platform
 import re
+import secrets
 from typing import TYPE_CHECKING, Any
 
 if TYPE_CHECKING:
@@ -40,10 +40,15 @@ class LoginError(Exception):
         self.details = details
 
 
-def default_device_name() -> str:
-    """This machine's name in the form the API accepts, or 'cli' when it has none."""
-    name = re.sub(r"[^\w.@:-]+", "-", platform.node()).strip("-")[:100]
-    return name or "cli"
+def new_device_id() -> str:
+    """A random name for this machine's key: ``cli-`` plus 8 hex characters.
+
+    Random rather than the hostname (or a hash of it): hostnames often carry a
+    person's name and are guessable, so nothing about the machine leaves it. Saved
+    in the config on first login and reused, so signing in again replaces this
+    machine's key instead of adding another.
+    """
+    return f"cli-{secrets.token_hex(4)}"
 
 
 def check_device_name(name: str) -> str:

{datalegion_cli-1.3.0 → datalegion_cli-1.3.1}/src/datalegion_cli/main.py

@@ -126,7 +126,10 @@ async def login(
         int | None, typer.Option("--team-id", help="Team the key bills, when you have several.")
     ] = None,
     device: Annotated[
-        str | None, typer.Option("--device", help="Name for this machine (default: hostname).")
+        str | None,
+        typer.Option(
+            "--device", help="Name for this machine (default: a random id saved locally)."
+        ),
     ] = None,
     no_browser: Annotated[
         bool, typer.Option("--no-browser", help="Print the sign-in link without opening it.")
@@ -145,7 +148,11 @@ async def login(
     from datalegion_cli import login as flow
 
     try:
-        device_name = flow.check_device_name(device or flow.default_device_name())
+        cfg = load_config()
+        if not device and not cfg.get("device_id"):
+            cfg["device_id"] = flow.new_device_id()
+            save_config(cfg)
+        device_name = flow.check_device_name(device or str(cfg["device_id"]))
         async with httpx.AsyncClient(timeout=30.0) as client:
             started = await flow.start_device_authorization(client)
             link = started.get("verification_uri_complete") or started["verification_uri"]

{datalegion_cli-1.3.0 → datalegion_cli-1.3.1}/tests/test_login.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 import json
+import re
 from unittest.mock import AsyncMock, patch
 
 import httpx
@@ -32,13 +33,15 @@ def tmp_config(tmp_config_dir, monkeypatch):
 
 
 class TestDeviceName:
-    def test_default_is_the_hostname_made_safe(self, monkeypatch):
-        monkeypatch.setattr(flow.platform, "node", lambda: "Jack's MacBook Pro.local")
-        assert flow.default_device_name() == "Jack-s-MacBook-Pro.local"
+    def test_new_ids_are_random_and_api_safe(self):
+        ids = {flow.new_device_id() for _ in range(50)}
+        assert len(ids) == 50
+        for device_id in ids:
+            assert re.fullmatch(r"cli-[0-9a-f]{8}", device_id)
+            assert flow.check_device_name(device_id) == device_id
 
-    def test_default_without_a_hostname(self, monkeypatch):
-        monkeypatch.setattr(flow.platform, "node", lambda: "")
-        assert flow.default_device_name() == "cli"
+    def test_the_hostname_is_never_read(self):
+        assert not hasattr(flow, "platform")
 
     @pytest.mark.parametrize("name", ["", " lead", "a\nb", "x" * 101, "semi;colon", "two  spaces"])
     def test_rejects_what_the_api_rejects(self, name):
@@ -181,6 +184,27 @@ class TestLoginCommand:
 
         assert load_config()["api_key"] == KEY
 
+    def test_default_device_is_a_saved_random_id_reused_next_time(self, steps, tmp_config):
+        exchange, _ = steps
+        assert runner.invoke(app, ["login"]).exit_code == 0
+        first = exchange.await_args.args[3]
+        assert re.fullmatch(r"cli-[0-9a-f]{8}", first)
+        from datalegion_cli.config import load_config
+
+        assert load_config()["device_id"] == first
+        assert runner.invoke(app, ["login"]).exit_code == 0
+        assert exchange.await_args.args[3] == first  # same machine, same key slot
+
+    def test_device_flag_wins_and_leaves_the_saved_id(self, steps, tmp_config):
+        exchange, _ = steps
+        assert runner.invoke(app, ["login"]).exit_code == 0
+        from datalegion_cli.config import load_config
+
+        saved = load_config()["device_id"]
+        assert runner.invoke(app, ["login", "--device", "laptop"]).exit_code == 0
+        assert exchange.await_args.args[3] == "laptop"
+        assert load_config()["device_id"] == saved
+
     def test_no_browser(self, steps, tmp_config):
         _, browser = steps
         assert runner.invoke(app, ["login", "--device", "laptop", "--no-browser"]).exit_code == 0