datajunction 0.0.142__tar.gz → 0.0.143__tar.gz

{datajunction-0.0.142 → datajunction-0.0.143}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: datajunction
-Version: 0.0.142
+Version: 0.0.143
 Summary: DataJunction client library for connecting to a DataJunction server
 Project-URL: repository, https://github.com/DataJunction/dj
 Author-email: DataJunction Authors <yian.shang@gmail.com>

{datajunction-0.0.142 → datajunction-0.0.143}/datajunction/__about__.py

@@ -2,4 +2,4 @@
 Version for Hatch
 """
 
-__version__ = "0.0.142"
+__version__ = "0.0.143"

{datajunction-0.0.142 → datajunction-0.0.143}/datajunction/builder.py

@@ -99,6 +99,8 @@ class DJBuilder(DJClient):  # pylint: disable=too-many-public-methods
                 "cascade": cascade,
             },
         )
+        if response.status_code == 404:
+            return
         if not response.status_code < 400:
             raise DJClientException(response.json()["message"])
 
@@ -176,6 +178,8 @@ class DJBuilder(DJClient):  # pylint: disable=too-many-public-methods
             timeout=self._timeout,
             params={"delete_git_branch": delete_git_branch},
         )
+        if response.status_code == 404:
+            return
         if not response.status_code < 400:
             raise DJClientException(response.json()["message"])
 

{datajunction-0.0.142 → datajunction-0.0.143}/tests/test_builder.py

@@ -1038,18 +1038,43 @@ class TestDJBuilder:  # pylint: disable=too-many-public-methods, protected-acces
                 params={"delete_git_branch": True},
             )
 
-    def test_delete_branch_error(self, client):
+    def test_delete_branch_404_is_idempotent(self, client):
         """
-        Verifies that delete_branch raises on error.
+        Verifies that delete_branch treats a 404 as success — DELETE is idempotent.
         """
         mock_response = MagicMock(
             status_code=404,
             json=lambda: {"message": "Branch not found"},
         )
         with patch.object(client._session, "request", return_value=mock_response):
-            with pytest.raises(DJClientException) as exc_info:
+            assert (
                 client.delete_branch(namespace="myns", branch_name="nonexistent")
-            assert "Branch not found" in str(exc_info.value)
+                is None
+            )
+
+    def test_delete_branch_error(self, client):
+        """
+        Verifies that delete_branch raises on non-404 errors.
+        """
+        mock_response = MagicMock(
+            status_code=500,
+            json=lambda: {"message": "Internal server error"},
+        )
+        with patch.object(client._session, "request", return_value=mock_response):
+            with pytest.raises(DJClientException) as exc_info:
+                client.delete_branch(namespace="myns", branch_name="feature-x")
+            assert "Internal server error" in str(exc_info.value)
+
+    def test_delete_namespace_404_is_idempotent(self, client):
+        """
+        Verifies that delete_namespace treats a 404 as success — DELETE is idempotent.
+        """
+        mock_response = MagicMock(
+            status_code=404,
+            json=lambda: {"message": "Namespace not found"},
+        )
+        with patch.object(client._session, "request", return_value=mock_response):
+            assert client.delete_namespace(namespace="nonexistent") is None
 
     #
     # Git config