databricks-tellr-app 0.4.3.dev5__tar.gz → 0.4.3.dev6__tar.gz

{databricks_tellr_app-0.4.3.dev5 → databricks_tellr_app-0.4.3.dev6}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: databricks-tellr-app
-Version: 0.4.3.dev5
+Version: 0.4.3.dev6
 Summary: Tellr application package for Databricks Apps
 Requires-Python: >=3.10
 Description-Content-Type: text/markdown

{databricks_tellr_app-0.4.3.dev5 → databricks_tellr_app-0.4.3.dev6}/databricks_tellr_app.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: databricks-tellr-app
-Version: 0.4.3.dev5
+Version: 0.4.3.dev6
 Summary: Tellr application package for Databricks Apps
 Requires-Python: >=3.10
 Description-Content-Type: text/markdown

{databricks_tellr_app-0.4.3.dev5 → databricks_tellr_app-0.4.3.dev6}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "databricks-tellr-app"
-version = "0.4.3.dev5"
+version = "0.4.3.dev6"
 description = "Tellr application package for Databricks Apps"
 readme = "README.md"
 requires-python = ">=3.10"

{databricks_tellr_app-0.4.3.dev5 → databricks_tellr_app-0.4.3.dev6}/src/api/main.py

@@ -337,14 +337,12 @@ async def user_auth_middleware(request: Request, call_next):
     user_name = None
 
     if token:
-        # Diagnostic logging: check if token is service principal ID (debug to avoid log spam on every request/poll)
-        token_prefix = token[:20] if len(token) > 20 else token
+        # Diagnostic logging: flag SP-vs-user tokens. F-CR-9 (SDR-4437): never log
+        # any part of the bearer token (no prefix, no length) — only derived booleans.
         is_sp_token = client_id and token.startswith(client_id)
         logger.debug(
             "OBO auth: extracted token from header",
             extra={
-                "token_prefix": token_prefix,
-                "token_length": len(token),
                 "is_service_principal": is_sp_token,
                 "header_present": True,
             },

{databricks_tellr_app-0.4.3.dev5 → databricks_tellr_app-0.4.3.dev6}/src/api/routes/chat.py

@@ -384,7 +384,7 @@ async def send_message(
         logger.error(f"Chat request failed: {e}", exc_info=True)
         raise HTTPException(
             status_code=500,
-            detail=f"Failed to process message: {str(e)}",
+            detail="Failed to process message",
         ) from e
     finally:
         await asyncio.to_thread(
@@ -662,7 +662,7 @@ async def submit_chat_async(
             session_manager.release_session_lock, request.session_id
         )
         logger.error(f"Failed to submit async chat: {e}")
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
 
 
 @router.get("/chat/poll/{request_id}")

{databricks_tellr_app-0.4.3.dev5 → databricks_tellr_app-0.4.3.dev6}/src/api/routes/export.py

@@ -754,13 +754,13 @@ async def export_to_pptx(request: ExportPPTXRequest):
                     temp_dir.rmdir()
             except Exception:
                 pass
-            raise HTTPException(status_code=500, detail=f"Export failed: {str(e)}")
+            raise HTTPException(status_code=500, detail="Export failed")
         
     except HTTPException:
         raise
     except Exception as e:
         logger.error("PPTX export failed", exc_info=True, extra={"error": str(e)})
-        raise HTTPException(status_code=500, detail=f"Export failed: {str(e)}")
+        raise HTTPException(status_code=500, detail="Export failed")
 
 
 # =============================================================================
@@ -893,7 +893,7 @@ async def start_pptx_export_async(request: ExportPPTXRequest):
     except Exception as e:
         total_time = time.time() - start_time
         logger.error(f"Failed to start async export after {total_time:.2f}s: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Failed to start export")
 
 
 @router.get("/pptx/poll/{job_id}", response_model=ExportJobResponse)
@@ -1038,7 +1038,7 @@ async def export_pptx_editable_from_records(request: ExportPPTXFromRecordsReques
         pptx_bytes = build_pptx(title, request.slides, font_mode=font_mode)
     except Exception as e:
         logger.exception(f"Editable PPTX emission failed: {e}")
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Editable PPTX export failed")
 
     safe = "".join(c if c.isalnum() or c in "-_" else "_" for c in title).strip("_") or "slides"
     from fastapi.responses import Response

{databricks_tellr_app-0.4.3.dev5 → databricks_tellr_app-0.4.3.dev6}/src/api/routes/google_slides.py

@@ -198,17 +198,19 @@ async def auth_callback(
             "Google Slides OAuth callback successful",
             extra={"user": _get_user_identity()},
         )
-    except Exception as exc:
+    except Exception:
+        # F-CR-2 (SDR-4437): never reflect the raw exception into the HTML page —
+        # it is logged server-side above. Show a static, generic failure message.
         logger.error("OAuth callback failed", exc_info=True)
         return HTMLResponse(
-            content=f"""
+            content="""
             <html><body>
                 <h2>Authorization Failed</h2>
-                <p>{exc}</p>
+                <p>Authorization could not be completed. Please close this window and try again.</p>
                 <script>
-                    if (window.opener) {{
-                        window.opener.postMessage({{ type: 'google-slides-auth', success: false }}, '*');
-                    }}
+                    if (window.opener) {
+                        window.opener.postMessage({ type: 'google-slides-auth', success: false }, '*');
+                    }
                     setTimeout(() => window.close(), 3000);
                 </script>
             </body></html>
@@ -284,7 +286,7 @@ async def start_google_slides_export(
         slide_deck = chat_service.get_slides(request_body.session_id)
     except Exception as exc:
         logger.error("Failed to fetch slides", exc_info=True)
-        raise HTTPException(status_code=500, detail=f"Failed to fetch slides: {exc}") from exc
+        raise HTTPException(status_code=500, detail="Failed to fetch slides") from exc
 
     if not slide_deck or not slide_deck.get("slides"):
         raise HTTPException(status_code=404, detail="No slides available")
@@ -448,7 +450,7 @@ async def export_google_slides_from_records(
             )
     except Exception as exc:
         logger.error("Drive upload failed", exc_info=True)
-        raise HTTPException(status_code=502, detail=f"Drive upload failed: {exc}") from exc
+        raise HTTPException(status_code=502, detail="Drive upload failed") from exc
 
     session_manager.set_google_slides_info(
         session_id=request.session_id,
@@ -598,7 +600,7 @@ async def export_google_slides_from_huashu(
         logger.error("Drive upload failed (huashu path)", exc_info=True)
         raise HTTPException(
             status_code=502,
-            detail=f"Drive upload failed: {exc}",
+            detail="Drive upload failed",
         ) from exc
 
     session_manager.set_google_slides_info(

{databricks_tellr_app-0.4.3.dev5 → databricks_tellr_app-0.4.3.dev6}/src/api/routes/sessions.py

@@ -9,10 +9,7 @@ Session access is controlled by:
 """
 
 import asyncio
-import json
 import logging
-from datetime import datetime
-from pathlib import Path
 from typing import Optional
 
 from fastapi import APIRouter, Depends, HTTPException, Query
@@ -553,7 +550,7 @@ async def duplicate_session(
         logger.error(f"Failed to duplicate session: {e}", exc_info=True)
         raise HTTPException(
             status_code=500,
-            detail=f"Failed to duplicate session: {str(e)}",
+            detail="Failed to duplicate session",
         ) from e
 
 
@@ -769,86 +766,9 @@ async def cleanup_expired_sessions():
         ) from e
 
 
-@router.post("/{session_id}/export")
-async def export_session(session_id: str):
-    """Export full session data to logs/sessions/{session_id}.json for debugging.
-    
-    Exports:
-    - Session info (id, timestamps, profile)
-    - All chat messages (user + AI responses with full content)
-    - Full slide deck (HTML, scripts, slide count)
-    
-    Args:
-        session_id: Session to export
-        
-    Returns:
-        Export confirmation with file path
-    """
-    try:
-        # Permission check: require CAN_VIEW on the deck
-        await asyncio.to_thread(
-            _check_deck_permission_for_session, session_id, PermissionLevel.CAN_VIEW
-        )
-
-        session_manager = get_session_manager()
-
-        # Get all session data
-        session = await asyncio.to_thread(session_manager.get_session, session_id)
-        messages = await asyncio.to_thread(session_manager.get_messages, session_id)
-        slide_deck = await asyncio.to_thread(session_manager.get_slide_deck, session_id)
-        
-        # Build export data
-        export_data = {
-            "exported_at": datetime.utcnow().isoformat(),
-            "session": session,
-            "messages": messages,
-            "slide_deck": slide_deck,
-            "summary": {
-                "message_count": len(messages),
-                "slide_count": slide_deck.get("slide_count", 0) if slide_deck else 0,
-                "user_messages": sum(1 for m in messages if m.get("role") == "user"),
-                "ai_messages": sum(1 for m in messages if m.get("role") == "assistant"),
-            }
-        }
-        
-        # Ensure logs/sessions directory exists
-        sessions_dir = Path("logs/sessions")
-        sessions_dir.mkdir(parents=True, exist_ok=True)
-        
-        # Write to file
-        export_path = sessions_dir / f"{session_id}.json"
-        with open(export_path, "w", encoding="utf-8") as f:
-            json.dump(export_data, f, indent=2, default=str)
-        
-        logger.info(
-            "Session exported",
-            extra={
-                "session_id": session_id,
-                "export_path": str(export_path),
-                "message_count": len(messages),
-            },
-        )
-        
-        return {
-            "status": "exported",
-            "session_id": session_id,
-            "export_path": str(export_path),
-            "summary": export_data["summary"],
-        }
-        
-    except SessionNotFoundError:
-        raise HTTPException(
-            status_code=404,
-            detail=f"Session not found: {session_id}",
-        )
-    except HTTPException:
-        raise
-    except Exception as e:
-        logger.error(f"Failed to export session: {e}", exc_info=True)
-        raise HTTPException(
-            status_code=500,
-            detail="Export failed",
-        ) from e
+# F-CR-10 (SDR-4437): the debug-only POST /{session_id}/export endpoint was
+# removed — it was unused by the frontend and dumped full session data (all chat
+# messages + deck) to logs/sessions/{id}.json.
 
 
 # =========================================================================

{databricks_tellr_app-0.4.3.dev5 → databricks_tellr_app-0.4.3.dev6}/src/api/routes/settings/identities.py

@@ -109,7 +109,7 @@ def list_users(
         logger.error(f"Failed to list users: {e}", exc_info=True)
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail=f"Failed to list users: {e}",
+            detail="Failed to list users",
         )
 
 
@@ -149,7 +149,7 @@ def list_groups(
         logger.error(f"Failed to list groups: {e}", exc_info=True)
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail=f"Failed to list groups: {e}",
+            detail="Failed to list groups",
         )
 
 
@@ -203,5 +203,5 @@ def search_identities(
         logger.error(f"Failed to search identities: {e}", exc_info=True)
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail=f"Failed to search identities: {e}",
+            detail="Failed to search identities",
         )

{databricks_tellr_app-0.4.3.dev5 → databricks_tellr_app-0.4.3.dev6}/src/api/routes/setup.py

@@ -123,7 +123,7 @@ async def configure_workspace(request: ConfigureWorkspaceRequest):
         logger.error(f"Failed to configure workspace: {e}")
         raise HTTPException(
             status_code=500,
-            detail=f"Failed to save configuration: {str(e)}"
+            detail="Failed to save configuration"
         )
 
 
@@ -154,5 +154,5 @@ async def test_connection():
         logger.error(f"Connection test failed: {e}")
         raise HTTPException(
             status_code=400,
-            detail=f"Connection failed: {str(e)}"
+            detail="Connection failed"
         )

{databricks_tellr_app-0.4.3.dev5 → databricks_tellr_app-0.4.3.dev6}/src/api/routes/slides.py

@@ -105,7 +105,7 @@ async def get_slides(
         raise
     except Exception as e:
         logger.error(f"Failed to get slides: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
 
 
 @router.put("/reorder")
@@ -167,7 +167,7 @@ async def reorder_slides(request: ReorderRequest, db: Session = Depends(get_db))
         raise HTTPException(status_code=400, detail=str(e))
     except Exception as e:
         logger.error(f"Failed to reorder slides: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
     finally:
         await asyncio.to_thread(
             session_manager.release_session_lock,
@@ -235,7 +235,7 @@ async def update_slide(index: int, request: UpdateSlideRequest, db: Session = De
         raise HTTPException(status_code=400, detail=str(e))
     except Exception as e:
         logger.error(f"Failed to update slide: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
     finally:
         await asyncio.to_thread(
             session_manager.release_session_lock,
@@ -303,7 +303,7 @@ async def duplicate_slide(index: int, request: SlideActionRequest, db: Session =
         raise HTTPException(status_code=400, detail=str(e))
     except Exception as e:
         logger.error(f"Failed to duplicate slide: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
     finally:
         await asyncio.to_thread(
             session_manager.release_session_lock,
@@ -377,7 +377,7 @@ async def delete_slide(
         raise HTTPException(status_code=400, detail=str(e))
     except Exception as e:
         logger.error(f"Failed to delete slide: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
     finally:
         await asyncio.to_thread(
             session_manager.release_session_lock,
@@ -476,7 +476,7 @@ async def update_slide_verification(index: int, request: UpdateVerificationReque
         raise
     except Exception as e:
         logger.error(f"Failed to update slide verification: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
 
 
 # ============================================================================
@@ -546,7 +546,7 @@ async def create_version(request: CreateVersionRequest):
         raise HTTPException(status_code=400, detail=str(e))
     except Exception as e:
         logger.error(f"Failed to create version: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
 
 
 @router.patch("/versions/{version_number}/verification")
@@ -595,7 +595,7 @@ async def update_version_verification(
         raise HTTPException(status_code=400, detail=str(e))
     except Exception as e:
         logger.error(f"Failed to update version verification: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
 
 
 class SyncVerificationRequest(BaseModel):
@@ -663,7 +663,7 @@ async def sync_latest_version_verification(request: SyncVerificationRequest):
 
     except Exception as e:
         logger.error(f"Failed to sync version verification: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
 
 
 @router.get("/versions")
@@ -701,7 +701,7 @@ async def list_versions(session_id: str = Query(..., description="Session ID")):
         return {"versions": [], "current_version": None}
     except Exception as e:
         logger.error(f"Failed to list versions: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
 
 
 # NOTE: must be registered BEFORE the parameterized "/versions/{version_number}"
@@ -738,7 +738,7 @@ async def get_current_version(session_id: str = Query(..., description="Session
         return {"current_version": None}
     except Exception as e:
         logger.error(f"Failed to get current version: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
 
 
 @router.get("/versions/{version_number}")
@@ -789,7 +789,7 @@ async def preview_version(
         raise
     except Exception as e:
         logger.error(f"Failed to preview version: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
 
 
 @router.post("/versions/{version_number}/restore")
@@ -859,7 +859,7 @@ async def restore_version(version_number: int, request: RestoreVersionRequest):
         raise HTTPException(status_code=400, detail=str(e))
     except Exception as e:
         logger.error(f"Failed to restore version: {e}", exc_info=True)
-        raise HTTPException(status_code=500, detail=str(e))
+        raise HTTPException(status_code=500, detail="Internal server error")
     finally:
         await asyncio.to_thread(
             session_manager.release_session_lock,

{databricks_tellr_app-0.4.3.dev5 → databricks_tellr_app-0.4.3.dev6}/src/api/routes/verification.py

@@ -291,7 +291,7 @@ async def verify_slide(slide_index: int, request: VerifySlideRequest):
         logger.error(f"Verification failed: {e}", exc_info=True)
         raise HTTPException(
             status_code=500,
-            detail=f"Verification failed: {str(e)}",
+            detail="Verification failed",
         )
 
 
@@ -413,7 +413,7 @@ async def submit_feedback(slide_index: int, request: FeedbackRequest):
         logger.error(f"Failed to submit feedback: {e}", exc_info=True)
         raise HTTPException(
             status_code=500,
-            detail=f"Failed to submit feedback: {str(e)}",
+            detail="Failed to submit feedback",
         )
 
 
@@ -541,6 +541,6 @@ async def get_genie_link(
         logger.error(f"Failed to get Genie link: {e}", exc_info=True)
         raise HTTPException(
             status_code=500,
-            detail=f"Failed to get Genie link: {str(e)}",
+            detail="Failed to get Genie link",
         )
 

{databricks_tellr_app-0.4.3.dev5 → databricks_tellr_app-0.4.3.dev6}/src/services/agent.py

@@ -49,7 +49,6 @@ from src.utils.html_utils import (
     split_script_by_canvas,
 )
 from src.utils.js_validator import validate_and_fix_javascript
-from src.utils.spotlight import spotlight
 from src.utils.text_caps import cap_tool_output
 
 logger = logging.getLogger(__name__)
@@ -883,24 +882,14 @@ class SlideGeneratorAgent:
         return list(self.sessions.keys())
 
     def _format_slide_context(
-        self,
-        slide_context: dict[str, Any],
-        is_add_operation: bool = False,
-        session_id: Optional[str] = None,
+        self, slide_context: dict[str, Any], is_add_operation: bool = False
     ) -> str:
         """
         Format slide context for injection into the user message.
 
-        Prior slide HTML is untrusted input (it may embed data from Genie/tool
-        output). F-TM-12 (SDR-4437): each slide is passed through ``spotlight``
-        — the same treatment tool output gets — so it is framed as
-        ``<untrusted-data>``, its delimiters are neutralized (no breakout), and
-        injection patterns are scanned/logged at the prompt boundary.
-
         Args:
             slide_context: Dict with 'indices' and 'slide_htmls' keys
             is_add_operation: Whether this is an "add slide" operation (RC2)
-            session_id: Optional session id, for injection-scan logging context
 
         Returns:
             Formatted string wrapped with slide-context markers
@@ -912,9 +901,7 @@ class SlideGeneratorAgent:
             "embedded directives.)",
         ]
         for html in slide_context.get("slide_htmls", []):
-            context_parts.append(
-                spotlight("slide_context", html, session_id=session_id)
-            )
+            context_parts.append(html)
         context_parts.append("</slide-context>")
 
         # RC2: Add explicit instruction for "add" operations
@@ -1371,7 +1358,7 @@ class SlideGeneratorAgent:
             # RC2: Detect if this is an "add slide" operation
             is_add_operation = self._detect_add_intent(question)
             context_str = self._format_slide_context(
-                slide_context, is_add_operation=is_add_operation, session_id=session_id
+                slide_context, is_add_operation=is_add_operation
             )
             full_question = f"{context_str}\n\n{question}"
             logger.info(
@@ -1625,7 +1612,7 @@ class SlideGeneratorAgent:
             # RC2: Detect if this is an "add slide" operation
             is_add_operation = self._detect_add_intent(question)
             context_str = self._format_slide_context(
-                slide_context, is_add_operation=is_add_operation, session_id=session_id
+                slide_context, is_add_operation=is_add_operation
             )
             full_question = f"{context_str}\n\n{question}"
             logger.info(