dar-backup 0.7.2__tar.gz → 0.8.1__tar.gz

{dar_backup-0.7.2/src/dar_backup → dar_backup-0.8.1}/Changelog.md

@@ -1,6 +1,23 @@
 <!-- markdownlint-disable MD024 -->
 # dar-backup Changelog
 
+## v2-beta-0.8.1 - 2025-07-16
+
+Github link: [v2-beta-0.8.1](https://github.com/per2jensen/dar-backup/tree/v2-beta-0.8.1/v2)
+
+### Added
+
+- FIX: runner now logs an error and fills more data into the returned CommandResult.
+
+## v2-beta-0.8.0 - 2025-06-13
+
+Github link: [v2-beta-0.8.0](https://github.com/per2jensen/dar-backup/tree/v2-beta-0.8.0/v2)
+
+### Added
+
+- Modified clone dashboard generator to produce easier to read dashboard and be more robust.
+- Dir_traversal sanitation: clean_log.py now only accepts files in configured log directory to `--file` option.
+
 ## v2-beta-0.7.2 - 2025-06-07
 
 Github link: [v2-beta-0.7.2](https://github.com/per2jensen/dar-backup/tree/v2-beta-0.7.2/v2)
@@ -16,7 +33,7 @@ Github link: [v2-beta-0.7.2](https://github.com/per2jensen/dar-backup/tree/v2-be
 - Enrolling into [Snyk code checker](https://snyk.io/code-checker/) and learning how to work with it.
   
   - Snyk helped pointing out vulnerable versions of some packages used.
-  - Input sanitization started, there is room for improvement.
+  - Input sanitation started, there is room for improvement.
 
 ## v2-beta-0.7.1 - 2025-05-22
 

{dar_backup-0.7.2 → dar_backup-0.8.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dar-backup
-Version: 0.7.2
+Version: 0.8.1
 Summary: A script to do full, differential and incremental backups using dar.     Some files are restored from the backups during verification, after which par2 redundancy files are created.     The script also has a cleanup feature to remove old backups and par2 files.
 Project-URL: GPG Public Key, https://keys.openpgp.org/search?q=dar-backup@pm.me
 Project-URL: Homepage, https://github.com/per2jensen/dar-backup/tree/main/v2
@@ -699,6 +699,8 @@ Requires-Dist: black>=25.1.0; extra == 'dev'
 Requires-Dist: coverage>=7.8.2; extra == 'dev'
 Requires-Dist: h11>=0.16.0; extra == 'dev'
 Requires-Dist: httpcore>=0.17.3; extra == 'dev'
+Requires-Dist: matplotlib>=3.10.3; extra == 'dev'
+Requires-Dist: pandas>=2.3.0; extra == 'dev'
 Requires-Dist: psutil>=7.0.0; extra == 'dev'
 Requires-Dist: pytest; extra == 'dev'
 Requires-Dist: pytest-cov>=6.1.1; extra == 'dev'
@@ -725,7 +727,7 @@ Description-Content-Type: text/markdown
 [![PyPI version](https://img.shields.io/pypi/v/dar-backup.svg)](https://pypi.org/project/dar-backup/)
 [![PyPI downloads](https://img.shields.io/badge/dynamic/json?color=blue&label=PyPI%20downloads&query=total&url=https%3A%2F%2Fraw.githubusercontent.com%2Fper2jensen%2Fdar-backup%2Fmain%2Fdownloads.json)](https://pypi.org/project/dar-backup/)
 [![# clones](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/per2jensen/dar-backup/main/v2/doc/badges/badge_clones.json)](https://github.com/per2jensen/dar-backup/blob/main/v2/doc/weekly_clones.png)
-[![Milestone](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/per2jensen/dar-backup/main/v2/doc/badges/milestone_badge.json)](https://github.com/per2jensen/dar-backup/blob/main/v2/doc/weekly_clones.png)
+[![Milestone](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/per2jensen/dar-backup/main/v2/doc/badges/milestone_badge.json)](https://github.com/per2jensen/dar-backup/blob/main/v2/doc/weekly_clones.png)  <sub>🎯 Stats powered by [ClonePulse](https://github.com/per2jensen/clonepulse)</sub>
 
 The wonderful 'dar' [Disk Archiver](https://github.com/Edrusb/DAR) is used for
 the heavy lifting, together with the [parchive](https://github.com/Parchive/par2cmdline) suite in these scripts.

{dar_backup-0.7.2 → dar_backup-0.8.1}/README.md

@@ -9,7 +9,7 @@
 [![PyPI version](https://img.shields.io/pypi/v/dar-backup.svg)](https://pypi.org/project/dar-backup/)
 [![PyPI downloads](https://img.shields.io/badge/dynamic/json?color=blue&label=PyPI%20downloads&query=total&url=https%3A%2F%2Fraw.githubusercontent.com%2Fper2jensen%2Fdar-backup%2Fmain%2Fdownloads.json)](https://pypi.org/project/dar-backup/)
 [![# clones](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/per2jensen/dar-backup/main/v2/doc/badges/badge_clones.json)](https://github.com/per2jensen/dar-backup/blob/main/v2/doc/weekly_clones.png)
-[![Milestone](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/per2jensen/dar-backup/main/v2/doc/badges/milestone_badge.json)](https://github.com/per2jensen/dar-backup/blob/main/v2/doc/weekly_clones.png)
+[![Milestone](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/per2jensen/dar-backup/main/v2/doc/badges/milestone_badge.json)](https://github.com/per2jensen/dar-backup/blob/main/v2/doc/weekly_clones.png)  <sub>🎯 Stats powered by [ClonePulse](https://github.com/per2jensen/clonepulse)</sub>
 
 The wonderful 'dar' [Disk Archiver](https://github.com/Edrusb/DAR) is used for
 the heavy lifting, together with the [parchive](https://github.com/Parchive/par2cmdline) suite in these scripts.

{dar_backup-0.7.2 → dar_backup-0.8.1}/doc/badges/badge_clones.json

@@ -1,6 +1,6 @@
 {
   "schemaVersion": 1,
   "label": "# clones",
-  "message": "845",
+  "message": "1453",
   "color": "deeppink"
 }

dar_backup-0.8.1/doc/badges/milestone_1000.txt

@@ -0,0 +1 @@
+Reached 1000 clones on 2025-06-13T02:51:59.728578+00:00Z

dar_backup-0.8.1/doc/badges/milestone_badge.json

@@ -0,0 +1,6 @@
+{
+  "schemaVersion": 1,
+  "label": "Milestone",
+  "message": "1000 clones \ud83c\udf89\ud83c\udf89",
+  "color": "orange"
+}

dar_backup-0.8.1/doc/clones.json

@@ -0,0 +1,385 @@
+{
+  "annotations": [
+    {
+      "date": "2025-05-17",
+      "label": "LinkedIn"
+    },
+    {
+      "date": "2025-05-04",
+      "label": "r/linuxadmin"
+    },
+    {
+      "date": "2025-05-20",
+      "label": "Daily max: 124"
+    }
+  ],
+  "total_clones": 1453,
+  "unique_clones": 824,
+  "daily": [
+    {
+      "timestamp": "2025-05-04T00:00:00Z",
+      "count": 30,
+      "uniques": 15
+    },
+    {
+      "timestamp": "2025-05-05T00:00:00Z",
+      "count": 7,
+      "uniques": 5
+    },
+    {
+      "timestamp": "2025-05-06T00:00:00Z",
+      "count": 7,
+      "uniques": 5
+    },
+    {
+      "timestamp": "2025-05-07T00:00:00Z",
+      "count": 2,
+      "uniques": 2
+    },
+    {
+      "timestamp": "2025-05-08T00:00:00Z",
+      "count": 10,
+      "uniques": 7
+    },
+    {
+      "timestamp": "2025-05-09T00:00:00Z",
+      "count": 10,
+      "uniques": 5
+    },
+    {
+      "timestamp": "2025-05-10T00:00:00Z",
+      "count": 8,
+      "uniques": 6
+    },
+    {
+      "timestamp": "2025-05-11T00:00:00Z",
+      "count": 7,
+      "uniques": 5
+    },
+    {
+      "timestamp": "2025-05-12T00:00:00Z",
+      "count": 11,
+      "uniques": 5
+    },
+    {
+      "timestamp": "2025-05-13T00:00:00Z",
+      "count": 25,
+      "uniques": 13
+    },
+    {
+      "timestamp": "2025-05-14T00:00:00Z",
+      "count": 22,
+      "uniques": 12
+    },
+    {
+      "timestamp": "2025-05-15T00:00:00Z",
+      "count": 13,
+      "uniques": 8
+    },
+    {
+      "timestamp": "2025-05-16T00:00:00Z",
+      "count": 8,
+      "uniques": 4
+    },
+    {
+      "timestamp": "2025-05-17T00:00:00Z",
+      "count": 14,
+      "uniques": 7
+    },
+    {
+      "timestamp": "2025-05-18T00:00:00Z",
+      "count": 53,
+      "uniques": 23
+    },
+    {
+      "timestamp": "2025-05-19T00:00:00Z",
+      "count": 31,
+      "uniques": 13
+    },
+    {
+      "timestamp": "2025-05-20T00:00:00Z",
+      "count": 124,
+      "uniques": 44
+    },
+    {
+      "timestamp": "2025-05-21T00:00:00Z",
+      "count": 40,
+      "uniques": 18
+    },
+    {
+      "timestamp": "2025-05-22T00:00:00Z",
+      "count": 19,
+      "uniques": 12
+    },
+    {
+      "timestamp": "2025-05-23T00:00:00Z",
+      "count": 9,
+      "uniques": 5
+    },
+    {
+      "timestamp": "2025-05-24T00:00:00Z",
+      "count": 8,
+      "uniques": 6
+    },
+    {
+      "timestamp": "2025-05-25T00:00:00Z",
+      "count": 63,
+      "uniques": 23
+    },
+    {
+      "timestamp": "2025-05-26T00:00:00Z",
+      "count": 13,
+      "uniques": 7
+    },
+    {
+      "timestamp": "2025-05-27T00:00:00Z",
+      "count": 9,
+      "uniques": 7
+    },
+    {
+      "timestamp": "2025-05-28T00:00:00Z",
+      "count": 5,
+      "uniques": 3
+    },
+    {
+      "timestamp": "2025-05-29T00:00:00Z",
+      "count": 13,
+      "uniques": 6
+    },
+    {
+      "timestamp": "2025-05-30T00:00:00Z",
+      "count": 7,
+      "uniques": 3
+    },
+    {
+      "timestamp": "2025-05-31T00:00:00Z",
+      "count": 8,
+      "uniques": 5
+    },
+    {
+      "timestamp": "2025-06-01T00:00:00Z",
+      "count": 25,
+      "uniques": 15
+    },
+    {
+      "timestamp": "2025-06-02T00:00:00Z",
+      "count": 15,
+      "uniques": 7
+    },
+    {
+      "timestamp": "2025-06-03T00:00:00Z",
+      "count": 57,
+      "uniques": 31
+    },
+    {
+      "timestamp": "2025-06-04T00:00:00Z",
+      "count": 35,
+      "uniques": 22
+    },
+    {
+      "timestamp": "2025-06-05T00:00:00Z",
+      "count": 15,
+      "uniques": 12
+    },
+    {
+      "timestamp": "2025-06-06T00:00:00Z",
+      "count": 33,
+      "uniques": 18
+    },
+    {
+      "timestamp": "2025-06-07T00:00:00Z",
+      "count": 49,
+      "uniques": 20
+    },
+    {
+      "timestamp": "2025-06-08T00:00:00Z",
+      "count": 33,
+      "uniques": 19
+    },
+    {
+      "timestamp": "2025-06-09T00:00:00Z",
+      "count": 18,
+      "uniques": 12
+    },
+    {
+      "timestamp": "2025-06-10T00:00:00Z",
+      "count": 26,
+      "uniques": 16
+    },
+    {
+      "timestamp": "2025-06-11T00:00:00Z",
+      "count": 9,
+      "uniques": 6
+    },
+    {
+      "timestamp": "2025-06-12T00:00:00Z",
+      "count": 10,
+      "uniques": 8
+    },
+    {
+      "timestamp": "2025-06-13T00:00:00Z",
+      "count": 48,
+      "uniques": 18
+    },
+    {
+      "timestamp": "2025-06-14T00:00:00Z",
+      "count": 11,
+      "uniques": 9
+    },
+    {
+      "timestamp": "2025-06-15T00:00:00Z",
+      "count": 10,
+      "uniques": 8
+    },
+    {
+      "timestamp": "2025-06-16T00:00:00Z",
+      "count": 18,
+      "uniques": 11
+    },
+    {
+      "timestamp": "2025-06-17T00:00:00Z",
+      "count": 11,
+      "uniques": 9
+    },
+    {
+      "timestamp": "2025-06-18T00:00:00Z",
+      "count": 9,
+      "uniques": 7
+    },
+    {
+      "timestamp": "2025-06-19T00:00:00Z",
+      "count": 10,
+      "uniques": 8
+    },
+    {
+      "timestamp": "2025-06-20T00:00:00Z",
+      "count": 25,
+      "uniques": 18
+    },
+    {
+      "timestamp": "2025-06-21T00:00:00Z",
+      "count": 8,
+      "uniques": 6
+    },
+    {
+      "timestamp": "2025-06-22T00:00:00Z",
+      "count": 8,
+      "uniques": 6
+    },
+    {
+      "timestamp": "2025-06-23T00:00:00Z",
+      "count": 19,
+      "uniques": 14
+    },
+    {
+      "timestamp": "2025-06-24T00:00:00Z",
+      "count": 8,
+      "uniques": 6
+    },
+    {
+      "timestamp": "2025-06-25T00:00:00Z",
+      "count": 11,
+      "uniques": 8
+    },
+    {
+      "timestamp": "2025-06-26T00:00:00Z",
+      "count": 6,
+      "uniques": 5
+    },
+    {
+      "timestamp": "2025-06-27T00:00:00Z",
+      "count": 11,
+      "uniques": 7
+    },
+    {
+      "timestamp": "2025-06-28T00:00:00Z",
+      "count": 12,
+      "uniques": 9
+    },
+    {
+      "timestamp": "2025-06-29T00:00:00Z",
+      "count": 10,
+      "uniques": 7
+    },
+    {
+      "timestamp": "2025-06-30T00:00:00Z",
+      "count": 20,
+      "uniques": 13
+    },
+    {
+      "timestamp": "2025-07-01T00:00:00Z",
+      "count": 12,
+      "uniques": 10
+    },
+    {
+      "timestamp": "2025-07-02T00:00:00Z",
+      "count": 12,
+      "uniques": 10
+    },
+    {
+      "timestamp": "2025-07-03T00:00:00Z",
+      "count": 20,
+      "uniques": 14
+    },
+    {
+      "timestamp": "2025-07-04T00:00:00Z",
+      "count": 18,
+      "uniques": 9
+    },
+    {
+      "timestamp": "2025-07-05T00:00:00Z",
+      "count": 21,
+      "uniques": 14
+    },
+    {
+      "timestamp": "2025-07-06T00:00:00Z",
+      "count": 20,
+      "uniques": 15
+    },
+    {
+      "timestamp": "2025-07-07T00:00:00Z",
+      "count": 26,
+      "uniques": 17
+    },
+    {
+      "timestamp": "2025-07-08T00:00:00Z",
+      "count": 14,
+      "uniques": 9
+    },
+    {
+      "timestamp": "2025-07-09T00:00:00Z",
+      "count": 19,
+      "uniques": 13
+    },
+    {
+      "timestamp": "2025-07-10T00:00:00Z",
+      "count": 18,
+      "uniques": 13
+    },
+    {
+      "timestamp": "2025-07-11T00:00:00Z",
+      "count": 22,
+      "uniques": 13
+    },
+    {
+      "timestamp": "2025-07-12T00:00:00Z",
+      "count": 19,
+      "uniques": 12
+    },
+    {
+      "timestamp": "2025-07-13T00:00:00Z",
+      "count": 20,
+      "uniques": 13
+    },
+    {
+      "timestamp": "2025-07-14T00:00:00Z",
+      "count": 38,
+      "uniques": 21
+    },
+    {
+      "timestamp": "2025-07-15T00:00:00Z",
+      "count": 18,
+      "uniques": 12
+    }
+  ]
+}

{dar_backup-0.7.2 → dar_backup-0.8.1}/pyproject.toml

@@ -99,6 +99,8 @@ dev = [
   "zipp>=3.19.1",
   "anyio>=4.4.0",
   "black>=25.1.0",
+  "pandas>=2.3.0",
+  "matplotlib>=3.10.3",
 ]
 
 packaging = [

{dar_backup-0.7.2 → dar_backup-0.8.1/src/dar_backup}/Changelog.md

@@ -1,6 +1,23 @@
 <!-- markdownlint-disable MD024 -->
 # dar-backup Changelog
 
+## v2-beta-0.8.1 - 2025-07-16
+
+Github link: [v2-beta-0.8.1](https://github.com/per2jensen/dar-backup/tree/v2-beta-0.8.1/v2)
+
+### Added
+
+- FIX: runner now logs an error and fills more data into the returned CommandResult.
+
+## v2-beta-0.8.0 - 2025-06-13
+
+Github link: [v2-beta-0.8.0](https://github.com/per2jensen/dar-backup/tree/v2-beta-0.8.0/v2)
+
+### Added
+
+- Modified clone dashboard generator to produce easier to read dashboard and be more robust.
+- Dir_traversal sanitation: clean_log.py now only accepts files in configured log directory to `--file` option.
+
 ## v2-beta-0.7.2 - 2025-06-07
 
 Github link: [v2-beta-0.7.2](https://github.com/per2jensen/dar-backup/tree/v2-beta-0.7.2/v2)
@@ -16,7 +33,7 @@ Github link: [v2-beta-0.7.2](https://github.com/per2jensen/dar-backup/tree/v2-be
 - Enrolling into [Snyk code checker](https://snyk.io/code-checker/) and learning how to work with it.
   
   - Snyk helped pointing out vulnerable versions of some packages used.
-  - Input sanitization started, there is room for improvement.
+  - Input sanitation started, there is room for improvement.
 
 ## v2-beta-0.7.1 - 2025-05-22
 

{dar_backup-0.7.2 → dar_backup-0.8.1}/src/dar_backup/README.md

@@ -9,7 +9,7 @@
 [![PyPI version](https://img.shields.io/pypi/v/dar-backup.svg)](https://pypi.org/project/dar-backup/)
 [![PyPI downloads](https://img.shields.io/badge/dynamic/json?color=blue&label=PyPI%20downloads&query=total&url=https%3A%2F%2Fraw.githubusercontent.com%2Fper2jensen%2Fdar-backup%2Fmain%2Fdownloads.json)](https://pypi.org/project/dar-backup/)
 [![# clones](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/per2jensen/dar-backup/main/v2/doc/badges/badge_clones.json)](https://github.com/per2jensen/dar-backup/blob/main/v2/doc/weekly_clones.png)
-[![Milestone](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/per2jensen/dar-backup/main/v2/doc/badges/milestone_badge.json)](https://github.com/per2jensen/dar-backup/blob/main/v2/doc/weekly_clones.png)
+[![Milestone](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/per2jensen/dar-backup/main/v2/doc/badges/milestone_badge.json)](https://github.com/per2jensen/dar-backup/blob/main/v2/doc/weekly_clones.png)  <sub>🎯 Stats powered by [ClonePulse](https://github.com/per2jensen/clonepulse)</sub>
 
 The wonderful 'dar' [Disk Archiver](https://github.com/Edrusb/DAR) is used for
 the heavy lifting, together with the [parchive](https://github.com/Parchive/par2cmdline) suite in these scripts.

{dar_backup-0.7.2 → dar_backup-0.8.1}/src/dar_backup/__about__.py

@@ -1,4 +1,4 @@
-__version__ = "0.7.2"
+__version__ = "0.8.1"
 
 __license__ = '''Licensed under GNU GENERAL PUBLIC LICENSE v3, see the supplied file "LICENSE" for details.
 THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW, not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

{dar_backup-0.7.2 → dar_backup-0.8.1}/src/dar_backup/clean_log.py

@@ -138,6 +138,18 @@ def main():
 
     for file_path in args.file:
 
+        if ".." in os.path.normpath(file_path).split(os.sep):
+            print(f"Error: Path traversal is not allowed: '{file_path}'")
+            sys.exit(1)
+
+        logfile_dir = os.path.dirname(os.path.realpath(config_settings.logfile_location))
+        resolved_path = os.path.realpath(file_path)
+
+        if not resolved_path.startswith(logfile_dir + os.sep):
+            print(f"Error: File is outside allowed directory: '{file_path}'")
+            sys.exit(1)
+
+        # Validate the file path type and existence        
         if not isinstance(file_path, (str, bytes, os.PathLike)):
             print(f"Error: Invalid file path type: {file_path}")
             sys.exit(1)

{dar_backup-0.7.2 → dar_backup-0.8.1}/src/dar_backup/command_runner.py

@@ -2,6 +2,7 @@
 
 import subprocess
 import logging
+import traceback
 import threading
 import os
 import sys
@@ -12,14 +13,24 @@ from dar_backup.util import get_logger
 
 
 class CommandResult:
-    def __init__(self, returncode: int, stdout: str, stderr: str):
+    def __init__(self, returncode: int, stdout: str, stderr: str, stack: str = None):
         self.returncode = returncode
         self.stdout = stdout
         self.stderr = stderr
+        self.stack = stack
 
     def __repr__(self):
-        return f"<CommandResult returncode={self.returncode}>"
-
+        return f"<CommandResult returncode={self.returncode}\nstdout={self.stdout}\nstderr={self.stderr}\nstack={self.stack}>"
+    
+
+    def __str__(self):
+        return (
+            f"CommandResult:\n"
+            f"  Return code: {self.returncode}\n"
+            f"  STDOUT:\n{self.stdout}\n"
+            f"  STDERR:\n{self.stderr}\n"
+            f"  Stacktrace:\n{self.stack if self.stack else '<none>'}"
+        )
 
 class CommandRunner:
     def __init__(
@@ -74,22 +85,29 @@ class CommandRunner:
     ) -> CommandResult:
         timeout = timeout or self.default_timeout
 
-        #log the command to be executed
         command = f"Executing command: {' '.join(cmd)} (timeout={timeout}s)"
-        self.command_logger.info(command) # log to command logger
-        self.logger.debug(command)        # log to main logger if "--log-level debug"
-
-        process = subprocess.Popen(
-            cmd,
-            stdout=subprocess.PIPE if capture_output else None,
-            stderr=subprocess.PIPE if capture_output else None,
-            text=False,
-            bufsize=-1
-        )
+        self.command_logger.info(command)
+        self.logger.debug(command)
 
         stdout_lines = []
         stderr_lines = []
 
+        try:
+            process = subprocess.Popen(
+                cmd,
+                stdout=subprocess.PIPE if capture_output else None,
+                stderr=subprocess.PIPE if capture_output else None,
+                text=False,
+                bufsize=-1
+            )
+        except Exception as e:
+            stack = traceback.format_exc()
+            return CommandResult(
+                returncode=-1,
+                stdout='',
+                stderr=str(e),
+                stack=stack
+            )
 
         def stream_output(stream, lines, level):
             try:
@@ -123,11 +141,27 @@ class CommandRunner:
             process.kill()
             self.logger.error(f"Command timed out: {' '.join(cmd)}")
             return CommandResult(-1, ''.join(stdout_lines), ''.join(stderr_lines))
+        except Exception as e:
+            stack = traceback.format_exc()
+            self.logger.error(f"Command execution failed: {' '.join(cmd)} with error: {e}")
+            return CommandResult(-1, ''.join(stdout_lines), ''.join(stderr_lines), stack)  
 
         for t in threads:
             t.join()
 
+
         if check and process.returncode != 0:
             self.logger.error(f"Command failed with exit code {process.returncode}")
+            return CommandResult(
+                process.returncode,
+                ''.join(stdout_lines),
+                ''.join(stderr_lines),
+                stack=traceback.format_stack()
+            )
+
+        return CommandResult(
+            process.returncode,
+            ''.join(stdout_lines),
+            ''.join(stderr_lines),
+        )
 
-        return CommandResult(process.returncode, ''.join(stdout_lines), ''.join(stderr_lines))