dagster-k8s 0.25.4rc0__tar.gz → 0.25.6__tar.gz

{dagster-k8s-0.25.4rc0/dagster_k8s.egg-info → dagster-k8s-0.25.6}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: dagster-k8s
-Version: 0.25.4rc0
+Version: 0.25.6
 Summary: A Dagster integration for k8s
 Home-page: https://github.com/dagster-io/dagster/tree/master/python_modules/libraries/dagster-k8s
 Author: Dagster Labs

{dagster-k8s-0.25.4rc0 → dagster-k8s-0.25.6}/dagster_k8s/client.py

@@ -673,7 +673,6 @@ class DagsterKubernetesClient:
             # State checks below, see:
             # https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#containerstate-v1-core
             state = container_status.state
-
             if state.running is not None:
                 if wait_for_state == WaitForPodState.Ready:
                     # ready is boolean field of container status
@@ -684,6 +683,11 @@ class DagsterKubernetesClient:
                         continue
                     else:
                         ready_containers.add(container_status.name)
+                        if container_status.name in initcontainers:
+                            self.logger(
+                                f'Init container "{container_status.name}" is ready, waiting for non-init containers...'
+                            )
+                            continue
                         if initcontainers.issubset(exited_containers | ready_containers):
                             self.logger(f'Pod "{pod_name}" is ready, done waiting')
                             break

{dagster-k8s-0.25.4rc0 → dagster-k8s-0.25.6}/dagster_k8s/executor.py

@@ -332,7 +332,7 @@ class K8sStepHandler(StepHandler):
         container_context = self._get_container_context(step_handler_context)
 
         status = self._api_client.get_job_status(
-            namespace=container_context.namespace,
+            namespace=container_context.namespace,  # pyright: ignore[reportArgumentType]
             job_name=job_name,
         )
         if not status:

{dagster-k8s-0.25.4rc0 → dagster-k8s-0.25.6}/dagster_k8s/launcher.py

@@ -313,6 +313,11 @@ class K8sRunLauncher(RunLauncher, ConfigurableClass):
 
         self._launch_k8s_job_with_args(job_name, args, run)
 
+    def _get_resume_attempt_number(self, run: DagsterRun) -> Optional[int]:
+        if not self.supports_run_worker_crash_recovery:
+            return None
+        return self._instance.count_resume_run_attempts(run.run_id)
+
     def terminate(self, run_id):
         check.str_param(run_id, "run_id")
         run = self._instance.get_run_by_id(run_id)
@@ -325,7 +330,7 @@ class K8sRunLauncher(RunLauncher, ConfigurableClass):
         container_context = self.get_container_context_for_run(run)
 
         job_name = get_job_name_from_run_id(
-            run_id, resume_attempt_number=self._instance.count_resume_run_attempts(run.run_id)
+            run_id, resume_attempt_number=self._get_resume_attempt_number(run)
         )
 
         try:
@@ -367,12 +372,10 @@ class K8sRunLauncher(RunLauncher, ConfigurableClass):
         self, run: DagsterRun, include_container_logs: Optional[bool] = True
     ) -> Optional[str]:
         container_context = self.get_container_context_for_run(run)
-        if self.supports_run_worker_crash_recovery:
-            resume_attempt_number = self._instance.count_resume_run_attempts(run.run_id)
-        else:
-            resume_attempt_number = None
 
-        job_name = get_job_name_from_run_id(run.run_id, resume_attempt_number=resume_attempt_number)
+        job_name = get_job_name_from_run_id(
+            run.run_id, resume_attempt_number=self._get_resume_attempt_number(run)
+        )
         namespace = container_context.namespace
         pod_names = self._api_client.get_pod_names_in_job(job_name, namespace=namespace)
         full_msg = ""
@@ -397,7 +400,7 @@ class K8sRunLauncher(RunLauncher, ConfigurableClass):
             )
 
         else:
-            job_debug_info = self._api_client.get_job_debug_info(job_name, namespace=namespace)
+            job_debug_info = self._api_client.get_job_debug_info(job_name, namespace=namespace)  # pyright: ignore[reportArgumentType]
             full_msg = (
                 full_msg
                 + "\n\n"
@@ -411,15 +414,12 @@ class K8sRunLauncher(RunLauncher, ConfigurableClass):
     def check_run_worker_health(self, run: DagsterRun):
         container_context = self.get_container_context_for_run(run)
 
-        if self.supports_run_worker_crash_recovery:
-            resume_attempt_number = self._instance.count_resume_run_attempts(run.run_id)
-        else:
-            resume_attempt_number = None
-
-        job_name = get_job_name_from_run_id(run.run_id, resume_attempt_number=resume_attempt_number)
+        job_name = get_job_name_from_run_id(
+            run.run_id, resume_attempt_number=self._get_resume_attempt_number(run)
+        )
         try:
             status = self._api_client.get_job_status(
-                namespace=container_context.namespace,
+                namespace=container_context.namespace,  # pyright: ignore[reportArgumentType]
                 job_name=job_name,
             )
         except Exception:

{dagster-k8s-0.25.4rc0 → dagster-k8s-0.25.6}/dagster_k8s/models.py

@@ -69,7 +69,7 @@ def _k8s_parse_value(data: Any, classname: str, attr_name: str) -> Any:
     elif klass == object:
         return data
     elif klass == datetime.date:
-        return parse(data).date()
+        return parse(data).date()  # pyright: ignore[reportAttributeAccessIssue]
     elif klass == datetime.datetime:
         return parse(data)
     else:

{dagster-k8s-0.25.4rc0 → dagster-k8s-0.25.6}/dagster_k8s/ops/k8s_job_op.py

@@ -371,7 +371,10 @@ def execute_k8s_job(
             watch = kubernetes.watch.Watch()  # consider moving in to api_client
 
             api_client.wait_for_pod(
-                pod_to_watch, namespace, wait_timeout=timeout, start_time=start_time
+                pod_to_watch,
+                namespace,  # pyright: ignore[reportArgumentType]
+                wait_timeout=timeout,
+                start_time=start_time,  # pyright: ignore[reportArgumentType]
             )
 
             log_stream = watch.stream(
@@ -416,6 +419,20 @@ def execute_k8s_job(
             num_pods_to_wait_for=num_pods_to_wait_for,
         )
     except (DagsterExecutionInterruptedError, Exception) as e:
+        try:
+            pods = api_client.get_pod_names_in_job(job_name=job_name, namespace=namespace)
+            pod_debug_info = "\n\n".join(
+                [api_client.get_pod_debug_info(pod_name, namespace) for pod_name in pods]
+            )
+        except Exception:
+            context.log.exception(
+                f"Error trying to get pod debug information for failed k8s job {job_name}"
+            )
+        else:
+            context.log.error(
+                f"Debug information for failed k8s job {job_name}:\n\n{pod_debug_info}"
+            )
+
         if delete_failed_k8s_jobs:
             context.log.info(
                 f"Deleting Kubernetes job {job_name} in namespace {namespace} due to exception"

dagster-k8s-0.25.6/dagster_k8s/version.py

@@ -0,0 +1 @@
+__version__ = "0.25.6"

{dagster-k8s-0.25.4rc0 → dagster-k8s-0.25.6/dagster_k8s.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: dagster-k8s
-Version: 0.25.4rc0
+Version: 0.25.6
 Summary: A Dagster integration for k8s
 Home-page: https://github.com/dagster-io/dagster/tree/master/python_modules/libraries/dagster-k8s
 Author: Dagster Labs

{dagster-k8s-0.25.4rc0 → dagster-k8s-0.25.6}/dagster_k8s.egg-info/requires.txt

@@ -1,3 +1,3 @@
-dagster==1.9.4rc0
+dagster==1.9.6
 kubernetes<32
 google-auth!=2.23.1

{dagster-k8s-0.25.4rc0 → dagster-k8s-0.25.6}/setup.py

@@ -43,7 +43,7 @@ setup(
     include_package_data=True,
     python_requires=">=3.9,<3.13",
     install_requires=[
-        "dagster==1.9.4rc0",
+        "dagster==1.9.6",
         f"kubernetes<{KUBERNETES_VERSION_UPPER_BOUND}",
         # exclude a google-auth release that added an overly restrictive urllib3 pin that confuses dependency resolvers
         "google-auth!=2.23.1",

dagster-k8s-0.25.4rc0/dagster_k8s/version.py

@@ -1 +0,0 @@
-__version__ = "0.25.4rc0"