cuenca-validations 2.1.48.dev1__tar.gz → 2.1.49__tar.gz

{cuenca_validations-2.1.48.dev1 → cuenca_validations-2.1.49}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cuenca_validations
-Version: 2.1.48.dev1
+Version: 2.1.49
 Summary: Cuenca common validations
 Home-page: https://github.com/cuenca-mx/cuenca-validations
 Author: Cuenca

{cuenca_validations-2.1.48.dev1 → cuenca_validations-2.1.49}/cuenca_validations/types/__init__.py

@@ -83,7 +83,6 @@ __all__ = [
     'Profession',
     'QueryParams',
     'ReferencedClabeRequest',
-    'RejectTransferOrderRequest',
     'LegalRfc',
     'Rfc',
     'QuestionnairesRequest',
@@ -114,6 +113,8 @@ __all__ = [
     'TransferOrderStatus',
     'TransferQuery',
     'TransferRequest',
+    'UpdateTransferOrderRequest',
+    'UpdateTransferOrderStatus',
     'UpdateTransferRequest',
     'UserCardNotification',
     'UserCredentialRequest',
@@ -191,6 +192,7 @@ from .enums import (
     TransactionStatus,
     TransferNetwork,
     TransferOrderStatus,
+    UpdateTransferOrderStatus,
     UserCardNotification,
     UserStatus,
     UserType,
@@ -280,7 +282,6 @@ from .requests import (
     PlatformRequest,
     QuestionnairesRequest,
     ReferencedClabeRequest,
-    RejectTransferOrderRequest,
     SavingRequest,
     SavingUpdateRequest,
     SessionRequest,
@@ -289,6 +290,7 @@ from .requests import (
     TransferOrderLineRequest,
     TransferOrderRequest,
     TransferRequest,
+    UpdateTransferOrderRequest,
     UpdateTransferRequest,
     UserCredentialRequest,
     UserCredentialUpdateRequest,

{cuenca_validations-2.1.48.dev1 → cuenca_validations-2.1.49}/cuenca_validations/types/enums.py

@@ -768,3 +768,8 @@ class TransferOrderStatus(str, Enum):
     authorized = 'authorized'
     rejected = 'rejected'
     expired = 'expired'
+
+
+class UpdateTransferOrderStatus(str, Enum):
+    authorized = 'authorized'
+    rejected = 'rejected'

{cuenca_validations-2.1.48.dev1 → cuenca_validations-2.1.49}/cuenca_validations/types/requests.py

@@ -50,6 +50,7 @@ from ..types.enums import (
     TrackDataMethod,
     TransactionStatus,
     TransactionTokenValidationStatus,
+    UpdateTransferOrderStatus,
     UserCardNotification,
     UserStatus,
     VerificationStatus,
@@ -1021,10 +1022,6 @@ class PhoneVerificationAssociationRequest(BaseRequest):
     verification_id: str
 
 
-MAX_TRANSFER_ORDER_BATCH_LINES = 5000
-MAX_TRANSFER_ORDER_EXPIRATION_HOURS = 24 * 7
-
-
 class TransferOrderLineRequest(BaseRequest):
     account_number: str
     recipient_name: str
@@ -1044,65 +1041,60 @@ class TransferOrderLineRequest(BaseRequest):
 
 
 class TransferOrderRequest(BaseRequest):
-    account_number: Optional[str] = None
-    recipient_name: Optional[str] = None
-    amount: Optional[int] = None
-    descriptor: Optional[str] = None
     idempotency_key: str
     legal_person_id: Optional[str] = None
-    items: Optional[list[TransferOrderLineRequest]] = None
-    expires_in_hours: Optional[int] = Field(
-        default=None,
-        gt=0,
-        le=MAX_TRANSFER_ORDER_EXPIRATION_HOURS,
-    )
+    items: list[TransferOrderLineRequest]
 
     model_config = ConfigDict(
         json_schema_extra={
             'example': {
-                'account_number': '646180157034181180',
-                'recipient_name': 'Doroteo Arango',
-                'amount': 100_00,
-                'descriptor': 'Mezcal, pulque y tequila',
                 'idempotency_key': 'UNIQUE-KEY-003',
                 'legal_person_id': 'USWqY5cvkISJOxHyEKjAKf8w',
+                'items': [
+                    {
+                        'account_number': '646180157034181180',
+                        'recipient_name': 'Doroteo Arango',
+                        'amount': 100_00,
+                        'descriptor': 'Mezcal, pulque y tequila',
+                    }
+                ],
             }
         },
     )
 
     @model_validator(mode='after')
-    def require_unitario_or_batch(self) -> 'TransferOrderRequest':
-        has_items = bool(self.items)
-        has_flat = all(
-            (
-                self.account_number is not None,
-                self.recipient_name is not None,
-                self.amount is not None,
-                self.descriptor is not None,
-            )
-        )
-        if has_items == has_flat:
-            raise ValueError(
-                'Provide either a single transfer (account_number, '
-                'recipient_name, amount, descriptor) or items[] for a batch, '
-                'not both'
-            )
-        if self.items is not None:
-            if len(self.items) > MAX_TRANSFER_ORDER_BATCH_LINES:
-                raise ValueError(
-                    'Batch exceeds maximum of '
-                    f'{MAX_TRANSFER_ORDER_BATCH_LINES} lines'
-                )
-            if len(self.items) == 0:
-                raise ValueError('items must not be empty')
+    def validate_items(self) -> 'TransferOrderRequest':
+        if len(self.items) == 0:
+            raise ValueError('items must not be empty')
         return self
 
 
-class RejectTransferOrderRequest(BaseRequest):
-    rejection_reason: str
+class UpdateTransferOrderRequest(BaseRequest):
+    status: UpdateTransferOrderStatus
+    rejection_reason: Optional[str] = None
 
     model_config = ConfigDict(
         json_schema_extra={
-            'example': {'rejection_reason': 'Monto incorrecto'},
+            'examples': [
+                {'status': 'authorized'},
+                {
+                    'status': 'rejected',
+                    'rejection_reason': 'Monto incorrecto',
+                },
+            ]
         },
     )
+
+    @model_validator(mode='after')
+    def validate_rejection_reason(self) -> 'UpdateTransferOrderRequest':
+        if self.status is UpdateTransferOrderStatus.rejected:
+            if (
+                self.rejection_reason is None
+                or not self.rejection_reason.strip()
+            ):
+                raise ValueError('rejection_reason is required')
+        elif self.rejection_reason is not None:
+            raise ValueError(
+                'rejection_reason is only allowed when status is rejected'
+            )
+        return self

cuenca_validations-2.1.49/cuenca_validations/version.py

@@ -0,0 +1 @@
+__version__ = '2.1.49'

{cuenca_validations-2.1.48.dev1 → cuenca_validations-2.1.49}/cuenca_validations.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cuenca_validations
-Version: 2.1.48.dev1
+Version: 2.1.49
 Summary: Cuenca common validations
 Home-page: https://github.com/cuenca-mx/cuenca-validations
 Author: Cuenca

{cuenca_validations-2.1.48.dev1 → cuenca_validations-2.1.49}/tests/test_requests.py

@@ -5,17 +5,18 @@ from pydantic_extra_types.phone_numbers import PhoneNumber
 from cuenca_validations.types.enums import (
     Country,
     OperatorRole,
+    UpdateTransferOrderStatus,
     VerificationType,
 )
 from cuenca_validations.types.queries import OperatorQuery
 from cuenca_validations.types.requests import (
-    MAX_TRANSFER_ORDER_BATCH_LINES,
     OperatorLoginRequest,
     OperatorLoginUpdateRequest,
     OperatorRequest,
     OperatorUpdateRequest,
     PasswordResetRequest,
     TransferOrderRequest,
+    UpdateTransferOrderRequest,
     UpdateTransferRequest,
     UserTOSAgreementRequest,
     UserUpdateRequest,
@@ -244,26 +245,61 @@ def test_transfer_order_request_shape() -> None:
         'descriptor': 'Mezcal',
     }
     single = TransferOrderRequest.model_validate(
-        {**line, 'idempotency_key': 'single'}
+        {'idempotency_key': 'single', 'items': [line]}
     )
-    assert single.items is None
+    assert single.items is not None
+    assert len(single.items) == 1
     batch = TransferOrderRequest.model_validate(
-        {'idempotency_key': 'batch', 'items': [line]}
+        {'idempotency_key': 'batch', 'items': [line, line]}
     )
     assert batch.items is not None
+    assert len(batch.items) == 2
 
-    with pytest.raises(ValidationError, match='not both'):
-        TransferOrderRequest.model_validate(
-            {**line, 'idempotency_key': 'both', 'items': [line]}
-        )
     with pytest.raises(ValidationError, match='items must not be empty'):
         TransferOrderRequest.model_validate(
-            {**line, 'idempotency_key': 'empty', 'items': []}
+            {'idempotency_key': 'empty', 'items': []}
         )
-    with pytest.raises(ValidationError, match='Batch exceeds maximum'):
-        TransferOrderRequest.model_validate(
-            {
-                'idempotency_key': 'too-many',
-                'items': [line] * (MAX_TRANSFER_ORDER_BATCH_LINES + 1),
-            }
+    with pytest.raises(ValidationError):
+        TransferOrderRequest.model_validate({'idempotency_key': 'missing'})
+
+
+@pytest.mark.parametrize(
+    'payload',
+    [
+        {'status': 'rejected'},
+        {'status': 'rejected', 'rejection_reason': ''},
+        {'status': 'rejected', 'rejection_reason': '   '},
+    ],
+)
+def test_update_transfer_order_request_rejected_requires_reason(
+    payload: dict,
+) -> None:
+    with pytest.raises(ValidationError, match='rejection_reason is required'):
+        UpdateTransferOrderRequest.model_validate(payload)
+
+
+def test_update_transfer_order_request_authorized_forbids_reason() -> None:
+    with pytest.raises(
+        ValidationError,
+        match='rejection_reason is only allowed when status is rejected',
+    ):
+        UpdateTransferOrderRequest.model_validate(
+            {'status': 'authorized', 'rejection_reason': 'no'}
         )
+
+
+@pytest.mark.parametrize(
+    'payload, status',
+    [
+        ({'status': 'authorized'}, UpdateTransferOrderStatus.authorized),
+        (
+            {'status': 'rejected', 'rejection_reason': 'Monto incorrecto'},
+            UpdateTransferOrderStatus.rejected,
+        ),
+    ],
+)
+def test_update_transfer_order_request_valid(
+    payload: dict, status: UpdateTransferOrderStatus
+) -> None:
+    req = UpdateTransferOrderRequest.model_validate(payload)
+    assert req.status is status

cuenca_validations-2.1.48.dev1/cuenca_validations/version.py

@@ -1 +0,0 @@
-__version__ = '2.1.48.dev1'