cuenca-validations 2.1.16.dev100__tar.gz → 2.1.17.dev1__tar.gz

{cuenca_validations-2.1.16.dev100 → cuenca_validations-2.1.17.dev1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cuenca_validations
-Version: 2.1.16.dev100
+Version: 2.1.17.dev1
 Summary: Cuenca common validations
 Home-page: https://github.com/cuenca-mx/cuenca-validations
 Author: Cuenca

{cuenca_validations-2.1.16.dev100 → cuenca_validations-2.1.17.dev1}/cuenca_validations/types/enums.py

@@ -705,7 +705,7 @@ class Profession(str, Enum):
     sistemas = 'sistemas'
     independiente = 'independiente'
     oficios = 'oficios'
-    otros = 'otros'
+    otro = 'otro'
 
 
 class AccountUseType(str, Enum):

{cuenca_validations-2.1.16.dev100 → cuenca_validations-2.1.17.dev1}/cuenca_validations/types/general.py

@@ -121,7 +121,7 @@ names_professions = {
     Profession.sistemas: 'Sistemas y Comunicaciones',
     Profession.independiente: 'Trabajador(a/e) Independiente',
     Profession.oficios: 'Oficios Varios',
-    Profession.otros: 'Otros',
+    Profession.otro: 'Otro',
 }
 
 

{cuenca_validations-2.1.16.dev100 → cuenca_validations-2.1.17.dev1}/cuenca_validations/types/requests.py

@@ -487,6 +487,13 @@ class UserRequest(BaseModel):
             validate_age_requirement(curp)
         return curp
 
+    @field_validator('profession')
+    @classmethod
+    def validate_profession(cls, profession: Profession) -> Profession:
+        if profession == Profession.otro:
+            raise ValueError('Profession "otro" is not allowed')
+        return profession
+
 
 class UserUpdateRequest(BaseModel):
     profession: Optional[Profession] = None
@@ -517,6 +524,13 @@ class UserUpdateRequest(BaseModel):
             raise ValueError('The total percentage should be 100%')
         return beneficiaries
 
+    @field_validator('profession')
+    @classmethod
+    def validate_profession(cls, profession: Profession) -> Profession:
+        if profession == Profession.otro:
+            raise ValueError('Profession "otro" is not allowed')
+        return profession
+
 
 class UserLoginRequest(BaseRequest):
     password: Annotated[
@@ -533,15 +547,17 @@ class SessionRequest(BaseRequest):
     type: SessionType
     success_url: Optional[SerializableAnyUrl] = None
     failure_url: Optional[SerializableAnyUrl] = None
-    metadata: Optional[dict] = None
+    resource_id: Optional[str] = None
 
     @model_validator(mode='before')
     @classmethod
     def validate_metadata(cls, values: dict) -> dict:
         if values[
             'type'
-        ] == SessionType.metamap_verification and not values.get('metadata'):
-            raise ValueError('Metadata expected for this session')
+        ] == SessionType.metamap_verification and not values.get(
+            'resource_id'
+        ):
+            raise ValueError('Resource id expected for this session')
         return values
 
     model_config = ConfigDict(
@@ -551,7 +567,7 @@ class SessionRequest(BaseRequest):
                 'type': 'session.registration',
                 'success_url': 'http://example_success.com',
                 'failure_url': 'http://example_failure.com',
-                'metadata': {'verification_id': 'some_verification_id'},
+                'resource_id': 'some_resource_id',
             }
         }
     )

cuenca_validations-2.1.17.dev1/cuenca_validations/version.py

@@ -0,0 +1 @@
+__version__ = '2.1.17.dev1'

{cuenca_validations-2.1.16.dev100 → cuenca_validations-2.1.17.dev1}/cuenca_validations.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cuenca_validations
-Version: 2.1.16.dev100
+Version: 2.1.17.dev1
 Summary: Cuenca common validations
 Home-page: https://github.com/cuenca-mx/cuenca-validations
 Author: Cuenca

{cuenca_validations-2.1.16.dev100 → cuenca_validations-2.1.17.dev1}/tests/test_requests.py

@@ -45,17 +45,17 @@ def test_session_request_without_metadata():
     assert request.user_id == 'USWqY5cvkISJOxHyEKjAKf8w'
 
 
-def test_session_request_with_metadata():
+def test_session_request_with_resource_id():
     request_data = {
         'user_id': 'USWqY5cvkISJOxHyEKjAKf8w',
         'type': 'session.metamap_verification',
-        'metadata': {'verification_id': 'some_verification'},
+        'resource_id': 'some_verification_id',
     }
     request = SessionRequest(**request_data)
     assert request.type == SessionType.metamap_verification
     assert request.user_id == 'USWqY5cvkISJOxHyEKjAKf8w'
-    assert request.metadata
-    assert request.metadata['verification_id'] == 'some_verification'
+    assert request.resource_id
+    assert request.resource_id == 'some_verification_id'
 
 
 def test_metamap_session_request_without_metadata():
@@ -67,4 +67,4 @@ def test_metamap_session_request_without_metadata():
     with pytest.raises(ValidationError) as exception:
         SessionRequest(**request_data)
 
-    assert 'Metadata expected for this session' in str(exception)
+    assert 'Resource id expected for this session' in str(exception)

{cuenca_validations-2.1.16.dev100 → cuenca_validations-2.1.17.dev1}/tests/test_types.py

@@ -328,6 +328,23 @@ def test_user_request():
     assert UserRequest(**request).model_dump(exclude_none=True) == request
 
 
+def test_user_request_invalid_profession():
+    request = dict(
+        curp='ABCD920604HDFSRN03',
+        profession=Profession.otro,
+        address=dict(
+            street='calle 1',
+            ext_number='2',
+            int_number='3',
+            postal_code_id='PC2ygq9j2bS9-9tsuVawzErA',
+        ),
+        phone_verification_id='VE12345678',
+        email_verification_id='VE0987654321',
+    )
+    with pytest.raises(ValidationError):
+        UserRequest(**request)
+
+
 @freeze_time('2022-01-01')
 def test_user_request_underage():
     request = dict(
@@ -419,6 +436,7 @@ def test_user_update_request():
             ),
         ],
         curp_document_uri='https://sandbox.cuenca.com/files/EF123',
+        profession=Profession.empleado,
     )
     update_req = UserUpdateRequest(**request)
     beneficiaries = [b.model_dump() for b in update_req.beneficiaries]
@@ -427,6 +445,7 @@ def test_user_update_request():
         update_req.curp_document_uri.unicode_string()
         == request['curp_document_uri']
     )
+    assert update_req.profession == Profession.empleado
 
     request['beneficiaries'] = [
         dict(
@@ -490,6 +509,10 @@ def test_user_update_request():
     )
     UserUpdateRequest(**kyc_request)
 
+    request['profession'] = Profession.otro
+    with pytest.raises(ValidationError) as v:
+        UserUpdateRequest(**request)
+
 
 def test_session_request():
     data = dict(

cuenca_validations-2.1.16.dev100/cuenca_validations/version.py

@@ -1 +0,0 @@
-__version__ = '2.1.16.dev100'