ctrlrelay 0.16.2__tar.gz → 0.16.3__tar.gz

{ctrlrelay-0.16.2 → ctrlrelay-0.16.3}/CHANGELOG.md

@@ -7,6 +7,21 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.16.3] - 2026-11-01
+
+A security fix: **upgrade every machine.** No config edit is required.
+
+### Fixed
+
+- Only issues the operator assigned to themselves are taken, as intended.
+  The check read `actor` on GitHub's `assigned` events, which is the account
+  assigned (the operator), not the one who assigned it (`assigner`), so an
+  issue anyone else assigned to the operator was taken too. It now reads
+  `assigner`, refuses an event without one, refuses an unnamed assignment
+  after the operator's last one, and reads every page of an issue's events.
+  The status page's "assigned by someone else" uses the same check (#275,
+  closes #274)
+
 ## [0.16.2] - 2026-11-01
 
 Status page changes only. **No config edit is required.**
@@ -2001,7 +2016,8 @@ pipeline).
   per-phase implementation plans (Phase 0 through Phase 4).
 - `docs/Claude_Code_Project_Guide.md` — project development guide.
 
-[Unreleased]: https://github.com/AInvirion/ctrlrelay/compare/v0.16.2...HEAD
+[Unreleased]: https://github.com/AInvirion/ctrlrelay/compare/v0.16.3...HEAD
+[0.16.3]: https://github.com/AInvirion/ctrlrelay/compare/v0.16.2...v0.16.3
 [0.16.2]: https://github.com/AInvirion/ctrlrelay/compare/v0.16.1...v0.16.2
 [0.16.1]: https://github.com/AInvirion/ctrlrelay/compare/v0.16.0...v0.16.1
 [0.16.0]: https://github.com/AInvirion/ctrlrelay/compare/v0.15.0...v0.16.0

{ctrlrelay-0.16.2 → ctrlrelay-0.16.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: ctrlrelay
-Version: 0.16.2
+Version: 0.16.3
 Summary: Local-first orchestrator for headless coding agents across multiple GitHub repos
 Project-URL: Homepage, https://github.com/AInvirion/ctrlrelay
 Project-URL: Documentation, https://ainvirion.github.io/ctrlrelay/

{ctrlrelay-0.16.2 → ctrlrelay-0.16.3}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "ctrlrelay"
-version = "0.16.2"
+version = "0.16.3"
 description = "Local-first orchestrator for headless coding agents across multiple GitHub repos"
 readme = "README.md"
 requires-python = ">=3.12"

{ctrlrelay-0.16.2 → ctrlrelay-0.16.3}/src/ctrlrelay/core/github.py

@@ -424,17 +424,21 @@ class GitHubCLI:
     ) -> list[dict[str, Any]]:
         """List ``assigned`` events for an issue in chronological order.
 
-        Returns the GitHub issue-events payload filtered to ``event == "assigned"``.
-        Each entry includes ``actor`` (who performed the assignment) and
-        ``assignee`` (who was assigned). Used by the poller to verify that the
-        most recent self-assignment was actually performed by the operator.
+        Returns the GitHub issue-events payload filtered to ``event == "assigned"``,
+        every page of it. Each entry includes ``assigner`` (who performed the
+        assignment) and ``assignee`` (who was assigned); its ``actor`` is the
+        assignee too, not who made it (#274). Used by the poller to verify
+        that the most recent self-assignment was actually performed by the
+        operator.
         """
+        # Every page: on an issue with more than one page of events the
+        # latest assignment would otherwise be missed.
         output = await self._run_gh(
-            "api",
+            "api", "--paginate",
             f"/repos/{repo}/issues/{issue_number}/events",
-            "--jq", '[.[] | select(.event=="assigned")]',
+            "--jq", '.[] | select(.event=="assigned")',
         )
-        return json.loads(output) if output.strip() else []
+        return [json.loads(line) for line in output.splitlines() if line.strip()]
 
     async def get_issue(
         self,

{ctrlrelay-0.16.2 → ctrlrelay-0.16.3}/src/ctrlrelay/core/poller.py

@@ -617,6 +617,25 @@ class IssuePoller:
             return True
 
         events = await self.github.list_assignment_events(repo, issue_number)
+        # An assignment after the operator's last one that names nobody
+        # cannot be ruled out as a newer one by someone else: refuse rather
+        # than skip past it. One before it is overtaken and does not count.
+        last_mine = max(
+            (i for i, e in enumerate(events)
+             if (e.get("assignee") or {}).get("login") == self.username),
+            default=-1,
+        )
+        if any(not (e.get("assignee") or {}).get("login")
+               for e in events[last_mine + 1:]):
+            log_event(
+                _logger,
+                "poll.issue.foreign_assignment",
+                repo=repo,
+                number=issue_number,
+                assigner_login=None,
+                reason="assignment_without_assignee",
+            )
+            return False
         relevant = [
             e
             for e in events
@@ -634,8 +653,12 @@ class IssuePoller:
             return False
 
         # Events endpoint returns chronological order; the last one wins.
+        # Who made the assignment is ``assigner``. On an ``assigned`` event
+        # ``actor`` is the account assigned, which is always the operator
+        # here, so reading it let anyone's assignment through (#274). No
+        # ``assigner`` is treated as foreign.
         latest = relevant[-1]
-        assigner_login = (latest.get("actor") or {}).get("login")
+        assigner_login = (latest.get("assigner") or {}).get("login")
         if assigner_login == self.username:
             return True
 

{ctrlrelay-0.16.2 → ctrlrelay-0.16.3}/tests/test_github.py

@@ -460,17 +460,21 @@ class TestGitHubCLI:
         """Should return only 'assigned' events for an issue."""
         from ctrlrelay.core.github import GitHubCLI
 
-        mock_output = json.dumps([
+        # ``gh api --paginate --jq '.[] | ...'`` prints one event per line,
+        # across every page.
+        mock_output = "\n".join(json.dumps(e) for e in [
             {
                 "event": "assigned",
                 "actor": {"login": "alice"},
                 "assignee": {"login": "alice"},
+                "assigner": {"login": "alice"},
                 "created_at": "2026-01-01T00:00:00Z",
             },
             {
                 "event": "assigned",
-                "actor": {"login": "bob"},
+                "actor": {"login": "alice"},
                 "assignee": {"login": "alice"},
+                "assigner": {"login": "bob"},
                 "created_at": "2026-01-02T00:00:00Z",
             },
         ])
@@ -481,11 +485,13 @@ class TestGitHubCLI:
             events = await gh.list_assignment_events("owner/repo", 42)
 
             assert len(events) == 2
-            assert events[0]["actor"]["login"] == "alice"
-            assert events[1]["actor"]["login"] == "bob"
+            assert events[0]["assigner"]["login"] == "alice"
+            assert events[1]["assigner"]["login"] == "bob"
 
             args = mock_run.call_args[0]
-            assert "api" in args
+            assert "api" in args and "--paginate" in args
+            # Only assigned events, one per line across every page.
+            assert args[args.index("--jq") + 1] == '.[] | select(.event=="assigned")'
             assert "/repos/owner/repo/issues/42/events" in args
 
     @pytest.mark.asyncio

{ctrlrelay-0.16.2 → ctrlrelay-0.16.3}/tests/test_node_claims.py

@@ -842,7 +842,7 @@ class TestThePollerLooksAgainWhenTheClaimCouldGoStale:
         gh.list_issues_by_label = AsyncMock(return_value=[])
         gh.list_assignment_events = AsyncMock(return_value=[{
             "event": "assigned", "actor": {"login": "alice"},
-            "assignee": {"login": "alice"},
+            "assignee": {"login": "alice"}, "assigner": {"login": "alice"},
         }])
         return IssuePoller(
             github=gh, username="alice", repos=["o/r"],

{ctrlrelay-0.16.2 → ctrlrelay-0.16.3}/tests/test_poller.py

@@ -43,11 +43,15 @@ def state_file(tmp_path: Path) -> Path:
     return tmp_path / "poller_state.json"
 
 
-def make_assigned_event(actor_login: str, assignee_login: str) -> dict:
+def make_assigned_event(assigner_login: str, assignee_login: str) -> dict:
+    """An ``assigned`` event as GitHub's issue events API returns it: ``actor``
+    is the account ASSIGNED (#274), and who made the assignment is in
+    ``assigner``. The first argument is the one that made it."""
     return {
         "event": "assigned",
-        "actor": {"login": actor_login},
+        "actor": {"login": assignee_login},
         "assignee": {"login": assignee_login},
+        "assigner": {"login": assigner_login},
         "created_at": "2026-01-01T00:00:00Z",
     }
 
@@ -2170,3 +2174,71 @@ class TestArchivedRepoSkip:
 
         assert poller.archived_tracker is tracker
         assert tracker.archived_repos == {"owner/repo-a"}
+
+
+
+class TestWhoAssignedIt:
+    """#274: who made an assignment is ``assigner``, never ``actor``."""
+
+    # Recorded from AInvirion/zzsites#784 on 2026-11-01: another account
+    # moved the issue to the operator. ``actor`` names the operator.
+    REAL_FOREIGN = [{
+        "event": "assigned", "created_at": "2026-11-01T21:24:13Z",
+        "actor": {"login": "oscarvalenzuelab"},
+        "assignee": {"login": "oscarvalenzuelab"},
+        "assigner": {"login": "mausisa-nico"},
+    }]
+
+    def _poller(self, gh, state_file):
+        return IssuePoller(github=gh, username="oscarvalenzuelab", repos=["o/r"],
+                           state_file=state_file)
+
+    @pytest.mark.asyncio
+    async def test_the_recorded_foreign_assignment_is_refused(
+        self, mock_github, state_file,
+    ) -> None:
+        mock_github.list_assignment_events = AsyncMock(return_value=self.REAL_FOREIGN)
+        assert not await self._poller(mock_github, state_file)._is_self_assigned("o/r", 784)
+
+    @pytest.mark.asyncio
+    async def test_an_event_with_no_assigner_is_refused(self, mock_github, state_file) -> None:
+        event = dict(self.REAL_FOREIGN[0])
+        del event["assigner"]
+        mock_github.list_assignment_events = AsyncMock(return_value=[event])
+        assert not await self._poller(mock_github, state_file)._is_self_assigned("o/r", 784)
+
+    # Recorded from AInvirion/ctrlrelay#268 on 2026-11-01: the operator
+    # assigned it to themselves.
+    REAL_SELF = [{
+        "event": "assigned", "created_at": "2026-11-01T21:44:14Z",
+        "actor": {"login": "oscarvalenzuelab"},
+        "assignee": {"login": "oscarvalenzuelab"},
+        "assigner": {"login": "oscarvalenzuelab"},
+    }]
+
+    @pytest.mark.asyncio
+    async def test_a_later_assignment_naming_nobody_is_refused(
+        self, mock_github, state_file,
+    ) -> None:
+        later = {"event": "assigned", "created_at": "2026-11-02T00:00:00Z",
+                 "actor": None, "assignee": None, "assigner": {"login": "mausisa-nico"}}
+        mock_github.list_assignment_events = AsyncMock(
+            return_value=[*self.REAL_SELF, later],
+        )
+        assert not await self._poller(mock_github, state_file)._is_self_assigned("o/r", 268)
+
+    @pytest.mark.asyncio
+    async def test_an_earlier_assignment_naming_nobody_does_not_block_a_later_self_one(
+        self, mock_github, state_file,
+    ) -> None:
+        earlier = {"event": "assigned", "created_at": "2026-10-01T00:00:00Z",
+                   "actor": None, "assignee": None, "assigner": None}
+        mock_github.list_assignment_events = AsyncMock(
+            return_value=[earlier, *self.REAL_SELF],
+        )
+        assert await self._poller(mock_github, state_file)._is_self_assigned("o/r", 268)
+
+    @pytest.mark.asyncio
+    async def test_a_real_self_assignment_is_taken(self, mock_github, state_file) -> None:
+        mock_github.list_assignment_events = AsyncMock(return_value=self.REAL_SELF)
+        assert await self._poller(mock_github, state_file)._is_self_assigned("o/r", 784)

{ctrlrelay-0.16.2 → ctrlrelay-0.16.3}/tests/test_usage.py

@@ -361,7 +361,7 @@ class TestAPausedMachineTakesTheIssueAfterTheReset:
         gh.list_issues_by_label = AsyncMock(return_value=[])
         gh.list_assignment_events = AsyncMock(return_value=[{
             "event": "assigned", "actor": {"login": "alice"},
-            "assignee": {"login": "alice"},
+            "assignee": {"login": "alice"}, "assigner": {"login": "alice"},
         }])
         poller = IssuePoller(
             github=gh, username="alice", repos=["o/r"],

{ctrlrelay-0.16.2 → ctrlrelay-0.16.3}/tests/test_web_waiting.py

@@ -407,12 +407,14 @@ class _FakeGitHub:
         return [copy.deepcopy(r) for r in self.by_label.get((repo, label), [])]
 
 
-def _assigned_by(actor: str) -> list[dict]:
-    """`list_assignment_events` output: GitHub `assigned` issue events."""
+def _assigned_by(assigner: str) -> list[dict]:
+    """`list_assignment_events` output, as GitHub returns it: ``actor`` is the
+    account assigned, ``assigner`` the one that assigned (#274)."""
     return [{
         "event": "assigned",
-        "actor": {"login": actor},
+        "actor": {"login": "octo"},
         "assignee": {"login": "octo"},
+        "assigner": {"login": assigner},
         "created_at": "2026-10-20T10:00:00Z",
     }]