crackerjack 0.33.1__tar.gz → 0.33.2__tar.gz

{crackerjack-0.33.1 → crackerjack-0.33.2}/CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.33.2] - 2025-09-14
+
+### Added
+
+- Fix regex validation and remove conflicting pre-commit git hook
+
 ## [0.33.1] - 2025-09-14
 
 ### Added

{crackerjack-0.33.1 → crackerjack-0.33.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: crackerjack
-Version: 0.33.1
+Version: 0.33.2
 Summary: Crackerjack Python project management tool
 Project-URL: documentation, https://github.com/lesleslie/crackerjack
 Project-URL: homepage, https://github.com/lesleslie/crackerjack

{crackerjack-0.33.1 → crackerjack-0.33.2}/crackerjack/services/regex_patterns.py

@@ -2704,6 +2704,19 @@ SAFE_PATTERNS: dict[str, ValidatedPattern] = {
             ("no coverage here", "no coverage here"),  # No match
         ],
     ),
+    "detect_typing_usage": ValidatedPattern(
+        name="detect_typing_usage",
+        pattern=r"\bt\.[A-Z]",
+        replacement="",
+        description="Detect usage of typing module aliases like t.Any, t.Dict, etc.",
+        global_replace=True,
+        test_cases=[
+            ("def func(x: t.Any) -> t.Dict:", "def func(x: ny) -> ict:"),  # Removes t.A and t.D
+            ("value: t.Optional[str] = None", "value: ptional[str] = None"),  # Removes t.O
+            ("from typing import Dict", "from typing import Dict"),  # No match
+            ("data = dict()", "data = dict()"),  # No match
+        ],
+    ),
 }
 
 

{crackerjack-0.33.1 → crackerjack-0.33.2}/docs/archive/CONFIG_MANAGEMENT_REPLACEMENT_PLAN.md

@@ -7,23 +7,27 @@ Replace the current ConfigMergeService and file-copying system with a cleaner, v
 ## Current System Problems
 
 ### 1. File Copying Overhead
+
 - **Issue**: 6 config files are copied TO the package directory on every `python -m crackerjack` run
 - **Files copied**: `.pre-commit-config.yaml`, `CLAUDE.md`, `RULES.md`, `.gitignore`, `example.mcp.json`, `uv.lock`
 - **Location**: `_copy_config_files_to_package()` in PhaseCoordinator (lines 251-295)
 - **Impact**: Unnecessary I/O, confusing self-referential copying for crackerjack itself
 
 ### 2. Dual Configuration Systems
+
 - **ConfigMergeService**: Automatically merges configs from package templates to project
 - **DynamicConfigGenerator**: Dynamically generates `.pre-commit-config.yaml`
 - **Problem**: Both systems can overwrite manual changes, causing conflicts
 
 ### 3. Pre-commit Cache Issues
+
 - **Location**: `~/.cache/pre-commit/`
 - **Problem**: Cached environments don't refresh when config changes
 - **Symptom**: Old hooks (like zuban) still appear even after config updates
 - **Current workaround**: Manual `pre-commit clean && pre-commit install`
 
 ### 4. Forced Automatic Updates
+
 - **Problem**: ConfigMergeService forces "smart merges" without user consent
 - **Impact**: Manual configuration changes get reverted
 - **Example**: Switching from zuban to pyright gets undone on next run
@@ -31,11 +35,12 @@ Replace the current ConfigMergeService and file-copying system with a cleaner, v
 ## Proposed Solution: Version-Based Pull Configuration System
 
 ### Core Principles
+
 1. **No file copying**: Templates stored as Python data structures
-2. **Pull-based updates**: Users explicitly request config updates
-3. **Version tracking**: Each config has a version number
-4. **Diff visibility**: Show changes before applying
-5. **Cache management**: Automatic pre-commit cache invalidation
+1. **Pull-based updates**: Users explicitly request config updates
+1. **Version tracking**: Each config has a version number
+1. **Diff visibility**: Show changes before applying
+1. **Cache management**: Automatic pre-commit cache invalidation
 
 ## Implementation Architecture
 
@@ -44,29 +49,31 @@ Replace the current ConfigMergeService and file-copying system with a cleaner, v
 ```python
 # crackerjack/services/config_template.py
 
+
 class ConfigTemplateService:
     """Version-based configuration template management."""
-    
+
     CONFIG_VERSIONS = {
         "pre-commit": "3.0.0",
         "pyproject": "1.2.0",
         "gitignore": "1.0.0",
     }
-    
+
     def get_template(self, config_type: str, version: str = None) -> dict:
         """Get config template as structured data."""
         pass
-    
+
     def check_updates(self, project_path: Path) -> dict[str, UpdateInfo]:
         """Check if newer config versions are available."""
         pass
-    
+
     def generate_diff(self, config_type: str, current: dict, new: dict) -> str:
         """Generate readable diff between configs."""
         pass
-    
-    def apply_update(self, config_type: str, project_path: Path, 
-                     interactive: bool = False) -> bool:
+
+    def apply_update(
+        self, config_type: str, project_path: Path, interactive: bool = False
+    ) -> bool:
         """Apply config update with optional interactive mode."""
         pass
 ```
@@ -89,9 +96,9 @@ PRE_COMMIT_TEMPLATE = {
                     "language": "system",
                     "files": r"\.py$",
                 }
-            ]
+            ],
         }
-    ]
+    ],
 }
 
 PYPROJECT_TEMPLATE = {
@@ -102,7 +109,7 @@ PYPROJECT_TEMPLATE = {
             "line-length": 88,
             # ... rest of config
         }
-    }
+    },
 }
 ```
 
@@ -146,15 +153,15 @@ configs:
 ```python
 class PreCommitCacheManager:
     """Manage pre-commit cache to prevent staleness."""
-    
+
     def get_config_hash(self, config_path: Path) -> str:
         """Generate hash of current config."""
         pass
-    
+
     def should_refresh_cache(self, config_path: Path) -> bool:
         """Check if cache needs refresh based on config changes."""
         pass
-    
+
     def refresh_cache(self) -> bool:
         """Run pre-commit clean and gc."""
         subprocess.run(["pre-commit", "clean"])
@@ -166,44 +173,51 @@ class PreCommitCacheManager:
 ## Migration Plan
 
 ### Phase 1: Add New System (Week 1)
+
 1. Create ConfigTemplateService
-2. Convert existing configs to template format
-3. Add version tracking
-4. Implement diff generation
-5. Add new CLI commands
+1. Convert existing configs to template format
+1. Add version tracking
+1. Implement diff generation
+1. Add new CLI commands
 
 ### Phase 2: Integration (Week 2)
+
 1. Add PreCommitCacheManager
-2. Integrate cache management with updates
-3. Add config version tracking file
-4. Update documentation
+1. Integrate cache management with updates
+1. Add config version tracking file
+1. Update documentation
 
 ### Phase 3: Deprecate Old System (Week 3)
+
 1. Mark ConfigMergeService as deprecated
-2. Remove `_copy_config_files_to_package` from PhaseCoordinator
-3. Update InitializationService to use new system
-4. Add migration warnings
+1. Remove `_copy_config_files_to_package` from PhaseCoordinator
+1. Update InitializationService to use new system
+1. Add migration warnings
 
 ### Phase 4: Remove Old System (Week 4)
+
 1. Delete ConfigMergeService
-2. Clean up all smart merge code
-3. Remove package-level config templates
-4. Final testing and validation
+1. Clean up all smart merge code
+1. Remove package-level config templates
+1. Final testing and validation
 
 ## Benefits
 
 ### For Crackerjack Project
+
 - No more self-referential file copying
 - Cleaner codebase without merge logic
 - Faster execution (no I/O for copying)
 
 ### For Other Projects Using Crackerjack
+
 - Control over when to update configs
 - See changes before applying
 - Pin configs to specific versions
 - No surprise overwrites
 
 ### For Development
+
 - Pre-commit cache properly managed
 - No more stale hook issues
 - Faster iteration cycles
@@ -220,7 +234,7 @@ class PreCommitCacheManager:
 - [ ] Implement update mechanism
 - [ ] Add interactive update mode
 - [ ] Create migration documentation
-- [ ] Remove _copy_config_files_to_package
+- [ ] Remove \_copy_config_files_to_package
 - [ ] Deprecate ConfigMergeService
 - [ ] Update InitializationService
 - [ ] Add tests for new system
@@ -229,20 +243,23 @@ class PreCommitCacheManager:
 ## Success Criteria
 
 1. **Zero file copying**: No configs copied to package directory
-2. **User control**: Updates only when explicitly requested
-3. **Version visibility**: Clear tracking of config versions
-4. **Cache freshness**: Pre-commit cache automatically managed
-5. **Backward compatibility**: Smooth migration path
+1. **User control**: Updates only when explicitly requested
+1. **Version visibility**: Clear tracking of config versions
+1. **Cache freshness**: Pre-commit cache automatically managed
+1. **Backward compatibility**: Smooth migration path
 
 ## Risk Mitigation
 
 1. **Risk**: Breaking existing projects
+
    - **Mitigation**: Gradual migration with deprecation warnings
 
-2. **Risk**: Complex diff generation
+1. **Risk**: Complex diff generation
+
    - **Mitigation**: Start with simple text diffs, enhance later
 
-3. **Risk**: User confusion
+1. **Risk**: User confusion
+
    - **Mitigation**: Clear documentation and migration guide
 
 ## Timeline
@@ -255,7 +272,7 @@ class PreCommitCacheManager:
 ## Next Steps
 
 1. Review and approve this plan
-2. Create feature branch
-3. Begin implementation with ConfigTemplateService
-4. Regular testing during development
-5. User acceptance testing before merge
+1. Create feature branch
+1. Begin implementation with ConfigTemplateService
+1. Regular testing during development
+1. User acceptance testing before merge

{crackerjack-0.33.1 → crackerjack-0.33.2}/docs/archive/CONFIG_MERGE_REMOVAL_PLAN.md

@@ -5,9 +5,9 @@
 The config merging system in crackerjack is causing configuration reversion issues:
 
 1. **ConfigMergeService** automatically syncs configs from `crackerjack/` package directory to project root
-2. **PhaseCoordinator** triggers this merge during every `python -m crackerjack` run
-3. Manual changes (like switching from zuban to pyright) get reverted every time
-4. The system was designed for project initialization but interferes with ongoing development
+1. **PhaseCoordinator** triggers this merge during every `python -m crackerjack` run
+1. Manual changes (like switching from zuban to pyright) get reverted every time
+1. The system was designed for project initialization but interferes with ongoing development
 
 ## Current Config Merge Flow
 
@@ -19,6 +19,7 @@ PhaseCoordinator._execute_configuration_steps()
 ```
 
 Files involved:
+
 - `/crackerjack/.pre-commit-config.yaml` (package template)
 - `/.pre-commit-config.yaml` (project config - gets overwritten)
 
@@ -27,57 +28,64 @@ Files involved:
 Remove the entire config merging system since:
 
 1. **It's counterproductive** - prevents manual configuration changes
-2. **It's not needed for existing projects** - only useful during initialization
-3. **It creates confusion** - users expect manual edits to persist
-4. **Alternative exists** - InitializationService can handle new project setup
+1. **It's not needed for existing projects** - only useful during initialization
+1. **It creates confusion** - users expect manual edits to persist
+1. **Alternative exists** - InitializationService can handle new project setup
 
 ## Implementation Steps
 
 ### Phase 1: Remove Config Merge Invocation
+
 - **File**: `crackerjack/core/phase_coordinator.py`
 - **Action**: Remove calls to `_handle_smart_config_merge()` and related methods
 - **Lines**: 212, 221-278, 310-315
 
 ### Phase 2: Remove Package-Level Templates
+
 - **Files to Delete**:
   - `/crackerjack/.pre-commit-config.yaml`
   - Any other config templates in package directory
 - **Rationale**: Remove the source of unwanted merging
 
 ### Phase 3: Preserve InitializationService
-- **File**: `crackerjack/services/initialization.py` 
+
+- **File**: `crackerjack/services/initialization.py`
 - **Action**: Keep as-is for `--init` functionality
 - **Rationale**: Still useful for new project setup
 
 ### Phase 4: Remove ConfigMergeService (Optional)
+
 - **Consideration**: May still be useful for `--init` command
 - **Decision**: Keep for now, remove only if unused after Phase 1-2
 
 ## Benefits
 
 1. **Manual edits persist** - Configuration changes will no longer be reverted
-2. **Cleaner workflow** - Less magic, more predictable behavior  
-3. **Reduced complexity** - Fewer moving parts in the system
-4. **User expectations met** - Configuration files behave like normal files
+1. **Cleaner workflow** - Less magic, more predictable behavior
+1. **Reduced complexity** - Fewer moving parts in the system
+1. **User expectations met** - Configuration files behave like normal files
 
 ## Risks & Mitigation
 
 1. **Risk**: Users might expect automatic config updates
+
    - **Mitigation**: Document that configs should be managed manually
-   
-2. **Risk**: New projects won't get optimal configs
+
+1. **Risk**: New projects won't get optimal configs
+
    - **Mitigation**: InitializationService still provides good defaults
-   
-3. **Risk**: Breaking change for existing workflows
+
+1. **Risk**: Breaking change for existing workflows
+
    - **Mitigation**: Most users probably don't rely on config merging
 
 ## Testing Strategy
 
 1. Remove config merge calls
-2. Test that manual edits to `.pre-commit-config.yaml` persist after running crackerjack
-3. Verify that `--init` still works for new projects
-4. Confirm no functionality is broken
+1. Test that manual edits to `.pre-commit-config.yaml` persist after running crackerjack
+1. Verify that `--init` still works for new projects
+1. Confirm no functionality is broken
 
 ## Implementation Priority
 
-**HIGH** - This is blocking the zuban → pyright transition and likely affects other manual configuration changes.
+**HIGH** - This is blocking the zuban → pyright transition and likely affects other manual configuration changes.

{crackerjack-0.33.1 → crackerjack-0.33.2}/docs/archive/DOCUMENTATION_REORGANIZATION_PLAN.md

@@ -5,18 +5,21 @@
 **Problem**: 50+ markdown files scattered across project root, docs/, tests/, and nested directories with significant duplication and poor organization.
 
 **Key Issues Identified**:
+
 - Duplicated files: `API_REFERENCE.md`, `ARCHITECTURE.md` exist in both root and docs/
 - Mixed purposes: User docs, implementation plans, and internal analysis all in root
 - Scattered security docs: Root has `SECURITY.md`, `SECURITY-AUDIT.md` + 5 files in docs/security/
-- Implementation plans cluttering root directory (12+ *_PLAN.md files)
+- Implementation plans cluttering root directory (12+ \*\_PLAN.md files)
 - No clear navigation structure for developers
 
 ## Proposed Reorganization
 
 ### Project Root - Essential User Files Only
+
 **Keep in root** (5 files):
+
 ```
-README.md           # Main project overview  
+README.md           # Main project overview
 CHANGELOG.md        # Version history
 CLAUDE.md          # Claude Code instructions
 SECURITY.md        # Security policy (consolidated)
@@ -24,11 +27,12 @@ RULES.md           # Development rules
 ```
 
 ### docs/ Directory - Organized Documentation
+
 ```
 docs/
 ├── architecture/
 │   ├── ARCHITECTURE.md     # (moved from root, deduplicated)
-│   ├── API_REFERENCE.md    # (moved from root, deduplicated)  
+│   ├── API_REFERENCE.md    # (moved from root, deduplicated)
 │   └── AGENTS.md          # (moved from root)
 ├── development/
 │   ├── IDE-SETUP.md
@@ -63,6 +67,7 @@ docs/
 ```
 
 ### tests/docs/ - Test Documentation
+
 ```
 tests/docs/
 ├── TEST_COVERAGE_PLAN.md
@@ -71,6 +76,7 @@ tests/docs/
 ```
 
 ### Keep As-Is
+
 - `crackerjack/docs/generated/` - Generated API documentation
 - `crackerjack/slash_commands/` - MCP command documentation
 - `examples/README.md` - Example documentation
@@ -79,17 +85,20 @@ tests/docs/
 ## File Actions Required
 
 ### Moves (25 files)
+
 - Root → docs/architecture/: `ARCHITECTURE.md`, `API_REFERENCE.md`, `AGENTS.md`
 - Root → docs/ai/: `AI-REFERENCE.md`
 - Root → docs/planning/: 12+ implementation and status files
 - tests/ → tests/docs/: 3 test planning files
 
 ### Consolidations (2 merges)
+
 - Merge duplicate `ARCHITECTURE.md` files (keep most current)
 - Merge duplicate `API_REFERENCE.md` files (keep most current)
 - Consolidate `SECURITY-AUDIT.md` into docs/security/
 
 ### Removals (3+ files)
+
 - Remove duplicate versions after content verification
 - Archive completed implementation plans (if any)
 - Remove obsolete analysis files (candidate: `QWEN.md`, `UVXUSAGE.md`)
@@ -97,24 +106,24 @@ tests/docs/
 ## Reference Updates Needed
 
 1. **CLAUDE.md**: Update any documentation references
-2. **README.md**: Update documentation links to new structure  
-3. **Internal docs**: Update cross-references between moved files
+1. **README.md**: Update documentation links to new structure
+1. **Internal docs**: Update cross-references between moved files
 
 ## Implementation Order
 
 1. Create new directory structure
-2. Check duplicates for content differences
-3. Move files to new locations
-4. Update cross-references
-5. Remove duplicates and obsolete files
-6. Verify all links work
+1. Check duplicates for content differences
+1. Move files to new locations
+1. Update cross-references
+1. Remove duplicates and obsolete files
+1. Verify all links work
 
 ## Expected Outcome
 
 - **Root directory**: Clean, only essential user files (5 files vs current 25+)
 - **docs/ directory**: Logical organization by purpose and audience
-- **No duplicates**: Single source of truth for each piece of documentation  
+- **No duplicates**: Single source of truth for each piece of documentation
 - **Better navigation**: Clear hierarchy for finding relevant documentation
 - **Easier maintenance**: Related docs grouped together
 
-**File count reduction**: ~50 scattered files → ~35 organized files
+**File count reduction**: ~50 scattered files → ~35 organized files

{crackerjack-0.33.1 → crackerjack-0.33.2}/fix_typing_imports.py

@@ -1,11 +1,11 @@
 #!/usr/bin/env python3
 """Fix missing 'import typing as t' in files that use 't' but don't import it."""
 
-import re
 import subprocess
-import typing as t
 from pathlib import Path
 
+from crackerjack.services.regex_patterns import SAFE_PATTERNS
+
 
 def get_files_needing_typing_import() -> list[str]:
     """Get files that use 't' but don't have the import."""
@@ -35,8 +35,8 @@ def file_needs_typing_import(file_path: str) -> bool:
         with open(file_path, encoding="utf-8") as f:
             content = f.read()
 
-        # Check if file uses t.Any, t.Dict, etc.
-        uses_t = bool(re.search(r"\bt\.[A-Z]", content))
+        # REGEX OK: Using safe pattern for typing detection
+        uses_t = SAFE_PATTERNS["detect_typing_usage"].test(content)
 
         # Check if it already has the import
         has_import = "import typing as t" in content or "from typing import" in content

{crackerjack-0.33.1 → crackerjack-0.33.2}/pyproject.toml

@@ -6,7 +6,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "crackerjack"
-version = "0.33.1"
+version = "0.33.2"
 description = "Crackerjack Python project management tool"
 readme = "README.md"
 authors = [

{crackerjack-0.33.1 → crackerjack-0.33.2}/uv.lock

@@ -398,7 +398,7 @@ wheels = [
 
 [[package]]
 name = "crackerjack"
-version = "0.33.1"
+version = "0.33.2"
 source = { editable = "." }
 dependencies = [
     { name = "aiofiles" },