cornflow-client 1.3.6__tar.gz → 1.3.7__tar.gz

{cornflow_client-1.3.6/cornflow_client.egg-info → cornflow_client-1.3.7}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cornflow-client
-Version: 1.3.6
+Version: 1.3.7
 Summary: Client to connect to a cornflow server
 Home-page: https://github.com/baobabsoluciones/cornflow
 Author: baobab soluciones

{cornflow_client-1.3.6 → cornflow_client-1.3.7}/cornflow_client/core/application.py

@@ -23,6 +23,7 @@ from cornflow_client.constants import (
     BadInstance,
     EXECUTION_FILES_STATUS_NOT_GENERATED,
 )
+
 from .experiment import ExperimentCore
 
 # Imports from internal modules
@@ -311,6 +312,7 @@ class ApplicationCore(ABC):
         # Perform data checks only if a valid solution dict was obtained
         # and the solver implements data_checks
         # Checks for non-None and non-empty dict
+        solution_has_errors = False
         if final_sol_dict:
             solution_checks, solution_has_errors = self._check_solution_errors(algo)
 

{cornflow_client-1.3.6 → cornflow_client-1.3.7}/cornflow_client/core/experiment.py

@@ -278,7 +278,6 @@ class ExperimentCore(CheckCore, ABC):
         ]:
             if data is None:
                 continue
-            data = {k: v for k, v in data.items() if len(v)}
             if not len(data):
                 continue
             default_files[f"{excel_name}.xlsx"] = to_excel_memory_file(data)

{cornflow_client-1.3.6 → cornflow_client-1.3.7}/cornflow_client/tests/unit/test_execution_files.py

@@ -5,6 +5,8 @@ import unittest
 import zipfile
 from unittest.mock import Mock, patch
 
+from openpyxl import load_workbook
+
 from cornflow_client import (
     ApplicationCore,
     CornFlow,
@@ -267,6 +269,23 @@ class TestExperimentExecutionFiles(unittest.TestCase):
         self.assertIn("checks.xlsx", names)
         self.assertIn("solution_checks.xlsx", names)
 
+    def test_get_zip_file_includes_empty_tables_as_sheets(self):
+        """
+        Validates that empty tables are kept as (empty) sheets in default exports.
+        """
+        experiment = self._experiment(output_files={})
+
+        zip_file, status = experiment._get_zip_file({}, False, {}, False)
+
+        self.assertEqual(EXECUTION_FILES_STATUS_OK, status)
+        with zipfile.ZipFile(zip_file) as zf:
+            with zf.open("solution.xlsx") as solution_file:
+                workbook = load_workbook(io.BytesIO(solution_file.read()))
+        # The solution contains "an_empty_table": [], which must still get a sheet.
+        self.assertIn("an_empty_table", workbook.sheetnames)
+        self.assertEqual(1, workbook["an_empty_table"].max_row)
+        self.assertIsNone(workbook["an_empty_table"].cell(row=1, column=1).value)
+
     def test_get_zip_file_includes_default_kpis_file(self):
         """
         Validates that KPI data is included as a default Excel export.
@@ -531,5 +550,25 @@ class TestApplicationExecutionFiles(unittest.TestCase):
         self.assertEqual(EXECUTION_FILES_STATUS_ERROR, result[4])
 
 
+    def test_validate_and_check_solution_handles_empty_solution(self):
+        """
+        Validates that a schema-valid but empty solution does not raise and reports
+        no solution errors (regression: solution_has_errors was previously unbound).
+        """
+        instance = ExecutionFilesInstance(self.instance_data)
+        # A solution whose schema validates but whose dict is falsy/empty.
+        solution = ExecutionFilesSolution({})
+        algo = ApplicationExecutionFilesSolver(instance, solution)
+
+        final_sol_dict, solution_checks, solution_has_errors, kpis = (
+            self.app._validate_and_check_solution(algo)
+        )
+
+        self.assertEqual({}, final_sol_dict)
+        self.assertFalse(solution_has_errors)
+        self.assertIsNone(solution_checks)
+        self.assertIsNone(kpis)
+
+
 if __name__ == "__main__":
     unittest.main()

{cornflow_client-1.3.6 → cornflow_client-1.3.7/cornflow_client.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cornflow-client
-Version: 1.3.6
+Version: 1.3.7
 Summary: Client to connect to a cornflow server
 Home-page: https://github.com/baobabsoluciones/cornflow
 Author: baobab soluciones

{cornflow_client-1.3.6 → cornflow_client-1.3.7}/setup.py

@@ -12,7 +12,7 @@ extra_required = {"excel": ["openpyxl", "pandas"]}
 
 setuptools.setup(
     name="cornflow-client",
-    version="1.3.6",
+    version="1.3.7",
     author="baobab soluciones",
     author_email="sistemas@baobabsoluciones.es",
     description="Client to connect to a cornflow server",