core-framework 1.3.0__tar.gz → 1.4.0__tar.gz

{core_framework-1.3.0 → core_framework-1.4.0}/.cursor/rules/constants-final.mdc

@@ -9,7 +9,7 @@ alwaysApply: false
 When introducing or editing **module-level constants** (values that are fixed for the lifetime of the module and not meant to be reassigned):
 
 - Annotate them with **`typing.Final`** and an explicit type, e.g. **`NAME: Final[int] = 42`** or **`_INTERNAL: Final[str] = "henry"`**.
-- Prefer **`FrozenSet`**, **`frozenset` literals**, **`MappingProxyType`**, or immutable collections for grouped constants when mutation must be prevented — e.g. **`USER_PREFERENCE_UPDATE_COLUMNS`** in **`core_framework/domains/user/constants.py`**.
+- Prefer **`FrozenSet`**, **`frozenset` literals**, **`MappingProxyType`**, or immutable collections for grouped constants when mutation must be prevented — e.g. **`ProfileUpdate.UPDATE_COLUMNS`** on domain update types.
 - **`Final`** is for **assignment** semantics (no rebinding): it does not freeze mutable object contents unless the type/container is immutable.
 
 Do not refactor unrelated legacy constants only to add **`Final`** unless you are already touching that symbol.

{core_framework-1.3.0 → core_framework-1.4.0}/.cursor/rules/database-triggers.md

@@ -124,30 +124,7 @@ $$ language plpgsql;
 - Error message isn't localized
 - Makes assumptions about business rules
 
-**Correct approach:**
-
-```python
-# In service layer
-async def change_profile(
-    self,
-    *,
-    actor_id: str,
-    user_id: str,
-    validated_update_request: dict[str, Any],
-) -> None:
-    if "username" in validated_update_request:
-        recent_changes = await self.repository.select_recent_username_changes(
-            user_id=user_id, since=datetime.now(timezone.utc) - timedelta(days=7)
-        )
-        if recent_changes:
-            raise UsernameCooldownException()
-
-    await self.repository.update_profile(
-        user_id=user_id,
-        validated_update_request=validated_update_request,
-        actor_id=actor_id,
-    )
-```
+**Correct approach:** enforce cooldown (or other policy) in the service, then call the repository with a typed **`ProfileUpdate`** (or the relevant `*Update`).
 
 ### ❌ Bad: Automatic State Transitions
 

{core_framework-1.3.0 → core_framework-1.4.0}/.cursor/rules/domain-input-guards.mdc

@@ -43,13 +43,14 @@ Use these across domains so validation stays consistent and call sites stay read
 | **`validate_pagination_limit(limit=...)`** | Paginated reads: `limit` in `[1, MAX_PAGE_FETCH_SIZE]` (aligned with `core_framework.core.pagination`). |
 | **`validate_pagination_offset(offset=...)`** | Paginated reads: `offset` must be **≥ 0** (aligned with `OffsetQueryParams`). |
 | **`require_positive_int(value=..., field=...)`** | **Integer** surrogate keys only (e.g. moderation `report_id`, `appeal_id`, `note_id`). Must be **≥ 1**. Domains that identify entities with **string** IDs (ULIDs) use **`require_non_blank_*`** instead—do not add this helper there. |
-| **`require_validated_update_has_allowed_fields(validated_update_request=..., allowed_fields=...)`** | PATCH-style dict updates: reject empty bodies and bodies with **no** recognized keys (use domain constants such as **`USER_*_UPDATE_FIELDS`**). |
 
 Prefer **`require_non_blank_kwargs`** / **`require_non_blank_if_not_none`** over many repeated **`require_non_blank`** lines when a method checks several fields.
 
+**PATCH partial updates:** domain `*Update` dataclasses (e.g. **`ProfileUpdate`**) expose **`require_has_updates()`** (non-empty body with at least one allowed field) and **`fields_set`** (which keys the client sent). API mappers build these from Pydantic **`model_fields_set`**; services call **`update.require_has_updates()`** before repository writes. Empty PATCH bodies remain rejected at the API via **`BasePatchRequest`**.
+
 ## Repository (thin data access; no duplicate validation)
 
-- **Call path**: API and application code must not import repositories directly (see **`domain-imports.mdc`**); they use **`{domain}_service`** from **`dependencies.py`**. So e.g. **`UserRepository.update_preferences` / `update_profile` / `update_account`** are only reached through **`UserService`**, which runs **`require_validated_update_has_allowed_fields`**—there is no supported bypass for empty or all-unknown PATCH bodies in product code.
+- **Call path**: API and application code must not import repositories directly (see **`domain-imports.mdc`**); they use **`{domain}_service`** from **`dependencies.py`**. PATCH flows reach **`UserRepository.update_*`** (and post/comment equivalents) only through **`UserService.change_*`**, which runs **`require_has_updates()`** on the typed update—there is no supported bypass for empty or all-unknown PATCH bodies in product code.
 - **Prefer no input-validation guards** in repositories (empty batches, non-blank strings, pagination limits, positive int IDs): the **domain service** owns those contracts. The repository runs SQL; **`WHERE … = any($1)`** with an empty array is valid in Postgres and returns no rows.
 - Only add a repository guard for **SQL-specific** hazards that are awkward to express as service policy (rare); **do not** duplicate service-level “skip if empty” logic.
 - **Do not** use the repository as the **main** home for product rules that belong in the service.

{core_framework-1.3.0 → core_framework-1.4.0}/.dockerignore

@@ -25,9 +25,8 @@ htmlcov/
 *.swo
 *~
 
-# Documentation
-README.md
-*.md
+# Documentation (wheel build needs root README.md; skip large doc tree)
+docs/
 
 # CI/CD
 .github/

{core_framework-1.3.0 → core_framework-1.4.0}/.github/workflows/_deploy.yml

@@ -39,8 +39,8 @@ jobs:
           REDIS_HOST: ${{ secrets.REDIS_HOST }}
           REDIS_PORT: ${{ secrets.REDIS_PORT }}
           ALLOWED_HOSTS: ${{ secrets.ALLOWED_HOSTS }}
-          AVATAR_BASE_URL: ${{ secrets.AVATAR_BASE_URL }}
-          AVATAR_DEFAULT_URL: ${{ secrets.AVATAR_DEFAULT_URL }}
+          AVATAR_HOST_DOMAIN: ${{ secrets.AVATAR_HOST_DOMAIN }}
+          AVATAR_DEFAULT_IMAGE: ${{ secrets.AVATAR_DEFAULT_IMAGE }}
           BANNER_BASE_URL: ${{ secrets.BANNER_BASE_URL }}
           BANNER_DEFAULT_URL: ${{ secrets.BANNER_DEFAULT_URL }}
           LOGFIRE_TOKEN: ${{ secrets.LOGFIRE_TOKEN }}

{core_framework-1.3.0 → core_framework-1.4.0}/CHANGELOG.md

@@ -4,6 +4,35 @@ Notable changes to **core-framework** (import **`core_framework`**). Format foll
 
 ## [Unreleased]
 
+## [1.4.0] - 2026-05-19
+
+### Changed
+
+- **Breaking:** **`avatar`** on profile and related user responses is an object (**`size_128`**, **`size_500`**, **`fallback`**) instead of a single URL string. See **`docs/flows/users/avatar.md`**.
+- **Breaking:** **`[avatar]`** config uses **`avatar_host_domain`** + **`default_avatar_image`** (deploy env **`AVATAR_HOST_DOMAIN`**, **`AVATAR_DEFAULT_IMAGE`**) instead of **`base_url`** / **`default_url`**.
+- **Typed PATCH payloads** — user (preferences, account, profile + admin profile), post, and comment PATCH routes map Pydantic requests to domain `*Update` types at the API boundary; no `model_dump(mode="json")` or dict partial-update payloads through application/domain/repository. See `docs/patch-update-typed-payload.md` and `docs/conventions.md` (*PATCH partial updates*).
+- Self-service profile PATCH invalidates **`USER_DETAIL`** only when **`display_name`** or **`avatar_id`** change (fields present in cached identity). **`profile_visibility`** is coerced to **`ProfileVisibility`** on repository read.
+
+### Added
+
+- Optional **`date_of_birth`** on user profiles: calendar date (`YYYY-MM-DD`), not in the future, omit unchanged / **`null`** clears. Exposed on **`GET`** / **`PATCH /users/me/profile`** and on admin user detail plus **`PATCH /admin/users/{user_id}/profile`**. Not returned on other users’ public surfaces (follow lists, post author cards, etc.).
+
+### Database
+
+- User domain migration **`user_add_date_of_birth`**: nullable **`date_of_birth`** column on **`user_profiles`**. Run **`uv run cf-alembic`** (or your host migration step) before deploying application code that reads or writes the field.
+
+### Documentation
+
+- **`docs/flows/users/avatar.md`**: multi-size **`avatar`** response shape and CDN URL convention.
+- **`docs/flows/media/upload_pipeline.md`**: upload pipeline design (implementation pending).
+- **`docs/flows/users/profile.md`**: DOB on get/update flows and validation errors.
+- **`docs/flows/users/change_history.md`**: profile **`date_of_birth`** changes are not written to change history (audit trigger unchanged).
+- **`docs/patch-update-typed-payload.md`**: typed PATCH decisions and patterns for partial-update endpoints.
+
+### Fixed
+
+- **Dockerfile**: include **`README.md`** in the build context so hatchling can resolve the package readme.
+
 ## [1.3.0] - 2026-05-16
 
 ### Added
@@ -140,4 +169,5 @@ First **SemVer-stable** release per **`docs/package-api.md`**.
 [1.1.1]: https://github.com/NepNepFFXIV/core-framework/compare/v1.1.0...v1.1.1
 [1.2.0]: https://github.com/NepNepFFXIV/core-framework/compare/v1.1.1...v1.2.0
 [1.3.0]: https://github.com/NepNepFFXIV/core-framework/compare/v1.2.0...v1.3.0
-[unreleased]: https://github.com/NepNepFFXIV/core-framework/compare/v1.3.0...HEAD
+[1.4.0]: https://github.com/NepNepFFXIV/core-framework/compare/v1.3.0...v1.4.0
+[unreleased]: https://github.com/NepNepFFXIV/core-framework/compare/v1.4.0...HEAD

{core_framework-1.3.0 → core_framework-1.4.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: core-framework
-Version: 1.3.0
+Version: 1.4.0
 Summary: Core framework package (import as core_framework)
 Project-URL: Homepage, https://github.com/NepNepFFXIV/core-framework
 Project-URL: Repository, https://github.com/NepNepFFXIV/core-framework

core_framework-1.4.0/alembic/user/alembic/versions/user_add_date_of_birth_to_profiles.py

@@ -0,0 +1,27 @@
+"""add optional date_of_birth to user_profiles
+
+Revision ID: user_add_date_of_birth
+Revises: v1_user_init
+Create Date: 2026-05-18 12:00:00.000000
+
+"""
+
+from collections.abc import Sequence
+
+from alembic import op
+
+revision: str = "user_add_date_of_birth"
+down_revision: str | Sequence[str] | None = "v1_user_init"
+branch_labels: str | Sequence[str] | None = None
+depends_on: str | Sequence[str] | None = None
+
+
+def upgrade() -> None:
+    op.execute("""
+        alter table user_profiles
+            add column date_of_birth date;
+    """)
+
+
+def downgrade() -> None:
+    pass

{core_framework-1.3.0 → core_framework-1.4.0}/config.toml

@@ -11,8 +11,8 @@ allowed_hosts = [
 secret_key = "local-dev-secret-key-change-in-production"
 
 [avatar]
-base_url = "https://avatar.core-framework.com"
-default_url = "https://avatar.core-framework.com/default.webp"
+avatar_host_domain = "https://avatar.core-framework.com"
+default_avatar_image = "default.webp"
 
 [banner]
 base_url = "https://banner.core-framework.com"

{core_framework-1.3.0 → core_framework-1.4.0}/config.toml.template

@@ -7,8 +7,8 @@ allowed_hosts = $ALLOWED_HOSTS
 secret_key = "$SECRET_KEY"
 
 [avatar]
-base_url = "$AVATAR_BASE_URL"
-default_url = "$AVATAR_DEFAULT_URL"
+avatar_host_domain = "$AVATAR_HOST_DOMAIN"
+default_avatar_image = "$AVATAR_DEFAULT_IMAGE"
 
 [banner]
 base_url = "$BANNER_BASE_URL"

{core_framework-1.3.0 → core_framework-1.4.0}/core_framework/api/admin/users/router.py

@@ -16,6 +16,7 @@ from core_framework.api.admin.users.schemas import (
     validate_note_id,
 )
 from core_framework.api.dependencies import RequiredUserID
+from core_framework.api.users.mappers import profile_update_from_request
 from core_framework.api.users.shared.schemas import validate_user_id
 from core_framework.application.users.admin_service import (
     add_user_note,
@@ -104,11 +105,10 @@ async def patch_user_profile(
     request_body: AdminProfileUpdateRequest,
 ) -> None:
     validated_target_user_id = validate_user_id(user_id=target_user_id)
-    validated_update_request = request_body.model_dump(mode="json", exclude_unset=True)
     await change_user_profile(
         actor_id=actor_id.root,
         target_user_id=validated_target_user_id.root,
-        validated_update_request=validated_update_request,
+        update=profile_update_from_request(request=request_body),
     )
 
 

{core_framework-1.3.0 → core_framework-1.4.0}/core_framework/api/admin/users/schemas.py

@@ -10,6 +10,7 @@ from core_framework.api.users.shared.schemas import (
     AvatarMixin,
     BannerMixin,
     Bio,
+    DateOfBirth,
     DisplayName,
     UserID,
     Username,
@@ -68,17 +69,18 @@ class AdminAccountResponse(BaseModel):
     user_id: UserID
     username: str
     role: UserRole
-    email: str | None = None
+    email: str | None
     email_verified: bool
-    deletion_scheduled_for: datetime | None = None
+    deletion_scheduled_for: datetime | None
 
 
 class AdminProfileResponse(AvatarMixin, BannerMixin):
-    display_name: DisplayName | None = None
-    bio: Bio | None = None
-    status: UserStatus | None = None
+    display_name: DisplayName | None
+    bio: Bio | None
+    status: UserStatus | None
     social_links: Annotated[dict[str, str], Field(default_factory=dict)]
     profile_visibility: ProfileVisibility
+    date_of_birth: DateOfBirth | None
 
 
 class UserDetailResponse(BaseModel):
@@ -108,6 +110,7 @@ class AdminProfileUpdateRequest(BasePatchRequest):
     status: UserStatus | None = None
     social_links: dict[str, str] | None = None
     profile_visibility: ProfileVisibility | None = None
+    date_of_birth: DateOfBirth | None = None
 
 
 class UserChangeHistoryItem(BaseModel):

core_framework-1.4.0/core_framework/api/comments/authenticated/mappers.py

@@ -0,0 +1,10 @@
+from core_framework.api.comments.authenticated.schemas import UpdateCommentRequest
+from core_framework.domains.comment import CommentUpdate
+
+
+def comment_update_from_request(*, request: UpdateCommentRequest) -> CommentUpdate:
+    fields_set = frozenset(request.model_fields_set)
+    return CommentUpdate(
+        fields_set=fields_set,
+        content=request.content.root if "content" in fields_set and request.content is not None else None,
+    )

{core_framework-1.3.0 → core_framework-1.4.0}/core_framework/api/comments/authenticated/router.py

@@ -1,6 +1,7 @@
 from fastapi import APIRouter, BackgroundTasks, Depends, status
 from ulid import ULID
 
+from core_framework.api.comments.authenticated.mappers import comment_update_from_request
 from core_framework.api.comments.authenticated.schemas import (
     CommentReportRequest,
     CreateCommentRequest,
@@ -86,11 +87,10 @@ async def patch_comment(
     user_id: RequiredUserID,
     request_body: UpdateCommentRequest,
 ) -> None:
-    validated_update_request = request_body.model_dump(mode="json", exclude_unset=True)
     await edit_comment(
         comment_id=str(comment_id),
         author_id=user_id.root,
-        validated_update_request=validated_update_request,
+        update=comment_update_from_request(request=request_body),
     )
 
 

core_framework-1.4.0/core_framework/api/posts/authenticated/mappers.py

@@ -0,0 +1,14 @@
+from core_framework.api.posts.authenticated.schemas import UpdatePostRequest
+from core_framework.domains.post import PostUpdate
+
+
+def post_update_from_request(*, request: UpdatePostRequest) -> PostUpdate:
+    fields_set = frozenset(request.model_fields_set)
+    return PostUpdate(
+        fields_set=fields_set,
+        content=request.content.root if "content" in fields_set and request.content is not None else None,
+        visibility=request.visibility if "visibility" in fields_set else None,
+        hashtags=(None if request.hashtags is None else [hashtag.root for hashtag in request.hashtags])
+        if "hashtags" in fields_set
+        else None,
+    )

{core_framework-1.3.0 → core_framework-1.4.0}/core_framework/api/posts/authenticated/router.py

@@ -2,6 +2,7 @@ from fastapi import APIRouter, BackgroundTasks, Depends, status
 from ulid import ULID
 
 from core_framework.api.dependencies import RequiredUserID, check_not_banned
+from core_framework.api.posts.authenticated.mappers import post_update_from_request
 from core_framework.api.posts.authenticated.schemas import CreatePostRequest, PostReportRequest, UpdatePostRequest
 from core_framework.application.posts.aggregation_service import mark_post_stats_dirty
 from core_framework.application.posts.authenticated_service import (
@@ -34,11 +35,10 @@ async def post_post(user_id: RequiredUserID, request_body: CreatePostRequest) ->
 
 @router.patch("/{post_id}", status_code=status.HTTP_204_NO_CONTENT)
 async def patch_post(post_id: ULID, user_id: RequiredUserID, request_body: UpdatePostRequest) -> None:
-    validated_update_request = request_body.model_dump(mode="json", exclude_unset=True)
     await edit_post(
         post_id=str(post_id),
         author_id=user_id.root,
-        validated_update_request=validated_update_request,
+        update=post_update_from_request(request=request_body),
     )
 
 

core_framework-1.4.0/core_framework/api/users/authenticated/mappers.py

@@ -0,0 +1,21 @@
+from core_framework.api.users.authenticated.schemas import AccountUpdateRequest, PreferencesUpdateRequest
+from core_framework.domains.user import AccountUpdate, PreferencesUpdate
+
+
+def preferences_update_from_request(*, request: PreferencesUpdateRequest) -> PreferencesUpdate:
+    fields_set = frozenset(request.model_fields_set)
+    return PreferencesUpdate(
+        fields_set=fields_set,
+        theme=request.theme if "theme" in fields_set else None,
+        language=request.language if "language" in fields_set else None,
+    )
+
+
+def account_update_from_request(*, request: AccountUpdateRequest) -> AccountUpdate:
+    fields_set = frozenset(request.model_fields_set)
+    return AccountUpdate(
+        fields_set=fields_set,
+        username=(request.username.root if request.username is not None else None)
+        if "username" in fields_set
+        else None,
+    )

{core_framework-1.3.0 → core_framework-1.4.0}/core_framework/api/users/authenticated/router.py

@@ -5,6 +5,10 @@ from fastapi import APIRouter, BackgroundTasks, Depends, Query, Request, status
 from core_framework.api.comments.public.schemas import CommentResponse
 from core_framework.api.dependencies import RequiredFirebaseUser, RequiredUserID, check_not_banned
 from core_framework.api.posts.public.schemas import PostResponse
+from core_framework.api.users.authenticated.mappers import (
+    account_update_from_request,
+    preferences_update_from_request,
+)
 from core_framework.api.users.authenticated.schemas import (
     AccountResponse,
     AccountUpdateRequest,
@@ -18,6 +22,7 @@ from core_framework.api.users.authenticated.schemas import (
     ProfileUpdateRequest,
     UserReportRequest,
 )
+from core_framework.api.users.mappers import profile_update_from_request
 from core_framework.api.users.shared.schemas import UsernameSuggestQuery, UserReference, validate_user_id
 from core_framework.application.comments.public_service import retrieve_my_comments
 from core_framework.application.posts.public_service import retrieve_my_posts
@@ -209,8 +214,10 @@ async def get_my_preferences(user_id: RequiredUserID) -> Any:
     dependencies=[Depends(check_not_banned)],
 )
 async def patch_my_preferences(user_id: RequiredUserID, update_request: PreferencesUpdateRequest) -> Any:
-    validated_update_request = update_request.model_dump(mode="json", exclude_unset=True)
-    return await change_my_preferences(user_id=user_id.root, validated_update_request=validated_update_request)
+    return await change_my_preferences(
+        user_id=user_id.root,
+        update=preferences_update_from_request(request=update_request),
+    )
 
 
 @router.get(
@@ -228,8 +235,10 @@ async def get_my_profile(user_id: RequiredUserID) -> Any:
     dependencies=[Depends(check_not_banned)],
 )
 async def patch_my_profile(user_id: RequiredUserID, update_request: ProfileUpdateRequest) -> Any:
-    validated_update_request = update_request.model_dump(mode="json", exclude_unset=True)
-    return await change_my_profile(user_id=user_id.root, validated_update_request=validated_update_request)
+    return await change_my_profile(
+        user_id=user_id.root,
+        update=profile_update_from_request(request=update_request),
+    )
 
 
 @router.get(
@@ -254,8 +263,10 @@ async def patch_my_account(
     firebase_user: RequiredFirebaseUser,
     update_request: AccountUpdateRequest,
 ) -> Any:
-    validated_update_request = update_request.model_dump(mode="json", exclude_unset=True)
-    await change_my_account(user_id=firebase_user.user_id.root, validated_update_request=validated_update_request)
+    await change_my_account(
+        user_id=firebase_user.user_id.root,
+        update=account_update_from_request(request=update_request),
+    )
     return await retrieve_my_account(
         user_id=firebase_user.user_id.root,
         email=firebase_user.email,

{core_framework-1.3.0 → core_framework-1.4.0}/core_framework/api/users/authenticated/schemas.py

@@ -9,6 +9,7 @@ from core_framework.api.users.shared.schemas import (
     AvatarMixin,
     BannerMixin,
     Bio,
+    DateOfBirth,
     DisplayName,
     UserID,
     Username,
@@ -37,6 +38,7 @@ class ProfileResponse(AvatarMixin, BannerMixin):
     status: UserStatus | None
     social_links: dict[str, str]
     profile_visibility: ProfileVisibility
+    date_of_birth: DateOfBirth | None
 
 
 class AccountResponse(BaseModel):
@@ -58,6 +60,7 @@ class ProfileUpdateRequest(BasePatchRequest):
     status: UserStatus | None = None
     social_links: dict[str, str] | None = None
     profile_visibility: ProfileVisibility | None = None
+    date_of_birth: DateOfBirth | None = None
 
 
 class UserReportRequest(BaseModel):

core_framework-1.4.0/core_framework/api/users/mappers.py

@@ -0,0 +1,77 @@
+from datetime import date
+
+from ulid import ULID
+
+from core_framework.api.admin.users.schemas import AdminProfileUpdateRequest
+from core_framework.api.users.authenticated.schemas import ProfileUpdateRequest
+from core_framework.domains.user import ProfileUpdate
+
+ProfilePatchRequest = ProfileUpdateRequest | AdminProfileUpdateRequest
+
+
+def profile_update_from_request(*, request: ProfilePatchRequest) -> ProfileUpdate:
+    fields_set = frozenset(request.model_fields_set)
+    return ProfileUpdate(
+        fields_set=fields_set,
+        display_name=_display_name_from_request(request=request, fields_set=fields_set),
+        avatar_id=_ulid_string_from_request(
+            value=request.avatar_id,
+            field="avatar_id",
+            fields_set=fields_set,
+        ),
+        banner_id=_ulid_string_from_request(
+            value=request.banner_id,
+            field="banner_id",
+            fields_set=fields_set,
+        ),
+        bio=_bio_from_request(request=request, fields_set=fields_set),
+        status=_status_from_request(request=request, fields_set=fields_set),
+        social_links=request.social_links if "social_links" in fields_set else None,
+        profile_visibility=request.profile_visibility if "profile_visibility" in fields_set else None,
+        date_of_birth=_date_of_birth_from_request(request=request, fields_set=fields_set),
+    )
+
+
+def _display_name_from_request(*, request: ProfilePatchRequest, fields_set: frozenset[str]) -> str | None:
+    if "display_name" not in fields_set:
+        return None
+    if request.display_name is None:
+        return None
+    return request.display_name.root
+
+
+def _bio_from_request(*, request: ProfilePatchRequest, fields_set: frozenset[str]) -> str | None:
+    if "bio" not in fields_set:
+        return None
+    if request.bio is None:
+        return None
+    return request.bio.root
+
+
+def _status_from_request(*, request: ProfilePatchRequest, fields_set: frozenset[str]) -> str | None:
+    if "status" not in fields_set:
+        return None
+    if request.status is None:
+        return None
+    return request.status.root
+
+
+def _date_of_birth_from_request(*, request: ProfilePatchRequest, fields_set: frozenset[str]) -> date | None:
+    if "date_of_birth" not in fields_set:
+        return None
+    if request.date_of_birth is None:
+        return None
+    return request.date_of_birth.root
+
+
+def _ulid_string_from_request(
+    *,
+    value: ULID | None,
+    field: str,
+    fields_set: frozenset[str],
+) -> str | None:
+    if field not in fields_set:
+        return None
+    if value is None:
+        return None
+    return str(value)

{core_framework-1.3.0 → core_framework-1.4.0}/core_framework/api/users/shared/schemas.py

@@ -1,3 +1,4 @@
+from datetime import date
 from typing import Annotated
 
 from fastapi.exceptions import RequestValidationError
@@ -75,6 +76,12 @@ def _get_user_media_urls() -> dict[str, str]:
     raise RuntimeError(msg)
 
 
+class AvatarUrls(BaseModel):
+    size_128: HttpUrl
+    size_500: HttpUrl
+    fallback: HttpUrl
+
+
 class UserID(RootModel[str]):
     model_config = ConfigDict(frozen=True)
     root: Annotated[
@@ -140,14 +147,28 @@ class DisplayName(RootModel[str]):
     ]
 
 
+class DateOfBirth(RootModel[date]):
+    model_config = ConfigDict(frozen=True)
+    root: Annotated[
+        date,
+        Field(description="User date of birth (calendar date)"),
+    ]
+
+    @field_validator("root", mode="after")
+    @classmethod
+    def not_future(cls, v: date) -> date:
+        if v > date.today():
+            raise ValueError("date_of_birth cannot be in the future")
+        return v
+
+
 class AvatarMixin(BaseModel):
     avatar_id: Annotated[str | None, Field(exclude=True)]
 
     @computed_field
     @property
-    def avatar(self) -> HttpUrl:
-        url_string = _construct_avatar_url(avatar_id=self.avatar_id)
-        return _http_url_adapter.validate_python(url_string)
+    def avatar(self) -> AvatarUrls:
+        return _construct_avatar_urls(avatar_id=self.avatar_id)
 
 
 class BannerMixin(BaseModel):
@@ -179,11 +200,19 @@ def validate_optional_user_id(*, user_id: str | None) -> UserID | None:
     return validate_user_id(user_id=user_id)
 
 
-def _construct_avatar_url(*, avatar_id: str | None) -> str:
+def _construct_avatar_urls(*, avatar_id: str | None) -> AvatarUrls:
     media_urls = _get_user_media_urls()
+    fallback = media_urls["avatar_default_url"]
+    base = media_urls["avatar_base_url"]
+    ext = media_urls["avatar_extension"]
     if avatar_id is None:
-        return media_urls["avatar_default_url"]
-    return f"{media_urls['avatar_base_url']}/{avatar_id}.{media_urls['avatar_extension']}"
+        fb = _http_url_adapter.validate_python(fallback)
+        return AvatarUrls(size_128=fb, size_500=fb, fallback=fb)
+    return AvatarUrls(
+        size_128=_http_url_adapter.validate_python(f"{base}/128/{avatar_id}.{ext}"),
+        size_500=_http_url_adapter.validate_python(f"{base}/500/{avatar_id}.{ext}"),
+        fallback=_http_url_adapter.validate_python(fallback),
+    )
 
 
 def _construct_banner_url(*, banner_id: str | None) -> str:

{core_framework-1.3.0 → core_framework-1.4.0}/core_framework/application/comments/authenticated_service.py

@@ -1,11 +1,9 @@
-from typing import Any
-
 import core_framework.application.notifications.notification_service as notification_service
 import core_framework.domains.comment.dependencies as comment_deps
 import core_framework.domains.moderation.dependencies as moderation_deps
 from core_framework.application.comments import aggregation_service as comment_aggregation_service
 from core_framework.application.posts import aggregation_service as post_aggregation_service
-from core_framework.domains.comment import CommentStatsImpact, CommentSubjectType
+from core_framework.domains.comment import CommentStatsImpact, CommentSubjectType, CommentUpdate
 from core_framework.domains.moderation import ReportCategory
 
 
@@ -63,13 +61,9 @@ async def edit_comment(
     *,
     comment_id: str,
     author_id: str,
-    validated_update_request: dict[str, Any],
+    update: CommentUpdate,
 ) -> None:
-    await comment_deps.comment_service.edit_comment(
-        comment_id=comment_id,
-        author_id=author_id,
-        validated_update_request=validated_update_request,
-    )
+    await comment_deps.comment_service.edit_comment(comment_id=comment_id, author_id=author_id, update=update)
 
 
 async def like_comment(*, comment_id: str, user_id: str) -> bool:

{core_framework-1.3.0 → core_framework-1.4.0}/core_framework/application/posts/authenticated_service.py

@@ -1,10 +1,8 @@
-from typing import Any
-
 import core_framework.application.notifications.notification_service as notification_service
 import core_framework.domains.moderation.dependencies as moderation_deps
 import core_framework.domains.post.dependencies as post_deps
 from core_framework.domains.moderation import ReportCategory
-from core_framework.domains.post import PostStatus, PostVisibility
+from core_framework.domains.post import PostStatus, PostUpdate, PostVisibility
 
 
 async def create_post(
@@ -33,13 +31,9 @@ async def edit_post(
     *,
     post_id: str,
     author_id: str,
-    validated_update_request: dict[str, Any],
+    update: PostUpdate,
 ) -> None:
-    await post_deps.post_service.edit_post(
-        post_id=post_id,
-        author_id=author_id,
-        validated_update_request=validated_update_request,
-    )
+    await post_deps.post_service.edit_post(post_id=post_id, author_id=author_id, update=update)
 
 
 async def delete_post(*, post_id: str, author_id: str) -> None: