contact-person-profile-csv-imp-local 0.0.49__tar.gz → 0.0.51__tar.gz

{contact_person_profile_csv_imp_local-0.0.49 → contact_person_profile_csv_imp_local-0.0.51}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: contact-person-profile-csv-imp-local
-Version: 0.0.49
+Version: 0.0.51
 Summary: PyPI Package for Circles CSVToContactPersonProfile-local Local/Remote Python
 Home-page: https://github.com/circles-zone/contact-person-profile-csv-imp-local-python-package
 Author: Circles

{contact_person_profile_csv_imp_local-0.0.49 → contact_person_profile_csv_imp_local-0.0.51}/contact_person_profile_csv_imp_local/src/CSVToContactPersonProfile.py

@@ -51,12 +51,12 @@ DEFAULT_PROFILE_ID = 0
 # Those methods should be called from the common method for this repo (contact-person-profile-csv-imp-local-python-package and google-contact-sync ...)
 
 # TODO def process_first_name( original_first_name: str) -> str: (move to people-local-python-package)
-#     normilized_first_name = the first word in original_first_name
-#     GroupsLocal.add_update_group_and_link_to_contact( normilized_first_name, is_group=true, contact_id) # When checking if exists, ignore the upper-case lower-case
-#     return normilized_first_name
+#     normalized_first_name = the first word in original_first_name
+#     GroupsLocal.add_update_group_and_link_to_contact( normalized_first_name, is_group=true, contact_id) # When checking if exists, ignore the upper-case lower-case
+#     return normalized_first_name
 
 # TODO def process_last_name( original_last_name : str) -> str: (move to people-local-python-package)
-#     normilized_last_name = Remove all the digits from the last_name
+#     normalized_last_name = Remove all the digits from the last name
 #     GroupsLocal.add_update_group_and_link_to_contact( normilized_last_name, is_group=true, contact_id) # When checking if exists, ignore the upper-case lower-case
 
 # TODO def process_phone( original_phone_number: str) -> str: (move to phone-local-python-package)
@@ -75,7 +75,7 @@ DEFAULT_PROFILE_ID = 0
 #     normalized_organization_name = GroupsLocal.add_update_group_and_link_to_contact( organization_name, is_organization=true) # When checking if the organization exists, remove suffix such as Ltd, Inc, בעמ... when searching ignore the uppper-case lower-case
 
 # TODO def process_department( department_name: str) -> str: (move to people-local-python-package
-#     normalized_department_name = GroupsLocal.add_update_group_and_link_to_contact( department_name, is_department=true) # When searching ignore the upper-case lower-case, return the value with is_main == true
+#     normalized_department_name = GroupsLocal.add_update_group_and_link_to_contact( department_name, is_department=true) # When searching, ignore the upper-case lower-case, return the value with is_main == true
 
 # TODO def process_continent( continent_name: str) -> str: (move to location-local-python-package)
 #     continent_id, normalized_continent_name = GroupsLocal.add_update_group_and_link_to_contact( continent_name, is_continent=true) # When checking if exists, ignore the upper-case lower-case, return the value with is_main == true
@@ -124,10 +124,8 @@ class CSVToContactPersonProfile(
                                 'contact_location', 'user_externals_local',
                                 'organizations_local', 'domain_local',
                                 'importers_local']
-        GenericCRUD.__init__(self, default_schema_name="field",
-                             default_column_name="field_id",
-                             default_table_name="field_table",
-                             default_view_table_name="field_view",
+        GenericCRUD.__init__(self, default_schema_name="profile",
+                             default_view_table_name="profile_view",
                              is_test_data=is_test_data)
         self.contact_entity_type_id = \
             self.select_one_value_by_column_and_value(
@@ -173,32 +171,11 @@ class CSVToContactPersonProfile(
         # Otherwise, return the value
         return value
 
-    # # TODO Does this function should be here on in https://github.com/circles-zone/variable-local-python-package/tree/dev/variable_local_python_package/variable_local/src "field/field.py"?
-    # def __get_field_name(self, field_id: int, data_source_type_id: int) -> str:
-    #     """
-    #     Get the field name from the database
-    #     :param field_id: The field ID
-    #     :param data_source_type_id: The data source ID
-    #     :return: The field name
-    #     """
-    #
-    #                  'data_source_type_id': data_source_type_id})
-
-    #     self.set_schema(schema_name="data_source_field")
-    #     data_source_field_tuples = self.select_multi_tuple_by_where(view_table_name="data_source_field_view",
-    #                                             select_clause_value="external_field_name",
-    #                                             where="data_source_type_id = %s AND field_id = %s",
-    #                                             params=(data_source_type_id, field_id))
-
-    #     if data_source_field_tuples:
-    #
-    #         return data_source_field_tuples[0][0]
-    #     return
-
-    # TODO what are the diff between csv_path and directory_name?
+
+    # What are the diff between csv_path and directory_name?
     # ans: csv_path is the full path to the csv file, directory_name is the directory where the csv file is located
 
-    # TODO I think file name should be after directory_name and csv_path
+    # I think file name should be after directory_name and csv_path
     # ans: it cannot be after directory_name and csv_path because it is a required parameter
 
     # TODO: break this function into smaller functions
@@ -227,7 +204,7 @@ class CSVToContactPersonProfile(
         :return:
         """
         data_source_type_name = DataSources().get_data_source_name_by_id(data_source_type_id)
-        # TODO There can be multiple profiles with the same email, why not to query `user_external_table`.`main_profile_id`?
+        # There can be multiple profiles with the same email, why not to query `user_external_table`.`main_profile_id`?
         # Answer: first, We can't query tables with GenericCRUD, second, we may not find profile_id in user_external table
         # and may have to insert a new record to user_external_table, in this case we need profile_id from profile_view
         profile_id = self.select_one_value_by_column_and_value(
@@ -243,7 +220,6 @@ class CSVToContactPersonProfile(
             self.logger.error("Couldn't find profile_id in profile_view by email_address.")
             raise Exception("Couldn't find profile_id in user_external or profile_view.")
         system_id = system_id or CONTACT_PERSON_PROFILE_CSV_SYSTEM_ID
-        self.set_schema(schema_name="field")
         self.list_of_group_dicts = list_of_group_dicts if list_of_group_dicts else []
         '''
         profile_id = ProfilesLocal().select_one_value_by_column_and_value(
@@ -252,10 +228,9 @@ class CSVToContactPersonProfile(
             column_value=user_external_username)
         '''
         self.logger.info(f"profile_id: {profile_id}")
-        # TODO Please explain
         # if csv_path is provided then we will use the full path
         # if csv_path is not provided then we will use the directory_name and file_name to create the full path
-        # if directory_name is not provided the assumption is that the file is in the same directory as the script and not in a folder
+        # If directory_name is not provided, the assumption is that the file is in the same directory as the script and not in a folder
         if csv_path is not None:
             csv_file_path = csv_path
         else:
@@ -274,7 +249,7 @@ class CSVToContactPersonProfile(
 
         user_external_id = self.__get_user_external_id(user_external_username=user_external_username,
                                                        profile_id=profile_id, system_id=system_id)
-        # We create a new data_source_instance_id everytime we import a new csv file
+        # We create a new data_source_instance_id every time we import a new csv file
         data_source_instance_id = self.__get_data_source_instance_id(
             data_source_type_id=data_source_type_id, csv_file_path=csv_file_path,
             user_external_id=user_external_id, file_name=file_name,
@@ -346,6 +321,7 @@ class CSVToContactPersonProfile(
                 # contact_dict['last_name'] = process_last_name(
                 #     original_last_name=contact_dict['last_name'])
 
+
                 # TODO This should be executed also by Google Contact Sync (please make sure it is in
                 #  people-local-python-package i.e. get_display_name(first_name, last_name, organization) -> str
                 if contact_dict.get('display_as') is None:
@@ -356,7 +332,6 @@ class CSVToContactPersonProfile(
                         contact_dict['display_as'] += " " + contact_dict['last_name']
                     if not contact_dict['display_as'] and contact_dict.get('organization'):
                         contact_dict['display_as'] += " " + contact_dict['organization']
-
                     # TODO if contact_dict['display_as'] still empty raise?
 
                 # TODO process_notes( contact_dict[notes] )
@@ -379,8 +354,6 @@ class CSVToContactPersonProfile(
                         data_source_type_id=data_source_type_id)
                     contact_data_by_contact_id_dict[contact_id] = contact_dict
                 # groups_linked_by_job_title = process_job_title(contact_id=contact_id, job_title=contact_dict['job_title'])
-                # if groups_linked_by_job_title is None:
-                #     logger.info("No groups linked by job title to contact " + str(contact_id))
 
         return contact_data_by_contact_id_dict
 
@@ -618,7 +591,9 @@ class CSVToContactPersonProfile(
         return linked_groups_results_list
 
     def __insert_link_contact_persons(self, contact_dict: dict) -> dict:
+        # TODO create and use mandatory_fields_to_link_contact_to_person_array
         if not contact_dict.get("first_name") and not contact_dict.get("last_name"):
+            # TODO logger.warning("Can't connect contact_id= contact.display_as= contact.organization to a person as we don't have first and last name
             return {}
         phones_local = PhonesLocal(is_test_data=self.is_test_data)
         contact_phone_number = contact_dict.get("phone1")
@@ -637,7 +612,7 @@ class CSVToContactPersonProfile(
 
         return contact_person_results_dict
 
-    # TODO This method is confusing me as based on the name I was expected to to have two parameters
+    # TODO This method is confusing me, as based on the name, I was expecting to have two parameters
     # contact_dict and email_addresses but we are sending profile_id, please explain or fix
     def __insert_link_contact_email_addresses(self, contact_dict: dict) -> list[int]:
         email_addresses = self.contacts_local.get_contact_email_addresses_from_contact_dict(
@@ -676,24 +651,6 @@ class CSVToContactPersonProfile(
 
         return contact_phone_ids
 
-    # old, TODO, do we need it?
-    def __insert_link_contact_user_external(self, contact_dict: dict) -> int:
-        contact_id = contact_dict.get("contact_id")
-        print("Before " + __name__, file=sys.stderr, flush=True)
-        contact_user_external_id = \
-            self.contact_user_external.insert_contact_and_link_to_existing_or_new_user_external(
-                contact_dict=contact_dict,
-                contact_email_address_str=contact_dict["email1"],
-                contact_id=contact_id,
-                system_id=contact_dict.get("system_id"),
-                # TODO What happends if contact do not have email?
-                # TODO I'm not sure we should use contact_dict["email1"] for user_external_dict["username"] probably bug
-                user_external_dict={"username": contact_dict["email1"]}
-            )
-        print("After " + __name__, file=sys.stderr, flush=True)
-        return contact_user_external_id
-
-    # new
     def __insert_link_contact_user_external_by_contact_dict_and_user_external_dict(
             self,
             contact_dict: dict,
@@ -767,7 +724,7 @@ class CSVToContactPersonProfile(
     # TODO merge this method with the method in google-contact-sync
     def __insert_importer(self, contact_id: int, location_id: int, user_external_id: int,
                           data_source_type_id: int, data_source_instance_id: int) -> int:
-        # TODO: Shall we consider the url of csv's as the following? Use Sql2Code. Use const enum
+        # TODO: Shall we consider the url of CSVs as the following? Use Sql2Code. Use const enum
         if data_source_type_id == CSVToContactPersonProfileConstants.GOOGLE_CSV_DATA_SOURCE_TYPE_ID:
             url = "www.google.com"
         elif data_source_type_id == CSVToContactPersonProfileConstants.OUTLOOK_CSV_DATA_SOURCE_TYPE_ID:
@@ -792,10 +749,10 @@ class CSVToContactPersonProfile(
 
         return importer_id
 
-    # TODO Move this method to ContactsLocal if not exists already
+    # TODO Move this method to ContactsLocal if not already exist
     def __procces_location_of_contact(self, contact_dict: dict) -> dict or None:
         """
-        Process location of Google contact
+        Process the location of the Google contact
         :param contact_dict: location_dict
         :return: location_dict
         """
@@ -824,6 +781,7 @@ class CSVToContactPersonProfile(
                 and not email_addresses_list):
             return
         # TODO: How can we add location type?
+        # TODO Rename to processed_location_dicts
         proccessed_location_dicts = []
         if is_contact_location1:
             location_dict = self.__create_location_dict(
@@ -989,6 +947,7 @@ class CSVToContactPersonProfile(
     @staticmethod
     # TODO Move this function to python-sdk
     def detect_encoding(file_path: str, data_source_type_id: int = None):
+        # TODO Do not use hard-coded values, get it from the data_source_type repo/package
         if data_source_type_id in [16, 17, 18]:
             detect_encodinfg_result = "utf-8"
         else:

{contact_person_profile_csv_imp_local-0.0.49 → contact_person_profile_csv_imp_local-0.0.51}/contact_person_profile_csv_imp_local/src/contact_person_profile_csv_imp_local_constants.py

@@ -20,6 +20,7 @@ class CSVToContactPersonProfileConstants:
         'developer_email': DEVELOPER_EMAIL
     }
 
+    # TODO search for the source_type_id in the database and remove those constants
     GOOGLE_CSV_DATA_SOURCE_TYPE_ID = 16
     LINKEDIN_CSV_DATA_SOURCE_TYPE_ID = 18
     OUTLOOK_CSV_DATA_SOURCE_TYPE_ID = 17

{contact_person_profile_csv_imp_local-0.0.49 → contact_person_profile_csv_imp_local-0.0.51}/contact_person_profile_csv_imp_local.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: contact-person-profile-csv-imp-local
-Version: 0.0.49
+Version: 0.0.51
 Summary: PyPI Package for Circles CSVToContactPersonProfile-local Local/Remote Python
 Home-page: https://github.com/circles-zone/contact-person-profile-csv-imp-local-python-package
 Author: Circles

{contact_person_profile_csv_imp_local-0.0.49 → contact_person_profile_csv_imp_local-0.0.51}/setup.py

@@ -5,7 +5,7 @@ package_dir = PACKAGE_NAME.replace("-", "_")
 
 setuptools.setup(
     name=PACKAGE_NAME,
-    version='0.0.49',  # https://pypi.org/project/contact-person-profile-csv-imp-local/
+    version='0.0.51',  # https://pypi.org/project/contact-person-profile-csv-imp-local/
 
     author="Circles",
     author_email="info@circles.ai",