conson-xp 2.0.2__tar.gz → 2.0.3__tar.gz

{conson_xp-2.0.2 → conson_xp-2.0.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: conson-xp
-Version: 2.0.2
+Version: 2.0.3
 Summary: XP Protocol Communication Tools
 Author-Email: ldvchosal <ldvchosal@github.com>
 License: MIT License

{conson_xp-2.0.2 → conson_xp-2.0.3}/pyproject.toml

@@ -22,7 +22,7 @@ dependencies = [
 ]
 requires-python = ">=3.11"
 readme = "README.md"
-version = "2.0.2"
+version = "2.0.3"
 
 [project.license]
 file = "LICENSE"

{conson_xp-2.0.2 → conson_xp-2.0.3}/src/xp/__init__.py

@@ -4,7 +4,7 @@ XP CLI tool for remote console bus operations.
 conson-xp package.
 """
 
-__version__ = "2.0.2"
+__version__ = "2.0.3"
 __manufacturer__ = "salchichon"
 __model__ = "xp.cli"
 __serial__ = "2025.09.23.000"

{conson_xp-2.0.2 → conson_xp-2.0.3}/src/xp/services/term/homekit_accessory_driver.py

@@ -10,9 +10,18 @@ from pyhap.const import CATEGORY_LIGHTBULB, CATEGORY_OUTLET
 
 from xp.models.homekit.homekit_config import HomekitConfig
 
+# Callback type: (accessory_name, is_on, brightness_or_none)
+OnSetCallback = Callable[[str, bool, Optional[int]], None]
+
 
 class XPAccessory(Accessory):
-    """Single accessory wrapping a Conbus output."""
+    """
+    Single accessory wrapping a Conbus output.
+
+    Attributes:
+        logger: Logger instance for this accessory.
+        current_brightness: Current brightness value 0-100.
+    """
 
     def __init__(
         self,
@@ -35,12 +44,19 @@ class XPAccessory(Accessory):
         super().__init__(driver._driver, display_name, aid=aid)
         self._hk_driver = driver
         self._accessory_id = name
+        self._is_dimmable = service_type == "dimminglight"
+        self._char_brightness: Optional[object] = None
+        self._current_brightness: int = 100
         self.logger = logging.getLogger(__name__)
 
-        if service_type == "dimminglight":
+        if self._is_dimmable:
             self.category = CATEGORY_LIGHTBULB
             serv = self.add_preload_service("Lightbulb", chars=["On", "Brightness"])
-            # Note: Brightness setter_callback deferred to future update
+            self._char_brightness = serv.configure_char(
+                "Brightness",
+                setter_callback=self._set_brightness,
+                value=self._current_brightness,
+            )
         elif service_type == "outlet":
             self.category = CATEGORY_OUTLET
             serv = self.add_preload_service("Outlet")
@@ -58,16 +74,36 @@ class XPAccessory(Accessory):
             value: True for on, False for off.
         """
         if self._hk_driver._on_set:
-            self._hk_driver._on_set(self._accessory_id, value)
+            self._hk_driver._on_set(self._accessory_id, value, None)
+
+    def _set_brightness(self, value: int) -> None:
+        """
+        Handle HomeKit set brightness request.
+
+        Args:
+            value: Brightness value 0-100.
+        """
+        if self._hk_driver._on_set:
+            self._hk_driver._on_set(self._accessory_id, True, value)
+        self._current_brightness = value
 
-    def update_state(self, is_on: bool) -> None:
+    def update_state(self, is_on: bool, brightness: Optional[int] = None) -> None:
         """
         Update accessory state from Conbus event.
 
         Args:
             is_on: True if accessory is on, False otherwise.
+            brightness: Optional brightness value 0-100.
         """
         self._char_on.set_value(is_on)
+        if brightness is not None and self._char_brightness:
+            self._char_brightness.set_value(brightness)  # type: ignore[attr-defined]
+            self._current_brightness = brightness
+
+    @property
+    def current_brightness(self) -> int:
+        """Get current brightness value."""
+        return self._current_brightness
 
 
 class HomekitAccessoryDriver:
@@ -84,14 +120,15 @@ class HomekitAccessoryDriver:
         self._homekit_config = homekit_config
         self._driver: Optional[AccessoryDriver] = None
         self._accessories: Dict[str, XPAccessory] = {}
-        self._on_set: Optional[Callable[[str, bool], None]] = None
+        self._on_set: Optional[OnSetCallback] = None
 
-    def set_callback(self, on_set: Callable[[str, bool], None]) -> None:
+    def set_callback(self, on_set: OnSetCallback) -> None:
         """
         Set callback for HomeKit set events.
 
         Args:
-            on_set: Callback(accessory_name, is_on) called when HomeKit app toggles.
+            on_set: Callback(accessory_name, is_on, brightness) called when HomeKit app changes state.
+                    brightness is None for on/off only, or 0-100 for dimming.
         """
         self._on_set = on_set
 
@@ -157,15 +194,34 @@ class HomekitAccessoryDriver:
         except Exception as e:
             self.logger.error(f"Error stopping AccessoryDriver: {e}", exc_info=True)
 
-    def update_state(self, accessory_name: str, is_on: bool) -> None:
+    def update_state(
+        self, accessory_name: str, is_on: bool, brightness: Optional[int] = None
+    ) -> None:
         """
         Update accessory state from Conbus event.
 
         Args:
             accessory_name: Accessory name to update.
             is_on: True if accessory is on, False otherwise.
+            brightness: Optional brightness value 0-100.
         """
-        if acc := self._accessories.get(accessory_name):
-            acc.update_state(is_on)
+        acc = self._accessories.get(accessory_name)
+        if acc:
+            acc.update_state(is_on, brightness)
         else:
             self.logger.warning(f"Unknown accessory name: {accessory_name}")
+
+    def get_brightness(self, accessory_name: str) -> int:
+        """
+        Get current brightness for an accessory.
+
+        Args:
+            accessory_name: Accessory name.
+
+        Returns:
+            Current brightness 0-100, defaults to 100 if not found.
+        """
+        acc = self._accessories.get(accessory_name)
+        if acc:
+            return acc.current_brightness
+        return 100

{conson_xp-2.0.2 → conson_xp-2.0.3}/src/xp/services/term/homekit_service.py

@@ -300,23 +300,82 @@ class HomekitService:
         await self._accessory_driver.stop()
         self.cleanup()
 
-    def _on_homekit_set(self, accessory_name: str, is_on: bool) -> None:
+    def _on_homekit_set(
+        self, accessory_name: str, is_on: bool, brightness: Optional[int]
+    ) -> None:
         """
-        Handle HomeKit app toggle request.
+        Handle HomeKit app set request (on/off or brightness).
 
         Args:
             accessory_name: Accessory name from HomeKit.
             is_on: True for on, False for off.
+            brightness: Brightness value 0-100, or None for on/off only.
         """
         config = self._find_accessory_config(accessory_name)
-        if config:
+        if not config:
+            self.logger.warning(f"No config found for accessory: {accessory_name}")
+            return
+
+        if brightness is not None:
+            # Handle brightness change
+            self._handle_brightness_change(accessory_name, config, brightness)
+        else:
+            # Handle on/off toggle
             action = config.on_action if is_on else config.off_action
             self.send_action(action)
             self.on_status_message.emit(
                 f"HomeKit: {accessory_name} {'ON' if is_on else 'OFF'}"
             )
+
+    def _handle_brightness_change(
+        self,
+        accessory_name: str,
+        config: "HomekitAccessoryConfig",
+        target_brightness: int,
+    ) -> None:
+        """
+        Handle brightness change by sending dimup/dimdown actions.
+
+        Calculates delta from current brightness and sends appropriate
+        number of LEVELINC or LEVELDEC commands (step = 10%).
+
+        Args:
+            accessory_name: Accessory name.
+            config: Accessory configuration.
+            target_brightness: Target brightness 0-100.
+        """
+        current = self._accessory_driver.get_brightness(accessory_name)
+        delta = target_brightness - current
+
+        if delta == 0:
+            return
+
+        # Determine action and steps (10% per step)
+        step_size = 10
+        steps = abs(delta) // step_size
+
+        if delta > 0:
+            # Increase brightness
+            if not config.dimup_action:
+                self.logger.warning(f"No dimup_action for {accessory_name}")
+                return
+            action = config.dimup_action
+            direction = "+"
         else:
-            self.logger.warning(f"No config found for accessory: {accessory_name}")
+            # Decrease brightness
+            if not config.dimdown_action:
+                self.logger.warning(f"No dimdown_action for {accessory_name}")
+                return
+            action = config.dimdown_action
+            direction = "-"
+
+        # Send action for each step
+        for _ in range(steps):
+            self.send_action(action)
+
+        self.on_status_message.emit(
+            f"HomeKit: {accessory_name} {current}% → {target_brightness}% ({direction}{steps * step_size}%)"
+        )
 
     def send_action(self, action: str) -> None:
         """