conexus 6.3.7__tar.gz → 6.3.8__tar.gz

{conexus-6.3.7 → conexus-6.3.8}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: conexus
-Version: 6.3.7
+Version: 6.3.8
 Summary: Self-hosted semantic search and knowledge management for LLM-driven development
 Project-URL: Homepage, https://github.com/Hellblazer/nexus
 Project-URL: Repository, https://github.com/Hellblazer/nexus

{conexus-6.3.7 → conexus-6.3.8}/mcpb/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "conexus-mcpb"
-version = "6.3.7"
+version = "6.3.8"
 description = "Conexus packaged as Claude Desktop .mcpb (Desktop Extension)"
 requires-python = ">=3.12"
 dependencies = [
@@ -10,7 +10,7 @@ dependencies = [
     # while collections are indexed at 768/1024-dim, so every T3 search hits a
     # dimension mismatch and returns zero results. The .mcpb cannot run the
     # interactive `nx init` embedder choice, so it must pin [local] explicitly.
-    "conexus[local]>=6.3.7",
+    "conexus[local]>=6.3.8",
 ]
 
 [tool.uv]

{conexus-6.3.7 → conexus-6.3.8}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "conexus"
-version = "6.3.7"
+version = "6.3.8"
 description = "Self-hosted semantic search and knowledge management for LLM-driven development"
 readme = { file = "README.md", content-type = "text/markdown" }
 requires-python = ">=3.12,<3.14"

{conexus-6.3.7 → conexus-6.3.8}/src/nexus/commands/guided_upgrade_cmd.py

@@ -34,6 +34,7 @@ this wiring.
 from __future__ import annotations
 
 import os
+from pathlib import Path
 from urllib.parse import urlparse, urlsplit
 
 import click
@@ -119,13 +120,31 @@ def guided_upgrade_cmd(
     """Stand up the service stack and migrate Chroma → pgvector in one command."""
     # 1. PRE-FLIGHT — is there anything to migrate? A fresh user no-ops here,
     #    WITHOUT provisioning a service for an empty footprint.
+    #
+    #    nexus-ltix8 (GH #1381): the no-op requires BOTH legs clean. The
+    #    Chroma probe alone answers "any vectors to move?" — it says nothing
+    #    about the T2 SQLite stores (memory/catalog/plans/...), which the
+    #    RDR-152 default flip strands on an unprovisioned service backend if
+    #    this command no-ops. A present T2 SQLite file means an existing
+    #    install: proceed (the T3 ETL leg no-ops naturally over an empty
+    #    footprint; `_run_migration` ships T2 unconditionally).
+    from nexus.commands.migrate_cmd import _resolve_db_path  # noqa: PLC0415  — command-local import (nexus.commands.migrate_cmd)
+
     pre = detect_pending_migration(local_path=local_path)
+    t2_sqlite = Path(_resolve_db_path(db_path))
     if not pre.needs_migration:
+        if not t2_sqlite.exists():
+            click.echo(
+                "No pre-RDR-160 Chroma footprint and no local T2 SQLite "
+                "store detected — nothing to migrate; you are already on "
+                "the service stack."
+            )
+            return
         click.echo(
-            "No pre-RDR-160 Chroma footprint detected — nothing to migrate; "
-            "you are already on the service stack."
+            "No Chroma vector footprint to migrate, but a local T2 SQLite "
+            f"store exists ({t2_sqlite}) — proceeding with the T2 "
+            "migration leg."
         )
-        return
 
     # 1a. ALREADY-MIGRATED DETECTION (RDR-178 Gap 7, nexus-1sx01) — cheap,
     #     local-only: consults the newest <config>/migration-reports/
@@ -135,11 +154,24 @@ def guided_upgrade_cmd(
     #     reporting data present — the migrate-leg already-migrated detection
     #     is nexus-s3dd4, Wave 2, and out of scope here); it only spares the
     #     T2 stores this pre-flight can positively confirm are covered.
-    from nexus.commands.migrate_cmd import _resolve_db_path  # noqa: PLC0415  — command-local import (nexus.commands.migrate_cmd)
-
     already = detect_already_migrated(
-        sqlite_path=_resolve_db_path(db_path), force=force,
+        sqlite_path=t2_sqlite, force=force,
     )
+    # nexus-ltix8 (critique M3): a FULLY-covered install reaches a clean no-op
+    # here instead of re-prompting/re-provisioning forever. Ordinary service-
+    # mode operation leaves a memory.db on disk (the mcp_infra degraded-write
+    # backstop), so "T2 file exists" alone must not mean "work to do" once
+    # every evaluated store is covered by a clean report with no newer local
+    # writes. Chroma-footprint-present still proceeds (the T3 leg has no
+    # already-migrated detection yet — nexus-s3dd4); --force bypasses via
+    # detect_already_migrated marking every store run.
+    if not pre.needs_migration and already.all_skipped:
+        click.echo(
+            "\nEvery T2 store is already covered by a clean migration report "
+            "with no newer local writes, and there is no Chroma footprint to "
+            "move — nothing to do. (--force re-migrates unconditionally.)"
+        )
+        return
     if already.skip_stores:
         click.echo(
             f"\nT2 stores: {len(already.skip_stores)} of "
@@ -149,11 +181,12 @@ def guided_upgrade_cmd(
         for line in already.summary_lines():
             click.echo(f"  {line}")
 
-    click.echo(
-        f"\nDetected {pre.data_bearing_count} data-bearing Chroma collection(s) "
-        f"to migrate ({pre.classified_unsupported_count} classified unsupported "
-        "— legacy-model collections are auto-remapped, not blocked)."
-    )
+    if pre.needs_migration:
+        click.echo(
+            f"\nDetected {pre.data_bearing_count} data-bearing Chroma collection(s) "
+            f"to migrate ({pre.classified_unsupported_count} classified unsupported "
+            "— legacy-model collections are auto-remapped, not blocked)."
+        )
     if not assume_yes and not click.confirm(
         "Provision the service stack and migrate now?"
     ):
@@ -311,6 +344,17 @@ def guided_upgrade_cmd(
                 os.environ[_var] = _prev
 
     # 4. ADVISORY post-step — verify the migrated stack end-to-end.
+    # GH #1381: users surviving the pre-fix gate bug on the sqlite opt-out
+    # would otherwise complete the migration and silently keep reading the
+    # OLD local SQLite via the still-exported env var.
+    if os.environ.get("NX_STORAGE_BACKEND", "").strip().lower() == "sqlite":
+        click.echo("")
+        click.echo(
+            "NOTE: NX_STORAGE_BACKEND=sqlite is set in your environment — "
+            "your T2 reads will keep routing to the OLD local SQLite until "
+            "you unset it (remove it from your shell profile, then restart "
+            "your shell/session)."
+        )
     click.echo("")
     click.echo("Advisory: verify the migrated stack:")
     click.echo("  nx doctor")

{conexus-6.3.7 → conexus-6.3.8}/src/nexus/commands/storage_cmd.py

@@ -1343,9 +1343,11 @@ def migrate_vectors_cmd(
     collections = [c.strip() for c in collections_csv.split(",") if c.strip()] or None
 
     if local_path is None:
-        from nexus.config import nexus_config_dir  # noqa: PLC0415 — circular-dep avoidance: deferred intra-package import
+        from nexus.migration.detection import resolve_default_local_leg  # noqa: PLC0415 — circular-dep avoidance: deferred intra-package import
 
-        local_path = nexus_config_dir() / "chroma"
+        # nexus-id750 (GH #1381): resolve the product's env-aware local-Chroma
+        # default; <config>/chroma was never a write location.
+        local_path = resolve_default_local_leg()
 
     from nexus.migration.vector_etl import (  # noqa: PLC0415 — circular-dep avoidance: deferred intra-package import
         migrate_cloud,

{conexus-6.3.7 → conexus-6.3.8}/src/nexus/migration/chroma_read.py

@@ -38,7 +38,7 @@ from nexus.db.chroma_quotas import QUOTAS
 _log = structlog.get_logger(__name__)
 
 
-def open_local_read_client(local_path: str | Path) -> Any:
+def open_local_read_client(local_path: str | Path | None = None) -> Any:
     """Open the LOCAL read leg: a ``chromadb.PersistentClient`` on *local_path*.
 
     The on-disk store the retired T3 daemon used to serve. The caller owns
@@ -46,12 +46,25 @@ def open_local_read_client(local_path: str | Path) -> Any:
     PersistentClients open the same store concurrently, so the ETL must be
     the only opener (the serving path no longer opens it — that is the
     point of Phase 4a).
+
+    A ``None`` *local_path* resolves via
+    :func:`nexus.migration.detection.resolve_default_local_leg` — the
+    product's own env-aware local-Chroma default (nexus-id750, GH #1381).
+    This is the DEEP chokepoint of the default: pre-fix, a bare
+    ``nx guided-upgrade`` threaded an un-defaulted ``None`` from the CLI all
+    the way down to this constructor, crashing on ``Path(None)`` at the ETL
+    copy step — AFTER provisioning a service (critique CRITICAL).
     """
+    if local_path is None:
+        from nexus.migration.detection import resolve_default_local_leg  # noqa: PLC0415 — circular-dep avoidance (detection imports this module deferred)
+
+        local_path = resolve_default_local_leg()
     p = Path(local_path)
     if not p.is_dir():
         raise FileNotFoundError(
             f"local Chroma store not found at {p} — nothing to migrate, or the "
-            "path is wrong (default: ~/.config/nexus/chroma)"
+            "path is wrong (default: $NX_LOCAL_CHROMA_PATH -> "
+            "$XDG_DATA_HOME/nexus/chroma -> ~/.local/share/nexus/chroma)"
         )
     import chromadb  # noqa: PLC0415  — optional/heavy dependency deferred (chromadb)
 

{conexus-6.3.7 → conexus-6.3.8}/src/nexus/migration/detection.py

@@ -340,25 +340,55 @@ def voyage_key_available() -> bool:
     return bool(get_credential("voyage_api_key").strip())
 
 
+def resolve_default_local_leg() -> Path:
+    """Resolve the default local-Chroma path for the migration read leg.
+
+    nexus-id750 (GH #1381): this detector historically defaulted to
+    ``<config>/chroma`` (``~/.config/nexus/chroma``) — a directory the
+    PRODUCT has never written local Chroma to. The real store has always
+    lived at :func:`nexus.config._default_local_path`
+    (``NX_LOCAL_CHROMA_PATH`` → ``$XDG_DATA_HOME/nexus/chroma`` →
+    ``~/.local/share/nexus/chroma``; identical as far back as v5.4.5). So a
+    bare ``nx guided-upgrade`` opened an empty directory, saw no footprint,
+    and no-opped with "you are already on the service stack" while the
+    user's real vectors sat at the XDG path.
+
+    Resolution: the product path wins when it exists; the old config-dir
+    location is retained as a secondary probe (defensive — nothing is known
+    to write there, but any manually-placed data should not become invisible
+    the other way); when neither exists, return the product path so the
+    fresh-user no-op message points at the honest default.
+    """
+    from nexus.config import _default_local_path, nexus_config_dir  # noqa: PLC0415 — circular-dep avoidance (nexus.config)
+
+    product = _default_local_path()
+    if product.exists():
+        return product
+    legacy = nexus_config_dir() / "chroma"
+    if legacy.exists():
+        return legacy
+    return product
+
+
 def open_read_legs(
     local_path: str | Path | None = None,
 ) -> tuple[Any | None, Any | None]:
     """Open whichever Chroma read legs are present, returning ``(local, cloud)``.
 
-    A missing local store (default ``~/.config/nexus/chroma``) or an
+    A missing local store (default: :func:`resolve_default_local_leg` — the
+    product's own env-aware local-Chroma path, nexus-id750) or an
     unconfigured cloud leg yields ``None`` for that leg — a fresh user with
     neither leg gets ``(None, None)``, which :func:`classify_collections`
     treats as a clean no-op. Only the "absent leg" sentinels
     (``FileNotFoundError`` / the cloud half-configured ``RuntimeError``) are
     swallowed; any other failure (a corrupt store) propagates loud.
     """
-    from nexus.config import nexus_config_dir  # noqa: PLC0415 — circular-dep avoidance (nexus.config)
     from nexus.migration.chroma_read import (  # noqa: PLC0415 — circular-dep avoidance (nexus.migration.chroma_read)
         open_cloud_read_client,
         open_local_read_client,
     )
 
-    path = Path(local_path) if local_path else nexus_config_dir() / "chroma"
+    path = Path(local_path) if local_path else resolve_default_local_leg()
     local: Any | None
     try:
         local = open_local_read_client(path)

{conexus-6.3.7 → conexus-6.3.8}/src/nexus/migration/driver.py

@@ -121,10 +121,10 @@ def _default_reopen_leg(leg: str, local_path: str | Path | None) -> Any:
 
     if leg == "cloud":
         return open_cloud_read_client()
-    from nexus.config import nexus_config_dir  # noqa: PLC0415  — command-local import (nexus.config)
-
-    path = Path(local_path) if local_path else nexus_config_dir() / "chroma"
-    return open_local_read_client(path)
+    # nexus-id750: a None local_path resolves via the product's env-aware
+    # default inside open_local_read_client (this fallback used to hardcode
+    # the never-written <config>/chroma).
+    return open_local_read_client(local_path)
 
 
 def run_guided_upgrade(