comfy-env 0.1.22__tar.gz → 0.1.24__tar.gz

{comfy_env-0.1.22 → comfy_env-0.1.24}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: comfy-env
-Version: 0.1.22
+Version: 0.1.24
 Summary: Environment management for ComfyUI custom nodes - CUDA wheel resolution and process isolation
 Project-URL: Homepage, https://github.com/PozzettiAndrea/comfy-env
 Project-URL: Repository, https://github.com/PozzettiAndrea/comfy-env

{comfy_env-0.1.22 → comfy_env-0.1.24}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "comfy-env"
-version = "0.1.22"
+version = "0.1.24"
 description = "Environment management for ComfyUI custom nodes - CUDA wheel resolution and process isolation"
 readme = "README.md"
 license = {text = "MIT"}

{comfy_env-0.1.22 → comfy_env-0.1.24}/src/comfy_env/install.py

@@ -59,7 +59,9 @@ def _install_apt_packages(packages: List[str], log: Callable[[str], None], dry_r
         return
     log(f"\n[apt] Installing: {', '.join(packages)}")
     if not dry_run:
-        apt_install(packages, log)
+        success = apt_install(packages, log)
+        if not success:
+            log("[apt] WARNING: Some apt packages failed to install. This may cause issues.")
 
 
 def _set_persistent_env_vars(env_vars: dict, log: Callable[[str], None], dry_run: bool) -> None:

comfy_env-0.1.24/src/comfy_env/packages/apt.py

@@ -0,0 +1,74 @@
+"""APT package installation (Linux only)."""
+
+import subprocess
+import sys
+from typing import Callable, List
+
+
+def apt_install(packages: List[str], log: Callable[[str], None] = print) -> bool:
+    """Install system packages via apt-get. No-op on non-Linux."""
+    if not packages or sys.platform != "linux":
+        return True
+
+    log(f"[apt] Requested packages: {packages}")
+
+    # Check which packages are missing
+    missing = check_apt_packages(packages)
+    if not missing:
+        log("[apt] All packages already installed")
+        return True
+
+    log(f"[apt] Missing packages: {missing}")
+
+    # Run apt-get update with full output
+    log("[apt] Running: sudo apt-get update")
+    update_result = subprocess.run(
+        ["sudo", "apt-get", "update"],
+        capture_output=True, text=True
+    )
+    if update_result.returncode != 0:
+        log(f"[apt] WARNING: apt-get update failed (exit {update_result.returncode})")
+        log(f"[apt] stderr: {update_result.stderr}")
+    else:
+        log("[apt] apt-get update succeeded")
+
+    # Install packages ONE BY ONE so one failure doesn't block others
+    installed = []
+    failed = []
+    for pkg in missing:
+        log(f"[apt] Installing: {pkg}")
+        result = subprocess.run(
+            ["sudo", "apt-get", "install", "-y", pkg],
+            capture_output=True, text=True
+        )
+        if result.returncode != 0:
+            log(f"[apt] FAILED: {pkg} - {result.stderr.strip()}")
+            failed.append(pkg)
+        else:
+            log(f"[apt] OK: {pkg}")
+            installed.append(pkg)
+
+    # Summary
+    if installed:
+        log(f"[apt] Successfully installed: {installed}")
+    if failed:
+        log(f"[apt] Failed to install: {failed}")
+
+    # Verify what's actually installed now
+    still_missing = check_apt_packages(packages)
+    if still_missing:
+        log(f"[apt] WARNING: These packages are not available: {still_missing}")
+
+    # Return True if we installed at least something (partial success is OK)
+    return len(installed) > 0 or len(missing) == len(failed)
+
+
+def check_apt_packages(packages: List[str]) -> List[str]:
+    """Return list of packages NOT installed."""
+    if sys.platform != "linux":
+        return []
+
+    return [
+        pkg for pkg in packages
+        if subprocess.run(["dpkg", "-s", pkg], capture_output=True).returncode != 0
+    ]

comfy_env-0.1.22/src/comfy_env/packages/apt.py

@@ -1,36 +0,0 @@
-"""APT package installation (Linux only)."""
-
-import subprocess
-import sys
-from typing import Callable, List
-
-
-def apt_install(packages: List[str], log: Callable[[str], None] = print) -> bool:
-    """Install system packages via apt-get. No-op on non-Linux."""
-    if not packages or sys.platform != "linux":
-        return True
-
-    log(f"Installing apt packages: {packages}")
-
-    subprocess.run(["sudo", "apt-get", "update"], capture_output=True, text=True)
-
-    result = subprocess.run(
-        ["sudo", "apt-get", "install", "-y"] + packages,
-        capture_output=True, text=True
-    )
-    if result.returncode != 0:
-        log(f"Warning: apt-get install failed: {result.stderr[:200]}")
-        return False
-
-    return True
-
-
-def check_apt_packages(packages: List[str]) -> List[str]:
-    """Return list of packages NOT installed."""
-    if sys.platform != "linux":
-        return []
-
-    return [
-        pkg for pkg in packages
-        if subprocess.run(["dpkg", "-s", pkg], capture_output=True).returncode != 0
-    ]