cognite-neat 0.123.17__tar.gz → 0.123.18__tar.gz

{cognite_neat-0.123.17 → cognite_neat-0.123.18}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cognite-neat
-Version: 0.123.17
+Version: 0.123.18
 Summary: Knowledge graph transformation
 Project-URL: Documentation, https://cognite-neat.readthedocs-hosted.com/
 Project-URL: Homepage, https://cognite-neat.readthedocs-hosted.com/

cognite_neat-0.123.18/cognite/neat/_version.py

@@ -0,0 +1,2 @@
+__version__ = "0.123.18"
+__engine__ = "^2.0.4"

{cognite_neat-0.123.17 → cognite_neat-0.123.18}/cognite/neat/core/_data_model/models/conceptual/_validation.py

@@ -13,6 +13,7 @@ from cognite.neat.core._issues.errors._resources import (
 )
 from cognite.neat.core._issues.warnings._models import (
     ConceptOnlyDataModelWarning,
+    ConversionToPhysicalModelImpossibleWarning,
     DanglingPropertyWarning,
     UndefinedConceptWarning,
 )
@@ -61,9 +62,30 @@ class ConceptualValidation:
 
         self._concept_only_data_model()
         self._regex_compliance_with_physical_data_model()
+        self._physical_data_model_conversion()
 
         return self.issue_list
 
+    def _physical_data_model_conversion(self) -> None:
+        """Check if the conceptual data model has issues that will likely lead
+        to problems when converting to a physical data model."""
+        warning_types_preventing_conversion = [
+            ConceptOnlyDataModelWarning,
+            ResourceRegexViolationWarning,
+            ResourceNotDefinedWarning,
+            UndefinedConceptWarning,
+            DanglingPropertyWarning,
+        ]
+
+        if seen_warnings := frozenset(
+            [
+                warning_type.__name__
+                for warning_type in warning_types_preventing_conversion
+                if self.issue_list.has_warning_type(warning_type)
+            ]
+        ):
+            self.issue_list.append_if_not_exist(ConversionToPhysicalModelImpossibleWarning(issue_types=seen_warnings))
+
     def _concept_only_data_model(self) -> None:
         """Check if the data model only consists of concepts without any properties."""
         if not self._properties:

{cognite_neat-0.123.17 → cognite_neat-0.123.18}/cognite/neat/core/_issues/warnings/__init__.py

@@ -23,6 +23,7 @@ from ._general import (
 from ._models import (
     BreakingModelingPrincipleWarning,
     CDFNotSupportedWarning,
+    ConversionToPhysicalModelImpossibleWarning,
     NotSupportedHasDataFilterLimitWarning,
     NotSupportedViewContainerLimitWarning,
     PrincipleMatchingSpaceAndVersionWarning,
@@ -58,6 +59,7 @@ __all__ = [
     "CDFAuthWarning",
     "CDFMaxIterationsWarning",
     "CDFNotSupportedWarning",
+    "ConversionToPhysicalModelImpossibleWarning",
     "DeprecatedWarning",
     "FileItemNotSupportedWarning",
     "FileMissingRequiredFieldWarning",

{cognite_neat-0.123.17 → cognite_neat-0.123.18}/cognite/neat/core/_issues/warnings/_models.py

@@ -109,6 +109,14 @@ class ConceptOnlyDataModelWarning(UserModelingWarning):
     fix = "Define properties for concepts or make sure that concepts implement other concepts that have properties."
 
 
+@dataclass(unsafe_hash=True)
+class ConversionToPhysicalModelImpossibleWarning(UserModelingWarning):
+    """Conceptual data model has {issue_types} that will lead to problems when converting to a physical data model."""
+
+    fix = "Fix the issues in the conceptual data model before attempting to convert it to a physical data model."
+    issue_types: frozenset[str]
+
+
 @dataclass(unsafe_hash=True)
 class DanglingPropertyWarning(UserModelingWarning):
     """Property {property_id} is not defined for any concept.

{cognite_neat-0.123.17 → cognite_neat-0.123.18}/cognite/neat/session/_base.py

@@ -173,6 +173,7 @@ class NeatSession:
             "Convert to physical",
             has_physical_data_model=False,
             has_conceptual_data_model=True,
+            can_convert_to_physical_data_model=True,
         )
         converter = ConceptualToPhysical(reserved_properties=reserved_properties, client=self._state.client)
 

{cognite_neat-0.123.17 → cognite_neat-0.123.18}/cognite/neat/session/_state.py

@@ -6,11 +6,13 @@ from rdflib import URIRef
 from cognite.neat.core._client import NeatClient
 from cognite.neat.core._data_model.importers import BaseImporter, InferenceImporter
 from cognite.neat.core._data_model.models import ConceptualDataModel, PhysicalDataModel
+from cognite.neat.core._data_model.models.conceptual._validation import ConceptualValidation
 from cognite.neat.core._data_model.transformers import (
     VerifiedDataModelTransformer,
 )
 from cognite.neat.core._instances.extractors import KnowledgeGraphExtractor
 from cognite.neat.core._issues import IssueList
+from cognite.neat.core._issues.warnings._models import ConversionToPhysicalModelImpossibleWarning
 from cognite.neat.core._store import NeatDataModelStore, NeatInstanceStore
 from cognite.neat.core._utils.upload import UploadResultList
 
@@ -72,6 +74,7 @@ class SessionState:
         instances_required: bool = False,
         client_required: bool = False,
         has_conceptual_data_model: bool | None = None,
+        can_convert_to_physical_data_model: bool = False,
         has_physical_data_model: bool | None = None,
     ) -> None:
         """Set conditions for raising an error in the session that are used by various methods in the session."""
@@ -84,6 +87,17 @@ class SessionState:
         if has_conceptual_data_model is True and self.data_model_store.try_get_last_conceptual_data_model is None:
             condition.add(f"{activity} expects conceptual data model in NEAT session")
             suggestion.add("Read in conceptual data model to neat session")
+        if (
+            can_convert_to_physical_data_model is True
+            and (conceptual_model := self.data_model_store.try_get_last_conceptual_data_model)
+            and ConceptualValidation(conceptual_model)
+            .validate()
+            .has_warning_type(ConversionToPhysicalModelImpossibleWarning)
+        ):
+            condition.add(f"{activity} expects conceptual data model that can be converted to physical data model")
+            suggestion.add(
+                "Read in conceptual data model and ensure that warnings that prevent conversion are resolved"
+            )
         if has_physical_data_model is False and self.data_model_store.try_get_last_physical_data_model is not None:
             condition.add(f"{activity} expects no physical data model in NEAT session")
             suggestion.add("You already have a physical data model in the session")

cognite_neat-0.123.18/last_changelog_entry.md

@@ -0,0 +1,5 @@
+### Improved
+
+- Added additional "overall" warning that is indicating wether
+conceptual data model is possible to convert to physical or not, which
+is used as flag to trigger stop on conversion process in `NeatSession`

cognite_neat-0.123.18/last_git_message.txt

@@ -0,0 +1,35 @@
+Prohibit conversion of conceptual if it is not possible (#1256)
+
+# Description
+
+Improved user-friendliness when attempting to convert conceptual data
+model to physical for cases when that is not possible. Previously python
+traceback was thrown at users:
+
+<img width="1130" height="837" alt="Screenshot 2025-07-24 at 17 38 35"
+src="https://github.com/user-attachments/assets/b2274f98-5c54-4d4d-9347-8c4ae27b3c30"
+/>
+
+now we indicate that conversion is not possible to perform
+<img width="1076" height="587" alt="Screenshot 2025-07-24 at 17 39 00"
+src="https://github.com/user-attachments/assets/d618f87b-3965-4836-b427-4d1b56f91783"
+/>
+
+Risk Review: ‼️ This is stacked 🧗 PR on top of #1251
+
+## Bump
+
+- [x] Patch
+- [ ] Minor
+- [ ] Skip
+
+## Changelog
+### Improved
+
+- Added additional "overall" warning that is indicating wether
+conceptual data model is possible to convert to physical or not, which
+is used as flag to trigger stop on conversion process in `NeatSession`
+
+---------
+
+Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

cognite_neat-0.123.18/last_version.txt

@@ -0,0 +1 @@
+0.123.17

{cognite_neat-0.123.17 → cognite_neat-0.123.18}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "cognite-neat"
-version = "0.123.17"
+version = "0.123.18"
 readme = "README.md"
 description = "Knowledge graph transformation"
 authors = [

{cognite_neat-0.123.17 → cognite_neat-0.123.18}/tests/tests_end_to_end/test_rules_flow.py

@@ -1,3 +1,5 @@
+import contextlib
+import io
 from pathlib import Path
 
 import pytest
@@ -26,6 +28,20 @@ class TestImportersToYAMLExporter:
         exported_rules = yaml.safe_load(exported_yaml_str)
         data_regression.check(exported_rules)
 
+    def test_prohibiting_conversion_with_nice_message(self) -> None:
+        neat = NeatSession()
+
+        neat.read.rdf.ontology(SchemaData.Conceptual.ontology_with_regex_warnings)
+
+        output = io.StringIO()
+        with contextlib.redirect_stdout(output):
+            neat.convert()
+
+        printed_statements = output.getvalue()
+        assert printed_statements.startswith(
+            "[ERROR] Cannot convert: Convert to physical expects conceptual data model"
+        )
+
     @pytest.mark.freeze_time("2017-05-21")
     @pytest.mark.skip("Needs NEAT-608 to be completed")
     def test_ontology_importer_to_yaml(self, data_regression: DataRegressionFixture, tmp_path: Path) -> None:

{cognite_neat-0.123.17 → cognite_neat-0.123.18}/tests/tests_unit/test_rules/test_importers/test_owl_importer.py

@@ -14,7 +14,7 @@ def test_ill_formed_owl_importer():
     with catch_issues() as issues:
         _ = VerifyAnyDataModel().transform(input)
 
-    assert len(issues) == 6
+    assert len(issues) == 7
     assert issues.has_errors
     assert str(issues.errors[0].identifier) == "neat_space:Award"
 

{cognite_neat-0.123.17 → cognite_neat-0.123.18}/tests/tests_unit/test_rules/test_models/test_conceptual_model.py

@@ -35,7 +35,12 @@ from cognite.neat.core._issues._base import MultiValueError
 from cognite.neat.core._issues._contextmanagers import catch_issues
 from cognite.neat.core._issues.errors import ResourceNotDefinedError
 from cognite.neat.core._issues.errors._resources import ResourceDuplicatedError
-from cognite.neat.core._issues.warnings._models import ConceptOnlyDataModelWarning, DanglingPropertyWarning
+from cognite.neat.core._issues.warnings._models import (
+    ConceptOnlyDataModelWarning,
+    ConversionToPhysicalModelImpossibleWarning,
+    DanglingPropertyWarning,
+    UndefinedConceptWarning,
+)
 
 
 def case_insensitive_value_types():
@@ -328,8 +333,9 @@ class TestInformationRules:
             _ = VerifyAnyDataModel(validate=True).transform(input_rules)
 
         assert not issues.has_errors
-        assert len(issues) == 3
-        assert len([issue for issue in issues if isinstance(issue, ConceptOnlyDataModelWarning)]) == 1
+        assert issues.has_warning_type(ConceptOnlyDataModelWarning)
+        assert issues.has_warning_type(ConversionToPhysicalModelImpossibleWarning)
+        assert issues.has_warning_type(UndefinedConceptWarning)
 
     def test_load_valid_jon_rules(self, david_spreadsheet: dict[str, dict[str, Any]]) -> None:
         valid_rules = ConceptualDataModel.model_validate(UnverifiedConceptualDataModel.load(david_spreadsheet).dump())

{cognite_neat-0.123.17 → cognite_neat-0.123.18}/uv.lock

@@ -346,7 +346,7 @@ wheels = [
 
 [[package]]
 name = "cognite-neat"
-version = "0.123.17"
+version = "0.123.18"
 source = { editable = "." }
 dependencies = [
     { name = "backports-strenum", marker = "python_full_version < '3.11'" },

cognite_neat-0.123.17/cognite/neat/_version.py

@@ -1,2 +0,0 @@
-__version__ = "0.123.17"
-__engine__ = "^2.0.4"

cognite_neat-0.123.17/last_changelog_entry.md

@@ -1,5 +0,0 @@
-
-### Removed
-
-- Remove method and check for properties redefinitions for ontology
-exporter

cognite_neat-0.123.17/last_git_message.txt

@@ -1,24 +0,0 @@
-Remove unnecessary method and check (#1252)
-
-# Description
-
-Previously we allowed for re-definition of properties (i.e., having
-several definition of the same property in
-`SheetList[ConceptualProperty|PhysicalProperty]`). Sometime ago we added
-more strict validation which does not allow this behavior. However, a
-method and check that looking for the redefinitions, which safeguard
-against it, pertained for ontology exporter. This PR removes them, as
-such edge case cannot longer happen (due to tougher validation at the
-source).
-
-## Bump
-
-- [x] Patch
-- [ ] Minor
-- [ ] Skip
-
-## Changelog
-### Removed
-
-- Remove method and check for properties redefinitions for ontology
-exporter

cognite_neat-0.123.17/last_version.txt

@@ -1 +0,0 @@
-0.123.16