cognite-neat 0.123.12__tar.gz → 0.123.14__tar.gz

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cognite-neat
-Version: 0.123.12
+Version: 0.123.14
 Summary: Knowledge graph transformation
 Project-URL: Documentation, https://cognite-neat.readthedocs-hosted.com/
 Project-URL: Homepage, https://cognite-neat.readthedocs-hosted.com/

cognite_neat-0.123.14/cognite/neat/_version.py

@@ -0,0 +1,2 @@
+__version__ = "0.123.14"
+__engine__ = "^2.0.4"

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/cognite/neat/core/_data_model/importers/_rdf/_owl2data_model.py

@@ -25,6 +25,8 @@ CLASSES_QUERY = """SELECT ?concept  ?name ?description ?implements
     }}
     """
 
+CLASSES_QUERY_PARAMETERS = {"concept", "name", "description", "implements"}
+
 PROPERTIES_QUERY = """
 
     SELECT ?concept  ?property_ ?name ?description ?value_type ?minCount ?maxCount ?default
@@ -44,34 +46,36 @@ PROPERTIES_QUERY = """
         FILTER (!bound(?description) || LANG(?description) = "" || LANGMATCHES(LANG(?description), "{language}"))
     }}
     """
+PROPERTIES_QUERY_PARAMETERS = {
+    "concept",
+    "property_",
+    "name",
+    "description",
+    "value_type",
+    "minCount",
+    "maxCount",
+    "default",
+}
 
 
 class OWLImporter(BaseRDFImporter):
     """Convert OWL ontology to unverified data model.
 
-        Args:
-            filepath: Path to OWL ontology
-
-    !!! Note
-        OWL Ontologies are information models which completeness varies. As such, constructing functional
-        data model directly will often be impossible, therefore the produced data model object will be ill formed.
-        To avoid this, neat will automatically attempt to make the imported data model compliant by adding default
-        values for missing information, attaching dangling properties to default containers based on the
-        property type, etc.
-
-        One has to be aware that NEAT will be opinionated about how to make the ontology
-        compliant, and that the resulting data model may not be what you expect.
-
+    Args:
+        filepath: Path to OWL ontology
     """
 
     def _to_data_model_components(
         self,
     ) -> dict:
-        concepts, issue_list = parse_concepts(self.graph, CLASSES_QUERY, self.language, self.issue_list)
+        concepts, issue_list = parse_concepts(
+            self.graph, CLASSES_QUERY, CLASSES_QUERY_PARAMETERS, self.language, self.issue_list
+        )
         self.issue_list = issue_list
 
-        # NeatError
-        properties, issue_list = parse_properties(self.graph, PROPERTIES_QUERY, self.language, self.issue_list)
+        properties, issue_list = parse_properties(
+            self.graph, PROPERTIES_QUERY, PROPERTIES_QUERY_PARAMETERS, self.language, self.issue_list
+        )
         self.issue_list = issue_list
 
         components = {

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/cognite/neat/core/_data_model/importers/_rdf/_shared.py

@@ -14,12 +14,17 @@ from cognite.neat.core._issues.warnings._resources import (
 from cognite.neat.core._utils.rdf_ import convert_rdflib_content
 
 
-def parse_concepts(graph: Graph, query: str, language: str, issue_list: IssueList) -> tuple[dict, IssueList]:
+def parse_concepts(
+    graph: Graph, query: str, parameters: set, language: str, issue_list: IssueList
+) -> tuple[dict, IssueList]:
     """Parse concepts from graph
 
     Args:
         graph: Graph containing concept definitions
+        query: SPARQL query to use for parsing concepts
+        parameters: Set of parameters to extract from the query results
         language: Language to use for parsing, by default "en"
+        issue_list: List to collect issues during parsing
 
     Returns:
         Dataframe containing owl classes
@@ -28,11 +33,10 @@ def parse_concepts(graph: Graph, query: str, language: str, issue_list: IssueLis
     concepts: dict[str, dict] = {}
 
     query = prepareQuery(query.format(language=language), initNs={k: v for k, v in graph.namespaces()})
-    expected_keys = [str(v) for v in query.algebra._vars]
 
     for raw in graph.query(query):
         res: dict = convert_rdflib_content(cast(ResultRow, raw).asdict(), True)
-        res = {key: res.get(key, None) for key in expected_keys}
+        res = {key: res.get(key, None) for key in parameters}
 
         # Quote the concept id to ensure it is web-safe
         res["concept"] = quote(res["concept"], safe="")
@@ -75,12 +79,17 @@ def parse_concepts(graph: Graph, query: str, language: str, issue_list: IssueLis
     return concepts, issue_list
 
 
-def parse_properties(graph: Graph, query: str, language: str, issue_list: IssueList) -> tuple[dict, IssueList]:
+def parse_properties(
+    graph: Graph, query: str, parameters: set, language: str, issue_list: IssueList
+) -> tuple[dict, IssueList]:
     """Parse properties from graph
 
     Args:
-        graph: Graph containing owl classes
+        graph: Graph containing property definitions
+        query: SPARQL query to use for parsing properties
+        parameters: Set of parameters to extract from the query results
         language: Language to use for parsing, by default "en"
+        issue_list: List to collect issues during parsing
 
     Returns:
         Dataframe containing owl classes
@@ -89,41 +98,40 @@ def parse_properties(graph: Graph, query: str, language: str, issue_list: IssueL
     properties: dict[str, dict] = {}
 
     query = prepareQuery(query.format(language=language), initNs={k: v for k, v in graph.namespaces()})
-    expected_keys = [str(v) for v in query.algebra._vars]
 
     for raw in graph.query(query):
         res: dict = convert_rdflib_content(cast(ResultRow, raw).asdict(), True)
-        res = {key: res.get(key, None) for key in expected_keys}
+        res = {key: res.get(key, None) for key in parameters}
 
         # Quote the concept id to ensure it is web-safe
         res["property_"] = quote(res["property_"], safe="")
         property_id = res["property_"]
 
-        # Safeguarding against incomplete semantic definitions
-        if not res["concept"] or isinstance(res["concept"], BNode):
+        # Skip Bnode
+        if isinstance(res["concept"], BNode):
             issue_list.append(
                 ResourceRetrievalWarning(
                     property_id,
                     "property",
-                    error=("Unable to determine to what concept property is being defined"),
+                    error="Cannot determine concept of property as it is a blank node",
                 )
             )
             continue
 
-        # Safeguarding against incomplete semantic definitions
-        if not res["value_type"] or isinstance(res["value_type"], BNode):
+        # Skip Bnode
+        if isinstance(res["value_type"], BNode):
             issue_list.append(
                 ResourceRetrievalWarning(
                     property_id,
                     "property",
-                    error=("Unable to determine value type of property"),
+                    error="Unable to determine value type of property as it is a blank node",
                 )
             )
             continue
 
         # Quote the concept and value_type to ensure they are web-safe
-        res["concept"] = quote(res["concept"], safe="")
-        res["value_type"] = quote(res["value_type"], safe="")
+        res["concept"] = quote(res["concept"], safe="") if res["concept"] else "#N/A"
+        res["value_type"] = quote(res["value_type"], safe="") if res["value_type"] else "#N/A"
 
         id_ = f"{res['concept']}.{res['property_']}"
 

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/cognite/neat/core/_data_model/models/conceptual/_unverified.py

@@ -78,7 +78,7 @@ class UnverifiedConceptualMetadata(UnverifiedComponent[ConceptualMetadata]):
 
 @dataclass
 class UnverifiedConceptualProperty(UnverifiedComponent[ConceptualProperty]):
-    concept: ConceptEntity | str
+    concept: ConceptEntity | str | UnknownEntity
     property_: str
     value_type: DataType | ConceptEntity | MultiValueTypeInfo | UnknownEntity | str
     name: str | None = None

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/cognite/neat/core/_data_model/models/conceptual/_validation.py

@@ -11,7 +11,11 @@ from cognite.neat.core._issues.errors._resources import (
     ResourceDuplicatedError,
     ResourceNotDefinedError,
 )
-from cognite.neat.core._issues.warnings._models import ConceptOnlyDataModelWarning, UndefinedConceptWarning
+from cognite.neat.core._issues.warnings._models import (
+    ConceptOnlyDataModelWarning,
+    DanglingPropertyWarning,
+    UndefinedConceptWarning,
+)
 from cognite.neat.core._issues.warnings._resources import (
     ResourceNotDefinedWarning,
     ResourceRegexViolationWarning,
@@ -47,6 +51,7 @@ class ConceptualValidation:
         self._referenced_classes_exist()
         self._referenced_value_types_exist()
         self._concept_only_data_model()
+        self._dangling_properties()
         self._regex_compliance_with_physical_data_model()
 
         return self.issue_list
@@ -56,6 +61,13 @@ class ConceptualValidation:
         if not self._properties:
             self.issue_list.append(ConceptOnlyDataModelWarning())
 
+    def _dangling_properties(self) -> None:
+        """Check if there are properties that do not reference any concept."""
+        dangling_properties = [prop for prop in self._properties if prop.concept == UnknownEntity()]
+        if dangling_properties:
+            for prop in dangling_properties:
+                self.issue_list.append(DanglingPropertyWarning(property_id=prop.property_))
+
     def _duplicated_resources(self) -> None:
         properties_sheet = self._read_info_by_spreadsheet.get("Properties")
         concepts_sheet = self._read_info_by_spreadsheet.get("Concepts")
@@ -119,7 +131,7 @@ class ConceptualValidation:
 
     def _undefined_classes(self) -> None:
         defined_concept = {concept.concept for concept in self._concepts}
-        referred_concepts = {property_.concept for property_ in self._properties}
+        referred_concepts = {property_.concept for property_ in self._properties} - {UnknownEntity()}
 
         if undefined_concepts := referred_concepts.difference(defined_concept):
             for concept in undefined_concepts:
@@ -153,7 +165,7 @@ class ConceptualValidation:
     def _referenced_classes_exist(self) -> None:
         # needs to be complete for this validation to pass
         defined_concept = {concept.concept for concept in self._concepts}
-        classes_with_explicit_properties = {property_.concept for property_ in self._properties}
+        classes_with_explicit_properties = {property_.concept for property_ in self._properties} - {UnknownEntity()}
 
         # USE CASE: models are complete
         if missing_classes := classes_with_explicit_properties.difference(defined_concept):
@@ -199,7 +211,7 @@ class ConceptualValidation:
                         PATTERNS.physical_property_id_compliance.pattern,
                     )
                 )
-            if not PATTERNS.view_id_compliance.match(prop_.concept.suffix):
+            if prop_.concept != UnknownEntity() and not PATTERNS.view_id_compliance.match(prop_.concept.suffix):
                 self.issue_list.append(
                     ResourceRegexViolationWarning(
                         prop_.concept,

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/cognite/neat/core/_data_model/models/conceptual/_verified.py

@@ -123,7 +123,7 @@ class ConceptualProperty(SheetRow):
               knowledge graph. Defaults to None (no transformation)
     """
 
-    concept: ConceptEntityType = Field(
+    concept: ConceptEntityType | UnknownEntity = Field(
         alias="Concept",
         description="Concept id that the property is defined for, strongly advise `PascalCase` usage.",
     )

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/cognite/neat/core/_issues/warnings/_models.py

@@ -109,6 +109,16 @@ class ConceptOnlyDataModelWarning(UserModelingWarning):
     fix = "Define properties for concepts or make sure that concepts implement other concepts that have properties."
 
 
+@dataclass(unsafe_hash=True)
+class DanglingPropertyWarning(UserModelingWarning):
+    """Property {property_id} is not defined for any concept.
+    This will likely cause issues when converting to a physical data model."""
+
+    fix = "Define the property for a concept or remove it from the data model."
+
+    property_id: str
+
+
 @dataclass(unsafe_hash=True)
 class UndefinedViewWarning(UserModelingWarning):
     """Undefined view {value_type} has been referred as value type for property <{view_property}> of view {view_id}."""

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/cognite/neat/core/_utils/spreadsheet.py

@@ -98,6 +98,10 @@ def read_individual_sheet(
         # Special handling for Value Type column, #N/A is treated specially by NEAT it means Unknown
         raw["Value Type"] = raw["Value Type"].replace(float("nan"), "#N/A")
 
+    if "Concept" in raw.columns:
+        # Special handling for Concept column, #N/A is treated specially by NEAT it means Unknown
+        raw["Concept"] = raw["Concept"].replace(float("nan"), "#N/A")
+
     output = raw.replace(float("nan"), None).to_dict(orient="records")
     if return_read_info:
         # If no rows are skipped, row 1 is the header row.

cognite_neat-0.123.14/last_changelog_entry.md

@@ -0,0 +1,4 @@
+### Improved
+
+- Enhanced OWL importer to detect and include object and data type
+properties without explicitly defined domain or range

cognite_neat-0.123.14/last_git_message.txt

@@ -0,0 +1,39 @@
+Improve OWL importer (#1250)
+
+# Description
+
+Updated the OWL importer to support parsing of object and data type
+properties that do not have explicitly defined domain or range (aka
+dangling properties). These properties are now captured and included
+during import, ensuring better coverage of implicit or loosely defined
+ontologies.
+
+
+**Why this change benefits users:**
+Many OWL ontologies omit explicit domain or range declarations,
+especially in evolving or lightweight schemas. Previously, such
+properties might have been ignored or incompletely imported. With this
+update, the importer now captures these properties, improving support
+for loosely structured ontologies and increasing data completeness. This
+allows users to work more effectively with third-party or custom
+ontologies that do not strictly follow formal OWL modeling conventions.
+
+**Risk Reviews**
+This is stacked PR. PR larger than 100 lines due to test data, otherwise
+pretty small PR.
+
+## Bump
+
+- [x] Patch
+- [ ] Minor
+- [ ] Skip
+
+## Changelog
+### Improved
+
+- Enhanced OWL importer to detect and include object and data type
+properties without explicitly defined domain or range
+
+---------
+
+Co-authored-by: Nikola Vasiljevic <nikola@Nikolas-MacBook-Air.local>

cognite_neat-0.123.14/last_version.txt

@@ -0,0 +1 @@
+0.123.13

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "cognite-neat"
-version = "0.123.12"
+version = "0.123.14"
 readme = "README.md"
 description = "Knowledge graph transformation"
 authors = [

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/tests/data/__init__.py

@@ -45,6 +45,7 @@ class SchemaData:
     class Conceptual:
         _conceptual = _schema_dir / "conceptual"
         only_concepts_xlsx = _conceptual / "only_concepts.xlsx"
+        dangling_properties_xlsx = _conceptual / "dangling-properties.xlsx"
         info_arch_car_rules_xlsx = _conceptual / "info-arch-car-rules.xlsx"
         information_unknown_value_type_xlsx = _conceptual / "information-unknown-value-type.xlsx"
         info_with_cdm_ref_xlsx = _conceptual / "info_with_cdm_ref.xlsx"

cognite_neat-0.123.14/tests/data/_schema/conceptual/ontology.ttl

@@ -0,0 +1,89 @@
+@prefix : <http://example.com/industrial#> .
+@prefix owl: <http://www.w3.org/2002/07/owl#> .
+@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
+@prefix xml: <http://www.w3.org/XML/1998/namespace> .
+@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
+@base <http://example.com/industrial#> .
+
+<http://example.com/industrial> rdf:type owl:Ontology .
+
+#################################################################
+#    Object Properties
+#################################################################
+
+###  http://example.com/industrial/has.Relation-Type(Generic):X~?@!$&'*+,;=%[]
+<http://example.com/industrial/has.Relation-Type(Generic):X~?@!$&'*+,;=%[]> rdf:type owl:ObjectProperty ;
+                                                                            rdfs:label "has generic relation" .
+
+
+###  http://example.com/industrial/has.Sensor-Unit(01):Temp~?@!$&'*+,;=%[]
+<http://example.com/industrial/has.Sensor-Unit(01):Temp~?@!$&'*+,;=%[]> rdf:type owl:ObjectProperty ;
+                                                                        rdfs:range <http://example.com/industrial/Sensor.Unit_01(Temp)~?@!$&'*+,;=%[]> ;
+                                                                        rdfs:label "has sensor unit" .
+
+
+###  http://example.com/industrial/is.Connected-To(Control):Panel~?@!$&'*+,;=%[]
+<http://example.com/industrial/is.Connected-To(Control):Panel~?@!$&'*+,;=%[]> rdf:type owl:ObjectProperty ;
+                                                                              rdfs:domain <http://example.com/industrial/Sensor.Unit_01(Temp)~?@!$&'*+,;=%[]> ;
+                                                                              rdfs:label "is connected to" .
+
+
+###  http://example.com/industrial/is.Controlled-By(Panel):Safety~?@!$&'*+,;=%[]
+<http://example.com/industrial/is.Controlled-By(Panel):Safety~?@!$&'*+,;=%[]> rdf:type owl:ObjectProperty ;
+                                                                              rdfs:domain <http://example.com/industrial/Machine.Type-A(01)~?@!$&'*+,;=%[]> ;
+                                                                              rdfs:range <http://example.com/industrial/Control.Panel-1(Safety)~?@!$&'*+,;=%[]> ;
+                                                                              rdfs:label "is controlled by" .
+
+
+###  http://example.com/industrial/links.Interface-Module(02):IO~?@!$&'*+,;=%[]
+<http://example.com/industrial/links.Interface-Module(02):IO~?@!$&'*+,;=%[]> rdf:type owl:ObjectProperty ;
+                                                                             rdfs:label "links interface module" .
+
+
+###  http://example.com/industrial/logs.Data-Stream(01):Raw~?@!$&'*+,;=%[]
+<http://example.com/industrial/logs.Data-Stream(01):Raw~?@!$&'*+,;=%[]> rdf:type owl:ObjectProperty ;
+                                                                        rdfs:label "logs raw data stream" .
+
+
+#################################################################
+#    Data properties
+#################################################################
+
+###  http://example.com/industrial/contains.Serial-Number(ID):X~?@!$&'*+,;=%[]
+<http://example.com/industrial/contains.Serial-Number(ID):X~?@!$&'*+,;=%[]> rdf:type owl:DatatypeProperty ;
+                                                                            rdfs:range xsd:string ;
+                                                                            rdfs:label "contains serial number" .
+
+
+###  http://example.com/industrial/has.Value-Reading(Temp):C~?@!$&'*+,;=%[]
+<http://example.com/industrial/has.Value-Reading(Temp):C~?@!$&'*+,;=%[]> rdf:type owl:DatatypeProperty ;
+                                                                         rdfs:domain <http://example.com/industrial/Sensor.Unit_01(Temp)~?@!$&'*+,;=%[]> ;
+                                                                         rdfs:label "has temperature value (Celsius)" .
+
+
+###  http://example.com/industrial/reports.Status-Flag(OK):1~?@!$&'*+,;=%[]
+<http://example.com/industrial/reports.Status-Flag(OK):1~?@!$&'*+,;=%[]> rdf:type owl:DatatypeProperty ;
+                                                                         rdfs:label "reports status flag" .
+
+
+#################################################################
+#    Classes
+#################################################################
+
+###  http://example.com/industrial/Control.Panel-1(Safety)~?@!$&'*+,;=%[]
+<http://example.com/industrial/Control.Panel-1(Safety)~?@!$&'*+,;=%[]> rdf:type owl:Class ;
+                                                                       rdfs:label "Safety Control Panel" .
+
+
+###  http://example.com/industrial/Machine.Type-A(01)~?@!$&'*+,;=%[]
+<http://example.com/industrial/Machine.Type-A(01)~?@!$&'*+,;=%[]> rdf:type owl:Class ;
+                                                                  rdfs:label "Machine Type A" .
+
+
+###  http://example.com/industrial/Sensor.Unit_01(Temp)~?@!$&'*+,;=%[]
+<http://example.com/industrial/Sensor.Unit_01(Temp)~?@!$&'*+,;=%[]> rdf:type owl:Class ;
+                                                                    rdfs:label "Temperature Sensor Unit" .
+
+
+###  Generated by the OWL API (version 4.5.29.2024-05-13T12:11:03Z) https://github.com/owlcs/owlapi

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/tests/tests_unit/test_rules/test_importers/test_excel_importer.py

@@ -5,6 +5,7 @@ from cognite.client.data_classes.data_modeling import ContainerId, ViewId
 
 from cognite.neat.core._data_model.importers import ExcelImporter
 from cognite.neat.core._data_model.models import ConceptualDataModel, PhysicalDataModel
+from cognite.neat.core._data_model.models.entities._single_value import UnknownEntity
 from cognite.neat.core._data_model.transformers import (
     VerifyAnyDataModel,
     VerifyPhysicalDataModel,
@@ -24,6 +25,7 @@ from cognite.neat.core._issues.warnings import (
     NotSupportedViewContainerLimitWarning,
     PropertyDefinitionWarning,
 )
+from cognite.neat.core._issues.warnings._models import DanglingPropertyWarning
 from tests.config import DOC_RULES
 from tests.data import SchemaData
 
@@ -242,3 +244,15 @@ class TestExcelImporter:
             ("Manufacturer", "name"): {"min_count": 0, "max_count": 1},
             ("Color", "name"): {"min_count": 0, "max_count": 1},
         }
+
+    def test_dangling_properties(self):
+        """Test that dangling properties are correctly identified."""
+        importer = ExcelImporter(SchemaData.Conceptual.dangling_properties_xlsx)
+        with catch_issues() as issues:
+            read_dm = importer.to_data_model()
+            validated_dm = VerifyAnyDataModel().transform(read_dm)
+
+        assert not issues.has_errors
+        assert issues.has_warning_type(DanglingPropertyWarning)
+        assert all([prop.concept == UnknownEntity() for prop in validated_dm.properties])
+        assert all([prop.value_type == UnknownEntity() for prop in validated_dm.properties])

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/tests/tests_unit/test_rules/test_importers/test_owl_importer.py

@@ -4,6 +4,7 @@ from cognite.neat.core._data_model.analysis import DataModelAnalysis
 from cognite.neat.core._data_model.models.entities import ConceptEntity
 from cognite.neat.core._data_model.transformers._verification import VerifyAnyDataModel
 from cognite.neat.core._issues import catch_issues
+from cognite.neat.core._issues.warnings._models import DanglingPropertyWarning
 from cognite.neat.core._issues.warnings._resources import ResourceNotDefinedWarning, ResourceRegexViolationWarning
 from tests.data import SchemaData
 
@@ -51,14 +52,37 @@ def test_owl_enitity_quoting():
             categorized_issues[type(issue)] = []
         categorized_issues[type(issue)].append(issue)
 
-    assert len(issues) == 13
+    assert len(issues) == 24
     # quoting is successful, but regex warnings are raised
     assert not issues.has_errors
     assert issues.has_warnings
 
-    assert len(categorized_issues) == 2
-    assert len(categorized_issues[ResourceRegexViolationWarning]) == 12
+    assert len(categorized_issues) == 3
+    assert len(categorized_issues[ResourceRegexViolationWarning]) == 17
     assert len(categorized_issues[ResourceNotDefinedWarning]) == 1
+    assert len(categorized_issues[DanglingPropertyWarning]) == 6
 
-    assert len(conceptual_data_model.concepts) == 3
-    assert len(conceptual_data_model.properties) == 3
+    expected_concepts = {
+        ConceptEntity(
+            prefix="neat_space", suffix="Control.Panel-1%28Safety%29~%3F%40%21%24%26%27%2A%2B%2C%3B%3D%25%5B%5D"
+        ),
+        ConceptEntity(prefix="neat_space", suffix="Machine.Type-A%2801%29~%3F%40%21%24%26%27%2A%2B%2C%3B%3D%25%5B%5D"),
+        ConceptEntity(
+            prefix="neat_space", suffix="Sensor.Unit_01%28Temp%29~%3F%40%21%24%26%27%2A%2B%2C%3B%3D%25%5B%5D"
+        ),
+    }
+
+    expected_properties = {
+        "contains.Serial-Number%28ID%29%3AX~%3F%40%21%24%26%27%2A%2B%2C%3B%3D%25%5B%5D",
+        "has.Relation-Type%28Generic%29%3AX~%3F%40%21%24%26%27%2A%2B%2C%3B%3D%25%5B%5D",
+        "has.Sensor-Unit%2801%29%3ATemp~%3F%40%21%24%26%27%2A%2B%2C%3B%3D%25%5B%5D",
+        "has.Value-Reading%28Temp%29%3AC~%3F%40%21%24%26%27%2A%2B%2C%3B%3D%25%5B%5D",
+        "is.Connected-To%28Control%29%3APanel~%3F%40%21%24%26%27%2A%2B%2C%3B%3D%25%5B%5D",
+        "is.Controlled-By%28Panel%29%3ASafety~%3F%40%21%24%26%27%2A%2B%2C%3B%3D%25%5B%5D",
+        "links.Interface-Module%2802%29%3AIO~%3F%40%21%24%26%27%2A%2B%2C%3B%3D%25%5B%5D",
+        "logs.Data-Stream%2801%29%3ARaw~%3F%40%21%24%26%27%2A%2B%2C%3B%3D%25%5B%5D",
+        "reports.Status-Flag%28OK%29%3A1~%3F%40%21%24%26%27%2A%2B%2C%3B%3D%25%5B%5D",
+    }
+
+    assert {concept.concept for concept in conceptual_data_model.concepts} == expected_concepts
+    assert {prop.property_ for prop in conceptual_data_model.properties} == expected_properties

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/tests/tests_unit/test_rules/test_models/test_conceptual_model.py

@@ -23,6 +23,7 @@ from cognite.neat.core._data_model.models.entities import (
     ConceptEntity,
     MultiValueTypeInfo,
 )
+from cognite.neat.core._data_model.models.entities._single_value import UnknownEntity
 from cognite.neat.core._data_model.transformers._converters import (
     ConceptualToPhysical,
     ToCompliantEntities,
@@ -34,7 +35,7 @@ from cognite.neat.core._issues._base import MultiValueError
 from cognite.neat.core._issues._contextmanagers import catch_issues
 from cognite.neat.core._issues.errors import ResourceNotDefinedError
 from cognite.neat.core._issues.errors._resources import ResourceDuplicatedError
-from cognite.neat.core._issues.warnings._models import ConceptOnlyDataModelWarning
+from cognite.neat.core._issues.warnings._models import ConceptOnlyDataModelWarning, DanglingPropertyWarning
 
 
 def case_insensitive_value_types():
@@ -180,15 +181,63 @@ def concepts_only_data_model():
             ],
             "Properties": [],
         },
+        id="concept_only_data_model",
+    )
+
+
+def dangling_properties_data_model():
+    yield pytest.param(
         {
-            ResourceDuplicatedError(
-                identifier="name",
-                resource_type="property",
-                location="the Properties sheet at row 1 and 2 if data model is read from a spreadsheet.",
-            ),
-            ConceptOnlyDataModelWarning(),
+            "Metadata": {
+                "role": "information architect",
+                "creator": "Jon, Emma, David",
+                "space": "power",
+                "external_id": "power2consumer",
+                "created": datetime(2024, 2, 9, 0, 0),
+                "updated": datetime(2024, 2, 9, 0, 0),
+                "version": "0.1.0",
+                "name": "Power to Consumer Data Model",
+            },
+            "Concepts": [
+                {
+                    "Concept": "GeneratingUnit",
+                    "Description": None,
+                    "Parent Class": None,
+                },
+                {
+                    "Concept": "Substation",
+                    "Description": None,
+                    "Parent Class": None,
+                },
+            ],
+            "Properties": [
+                {
+                    "Concept": UnknownEntity(),
+                    "Property": "name_xx",
+                    "Description": None,
+                    "Value Type": "string",
+                    "Min Count": 1,
+                    "Max Count": 1.0,
+                    "Default": None,
+                    "Source": None,
+                    "MatchType": None,
+                    "Transformation": None,
+                },
+                {
+                    "Concept": UnknownEntity(),
+                    "Property": "name",
+                    "Description": None,
+                    "Value Type": UnknownEntity(),
+                    "Min Count": 1,
+                    "Max Count": 1.0,
+                    "Default": None,
+                    "Source": None,
+                    "MatchType": None,
+                    "Transformation": None,
+                },
+            ],
         },
-        id="concept_only_data_model",
+        id="dangling_properties_data_model",
     )
 
 
@@ -256,8 +305,21 @@ class TestInformationRules:
 
         assert set(e.value.errors) == expected_exception
 
-    @pytest.mark.parametrize("dm_dict, expected_exception", list(concepts_only_data_model()))
-    def test_concepts_only_data_model(self, dm_dict, expected_exception) -> None:
+    @pytest.mark.parametrize("dm_dict", list(dangling_properties_data_model()))
+    def test_dangling_properties(self, dm_dict) -> None:
+        input_rules = ImportedDataModel(
+            unverified_data_model=UnverifiedConceptualDataModel.load(dm_dict),
+            context={},
+        )
+        with catch_issues() as issues:
+            _ = VerifyAnyDataModel(validate=True).transform(input_rules)
+
+        assert not issues.has_errors
+        assert len(issues) == 4
+        assert len([issue for issue in issues if isinstance(issue, DanglingPropertyWarning)]) == 2
+
+    @pytest.mark.parametrize("dm_dict", list(concepts_only_data_model()))
+    def test_concepts_only_data_model(self, dm_dict) -> None:
         input_rules = ImportedDataModel(
             unverified_data_model=UnverifiedConceptualDataModel.load(dm_dict),
             context={},

{cognite_neat-0.123.12 → cognite_neat-0.123.14}/uv.lock

@@ -346,7 +346,7 @@ wheels = [
 
 [[package]]
 name = "cognite-neat"
-version = "0.123.12"
+version = "0.123.14"
 source = { editable = "." }
 dependencies = [
     { name = "backports-strenum", marker = "python_full_version < '3.11'" },