cognite-neat 0.123.11__tar.gz → 0.123.13__tar.gz

{cognite_neat-0.123.11 → cognite_neat-0.123.13}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cognite-neat
-Version: 0.123.11
+Version: 0.123.13
 Summary: Knowledge graph transformation
 Project-URL: Documentation, https://cognite-neat.readthedocs-hosted.com/
 Project-URL: Homepage, https://cognite-neat.readthedocs-hosted.com/

cognite_neat-0.123.13/cognite/neat/_version.py

@@ -0,0 +1,2 @@
+__version__ = "0.123.13"
+__engine__ = "^2.0.4"

{cognite_neat-0.123.11 → cognite_neat-0.123.13}/cognite/neat/core/_data_model/models/conceptual/_unverified.py

@@ -78,7 +78,7 @@ class UnverifiedConceptualMetadata(UnverifiedComponent[ConceptualMetadata]):
 
 @dataclass
 class UnverifiedConceptualProperty(UnverifiedComponent[ConceptualProperty]):
-    concept: ConceptEntity | str
+    concept: ConceptEntity | str | UnknownEntity
     property_: str
     value_type: DataType | ConceptEntity | MultiValueTypeInfo | UnknownEntity | str
     name: str | None = None
@@ -146,8 +146,8 @@ class UnverifiedConcept(UnverifiedComponent[Concept]):
 @dataclass
 class UnverifiedConceptualDataModel(UnverifiedDataModel[ConceptualDataModel]):
     metadata: UnverifiedConceptualMetadata
-    properties: list[UnverifiedConceptualProperty] = field(default_factory=list)
     concepts: list[UnverifiedConcept] = field(default_factory=list)
+    properties: list[UnverifiedConceptualProperty] = field(default_factory=list)
     prefixes: dict[str, Namespace] | None = None
 
     @classmethod

{cognite_neat-0.123.11 → cognite_neat-0.123.13}/cognite/neat/core/_data_model/models/conceptual/_validation.py

@@ -11,7 +11,11 @@ from cognite.neat.core._issues.errors._resources import (
     ResourceDuplicatedError,
     ResourceNotDefinedError,
 )
-from cognite.neat.core._issues.warnings._models import UndefinedConceptWarning
+from cognite.neat.core._issues.warnings._models import (
+    ConceptOnlyDataModelWarning,
+    DanglingPropertyWarning,
+    UndefinedConceptWarning,
+)
 from cognite.neat.core._issues.warnings._resources import (
     ResourceNotDefinedWarning,
     ResourceRegexViolationWarning,
@@ -46,10 +50,24 @@ class ConceptualValidation:
         self._parent_concept_defined()
         self._referenced_classes_exist()
         self._referenced_value_types_exist()
+        self._concept_only_data_model()
+        self._dangling_properties()
         self._regex_compliance_with_physical_data_model()
 
         return self.issue_list
 
+    def _concept_only_data_model(self) -> None:
+        """Check if the data model only consists of concepts without any properties."""
+        if not self._properties:
+            self.issue_list.append(ConceptOnlyDataModelWarning())
+
+    def _dangling_properties(self) -> None:
+        """Check if there are properties that do not reference any concept."""
+        dangling_properties = [prop for prop in self._properties if prop.concept == UnknownEntity()]
+        if dangling_properties:
+            for prop in dangling_properties:
+                self.issue_list.append(DanglingPropertyWarning(property_id=prop.property_))
+
     def _duplicated_resources(self) -> None:
         properties_sheet = self._read_info_by_spreadsheet.get("Properties")
         concepts_sheet = self._read_info_by_spreadsheet.get("Concepts")
@@ -113,7 +131,7 @@ class ConceptualValidation:
 
     def _undefined_classes(self) -> None:
         defined_concept = {concept.concept for concept in self._concepts}
-        referred_concepts = {property_.concept for property_ in self._properties}
+        referred_concepts = {property_.concept for property_ in self._properties} - {UnknownEntity()}
 
         if undefined_concepts := referred_concepts.difference(defined_concept):
             for concept in undefined_concepts:
@@ -193,7 +211,7 @@ class ConceptualValidation:
                         PATTERNS.physical_property_id_compliance.pattern,
                     )
                 )
-            if not PATTERNS.view_id_compliance.match(prop_.concept.suffix):
+            if prop_.concept != UnknownEntity() and not PATTERNS.view_id_compliance.match(prop_.concept.suffix):
                 self.issue_list.append(
                     ResourceRegexViolationWarning(
                         prop_.concept,

{cognite_neat-0.123.11 → cognite_neat-0.123.13}/cognite/neat/core/_data_model/models/conceptual/_verified.py

@@ -123,7 +123,7 @@ class ConceptualProperty(SheetRow):
               knowledge graph. Defaults to None (no transformation)
     """
 
-    concept: ConceptEntityType = Field(
+    concept: ConceptEntityType | UnknownEntity = Field(
         alias="Concept",
         description="Concept id that the property is defined for, strongly advise `PascalCase` usage.",
     )
@@ -241,8 +241,10 @@ class ConceptualProperty(SheetRow):
 
 class ConceptualDataModel(BaseVerifiedDataModel):
     metadata: ConceptualMetadata = Field(alias="Metadata", description="Metadata for the conceptual data model")
-    properties: SheetList[ConceptualProperty] = Field(alias="Properties", description="List of properties")
     concepts: SheetList[Concept] = Field(alias="Concepts", description="List of concepts")
+    properties: SheetList[ConceptualProperty] = Field(
+        alias="Properties", default_factory=SheetList, description="List of properties"
+    )
     prefixes: dict[str, Namespace] = Field(
         alias="Prefixes",
         default_factory=get_default_prefixes_and_namespaces,

{cognite_neat-0.123.11 → cognite_neat-0.123.13}/cognite/neat/core/_issues/warnings/_models.py

@@ -101,6 +101,24 @@ class UndefinedConceptWarning(UserModelingWarning):
     concept_id: str
 
 
+@dataclass(unsafe_hash=True)
+class ConceptOnlyDataModelWarning(UserModelingWarning):
+    """Data model is concept-only (contains concepts but no properties).
+    This model will likely cause issues when converting to a physical data model."""
+
+    fix = "Define properties for concepts or make sure that concepts implement other concepts that have properties."
+
+
+@dataclass(unsafe_hash=True)
+class DanglingPropertyWarning(UserModelingWarning):
+    """Property {property_id} is not defined for any concept.
+    This will likely cause issues when converting to a physical data model."""
+
+    fix = "Define the property for a concept or remove it from the data model."
+
+    property_id: str
+
+
 @dataclass(unsafe_hash=True)
 class UndefinedViewWarning(UserModelingWarning):
     """Undefined view {value_type} has been referred as value type for property <{view_property}> of view {view_id}."""

cognite_neat-0.123.13/last_changelog_entry.md

@@ -0,0 +1,4 @@
+### Improved
+
+- Added support for dangling properties in conceptual models, useful for
+OWL imports with undefined domains/ranges.

cognite_neat-0.123.13/last_git_message.txt

@@ -0,0 +1,35 @@
+Enable defining properties in conceptual data model which are not defined for any concept (dangling properties) (#1248)
+
+# Description
+
+This PR adds support for defining dangling properties—properties in the
+conceptual data model that are not yet associated with any specific
+concept.
+
+**Justification**:
+When generating a conceptual data model from an OWL ontology, it’s
+common to encounter properties (e.g., owl:ObjectProperty,
+owl:DatatypeProperty) that are declared but not explicitly linked to any
+defined class via domain or range. Supporting dangling properties
+ensures these are not lost during transformation and allows the model to
+faithfully represent the source ontology structure. It also enables
+incremental refinement, where associations can be added later as
+understanding of the domain evolves.
+
+**Note**: This PR is stacked on top of #1247
+
+## Bump
+
+- [x] Patch
+- [ ] Minor
+- [ ] Skip
+
+## Changelog
+### Improved
+
+- Added support for dangling properties in conceptual models, useful for
+OWL imports with undefined domains/ranges.
+
+---------
+
+Co-authored-by: Nikola Vasiljevic <nikola@Nikolas-MacBook-Air.local>

cognite_neat-0.123.13/last_version.txt

@@ -0,0 +1 @@
+0.123.12

{cognite_neat-0.123.11 → cognite_neat-0.123.13}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "cognite-neat"
-version = "0.123.11"
+version = "0.123.13"
 readme = "README.md"
 description = "Knowledge graph transformation"
 authors = [

{cognite_neat-0.123.11 → cognite_neat-0.123.13}/tests/tests_unit/test_rules/test_models/test_conceptual_model.py

@@ -23,6 +23,7 @@ from cognite.neat.core._data_model.models.entities import (
     ConceptEntity,
     MultiValueTypeInfo,
 )
+from cognite.neat.core._data_model.models.entities._single_value import UnknownEntity
 from cognite.neat.core._data_model.transformers._converters import (
     ConceptualToPhysical,
     ToCompliantEntities,
@@ -31,8 +32,10 @@ from cognite.neat.core._data_model.transformers._converters import (
 from cognite.neat.core._data_model.transformers._verification import VerifyAnyDataModel
 from cognite.neat.core._issues import NeatError
 from cognite.neat.core._issues._base import MultiValueError
+from cognite.neat.core._issues._contextmanagers import catch_issues
 from cognite.neat.core._issues.errors import ResourceNotDefinedError
 from cognite.neat.core._issues.errors._resources import ResourceDuplicatedError
+from cognite.neat.core._issues.warnings._models import ConceptOnlyDataModelWarning, DanglingPropertyWarning
 
 
 def case_insensitive_value_types():
@@ -151,6 +154,93 @@ def duplicated_entries():
     )
 
 
+def concepts_only_data_model():
+    yield pytest.param(
+        {
+            "Metadata": {
+                "role": "information architect",
+                "creator": "Jon, Emma, David",
+                "space": "power",
+                "external_id": "power2consumer",
+                "created": datetime(2024, 2, 9, 0, 0),
+                "updated": datetime(2024, 2, 9, 0, 0),
+                "version": "0.1.0",
+                "name": "Power to Consumer Data Model",
+            },
+            "Concepts": [
+                {
+                    "Concept": "GeneratingUnit",
+                    "Description": None,
+                    "Parent Class": None,
+                },
+                {
+                    "Concept": "Substation",
+                    "Description": None,
+                    "Parent Class": None,
+                },
+            ],
+            "Properties": [],
+        },
+        id="concept_only_data_model",
+    )
+
+
+def dangling_properties_data_model():
+    yield pytest.param(
+        {
+            "Metadata": {
+                "role": "information architect",
+                "creator": "Jon, Emma, David",
+                "space": "power",
+                "external_id": "power2consumer",
+                "created": datetime(2024, 2, 9, 0, 0),
+                "updated": datetime(2024, 2, 9, 0, 0),
+                "version": "0.1.0",
+                "name": "Power to Consumer Data Model",
+            },
+            "Concepts": [
+                {
+                    "Concept": "GeneratingUnit",
+                    "Description": None,
+                    "Parent Class": None,
+                },
+                {
+                    "Concept": "Substation",
+                    "Description": None,
+                    "Parent Class": None,
+                },
+            ],
+            "Properties": [
+                {
+                    "Concept": UnknownEntity(),
+                    "Property": "name_xx",
+                    "Description": None,
+                    "Value Type": "string",
+                    "Min Count": 1,
+                    "Max Count": 1.0,
+                    "Default": None,
+                    "Source": None,
+                    "MatchType": None,
+                    "Transformation": None,
+                },
+                {
+                    "Concept": UnknownEntity(),
+                    "Property": "name",
+                    "Description": None,
+                    "Value Type": UnknownEntity(),
+                    "Min Count": 1,
+                    "Max Count": 1.0,
+                    "Default": None,
+                    "Source": None,
+                    "MatchType": None,
+                    "Transformation": None,
+                },
+            ],
+        },
+        id="dangling_properties_data_model",
+    )
+
+
 def incomplete_rules_case():
     yield pytest.param(
         {
@@ -215,6 +305,32 @@ class TestInformationRules:
 
         assert set(e.value.errors) == expected_exception
 
+    @pytest.mark.parametrize("dm_dict", list(dangling_properties_data_model()))
+    def test_dangling_properties(self, dm_dict) -> None:
+        input_rules = ImportedDataModel(
+            unverified_data_model=UnverifiedConceptualDataModel.load(dm_dict),
+            context={},
+        )
+        with catch_issues() as issues:
+            _ = VerifyAnyDataModel(validate=True).transform(input_rules)
+
+        assert not issues.has_errors
+        assert len(issues) == 5
+        assert len([issue for issue in issues if isinstance(issue, DanglingPropertyWarning)]) == 2
+
+    @pytest.mark.parametrize("dm_dict", list(concepts_only_data_model()))
+    def test_concepts_only_data_model(self, dm_dict) -> None:
+        input_rules = ImportedDataModel(
+            unverified_data_model=UnverifiedConceptualDataModel.load(dm_dict),
+            context={},
+        )
+        with catch_issues() as issues:
+            _ = VerifyAnyDataModel(validate=True).transform(input_rules)
+
+        assert not issues.has_errors
+        assert len(issues) == 3
+        assert len([issue for issue in issues if isinstance(issue, ConceptOnlyDataModelWarning)]) == 1
+
     def test_load_valid_jon_rules(self, david_spreadsheet: dict[str, dict[str, Any]]) -> None:
         valid_rules = ConceptualDataModel.model_validate(UnverifiedConceptualDataModel.load(david_spreadsheet).dump())
 

{cognite_neat-0.123.11 → cognite_neat-0.123.13}/uv.lock

@@ -346,7 +346,7 @@ wheels = [
 
 [[package]]
 name = "cognite-neat"
-version = "0.123.11"
+version = "0.123.13"
 source = { editable = "." }
 dependencies = [
     { name = "backports-strenum", marker = "python_full_version < '3.11'" },

cognite_neat-0.123.11/cognite/neat/_version.py

@@ -1,2 +0,0 @@
-__version__ = "0.123.11"
-__engine__ = "^2.0.4"

cognite_neat-0.123.11/last_changelog_entry.md

@@ -1,4 +0,0 @@
-### Improved
-
-- OWL importer got improved flexibility for ids of entities that making
-ontology

cognite_neat-0.123.11/last_git_message.txt

@@ -1,23 +0,0 @@
-Improve OWL importer by quoting IDs (#1246)
-
-# Description
-
-OWL importer has been improved allowing for class and property ids which
-contain "non-web-safe" characters, which can exist since OWL allows
-defining ids using IRIs , which are allow for more characters than URIs.
-
-## Bump
-
-- [x] Patch
-- [ ] Minor
-- [ ] Skip
-
-## Changelog
-### Improved
-
-- OWL importer got improved flexibility for ids of entities that making
-ontology
-
----------
-
-Co-authored-by: Nikola Vasiljevic <nikola@Nikolas-MacBook-Air.local>

cognite_neat-0.123.11/last_version.txt

@@ -1 +0,0 @@
-0.123.10