codna 0.2.18__tar.gz → 0.2.19__tar.gz

{codna-0.2.18 → codna-0.2.19}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: codna
-Version: 0.2.18
+Version: 0.2.19
 Summary: Local-first repo intelligence and agent fixing for Codna.
 Author: Thyn
 Maintainer: Thyn

{codna-0.2.18 → codna-0.2.19}/codna/__init__.py

@@ -5,4 +5,4 @@ This package is the `codna` CLI. Users never touch "algenta" directly — the en
 is an internal dependency reached over HTTP.
 """
 
-__version__ = "0.2.18"
+__version__ = "0.2.19"

{codna-0.2.18 → codna-0.2.19}/codna/webhook_worker.py

@@ -203,6 +203,37 @@ def _job_env(
     return env
 
 
+def _review_job_summary(stdout: str) -> str | None:
+    """A short, markdown-safe summary for a review job's wrapper Check Run.
+
+    ``codna review ... --json`` (the only command codna_command adds ``--json`` to) prints a
+    findings-review result dict as its ENTIRE stdout -- the same shape
+    ``cli/codna/review.py::render_findings`` renders for a human. That renderer is for a
+    terminal, though: several of its lines are indented 4+ spaces, which GitHub's markdown
+    turns into a code block rather than the intended text, so it is deliberately not reused
+    here. Returns None (never raises) on anything that isn't exactly this shape, so the caller
+    falls back to its existing raw-stdout-tail behavior instead of guessing.
+    """
+    try:
+        result = json.loads(stdout)
+    except (json.JSONDecodeError, TypeError, ValueError):
+        return None
+    if not isinstance(result, dict) or "conclusion" not in result or "findings" not in result:
+        return None
+    findings = result.get("findings") or []
+    if not findings:
+        note = result.get("note")
+        return f"codna review: {note}" if note else "codna review: no high-confidence issues found ✅"
+    posted = result.get("posted") or {}
+    inline = posted.get("inline_posted", 0)
+    summary_n = result.get("summary_count", 0)
+    return (
+        f"codna review: {len(findings)} finding(s) — {inline} inline, {summary_n} in summary "
+        f"(conclusion: {result.get('conclusion', 'unknown')}). See the **Codna Review** check "
+        "and the PR's review comments for details."
+    )
+
+
 def run_codna_job(job: WebhookJob, *, token: str | None, engine_key: str | None,
                   provider: str | None = None, provider_key: str | None = None,
                   codna_bin: str = "codna") -> JobResult:
@@ -252,6 +283,18 @@ def run_codna_job(job: WebhookJob, *, token: str | None, engine_key: str | None,
             )
         except subprocess.TimeoutExpired:
             return JobResult(False, f"codna {job.kind} timed out after {_JOB_TIMEOUT_S}s")
+        if job.kind == "review":
+            # `codna review ... --json` (codna_command's only caller of --json) prints ONE pure
+            # JSON object to stdout for the caller (review_github.py's own posting logic) to
+            # consume -- capture_output means it's also sitting right here in proc.stdout. The
+            # generic tail-of-stdout fallback below would dump that raw JSON as THIS wrapper
+            # check-run's summary verbatim: an unreadable wall of braces where a human expects a
+            # sentence. The detailed, well-formatted findings already live on the "Codna Review"
+            # check this same subprocess posts (review_github.py::summary_body) and as inline PR
+            # comments; this wrapper only needs to say the job completed and point there.
+            summary = _review_job_summary(proc.stdout)
+            if summary is not None:
+                return JobResult(proc.returncode == 0, summary)
         tail = (proc.stdout or "")[-1500:] + (("\n" + proc.stderr[-500:]) if proc.stderr else "")
         return JobResult(proc.returncode == 0, tail.strip() or f"codna {job.kind} exit {proc.returncode}")
 

{codna-0.2.18 → codna-0.2.19}/codna.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: codna
-Version: 0.2.18
+Version: 0.2.19
 Summary: Local-first repo intelligence and agent fixing for Codna.
 Author: Thyn
 Maintainer: Thyn

{codna-0.2.18 → codna-0.2.19}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "codna"
-version = "0.2.18"
+version = "0.2.19"
 description = "Local-first repo intelligence and agent fixing for Codna."
 readme = "README.md"
 requires-python = ">=3.10"

{codna-0.2.18 → codna-0.2.19}/tests/test_webhook_worker.py

@@ -463,6 +463,56 @@ def test_run_codna_secure_without_token_fails_closed():
     assert res.ok is False and "token" in res.summary.lower()
 
 
+# --- runner: a "review" job's summary must be human text, never the raw --json stdout ------
+# codna_command's --json flag exists ONLY for the "review" kind (so review_github.py's own
+# posting logic can parse the subprocess's result); before this fix, run_codna_job reused that
+# same raw JSON verbatim as the wrapper Check Run's summary. Live evidence: thyn-ai/algenta run
+# 105075740163, whose Check Run summary was a multi-KB wall of unformatted JSON braces.
+def test_review_job_summary_reformats_valid_json_into_a_short_sentence():
+    stdout = json.dumps({
+        "findings": [{"path": "a.py", "line": 1}, {"path": "b.py", "line": 2}],
+        "inline_count": 2, "summary_count": 0, "conclusion": "neutral",
+        "posted": {"posted_review": True, "inline_posted": 2, "skipped_duplicates": 0},
+    })
+    summary = worker_module._review_job_summary(stdout)
+    assert summary is not None
+    assert "{" not in summary and "}" not in summary  # never raw JSON
+    assert "2 finding(s)" in summary and "2 inline" in summary and "neutral" in summary
+    assert "Codna Review" in summary  # points at the check that has the real detail
+
+
+def test_review_job_summary_no_findings():
+    stdout = json.dumps({"findings": [], "inline_count": 0, "summary_count": 0, "conclusion": "success"})
+    summary = worker_module._review_job_summary(stdout)
+    assert summary == "codna review: no high-confidence issues found ✅"
+
+
+def test_review_job_summary_falls_back_to_none_on_anything_else():
+    # Not JSON at all, JSON that isn't a dict, and a dict missing the review-result shape --
+    # every one must return None so the caller keeps its existing raw-tail fallback rather
+    # than fabricating a summary from something that isn't actually a review result.
+    assert worker_module._review_job_summary("not json at all") is None
+    assert worker_module._review_job_summary("[1, 2, 3]") is None
+    assert worker_module._review_job_summary(json.dumps({"ok": True})) is None
+    assert worker_module._review_job_summary("") is None
+
+
+def test_run_codna_job_review_kind_uses_the_clean_summary_not_raw_stdout(monkeypatch, tmp_path):
+    monkeypatch.setattr(worker_module, "_JOB_TIMEOUT_S", 30)
+    fake_result = {
+        "findings": [{"path": "x.py", "line": 9}], "inline_count": 1, "summary_count": 0,
+        "conclusion": "neutral", "posted": {"posted_review": True, "inline_posted": 1},
+    }
+    fake_bin = tmp_path / "fake-codna"
+    fake_bin.write_text("#!/bin/sh\ncat <<'EOF'\n" + json.dumps(fake_result) + "\nEOF\n")
+    fake_bin.chmod(0o755)
+    job = WebhookJob("review", "acme/app", ref="sha1", installation_id=42, pr_number=7, reason="test")
+    res = run_codna_job(job, token="t", engine_key="k", codna_bin=str(fake_bin))
+    assert res.ok is True
+    assert "{" not in res.summary
+    assert "1 finding(s)" in res.summary
+
+
 def _issue_label_job():
     return WebhookJob("fix", "acme/app", ref=None, installation_id=42, issue_number=12,
                       reason="labeled_codna_fix")