codingest 0.2.22__tar.gz → 0.2.24__tar.gz

{codingest-0.2.22 → codingest-0.2.24}/Cargo.lock

@@ -302,7 +302,7 @@ dependencies = [
 
 [[package]]
 name = "codingest"
-version = "0.2.22"
+version = "0.2.24"
 dependencies = [
  "aho-corasick",
  "base64 0.22.1",
@@ -338,7 +338,7 @@ dependencies = [
 
 [[package]]
 name = "codingest-cli"
-version = "0.2.22"
+version = "0.2.24"
 dependencies = [
  "anyhow",
  "clap",
@@ -350,7 +350,7 @@ dependencies = [
 
 [[package]]
 name = "codingest-mcp"
-version = "0.2.22"
+version = "0.2.24"
 dependencies = [
  "anyhow",
  "codingest",
@@ -361,7 +361,7 @@ dependencies = [
 
 [[package]]
 name = "codingest-py"
-version = "0.2.22"
+version = "0.2.24"
 dependencies = [
  "codingest",
  "codingest-cli",
@@ -1368,9 +1368,9 @@ dependencies = [
 
 [[package]]
 name = "kglite"
-version = "0.17.6"
+version = "0.17.9"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6f3f148d8a40ffbfbf0c514a92cadc9382e25443409324628637b30eace18c02"
+checksum = "84cc52c7ac2e3901aaf1b23311ee329b7509c9dd483cc6e59ed70b079ec9c78e"
 dependencies = [
  "bzip2",
  "chrono",
@@ -1386,6 +1386,7 @@ dependencies = [
  "memmap2",
  "petgraph",
  "postcard",
+ "pulldown-cmark",
  "rayon",
  "regex",
  "rstar 0.13.0",
@@ -1404,11 +1405,12 @@ dependencies = [
 
 [[package]]
 name = "kglite-mcp-server"
-version = "0.17.6"
+version = "0.17.9"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6f2d4f097da41a62ee5b6ea67fd983ab576ee33dd69656a88de9f97269132f22"
+checksum = "ffd62a6af8cb4f07b89375612a04c4a71adf525d5054597c466824586a49360a"
 dependencies = [
  "anyhow",
+ "base64 0.22.1",
  "bytes",
  "chrono",
  "clap",
@@ -1510,9 +1512,9 @@ dependencies = [
 
 [[package]]
 name = "mcp-methods"
-version = "0.4.11"
+version = "0.4.12"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "31c5a17334897b67053e843235be8c66610d0c6684c845bea30e70ecff9dd204"
+checksum = "5bcc5fdac2ffd82893fbc640b569785bdc63ead7f3c6c3d695685b692ddf2d1a"
 dependencies = [
  "anyhow",
  "clap",
@@ -1742,6 +1744,17 @@ dependencies = [
  "cc",
 ]
 
+[[package]]
+name = "pulldown-cmark"
+version = "0.13.4"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "e9f068eba8e7071c5f9511831b44f32c740d5adf574e990f946ddb53db2f314e"
+dependencies = [
+ "bitflags",
+ "memchr",
+ "unicase",
+]
+
 [[package]]
 name = "pyo3"
 version = "0.29.0"
@@ -2792,6 +2805,12 @@ version = "1.20.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "b6f5e870be6c3b371b77fe0ee0bafb859fa4964b4404c27de1d380043c4dda20"
 
+[[package]]
+name = "unicase"
+version = "2.9.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "dbc4bc3a9f746d862c45cb89d705aa10f187bb96c76001afab07a0d35ce60142"
+
 [[package]]
 name = "unicode-ident"
 version = "1.0.24"

{codingest-0.2.22 → codingest-0.2.24}/Cargo.toml

@@ -3,7 +3,7 @@ members = ["crates/codingest", "crates/codingest-cli", "crates/codingest-mcp", "
 resolver = "2"
 
 [workspace.package]
-version = "0.2.22"
+version = "0.2.24"
 edition = "2021"
 rust-version = "1.88"
 license = "MIT"
@@ -12,12 +12,72 @@ repository = "https://github.com/kkollsga/codingest"
 [workspace.dependencies]
 base64 = "0.22"
 sha2 = "0.11"
-# kglite engine + MCP server — imported as crates.io libraries. The 0.17.6
+# kglite engine + MCP server — imported as crates.io libraries. The 0.17.9
+# floor covers two same-day releases, 0.17.8 (the Obsidian vault format) and
+# 0.17.9 (the vault structure profile). Both land almost entirely on
+# `dialect="obsidian"`, which codingest never selects — but they rebuilt the
+# `kglite::okf` *type* surface underneath our docs pass, so this is the first
+# kglite bump since 0.16.x that needs a source change:
+#   * `okf::BuildOptions` gained `profile` (a `Profile` the parser reads for
+#     its conventions) and lost `embed` (a field the loader never read — it
+#     embedded nothing in any dialect, so removing it changes no behaviour),
+#     and `okf::walk::DiscoveredFile` gained `size` / `mtime`. Our docs pass
+#     built both as exhaustive struct literals. `BuildOptions` is now
+#     constructed through `BuildOptions::for_dialect(Dialect::Okf)` with only
+#     the two fields we deliberately differ on overridden — a `Profile` cannot
+#     be a struct literal outside kglite any more, and `for_dialect` is the
+#     constructor that keeps a future field at its dialect default instead of
+#     failing the build a third time. `size`/`mtime` are `0`/`None`: they feed
+#     only `okf::fingerprint` and the vault's attachment nodes, and
+#     `parse_concepts` — the one entry point we call — reads neither.
+#   * The rest of the breaking set does not reach us: `okf::build` now returns
+#     `BuildOutput { graph, report }`, `links::extract_links` and
+#     `walk::discover` take the options/profile instead of a `Dialect` /
+#     `skip_dirs` slice, `Dialect` gained `Obsidian`, `Link` lost
+#     `is_wikilink`, and `ExportOptions` / `ExportReport` gained
+#     `edge_tables` / `warnings`. codingest calls none of them (grep: zero
+#     hits outside `docs/mod.rs`) — we use `okf::parse_concepts` and nothing
+#     else, and we read only `concept_id` / `file_path` / `title` / `body` /
+#     `props` off each `ConceptDoc`, never its links.
+#   * Behaviour under `Dialect::Okf` is the old behaviour by construction:
+#     `Profile::default()` is the OKF-bundle profile with every vault feature
+#     (wikilinks, embeds, inline tags, frontmatter edges, aliases, folder
+#     notes, attachments, `structure:`) off, which is what the parser hardcoded
+#     before. The one 0.17.8 parser fix that is dialect-independent and lands
+#     on a value we store is the heading rule: a line starting with `#` is a
+#     heading only when one to six `#` are followed by a space, a tab, or the
+#     line end, so an inline-tag line like `#project see …` is no longer read
+#     as an `# H1`. That feeds our `:Doc` title fallback. The 31 frozen
+#     goldens are the gate on it, and they are byte-identical across this move.
+#   * kglite-mcp-server: `--vault` mode and the vault-authoring skill are new
+#     surface we do not register, and the bundled skill set is now gated by
+#     graph shape — the four code-graph skills bundle only where the graph
+#     carries `Function` / `Class`, which is exactly a codingest graph, so the
+#     skills an agent reaches through `codingest-mcp` are unchanged while a
+#     document deployment stops paying for ours. Our producer layer
+#     (`ServerExtensions::with_skills` / `with_recipes`) is untouched.
+# The preceding 0.17.7
+# floor adds the producer-level methodology hook codingest asked for on
+# 2026-09-16: `ServerExtensions::with_skills` / `with_recipes` let the binary
+# embedding the server register its own skill layer and Cypher recipe
+# catalogue once, applying to every graph it serves in EVERY mode — including
+# codingest-mcp's manifest-less workspace boot, where graph-carried records
+# are never read. Precedence `bundled < producer < graph < operator`; with no
+# manifest, or one that never mentions `skills:`, the server serves the
+# bundled set plus the producer layer, and an explicit `skills: false`
+# silences both. A producer record that fails validation fails the boot
+# naming itself. 0.17.7 also revives the bundled predicate-gated code-graph
+# skills, which were dead in every workspace deployment (no graph at boot,
+# never re-evaluated): they now activate on the first `set_root_dir`.
+# codingest-mcp registers the code-review skill and recipe corpus through
+# these builders (`crates/codingest-mcp/src/lib.rs`).
+# The preceding 0.17.6
 # floor is the graph-carried skills and recipes release. `kglite::api::skills`
-# and `kglite::api::recipes` are new and uncalled here: their `KgliteSkill` /
+# and `kglite::api::recipes` arrived here: their `KgliteSkill` /
 # `KgliteRecipe` records are system labels, hidden from every type enumeration,
 # so a codingest graph reports the same `node_types()` / `describe()` as before
-# and every golden digest is unchanged. What reaches users is in the embedded
+# and every golden digest is unchanged (codingest writes them only behind the
+# opt-in `codingest build --embed-skills`). What reaches users is in the embedded
 # `codingest-mcp` server, and only when an operator manifest turns `skills:`
 # on: methodology skills are now delivered lazily (mcp-methods 0.4.11 — a
 # skill contributes its when-to-use paragraph to the tools it references and
@@ -530,8 +590,8 @@ sha2 = "0.11"
 # and no disk storage. Neither 0.15.7 nor 0.15.8 changes the `kglite::api` we
 # call, graph output, property encoding, or `.kgl` serialization.
 # Keep both libraries aligned so the graph and server share one engine release.
-kglite = { version = "0.17.6", default-features = false }
-kglite-mcp-server = { version = "0.17.6", default-features = false }
+kglite = { version = "0.17.9", default-features = false }
+kglite-mcp-server = { version = "0.17.9", default-features = false }
 
 # Dependency debuginfo capped at line tables (kglite coordination, 2026-08-31,
 # after unbounded debug trees filled the build-cache disk to zero): a

{codingest-0.2.22 → codingest-0.2.24}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: codingest
-Version: 0.2.22
+Version: 0.2.24
 Classifier: Development Status :: 3 - Alpha
 Classifier: Intended Audience :: Developers
 Classifier: Programming Language :: Python :: 3
@@ -12,7 +12,7 @@ Classifier: Programming Language :: Python :: 3.14
 Classifier: Programming Language :: Rust
 Classifier: Topic :: Software Development
 Classifier: Topic :: Software Development :: Libraries
-Requires-Dist: kglite>=0.17.6,<0.18
+Requires-Dist: kglite>=0.17.9,<0.18
 License-File: LICENSE
 Summary: Build fast, queryable code graphs for AI agents, MCP code review, and local or GitHub repository analysis.
 Keywords: ai-agents,mcp,code-review,knowledge-graph,code-analysis,github,tree-sitter,cypher
@@ -59,7 +59,9 @@ a real `kglite.KnowledgeGraph`, ready for Cypher queries.
 ## Built for agents and code analysis
 
 - **Agent-ready MCP:** give an MCP client `graph_overview`, `cypher_query`,
-  `read_code_source`, repository switching, and automatic graph refresh.
+  `read_code_source`, repository switching, automatic graph refresh, and the
+  code-review methodology itself — a `code_review` skill and a catalogue of
+  parameter-checked review recipes (`run_recipe_query`) served for every graph.
   [opencode is set up and verified end to end](https://codingest.readthedocs.io/en/latest/mcp.html#using-codingest-mcp-with-opencode)
   — including a config that needs no absolute paths — and `codingest skill
   install` packages the review skill for Claude Code and Codex, which opencode
@@ -192,7 +194,7 @@ codingest skill install        # code-review Agent Skill
 ```
 
 The wheel bundles every grammar plus the `codingest` and `codingest-mcp`
-commands. KGLite ≥0.17.6 is installed automatically as the query/storage
+commands. KGLite ≥0.17.9 is installed automatically as the query/storage
 engine; its MCP server and the transitive `mcp-methods` framework power the
 builder-aware Codingest server. Nothing else needs to be installed.
 
@@ -205,7 +207,7 @@ Python prerequisites.
 ```toml
 [dependencies]
 codingest = "0.2"
-kglite = "0.17.6"
+kglite = "0.17.9"
 ```
 
 ```rust
@@ -237,7 +239,7 @@ Documentation: **[codingest.readthedocs.io](https://codingest.readthedocs.io)**
 |---|---|
 | `crates/codingest` | The component library (`codingest`): builder, parsers, manifest reader, docs pass, multi-rev merge, cross-language edges. Extracted from the former `KGLite/crates/kglite/src/code_tree/` (removed upstream 2026-07-16) and re-targeted at the public `kglite::api` facade. Ships the `codingest_stats` + `codingest_bench` binaries. |
 | `crates/codingest-cli` | `codingest` binary — `build` a checkout or git revision(s) into a `.kgl` graph, `status` to check staleness, and `skill` to install Codingest's code-review Agent Skill. |
-| `crates/codingest-mcp` | `codingest-mcp` binary — the full MCP tool surface imported from the `kglite-mcp-server` library, with the codingest builder injected. |
+| `crates/codingest-mcp` | `codingest-mcp` binary — the full MCP tool surface imported from the `kglite-mcp-server` library, with the codingest builder injected and codingest's `code_review` skill + recipe catalogue registered as the producer's methodology. |
 | `crates/codingest-py` | PyO3 wrapper built by maturin into the `codingest` wheel (`pip install codingest`). Python package source is `codingest/`; `pyproject.toml` drives the maturin build. Not published to crates.io (`publish = false`). |
 
 ## CI-equivalent local gate
@@ -277,7 +279,7 @@ diagnostic.
 ## Dependency policy
 
 `kglite` and `kglite-mcp-server` use matching crates.io requirements with a
-0.17.6 minimum and a shared lockfile. This keeps the builder, persistence
+0.17.9 minimum and a shared lockfile. This keeps the builder, persistence
 handoff, and embedded MCP server on one compatible engine patch line.
 
 ## Parity with the (now-removed) in-tree component

{codingest-0.2.22 → codingest-0.2.24}/README.md

@@ -32,7 +32,9 @@ a real `kglite.KnowledgeGraph`, ready for Cypher queries.
 ## Built for agents and code analysis
 
 - **Agent-ready MCP:** give an MCP client `graph_overview`, `cypher_query`,
-  `read_code_source`, repository switching, and automatic graph refresh.
+  `read_code_source`, repository switching, automatic graph refresh, and the
+  code-review methodology itself — a `code_review` skill and a catalogue of
+  parameter-checked review recipes (`run_recipe_query`) served for every graph.
   [opencode is set up and verified end to end](https://codingest.readthedocs.io/en/latest/mcp.html#using-codingest-mcp-with-opencode)
   — including a config that needs no absolute paths — and `codingest skill
   install` packages the review skill for Claude Code and Codex, which opencode
@@ -165,7 +167,7 @@ codingest skill install        # code-review Agent Skill
 ```
 
 The wheel bundles every grammar plus the `codingest` and `codingest-mcp`
-commands. KGLite ≥0.17.6 is installed automatically as the query/storage
+commands. KGLite ≥0.17.9 is installed automatically as the query/storage
 engine; its MCP server and the transitive `mcp-methods` framework power the
 builder-aware Codingest server. Nothing else needs to be installed.
 
@@ -178,7 +180,7 @@ Python prerequisites.
 ```toml
 [dependencies]
 codingest = "0.2"
-kglite = "0.17.6"
+kglite = "0.17.9"
 ```
 
 ```rust
@@ -210,7 +212,7 @@ Documentation: **[codingest.readthedocs.io](https://codingest.readthedocs.io)**
 |---|---|
 | `crates/codingest` | The component library (`codingest`): builder, parsers, manifest reader, docs pass, multi-rev merge, cross-language edges. Extracted from the former `KGLite/crates/kglite/src/code_tree/` (removed upstream 2026-07-16) and re-targeted at the public `kglite::api` facade. Ships the `codingest_stats` + `codingest_bench` binaries. |
 | `crates/codingest-cli` | `codingest` binary — `build` a checkout or git revision(s) into a `.kgl` graph, `status` to check staleness, and `skill` to install Codingest's code-review Agent Skill. |
-| `crates/codingest-mcp` | `codingest-mcp` binary — the full MCP tool surface imported from the `kglite-mcp-server` library, with the codingest builder injected. |
+| `crates/codingest-mcp` | `codingest-mcp` binary — the full MCP tool surface imported from the `kglite-mcp-server` library, with the codingest builder injected and codingest's `code_review` skill + recipe catalogue registered as the producer's methodology. |
 | `crates/codingest-py` | PyO3 wrapper built by maturin into the `codingest` wheel (`pip install codingest`). Python package source is `codingest/`; `pyproject.toml` drives the maturin build. Not published to crates.io (`publish = false`). |
 
 ## CI-equivalent local gate
@@ -250,7 +252,7 @@ diagnostic.
 ## Dependency policy
 
 `kglite` and `kglite-mcp-server` use matching crates.io requirements with a
-0.17.6 minimum and a shared lockfile. This keeps the builder, persistence
+0.17.9 minimum and a shared lockfile. This keeps the builder, persistence
 handoff, and embedded MCP server on one compatible engine patch line.
 
 ## Parity with the (now-removed) in-tree component

{codingest-0.2.22 → codingest-0.2.24}/codingest/__init__.pyi

@@ -23,6 +23,7 @@ def build(
     rev: Optional[str] = None,
     revs: Optional[list[str]] = None,
     repo_root: Optional[str] = None,
+    embed_skills: bool = False,
 ) -> KnowledgeGraph:
     """Parse a codebase at ``src_dir`` into a :class:`kglite.KnowledgeGraph`.
 
@@ -70,6 +71,12 @@ def build(
         include_tests: Include test files/dirs in the graph (default True).
         max_loc_per_file: Skip files longer than this many lines (None = no cap).
         include_docs: Ingest markdown as ``:Doc`` nodes (see above).
+        embed_skills: Also write codingest's ``code_review`` skill and its
+            recipe catalogue into the graph as graph-carried records
+            (``KgliteSkill`` / ``KgliteRecipe``), for a ``.kgl`` served by a
+            plain ``kglite-mcp-server --graph``. Off by default: the default
+            graph is byte-identical to earlier releases, and ``codingest-mcp``
+            serves the methodology by itself. ``repo_tree`` never embeds.
         rev: A single git revspec to build (mutually exclusive with ``revs``).
         revs: A list of git revspecs to merge into a multi-rev graph.
         repo_root: Override the auto-resolved git root for ``rev``/``revs``.

{codingest-0.2.22 → codingest-0.2.24}/crates/codingest/Cargo.toml

@@ -10,7 +10,7 @@ keywords = ["knowledge-graph", "code-analysis", "tree-sitter", "cypher", "kglite
 categories = ["development-tools", "parser-implementations"]
 
 # Requires the kglite 0.15 engine API (`kglite::api::code_entities`); the
-# workspace pins the current engine floor (0.17.6).
+# workspace pins the current engine floor (0.17.9).
 
 [lib]
 name = "codingest"

codingest-0.2.24/crates/codingest/assets/code_review/recipes.json

@@ -0,0 +1,97 @@
+{
+  "code_review": {
+    "description": "Exact, parameter-checked operations for reviewing a change to a codingest code graph: resolve targets, count and page callers, walk callees, witness bounded call paths, and find type consumers and trait implementors.",
+    "queries": {
+      "target_coverage": {
+        "description": "For each requested qualified name: whether the Function exists (target is null when missing) and how many Functions call it (callers is zero for an existing target with no callers). Run this before reading any empty result as an absence.",
+        "parameters": {
+          "type": "object",
+          "properties": {
+            "requested": {
+              "type": "array",
+              "items": { "type": "string" },
+              "description": "Exact Function qualified names to resolve."
+            }
+          },
+          "required": ["requested"],
+          "additionalProperties": false
+        },
+        "cypher": "UNWIND $requested AS requested OPTIONAL MATCH (target:Function {qualified_name: requested}) OPTIONAL MATCH (caller:Function)-[:CALLS]->(target) RETURN requested, target.qualified_name AS target, count(caller) AS callers ORDER BY requested"
+      },
+      "caller_coverage": {
+        "description": "Caller counts of one Function split by whether the caller is a test (is_test), so production and test pages can be requested separately with callers_page.",
+        "parameters": {
+          "type": "object",
+          "properties": {
+            "qualified_name": { "type": "string", "description": "Exact Function qualified name." }
+          },
+          "required": ["qualified_name"],
+          "additionalProperties": false
+        },
+        "cypher": "MATCH (caller:Function)-[:CALLS]->(target:Function) WHERE target.qualified_name = $qualified_name RETURN target.qualified_name AS target, caller.is_test AS is_test, count(caller) AS callers ORDER BY is_test"
+      },
+      "callers_page": {
+        "description": "One page (25 rows) of direct callers of a Function, production (is_test false) or test (is_test true), with each caller's location and the evidence behind the CALLS edge: resolution, candidates (>1 means the call site fanned out), import_backed (false is unconfirmed, not refuted) and call_lines.",
+        "parameters": {
+          "type": "object",
+          "properties": {
+            "qualified_name": { "type": "string", "description": "Exact Function qualified name of the callee." },
+            "is_test": { "type": "boolean", "description": "true for test callers, false for production callers." }
+          },
+          "required": ["is_test", "qualified_name"],
+          "additionalProperties": false
+        },
+        "cypher": "MATCH (caller:Function)-[rel:CALLS]->(target:Function) WHERE target.qualified_name = $qualified_name AND caller.is_test = $is_test RETURN target.qualified_name AS target, caller.qualified_name AS caller, caller.file_path AS file, caller.line_number AS line, rel.resolution AS resolution, rel.candidates AS candidates, rel.import_backed AS import_backed, rel.call_lines AS call_lines ORDER BY caller, file, line LIMIT 25"
+      },
+      "direct_callees": {
+        "description": "Up to 25 Functions a Function calls directly, with both locations and the CALLS edge evidence (resolution, candidates, import_backed, call_lines). An unresolved source call has no CALLS edge; inspect the source before concluding a call is absent.",
+        "parameters": {
+          "type": "object",
+          "properties": {
+            "qualified_name": { "type": "string", "description": "Exact Function qualified name of the caller." }
+          },
+          "required": ["qualified_name"],
+          "additionalProperties": false
+        },
+        "cypher": "MATCH (caller:Function)-[rel:CALLS]->(callee:Function) WHERE caller.qualified_name = $qualified_name RETURN caller.qualified_name AS caller, callee.qualified_name AS callee, caller.file_path AS caller_file, caller.line_number AS caller_line, callee.file_path AS callee_file, callee.line_number AS callee_line, rel.resolution AS resolution, rel.candidates AS candidates, rel.import_backed AS import_backed, rel.call_lines AS call_lines ORDER BY callee, callee_file, callee_line LIMIT 25"
+      },
+      "bounded_call_path": {
+        "description": "Up to ten CALLS paths of one to four hops from one Function to another, shortest first: bounded path witnesses instead of an unbounded neighbourhood.",
+        "parameters": {
+          "type": "object",
+          "properties": {
+            "start": { "type": "string", "description": "Exact qualified name of the starting Function." },
+            "finish": { "type": "string", "description": "Exact qualified name of the Function to reach." }
+          },
+          "required": ["finish", "start"],
+          "additionalProperties": false
+        },
+        "cypher": "MATCH path = (start:Function)-[:CALLS*1..4]->(finish:Function) WHERE start.qualified_name = $start AND finish.qualified_name = $finish RETURN [step IN nodes(path) | step.qualified_name] AS functions, length(path) AS hops ORDER BY hops, functions LIMIT 10"
+      },
+      "type_consumers": {
+        "description": "Up to 25 Functions that take a Struct as an explicit parameter (position parameter or both, since one USES_TYPE edge aggregates a type used as both parameter and return value), with each consumer's location.",
+        "parameters": {
+          "type": "object",
+          "properties": {
+            "qualified_name": { "type": "string", "description": "Exact Struct qualified name." }
+          },
+          "required": ["qualified_name"],
+          "additionalProperties": false
+        },
+        "cypher": "MATCH (consumer:Function)-[use:USES_TYPE]->(used:Struct) WHERE used.qualified_name = $qualified_name AND use.position IN ['parameter', 'both'] RETURN used.qualified_name AS used_type, consumer.qualified_name AS consumer, consumer.file_path AS file, consumer.line_number AS line, use.position AS position ORDER BY consumer, file, line LIMIT 25"
+      },
+      "trait_implementations": {
+        "description": "Up to 25 Structs with an IMPLEMENTS edge to a Trait, with each implementor's location. Macro-generated or heuristic structure may be absent from the graph: a missing edge is a reason to inspect source, not proof of no implementation.",
+        "parameters": {
+          "type": "object",
+          "properties": {
+            "qualified_name": { "type": "string", "description": "Exact Trait qualified name." }
+          },
+          "required": ["qualified_name"],
+          "additionalProperties": false
+        },
+        "cypher": "MATCH (implementor:Struct)-[:IMPLEMENTS]->(implemented:Trait) WHERE implemented.qualified_name = $qualified_name RETURN implemented.qualified_name AS trait, implementor.qualified_name AS implementor, implementor.file_path AS file, implementor.line_number AS line ORDER BY implementor, file, line LIMIT 25"
+      }
+    }
+  }
+}

codingest-0.2.24/crates/codingest/assets/code_review/skill.md

@@ -0,0 +1,70 @@
+# Reviewing a codingest code graph
+
+codingest built every graph this server serves, so the shapes are fixed:
+`Function`, `Struct`, `Class`, `Trait`, `Interface`, `Protocol`, `Enum`,
+`Module`, `File`, `Doc` nodes keyed by `qualified_name`; `CALLS`,
+`USES_TYPE`, `IMPLEMENTS`, `EXTENDS`, `HAS_METHOD`, `IMPORTS`, `DEFINES`,
+`HAS_FILE` edges. Functions carry `file_path`, `line_number`, `is_test`.
+The graph is structural evidence beside the diff and the source; use it
+only as far as the question requires.
+
+## Sequence
+
+1. **Resolve targets first** with `run_recipe_query("code_review",
+   "target_coverage", {"requested": [...]})`. A null `target` means the name is
+   not in this graph (typo, macro-generated, other revision); `callers` of zero
+   for an existing target is a real absence. Never read an empty result as an
+   absence until the target has resolved.
+2. **Count before paging.** `caller_coverage` splits one target's callers into
+   production and test counts. One target per call: a shared page can fill
+   with one target and hide another.
+3. **Page callers by kind.** `callers_page` with `is_test: false` gives the
+   production callers, `is_test: true` the tests that would notice, 25 at a
+   time with file and line. Each row carries the `CALLS` edge's evidence:
+   `resolution`, `candidates` (>1 = the call site fanned out), `import_backed`
+   (false is unconfirmed, not refuted) and `call_lines`.
+4. **Walk the other way** with `direct_callees`, same evidence columns. An
+   unresolved source call has no `CALLS` edge at all, so read the source before
+   concluding a call is absent.
+5. **Witness reachability, do not explore it.** `bounded_call_path` returns up
+   to ten paths of at most four hops between two resolved functions.
+6. **Type and trait impact.** `type_consumers` lists functions taking a struct
+   as an explicit parameter; `trait_implementations` lists structs with an
+   `IMPLEMENTS` edge to a trait. Macro-generated or heuristic structure may be
+   missing, so a missing edge is a reason to read source.
+7. **Read the selected source** with `read_code_source` (qualified name) or
+   `read_source` (path), bounded by `start_line` / `end_line`.
+8. **Use `cypher_query` only for a question no recipe shapes** — imports,
+   module structure, docs links, `CALL rev_diff({from, to})` on a multi-rev
+   graph — and check the shape with `graph_overview` first.
+
+## Recipes served for this graph
+
+- `code_review/target_coverage` — existence plus caller count, for a list of names.
+- `code_review/caller_coverage` — production versus test caller counts for one target.
+- `code_review/callers_page` — direct callers of one kind, 25 at a time, with edge evidence.
+- `code_review/direct_callees` — what one function calls, 25 at a time, with edge evidence.
+- `code_review/bounded_call_path` — up to ten paths of at most four hops between two functions.
+- `code_review/type_consumers` — functions taking a struct as an explicit parameter.
+- `code_review/trait_implementations` — structs implementing a trait.
+
+For a diff-scoped review, start from the functions whose `file_path` the
+diff touched, resolve them, then run steps 2 to 4 on each.
+
+## Reading results
+
+A page is complete only up to its literal size (25 rows, 10 paths); a full
+page proves nothing about other targets or edges the builder never emitted.
+Follow a retained result's advertised expansion; expansion cannot recover
+rows a `LIMIT` excluded — narrow the target instead. A warning about an
+unknown property or reversed relationship means the query shape is wrong, not
+that the result is empty.
+
+## Findings and honesty
+
+A finding names a concrete failure — the input or state and the wrong outcome
+— verified against exact source lines at the reviewed revision. "No findings"
+is a valid review; design preferences are not findings, and an edge showing
+coupling is a fact, not a defect. Never invent labels, properties, edge types
+or recipe names; a missing edge is absence of evidence, not proof of absence;
+never build or execute a repository's code merely to review it.

{codingest-0.2.22 → codingest-0.2.24}/crates/codingest/src/docs/mod.rs

@@ -249,20 +249,29 @@ fn discover_and_parse(root: &Path) -> Result<Vec<DocEntry>, String> {
     // computes titles from frontmatter / first heading, honors `kg_skip`,
     // flattens frontmatter). We bypass `okf::walk` so `.rst` shares one traversal and so
     // `index.md` is kept (the docs pass builds no Folder hierarchy).
+    // `for_dialect` rather than a struct literal: it carries the dialect's
+    // `Profile` (the conventions the parser reads — id scheme, reserved keys,
+    // wikilinks, collection encoding), which a literal cannot construct from
+    // outside kglite and which a bare `dialect:` assignment would leave at the
+    // wrong dialect's defaults. Only the two fields the docs pass deliberately
+    // differs on are overridden: every `.md` is admitted (a repo's docs carry
+    // no frontmatter) and the body is stored (the `:Doc` node's prose).
     let md_opts = okf::BuildOptions {
-        dialect: okf::Dialect::Okf,
         require_frontmatter: false,
-        respect_skip: true,
-        skip_dirs: Vec::new(),
         with_body: true,
-        embed: false,
+        ..okf::BuildOptions::for_dialect(okf::Dialect::Okf)
     };
+    // `size` / `mtime` feed only `okf::fingerprint` and the attachment nodes,
+    // neither of which the docs pass reaches — `parse_concepts` reads nothing
+    // but the two paths — so the walk does not stat a second time to fill them.
     let md_files: Vec<okf::walk::DiscoveredFile> = found
         .iter()
         .filter(|d| d.format == DocFormat::Markdown)
         .map(|d| okf::walk::DiscoveredFile {
             rel_path: d.rel_path.clone(),
             abs_path: d.abs_path.clone(),
+            size: 0,
+            mtime: None,
         })
         .collect();
     let mut docs: Vec<DocEntry> = okf::parse_concepts(&md_files, &md_opts)

{codingest-0.2.22 → codingest-0.2.24}/crates/codingest/src/lib.rs

@@ -23,6 +23,7 @@ pub mod cross_lang;
 #[cfg(feature = "docs")]
 pub mod docs;
 pub mod manifest;
+pub mod methodology;
 pub mod models;
 pub mod parsers;
 pub mod repo;