code-sandboxes 1.9.1__tar.gz → 1.9.2__tar.gz

{code_sandboxes-1.9.1 → code_sandboxes-1.9.2}/CHANGELOG.md

@@ -8,6 +8,20 @@
 
 ## Unreleased
 
+## 1.9.2
+
+- **A real ECR repository name is lowercase; a real owner uid is not**
+  (`environments.adapters.datalayer.owner_repository`, new
+  `owner_cache_repository`; PLAN_ENV.md E1-07). Found live, 2026-09-14, the
+  first real Datalayer build ever run for a real account's own uid rather
+  than a lowercase test fixture: `DescribeRepositories` refused outright,
+  "Invalid parameter at 'repositoryName'" — this project's own uids are
+  ULIDs, conventionally uppercase, and ECR repository names match
+  `[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*` per path segment. Both the owner's own
+  repository and the owner's cache repository are lowered at the one place
+  each is built, so every caller (create, inspect, exists, delete, the
+  cache import/export) stays consistent with itself.
+
 ## 1.9.1
 
 - **mTLS to the build pool's `buildkitd`** (`environments.adapters.datalayer.Builder`,

{code_sandboxes-1.9.1 → code_sandboxes-1.9.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: code_sandboxes
-Version: 1.9.1
+Version: 1.9.2
 Project-URL: Home, https://github.com/datalayer/code-sandboxes
 Author-email: Datalayer <info@datalayer.io>
 License: BSD 3-Clause License

{code_sandboxes-1.9.1 → code_sandboxes-1.9.2}/code_sandboxes/__version__.py

@@ -3,4 +3,4 @@
 
 """Code Sandboxes."""
 
-__version__ = "1.9.1"
+__version__ = "1.9.2"

{code_sandboxes-1.9.1 → code_sandboxes-1.9.2}/code_sandboxes/environments/adapters/datalayer.py

@@ -71,7 +71,12 @@ from ..files import files_step
 from ..resolve import WHEELHOUSE_IMAGE_PATH, WHEELHOUSE_PATH, apt_pins_in, locked_versions
 from ..spec import BuildSecret, Environment
 
-__all__ = ["ECR_ENVIRONMENT_PREFIX", "Builder", "owner_repository"]
+__all__ = [
+    "ECR_ENVIRONMENT_PREFIX",
+    "Builder",
+    "owner_cache_repository",
+    "owner_repository",
+]
 
 #: Where an owner's environments live in ECR (D-10).
 ECR_ENVIRONMENT_PREFIX = "environments/u/"
@@ -89,10 +94,32 @@ DEFAULT_MAX_ARTIFACT_BYTES = 20 * 1024**3
 
 
 def owner_repository(owner_uid: str, environment_name: str) -> str:
-    """The owner's repository for one environment: ``environments/u/<owner>/<name>``."""
+    """The owner's repository for one environment: ``environments/u/<owner>/<name>``.
+
+    Lowercased: an ECR repository name matches
+    ``[a-z0-9]+((\\.|_|__|-+)[a-z0-9]+)*`` per path segment, and this
+    project's own uids are ULIDs, conventionally uppercase — found live,
+    2026-09-14, the first real build ever run for a real account's own
+    uid rather than a lowercase test fixture: ``DescribeRepositories``
+    refused it outright, "Invalid parameter at 'repositoryName'". Lowering
+    both segments here, the one place this reference is built, keeps every
+    caller (create, inspect, exists, delete) consistent with itself without
+    each needing to remember to.
+    """
     if not owner_uid or not environment_name:
         raise ValueError("an owner and an environment name make the repository")
-    return f"{ECR_ENVIRONMENT_PREFIX}{owner_uid}/{environment_name}"
+    return f"{ECR_ENVIRONMENT_PREFIX}{owner_uid}/{environment_name}".lower()
+
+
+def owner_cache_repository(owner_uid: str) -> str:
+    """The owner's own BuildKit cache repository: ``environments/cache/u/<owner>``.
+
+    Lowercased for the same reason ``owner_repository`` is (a ULID, not a
+    lowercase test fixture, is what a real build actually names).
+    """
+    if not owner_uid:
+        raise ValueError("an owner makes the cache repository")
+    return f"environments/cache/u/{owner_uid}".lower()
 
 
 def _secret_mount(secret: BuildSecret) -> str:
@@ -374,7 +401,7 @@ class Builder:
         repository = owner_repository(request.owner_uid, request.environment.metadata.name)
         registry = self._registry_host()
         self._ensure_repository(repository)
-        self._ensure_cache_repository(f"environments/cache/u/{request.owner_uid}")
+        self._ensure_cache_repository(owner_cache_repository(request.owner_uid))
         tag = f"v{request.version}-{request.build_uid}"
         reference = f"{registry}/{repository}:{tag}"
         with tempfile.TemporaryDirectory(prefix="dl-build-") as directory:
@@ -637,7 +664,7 @@ class Builder:
     def _cache_options(self, request: BuildRequest) -> list[str]:
         """The owner's cache, imported and exported: never another owner's (D-12)."""
         registry = self._registry_host()
-        cache = f"{registry}/environments/cache/u/{request.owner_uid}:{self.variant}"
+        cache = f"{registry}/{owner_cache_repository(request.owner_uid)}:{self.variant}"
         return [
             "--import-cache",
             f"type=registry,ref={cache}",

{code_sandboxes-1.9.1 → code_sandboxes-1.9.2}/tests/test_environment_datalayer_builder.py

@@ -19,7 +19,11 @@ from pathlib import Path
 
 import pytest
 
-from code_sandboxes.environments.adapters.datalayer import Builder, owner_repository
+from code_sandboxes.environments.adapters.datalayer import (
+    Builder,
+    owner_cache_repository,
+    owner_repository,
+)
 from code_sandboxes.environments.builders import ArtifactReference, BuildRequest
 from code_sandboxes.environments.errors import EnvironmentsError
 from code_sandboxes.environments.spec import parse_environment
@@ -565,6 +569,24 @@ class TestBuildingAndPushing:
         a_builder(run=Buildctl(), ecr=ecr).build(a_request())
         assert ecr.created == []
 
+    def test_a_real_uppercase_ulid_owner_still_names_a_valid_ecr_repository(self) -> None:
+        """Found live, 2026-09-14: the first real build for a real account's
+        own uid, not a lowercase test fixture. ECR repository names match
+        ``[a-z0-9]+((\\.|_|__|-+)[a-z0-9]+)*`` per segment; this project's own
+        uids are ULIDs, conventionally uppercase — `DescribeRepositories`
+        refused the request outright before this fix."""
+        ulid_owner = "01JV1VE1T5VG22Z05F6EFBMW8E"
+        ecr = FakeEcr()
+        a_builder(run=Buildctl(), ecr=ecr).build(a_request(owner_uid=ulid_owner))
+        names = [item["repositoryName"] for item in ecr.created]
+        assert names, "the build should have created at least the owner's own repository"
+        for name in names:
+            assert name == name.lower(), f"{name!r} is not a valid ECR repository name"
+        assert owner_repository(ulid_owner, "geospatial-analysis") == (
+            f"environments/u/{ulid_owner.lower()}/geospatial-analysis"
+        )
+        assert owner_cache_repository(ulid_owner) == f"environments/cache/u/{ulid_owner.lower()}"
+
     def test_the_credential_reaches_buildctl_and_not_the_workers_own_config(self) -> None:
         seen: dict[str, object] = {}