code-review-ai-cli 2.2.0__tar.gz → 2.2.2__tar.gz

{code_review_ai_cli-2.2.0 → code_review_ai_cli-2.2.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-review-ai-cli
-Version: 2.2.0
+Version: 2.2.2
 Summary: Automated AI-powered code review CLI for Azure DevOps / TFS Pull Requests
 License: MIT
 Keywords: code-review,ai,azure-devops,tfs,pull-request,llm

{code_review_ai_cli-2.2.0 → code_review_ai_cli-2.2.2}/code_review_ai_cli.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-review-ai-cli
-Version: 2.2.0
+Version: 2.2.2
 Summary: Automated AI-powered code review CLI for Azure DevOps / TFS Pull Requests
 License: MIT
 Keywords: code-review,ai,azure-devops,tfs,pull-request,llm

{code_review_ai_cli-2.2.0 → code_review_ai_cli-2.2.2}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "code-review-ai-cli"
-version = "2.2.0"
+version = "2.2.2"
 description = "Automated AI-powered code review CLI for Azure DevOps / TFS Pull Requests"
 readme = "README.md"
 requires-python = ">=3.10"

{code_review_ai_cli-2.2.0 → code_review_ai_cli-2.2.2}/src/tfs_client.py

@@ -290,13 +290,16 @@ class TFSClient:
 
         files = []
         for change in changes.get("changeEntries", []):
-            item = change.get("item", {})
+            # `item` can be null for deleted files; use `or {}` as a safe fallback.
+            item = change.get("item") or {}
             if item.get("isFolder"):
                 continue
+            # `path` can be null for deleted files; fall back to `originalPath`.
+            path = item.get("path") or change.get("originalPath") or ""
             files.append({
-                "path": item.get("path", ""),
+                "path": path,
                 "change_type": change.get("changeType", "unknown"),
-                "original_path": change.get("originalPath", ""),
+                "original_path": change.get("originalPath") or path,
             })
         return files
 
@@ -339,8 +342,7 @@ class TFSClient:
             Diff as text, ready to be passed to the LLM client.
 
         Raises:
-            TFSError: If the PR has no iterations or contains no file changes
-                after filtering.
+            TFSError: If the PR has no iterations.
         """
         # Get PR details
         path = f"git/repositories/{repository}/pullrequests/{pr_id}"
@@ -377,14 +379,22 @@ class TFSClient:
         # Build diff from the changes
         diff_parts = []
         for change in changes.get("changeEntries", []):
-            item = change.get("item", {})
+            # `item` can be null for deleted files; use `or {}` as a safe fallback.
+            item = change.get("item") or {}
             change_type = change.get("changeType", "unknown")
-            file_path = item.get("path", "unknown")
-            original_path = change.get("originalPath") or file_path
 
             if item.get("isFolder"):
                 continue
 
+            # Deleted files are skipped from the LLM diff.
+            # They are still reported in the terminal summary via _get_pr_changed_files.
+            if change_type == "delete":
+                continue
+
+            # `path` can be null; fall back to `originalPath` (safe for add/edit/rename).
+            file_path = item.get("path") or change.get("originalPath") or "unknown"
+            original_path = change.get("originalPath") or file_path
+
             # --- Early-exit filters (no HTTP request made for skipped files) ---
             # Normalise once: strip leading slash, lower-case, forward slashes.
             norm_path = file_path.replace("\\", "/").lstrip("/").lower()
@@ -425,7 +435,7 @@ class TFSClient:
             diff_parts.append("")
 
         if not diff_parts:
-            raise TFSError(f"PR #{pr_id} contains no file changes after filtering.")
+            return ""
 
         return "\n".join(diff_parts)
 
@@ -500,7 +510,8 @@ class TFSClient:
             file_path: Server path of the new version of the file.
             original_path: Server path of the old version (differs on renames).
             change_type: TFS change type string (``"edit"``, ``"add"``,
-                ``"rename"``, ``"delete"``, …).
+                ``"rename"``). ``"delete"`` entries are filtered out
+                by the caller before this method is invoked.
             source_branch: Source branch ref (feature branch — new version).
             target_branch: Target branch ref (base branch — old version).
 

{code_review_ai_cli-2.2.0 → code_review_ai_cli-2.2.2}/tests/test_tfs_client.py

@@ -326,8 +326,8 @@ def test_get_pull_request_diff_raises_for_missing_iterations_or_changes(mocker)
             {"changeEntries": []},
         ],
     )
-    with pytest.raises(TFSError, match="contains no file changes after filtering"):
-        client.get_pull_request_diff("repo-a", 1)
+    result = client.get_pull_request_diff("repo-a", 1)
+    assert result == ""
 
 
 def test_get_pull_request_diff_filters_excluded_paths(mocker) -> None:
@@ -392,8 +392,8 @@ def test_get_pull_request_diff_filters_extensions(mocker) -> None:
     )
 
 
-def test_get_pull_request_diff_raises_if_all_filtered(mocker) -> None:
-    """It should raise a TFSError if all files are filtered out."""
+def test_get_pull_request_diff_returns_empty_if_all_filtered(mocker) -> None:
+    """It should return an empty string (not raise) if all files are filtered out."""
     client = TFSClient(make_tfs_config())
     mocker.patch(
         "src.tfs_client.TFSClient._get",
@@ -407,10 +407,117 @@ def test_get_pull_request_diff_raises_if_all_filtered(mocker) -> None:
     )
     mocker.patch("src.tfs_client.TFSClient._build_unified_diff_part", return_value=["UNIFIED"])
 
-    # Exclude IoT. All files are filtered, raising TFSError
-    with pytest.raises(TFSError, match="contains no file changes after filtering"):
-        client.get_pull_request_diff("repo-a", 1, excluded_paths=["IoT"])
+    # Exclude IoT. All files are filtered — returns empty string instead of raising.
+    result = client.get_pull_request_diff("repo-a", 1, excluded_paths=["IoT"])
+    assert result == ""
+
+
+def test_get_pr_changed_files_handles_null_item(mocker) -> None:
+    """It should not crash and use originalPath as fallback when item is null (deleted files)."""
+    client = TFSClient(make_tfs_config())
+    mocker.patch(
+        "src.tfs_client.TFSClient._get",
+        side_effect=[
+            {"value": [{"id": 1}]},
+            {"changeEntries": [
+                # Deleted file: API returns item=null and provides originalPath instead.
+                {"item": None, "changeType": "delete", "originalPath": "/src/deleted.py"},
+                # Normal file alongside the delete.
+                {"item": {"path": "/src/kept.py"}, "changeType": "edit", "originalPath": ""},
+            ]},
+        ],
+    )
+    result = client._get_pr_changed_files("repo-a", 1)
+
+    # Both entries must be surfaced to the terminal summary without crashing.
+    assert len(result) == 2
+    deleted = next(r for r in result if r["change_type"] == "delete")
+    assert deleted["path"] == "/src/deleted.py"
+    assert deleted["original_path"] == "/src/deleted.py"
+
+
+def test_get_pull_request_diff_skips_deleted_files(mocker) -> None:
+    """Deleted files must be excluded from the LLM diff without raising an error."""
+    client = TFSClient(make_tfs_config())
+    mocker.patch(
+        "src.tfs_client.TFSClient._get",
+        side_effect=[
+            {"sourceRefName": "refs/heads/feature", "targetRefName": "refs/heads/main"},
+            {"value": [{"id": 1}]},
+            {"changeEntries": [
+                # Deleted file — item is null, API provides only originalPath.
+                {"item": None, "changeType": "delete", "originalPath": "/src/removed.py"},
+                # Edited file that should still appear in the diff.
+                {"item": {"path": "/src/app.py"}, "changeType": "edit", "originalPath": "/src/app.py"},
+            ]},
+        ],
+    )
+    unified = mocker.patch(
+        "src.tfs_client.TFSClient._build_unified_diff_part", return_value=["UNIFIED"]
+    )
+
+    result = client.get_pull_request_diff("repo-a", 1)
+
+    # The diff builder must only be called for the edited file, not the deleted one.
+    unified.assert_called_once_with(
+        repository="repo-a",
+        file_path="/src/app.py",
+        original_path="/src/app.py",
+        change_type="edit",
+        source_branch="refs/heads/feature",
+        target_branch="refs/heads/main",
+    )
+    assert "UNIFIED" in result
+
+
+def test_get_pull_request_diff_handles_null_item_in_non_delete(mocker) -> None:
+    """A null item for a non-delete change must not crash; originalPath is used as path fallback."""
+    client = TFSClient(make_tfs_config())
+    mocker.patch(
+        "src.tfs_client.TFSClient._get",
+        side_effect=[
+            {"sourceRefName": "refs/heads/feature", "targetRefName": "refs/heads/main"},
+            {"value": [{"id": 1}]},
+            {"changeEntries": [
+                # Unexpected null item for an edit — defensive case.
+                {"item": None, "changeType": "edit", "originalPath": "/src/fallback.py"},
+            ]},
+        ],
+    )
+    unified = mocker.patch(
+        "src.tfs_client.TFSClient._build_unified_diff_part", return_value=["UNIFIED"]
+    )
+
+    result = client.get_pull_request_diff("repo-a", 1)
+
+    unified.assert_called_once_with(
+        repository="repo-a",
+        file_path="/src/fallback.py",
+        original_path="/src/fallback.py",
+        change_type="edit",
+        source_branch="refs/heads/feature",
+        target_branch="refs/heads/main",
+    )
+    assert "UNIFIED" in result
+
+
+def test_get_pull_request_diff_returns_empty_when_only_deletes_present(mocker) -> None:
+    """It should return an empty string (not raise) when the PR contains only deleted files."""
+    client = TFSClient(make_tfs_config())
+    mocker.patch(
+        "src.tfs_client.TFSClient._get",
+        side_effect=[
+            {"sourceRefName": "refs/heads/feature", "targetRefName": "refs/heads/main"},
+            {"value": [{"id": 1}]},
+            {"changeEntries": [
+                {"item": None, "changeType": "delete", "originalPath": "/src/a.py"},
+                {"item": None, "changeType": "delete", "originalPath": "/src/b.py"},
+            ]},
+        ],
+    )
 
+    result = client.get_pull_request_diff("repo-a", 1)
+    assert result == ""
 
 
 def test_build_diff_parts_and_file_content(mocker) -> None:
@@ -488,7 +595,12 @@ def test_build_unified_diff_part_context_block_present_on_add(mocker) -> None:
 
 
 def test_build_unified_diff_part_no_context_block_on_delete(mocker) -> None:
-    """_build_unified_diff_part must NOT append any context block when change_type is delete."""
+    """_build_unified_diff_part must NOT append any context block when change_type is delete.
+
+    Note: in production this code path is no longer reached via get_pull_request_diff —
+    deleted entries are filtered out before _build_unified_diff_part is ever called.
+    This test is kept as a defensive contract on the method's own behaviour.
+    """
     client = TFSClient(make_tfs_config())
     mocker.patch(
         "src.tfs_client.TFSClient._get_file_content",