code-review-ai-cli 1.3.4__tar.gz → 1.3.5__tar.gz

{code_review_ai_cli-1.3.4 → code_review_ai_cli-1.3.5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-review-ai-cli
-Version: 1.3.4
+Version: 1.3.5
 Summary: Automated AI-powered code review CLI for Azure DevOps / TFS Pull Requests
 License: MIT
 Keywords: code-review,ai,azure-devops,tfs,pull-request,llm
@@ -126,7 +126,6 @@ tfs:
   # ca_bundle: C:/certs/corporate-root-ca.pem
 
 review:
-  language: pt
   verbosity: detailed
   scope: diff_only
   custom_prompt_file: review_prompt.md

{code_review_ai_cli-1.3.4 → code_review_ai_cli-1.3.5}/README.md

@@ -89,7 +89,6 @@ tfs:
   # ca_bundle: C:/certs/corporate-root-ca.pem
 
 review:
-  language: pt
   verbosity: detailed
   scope: diff_only
   custom_prompt_file: review_prompt.md

{code_review_ai_cli-1.3.4 → code_review_ai_cli-1.3.5}/code_review_ai_cli.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-review-ai-cli
-Version: 1.3.4
+Version: 1.3.5
 Summary: Automated AI-powered code review CLI for Azure DevOps / TFS Pull Requests
 License: MIT
 Keywords: code-review,ai,azure-devops,tfs,pull-request,llm
@@ -126,7 +126,6 @@ tfs:
   # ca_bundle: C:/certs/corporate-root-ca.pem
 
 review:
-  language: pt
   verbosity: detailed
   scope: diff_only
   custom_prompt_file: review_prompt.md

{code_review_ai_cli-1.3.4 → code_review_ai_cli-1.3.5}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "code-review-ai-cli"
-version = "1.3.4"
+version = "1.3.5"
 description = "Automated AI-powered code review CLI for Azure DevOps / TFS Pull Requests"
 readme = "README.md"
 requires-python = ">=3.10"

{code_review_ai_cli-1.3.4 → code_review_ai_cli-1.3.5}/src/ai_review.py

@@ -858,7 +858,6 @@ def _show_config(config: ReviewConfig) -> None:
     print(f"  {c.CYAN}API Key:{c.RESET}       {'✅ Configured' if has_effective_key else '❌ Not configured'}")
     print(f"  {c.CYAN}Temperature:{c.RESET}   {config.temperature}")
     print(f"  {c.CYAN}Max Tokens:{c.RESET}    {config.max_tokens}")
-    print(f"  {c.CYAN}Language:{c.RESET}      {config.review_language}")
     print(f"  {c.CYAN}Verbosity:{c.RESET}     {config.verbosity}")
     print(f"  {c.CYAN}Format:{c.RESET}        {config.output_format}")
     print(f"\n  {c.CYAN}TFS URL:{c.RESET}      {config.tfs_base_url or '(not configured)'}")

{code_review_ai_cli-1.3.4 → code_review_ai_cli-1.3.5}/src/config.py

@@ -85,7 +85,6 @@ class ReviewConfig:
     tfs_repository: str = ""                # Default repository (empty = all)
 
     # --- Review -------------------------------------------------------
-    review_language: str = "pt"             # Review language (pt/en)
     verbosity: str = "detailed"             # "quick" | "detailed" | "security"
     review_scope: str = "diff_only"         # "diff_only" | "full_code"
     max_diff_files: int = 50                 # Max diff files sent to LLM
@@ -211,7 +210,6 @@ class ReviewConfig:
             "tfs_ca_bundle": ("tfs", "ca_bundle"),
             "tfs_repository": ("tfs", "repository"),
             # Review
-            "review_language": ("review", "language"),
             "verbosity": ("review", "verbosity"),
             "review_scope": ("review", "scope"),
             "max_diff_files": ("review", "max_diff_files"),

{code_review_ai_cli-1.3.4 → code_review_ai_cli-1.3.5}/src/llm_client.py

@@ -26,209 +26,124 @@ class LLMError(Exception):
 # ---------------------------------------------------------------------------
 # System Prompts
 # ---------------------------------------------------------------------------
+# Maps each verbosity level ("quick", "detailed", "security") to its
+# English-only system prompt.
+#
+# Type:
+#     dict[str, str] — flat mapping of verbosity -> prompt string. There is
+#     no per-language nesting; each value is a plain ``str``.
+#
+# See Also:
+#     get_system_prompt: Resolves a prompt for a given verbosity, with a
+#     fallback to "detailed" when the key is not recognised.
 SYSTEM_PROMPTS = {
-    "quick": {
-        "pt": (
-            "És um code reviewer senior experiente. Analisa o diff de código fornecido "
-            "e dá um review CONCISO e direto. Foca-te nos problemas mais críticos:\n"
-            "- Bugs e erros lógicos\n"
-            "- Problemas de segurança\n"
-            "- Problemas de performance graves\n\n"
-            "Formato: Lista de bullet points com o ficheiro e linha quando possível. "
-        ),
-        "en": (
-            "You are an experienced Senior Code Reviewer. Analyze the provided code diff "
-            "and give a CONCISE review. Focus on critical issues:\n"
-            "- Bugs and logic errors\n"
-            "- Security issues\n"
-            "- Major performance problems\n\n"
-            "Format: Bullet points with file and line when possible. "
-        ),
-    },
-    "detailed": {
-        "pt": (
-            "És um code reviewer senior experiente. Analisa o diff de código "
-            "fornecido e retorna apenas comentários inline.\n\n"
-            "Formato de output — para cada problema encontrado, escreve exatamente:\n"
-            "- Linha <número_linha>: <descrição do problema> \n\n"
-            "Regras:\n"
-            "- Reporta APENAS problemas específicos associados a uma linha ou bloco concreto de código alterado.\n"
-            "- NÃO produzas secções de sumário (ex: 'Bugs Potenciais', 'Visão Geral de Segurança').\n"
-            "- NÃO produzas parágrafos introdutórios ou de fecho.\n"
-            "- Se não encontrares problemas, escreve apenas: Nenhum problema encontrado.\n"
-            "- Sê específico, objetivo e conciso. Responde em português."
-        ),
-        "en": (
-            "You are an experienced Senior Code Reviewer. Analyze the provided code and return only inline comments.\n\n"
-            "Output format — for each issue found, output exactly:\n"
-            "- Line <line_number>: <issue description>\n\n"
-            "Rules:\n"
-            "- Report ONLY specific issues tied to a concrete line or block of changed code.\n"
-            "- Do NOT produce summary sections (e.g. 'Potential Bugs', 'Security Overview').\n"
-            "- Do NOT produce introductory or closing paragraphs.\n"
-            "- If no issues are found, output only: No issues found.\n"
-            "- Be specific, actionable, and concise."
-        ),
-    },
-    "security": {
-        "pt": (
-            "És um especialista em segurança de aplicações. Analisa o diff "
-            "de código fornecido com foco EXCLUSIVO em segurança.\n\n"
-            "Procura por:\n"
-            "- SQL Injection\n"
-            "- Cross-Site Scripting (XSS)\n"
-            "- Cross-Site Request Forgery (CSRF)\n"
-            "- Credenciais hardcoded ou secrets expostos\n"
-            "- Vulnerabilidades de autenticação/autorização\n"
-            "- Insecure deserialization\n"
-            "- Path traversal\n"
-            "- Command injection\n"
-            "- Dependências com vulnerabilidades conhecidas\n"
-            "- Logging de informação sensível\n"
-            "- Configurações inseguras\n\n"
-            "Fornece recomendações de correção para cada problema. "
-            "Responde em português."
-        ),
-        "en": (
-            "You are an application security. Analyze the "
-            "provided code diff with EXCLUSIVE focus on security.\n\n"
-            "Look for:\n"
-            "- SQL Injection\n"
-            "- Cross-Site Scripting (XSS)\n"
-            "- Cross-Site Request Forgery (CSRF)\n"
-            "- Hardcoded credentials or exposed secrets\n"
-            "- Authentication/authorization vulnerabilities\n"
-            "- Insecure deserialization\n"
-            "- Path traversal\n"
-            "- Command injection\n"
-            "- Dependencies with known vulnerabilities\n"
-            "- Logging of sensitive information\n"
-            "- Insecure configurations\n\n"
-            "Provide fix recommendations for each issue."
-        ),
-    },
-}
-
-# Special prompt for PR review with a combined narrative summary + structured comments
-PR_COMMENT_PROMPT = {
-    "pt": (
-        "Analisa o diff de código de um Pull Request e retorna a tua resposta num único objeto JSON "
-        "com dois campos:\n"
-        '- "summary": um resumo narrativo do review, em texto (string). Se não encontrares problemas, '
-        'escreve algo como "Nenhum problema encontrado."\n'
-        '- "comments": um array de objetos, um por cada problema encontrado, com:\n'
-        '  - "file": caminho do ficheiro (ex: "src/auth.py")\n'
-        '  - "line": número da linha no diff (inteiro, ou 0 se geral)\n'
-        '  - "type": tipo de issue ("bug", "security", "performance", "style", "suggestion", "praise")\n'
-        '  - "comment": descrição direta do problema em português, sem saudações e sem emojis\n'
-        '  - "suggestion": sugestão de correção (opcional, string vazia se não aplicável)\n'
-        '  - "reference": fonte ou referência para o problema (URL de documentação, padrão ou princípio). '
-        'Importante: incluir SEMPRE uma referência relevante.\n\n'
-        "No campo 'comment', escreve de forma objetiva e curta. "
-        "Não uses introduções como 'Olá' ou 'Como code reviewer sénior'.\n"
-        "No campo 'reference', inclui uma fonte confiável, padrão ou link para documentação relevante.\n\n"
-        "Responde APENAS com um JSON object válido. Exemplo:\n"
-        '{\n'
-        '  "summary": "Resumo narrativo curto do review...",\n'
-        '  "comments": [\n'
-        '    {\n'
-        '      "file": "src/auth.py",\n'
-        '      "line": 42,\n'
-        '      "type": "security",\n'
-        '      "comment": "Password armazenada em texto simples sem hashing",\n'
-        '      "suggestion": "Usar bcrypt ou argon2 para hash de passwords",\n'
-        '      "reference": "OWASP - Password Storage Cheat Sheet"\n'
-        '    }\n'
-        '  ]\n'
-        '}\n\n'
+    "quick": (
+        "You are an experienced Senior Code Reviewer. Analyze the provided code diff "
+        "and give a CONCISE review. Focus on critical issues:\n"
+        "- Bugs and logic errors\n"
+        "- Security issues\n"
+        "- Major performance problems\n\n"
+        "Format: Bullet points with file and line when possible. "
+    ),
+    "detailed": (
+        "You are an experienced Senior Code Reviewer. Analyze the provided code and return only inline comments.\n\n"
+        "Output format — for each issue found, output exactly:\n"
+        "- Line <line_number>: <issue description>\n\n"
+        "Rules:\n"
+        "- Report ONLY specific issues tied to a concrete line or block of changed code.\n"
+        "- Do NOT produce summary sections (e.g. 'Potential Bugs', 'Security Overview').\n"
+        "- Do NOT produce introductory or closing paragraphs.\n"
+        "- If no issues are found, output only: No issues found.\n"
+        "- Be specific, actionable, and concise."
     ),
-    "en": (
-        "Analyze the Pull Request code diff and return your response as a single JSON object with two "
-        "fields:\n"
-        '- "summary": a narrative text summary of the review (string). If no issues are found, write '
-        'something like "No issues found."\n'
-        '- "comments": an array of objects, one per issue found, with:\n'
-        '  - "file": file path (e.g., "src/auth.py")\n'
-        '  - "line": line number in diff (integer, or 0 if general)\n'
-        '  - "type": issue type ("bug", "security", "performance", "style", "suggestion", "praise")\n'
-        '  - "comment": direct description of the issue, with no greetings and no emojis\n'
-        '  - "suggestion": fix suggestion (optional, empty string if not applicable)\n'
-        '  - "reference": source or reference for the issue (e.g., "OWASP Top 10", "PEP 8", documentation '
-        'URL, standard or principle). Important: ALWAYS include a relevant reference.\n\n'
-        "In 'comment', use a short and objective tone. "
-        "Do not include intros like 'Hello' or 'As a senior reviewer'.\n"
-        "In 'reference', include a trusted source, standard or link to relevant documentation.\n\n"
-        "Respond ONLY with a valid JSON object. Example:\n"
-        '{\n'
-        '  "summary": "Short narrative summary of the review...",\n'
-        '  "comments": [\n'
-        '    {\n'
-        '      "file": "src/auth.py",\n'
-        '      "line": 42,\n'
-        '      "type": "security",\n'
-        '      "comment": "Password stored in plain text without hashing",\n'
-        '      "suggestion": "Use bcrypt or argon2 to hash passwords",\n'
-        '      "reference": "OWASP - Password Storage Cheat Sheet"\n'
-        '    }\n'
-        '  ]\n'
-        '}\n\n'
+    "security": (
+        "You are an application security. Analyze the "
+        "provided code diff with EXCLUSIVE focus on security.\n\n"
+        "Look for:\n"
+        "- SQL Injection\n"
+        "- Cross-Site Scripting (XSS)\n"
+        "- Cross-Site Request Forgery (CSRF)\n"
+        "- Hardcoded credentials or exposed secrets\n"
+        "- Authentication/authorization vulnerabilities\n"
+        "- Insecure deserialization\n"
+        "- Path traversal\n"
+        "- Command injection\n"
+        "- Dependencies with known vulnerabilities\n"
+        "- Logging of sensitive information\n"
+        "- Insecure configurations\n\n"
+        "Provide fix recommendations for each issue."
     ),
 }
 
-
-def get_system_prompt(verbosity: str, language: str) -> str:
-    """Returns the system prompt for the given verbosity level and language.
+# Special prompt for PR review with a combined narrative summary + structured comments.
+#
+# Type:
+#     str — a single English-only prompt (not a per-language dict) instructing
+#     the LLM to respond with one JSON object containing a "summary" string
+#     and a "comments" array (each with file, line, type, comment,
+#     suggestion, and reference fields).
+#
+# See Also:
+#     LLMClient.review_pr: Combines this prompt with the verbosity system
+#     prompt (from get_system_prompt) and scope guidance (from
+#     get_scope_guidance) to build the final system prompt sent to the LLM.
+PR_COMMENT_PROMPT = (
+    "Analyze the Pull Request code diff and return your response as a single JSON object with two "
+    "fields:\n"
+    '- "summary": a narrative text summary of the review (string). If no issues are found, write '
+    'something like "No issues found."\n'
+    '- "comments": an array of objects, one per issue found, with:\n'
+    '  - "file": file path (e.g., "src/auth.py")\n'
+    '  - "line": line number in diff (integer, or 0 if general)\n'
+    '  - "type": issue type ("bug", "security", "performance", "style", "suggestion", "praise")\n'
+    '  - "comment": direct description of the issue, with no greetings and no emojis\n'
+    '  - "suggestion": fix suggestion (optional, empty string if not applicable)\n'
+    '  - "reference": source or reference for the issue (e.g., "OWASP Top 10", "PEP 8", documentation '
+    'URL, standard or principle). Important: ALWAYS include a relevant reference.\n\n'
+    "In 'comment', use a short and objective tone. "
+    "Do not include intros like 'Hello' or 'As a senior reviewer'.\n"
+    "In 'reference', include a trusted source, standard or link to relevant documentation.\n\n"
+    "Respond ONLY with a valid JSON object. Example:\n"
+    '{\n'
+    '  "summary": "Short narrative summary of the review...",\n'
+    '  "comments": [\n'
+    '    {\n'
+    '      "file": "src/auth.py",\n'
+    '      "line": 42,\n'
+    '      "type": "security",\n'
+    '      "comment": "Password stored in plain text without hashing",\n'
+    '      "suggestion": "Use bcrypt or argon2 to hash passwords",\n'
+    '      "reference": "OWASP - Password Storage Cheat Sheet"\n'
+    '    }\n'
+    '  ]\n'
+    '}\n\n'
+)
+
+
+def get_system_prompt(verbosity: str) -> str:
+    """Returns the system prompt for the given verbosity level.
 
     Selects a prompt from ``SYSTEM_PROMPTS`` keyed by *verbosity*. If the
     requested verbosity is not found, the function falls back to
-    ``"detailed"``.  Within the selected prompt group, the language is
-    resolved by *language*; if the language key is absent, ``"pt"``
-    (Portuguese) is used as the default.
+    ``"detailed"``.
 
     The ``"detailed"`` prompt instructs the LLM to return **only** inline
     comments in the format ``- Line <n>: <description>``,
     prohibiting summary sections and introductory/closing paragraphs.
     When no issues are found the expected output is ``No issues found.``
-    (English) or ``Nenhum problema encontrado.`` (Portuguese).
 
     Args:
         verbosity: Review depth key — one of ``"quick"``, ``"detailed"``,
             or ``"security"``. Any unrecognised value falls back to
             ``"detailed"``.
-        language: Response language code — ``"en"`` for English,
-            ``"pt"`` for Portuguese.
 
     Returns:
-        The system prompt string for the resolved verbosity and language.
+        The system prompt string for the resolved verbosity.
     """
-    prompts = SYSTEM_PROMPTS.get(verbosity, SYSTEM_PROMPTS["detailed"])
-    return prompts.get(language, prompts["pt"])
-
+    return SYSTEM_PROMPTS.get(verbosity, SYSTEM_PROMPTS["detailed"])
 
-def get_pr_comment_prompt(language: str) -> str:
-    """Returns the prompt that requests structured JSON PR comments from the LLM.
 
-    Retrieves the prompt from ``PR_COMMENT_PROMPT`` for the given *language*.
-    If the language key is not present, ``"pt"`` (Portuguese) is used as the
-    default.
-
-    The returned prompt instructs the LLM to produce a single valid JSON
-    object with a ``"summary"`` field (narrative review text) and a
-    ``"comments"`` field (array of review comment objects, each with the
-    fields ``file``, ``line``, ``type``, ``comment``, ``suggestion``,
-    and ``reference``).
-
-    Args:
-        language: Response language code — ``"en"`` for English,
-            ``"pt"`` for Portuguese.
-
-    Returns:
-        The prompt string used to request structured PR comments.
-    """
-    return PR_COMMENT_PROMPT.get(language, PR_COMMENT_PROMPT["pt"])
-
-
-def get_scope_guidance(review_scope: str, language: str, structured: bool = False) -> str:
+def get_scope_guidance(review_scope: str, structured: bool = False) -> str:
     """Returns LLM instructions tailored to the active review scope.
 
     For ``diff_only`` scope, the instructions inform the LLM that:
@@ -248,8 +163,6 @@ def get_scope_guidance(review_scope: str, language: str, structured: bool = Fals
 
     Args:
         review_scope: ``"diff_only"`` (default) or ``"full_code"``.
-        language: Response language code — ``"en"`` for English,
-            ``"pt"`` for Portuguese.
         structured: When ``True``, appends additional constraints for the
             structured JSON comment mode (every comment must carry a valid
             file path and line number > 0 for inline posting).
@@ -260,52 +173,29 @@ def get_scope_guidance(review_scope: str, language: str, structured: bool = Fals
     scope = (review_scope or "diff_only").lower()
 
     if scope == "full_code":
-        if language == "en":
-            return (
-                "Review scope: full_code. The diff contains only added lines (+) for each file. "
-                "Analyze the complete content of the changed files and identify issues in the new code. "
-                "Do not comment on deleted or absent code."
-            )
         return (
-            "Ambito de review: full_code. O diff contém apenas linhas adicionadas (+) de cada ficheiro. "
-            "Analisa o conteúdo completo dos ficheiros alterados e identifica problemas no novo código. "
-            "Não comentes código eliminado ou ausente."
+            "Review scope: full_code. The diff contains only added lines (+) for each file. "
+            "Analyze the complete content of the changed files and identify issues in the new code. "
+            "Do not comment on deleted or absent code."
         )
 
     if structured:
-        if language == "en":
-            return (
-                "Review scope: diff_only. The diff contains only added lines (+) — context and deletions were removed. "
-                "The complete new-version file content, after the changes (between ### FULL_FILE_CONTEXT_START and ### FULL_FILE_CONTEXT_END markers) "
-                "is provided for each file as read-only context. "
-                "Use it to understand the surrounding code, but focus your review EXCLUSIVELY on the changed lines (marked + in the diff). "
-                "Do NOT report issues in unchanged lines unless they directly affect the correctness of the changes. "
-                "For every problem, you MUST provide a valid file and line (>0) to allow inline comments. "
-                "Do not emit general problem comments without file/line."
-            )
         return (
-            "Ambito de review: diff_only. O diff contém apenas linhas adicionadas (+) — contexto e eliminações foram removidos. "
-            "É fornecido o conteúdo completo do ficheiro na versão nova, depois das alterações (entre os marcadores ### FULL_FILE_CONTEXT_START e ### FULL_FILE_CONTEXT_END) como contexto de leitura. "
-            "Usa-a para compreender o código envolvente, mas foca o teu review EXCLUSIVAMENTE nas linhas alteradas (marcadas com + no diff). "
-            "NÃO reportes problemas em linhas não alteradas, exceto se afetarem diretamente a correção das alterações. "
-            "Para cada problema, DEVE ser fornecido file e line válidos (>0) para comentário inline. "
-            "Não emitas comentários gerais de problema sem file/line."
-        )
-
-    if language == "en":
-        return (
-            "Review scope: diff_only. The diff contains only added lines (+). "
-            "The new-version (post-change) full file content (between ### FULL_FILE_CONTEXT_START and ### FULL_FILE_CONTEXT_END markers) "
+            "Review scope: diff_only. The diff contains only added lines (+) — context and deletions were removed. "
+            "The complete new-version file content, after the changes (between ### FULL_FILE_CONTEXT_START and ### FULL_FILE_CONTEXT_END markers) "
             "is provided for each file as read-only context. "
-            "Use it to understand the surrounding code, but focus your review EXCLUSIVELY on the changed lines. "
-            "Do NOT report issues in unchanged lines unless they directly affect the correctness of the changes."
+            "Use it to understand the surrounding code, but focus your review EXCLUSIVELY on the changed lines (marked + in the diff). "
+            "Do NOT report issues in unchanged lines unless they directly affect the correctness of the changes. "
+            "For every problem, you MUST provide a valid file and line (>0) to allow inline comments. "
+            "Do not emit general problem comments without file/line."
         )
+
     return (
-        "Ambito de review: diff_only. O diff contém apenas linhas adicionadas (+). "
-        "Uma secção com o conteúdo completo do ficheiro na versão nova, após as alterações (entre os marcadores ### FULL_FILE_CONTEXT_START e ### FULL_FILE_CONTEXT_END) "
-        "é fornecida como contexto de leitura. "
-        "Usa-a para compreender o código envolvente, mas foca o teu review EXCLUSIVAMENTE nas linhas alteradas. "
-        "NÃO reportes problemas em linhas não alteradas, exceto se afetarem diretamente a correção das alterações."
+        "Review scope: diff_only. The diff contains only added lines (+). "
+        "The new-version (post-change) full file content (between ### FULL_FILE_CONTEXT_START and ### FULL_FILE_CONTEXT_END markers) "
+        "is provided for each file as read-only context. "
+        "Use it to understand the surrounding code, but focus your review EXCLUSIVELY on the changed lines. "
+        "Do NOT report issues in unchanged lines unless they directly affect the correctness of the changes."
     )
 
 
@@ -407,13 +297,12 @@ class LLMClient:
             is a list of dicts with keys: file, line, type, comment, suggestion,
             reference.
         """
-        base_prompt = get_system_prompt(self.config.verbosity, self.config.review_language)
-        json_schema_prompt = get_pr_comment_prompt(self.config.review_language)
+        base_prompt = get_system_prompt(self.config.verbosity)
+        json_schema_prompt = PR_COMMENT_PROMPT
         custom_prompt = self._load_custom_prompt_text()
 
         scope_guidance = get_scope_guidance(
             review_scope=review_scope,
-            language=self.config.review_language,
             structured=True,
         )
 

{code_review_ai_cli-1.3.4 → code_review_ai_cli-1.3.5}/src/prompts/config.yaml.template

@@ -72,9 +72,6 @@ tfs:
 # Review Preferences
 # ---------------------------------------------------------------------------
 review:
-  # Language: "pt" or "en"
-  language: en
-
   # Default verbosity: "quick", "detailed" or "security"
   verbosity: detailed
 

{code_review_ai_cli-1.3.4 → code_review_ai_cli-1.3.5}/tests/test_config.py

@@ -17,6 +17,14 @@ def test_get_effective_model_prefers_explicit_value() -> None:
     assert config.get_effective_model() == "custom-model"
 
 
+def test_review_config_has_no_review_language_attribute() -> None:
+    """Regression: the configurable review language feature was removed."""
+    config = ReviewConfig()
+
+    assert hasattr(config, "review_language") is False
+    assert "review_language" not in ReviewConfig.__dataclass_fields__
+
+
 @pytest.mark.parametrize(
     ("provider", "field", "expected"),
     [
@@ -171,7 +179,6 @@ tfs:
   ca_bundle: ~/ca.pem
   repository: repo-a
 review:
-  language: en
   verbosity: quick
   scope: full_code
   max_diff_files: 12
@@ -215,7 +222,6 @@ output:
     assert config.tfs_verify_ssl is False
     assert config.tfs_ca_bundle == "~/ca.pem"
     assert config.tfs_repository == "repo-a"
-    assert config.review_language == "en"
     assert config.verbosity == "quick"
     assert config.review_scope == "full_code"
     assert config.max_diff_files == 12

{code_review_ai_cli-1.3.4 → code_review_ai_cli-1.3.5}/tests/test_llm_client.py

@@ -10,7 +10,8 @@ from types import ModuleType, SimpleNamespace
 import pytest
 
 from src.config import ReviewConfig
-from src.llm_client import LLMClient, LLMError, build_user_message, get_pr_comment_prompt, get_scope_guidance, get_system_prompt
+from src import llm_client
+from src.llm_client import LLMClient, LLMError, build_user_message, get_scope_guidance, get_system_prompt, PR_COMMENT_PROMPT
 
 
 class FakeResponse:
@@ -79,7 +80,6 @@ def make_llm_config(**changes: object) -> ReviewConfig:
         model="gpt-4o-mini",
         max_tokens=256,
         temperature=0.2,
-        review_language="en",
         verbosity="detailed",
     )
     for key, value in changes.items():
@@ -89,88 +89,72 @@ def make_llm_config(**changes: object) -> ReviewConfig:
 
 def test_prompt_helpers_select_expected_language_and_scope() -> None:
     """It should select prompts and scope guidance consistently."""
-    assert "code reviewer" in get_system_prompt("quick", "en").lower()
-    assert "JSON" in get_pr_comment_prompt("pt")
-    assert "full_code" in get_scope_guidance("full_code", "en")
-    assert "file e line" in get_scope_guidance("diff_only", "pt", structured=True)
-    assert "added lines" in get_scope_guidance("diff_only", "en")
+    assert "code reviewer" in get_system_prompt("quick").lower()
+    assert "JSON" in PR_COMMENT_PROMPT
+    assert "full_code" in get_scope_guidance("full_code")
+    assert "file and line" in get_scope_guidance("diff_only", structured=True).lower()
+    assert "added lines" in get_scope_guidance("diff_only")
+
+
+def test_get_pr_comment_prompt_function_removed() -> None:
+    """Regression: get_pr_comment_prompt() was replaced by PR_COMMENT_PROMPT."""
+    assert not hasattr(llm_client, "get_pr_comment_prompt")
+
+
+def test_get_system_prompt_and_get_scope_guidance_reject_language_kwarg() -> None:
+    """Regression: language parameter was removed from both prompt helpers."""
+    with pytest.raises(TypeError):
+        get_system_prompt("quick", language="pt")  # type: ignore[call-arg]
+
+    with pytest.raises(TypeError):
+        get_scope_guidance("diff_only", structured=False, language="pt")  # type: ignore[call-arg]
+
 
 
 # ---------------------------------------------------------------------------
 # SYSTEM_PROMPTS / get_system_prompt — Phase 1 change validation
 # ---------------------------------------------------------------------------
 
-@pytest.mark.parametrize("language", ["en", "pt"])
-def test_get_system_prompt_quick_returns_non_empty_string(language: str) -> None:
-    """quick prompts must return a non-empty string for every supported language."""
-    prompt = get_system_prompt("quick", language)
+def test_get_system_prompt_quick_returns_non_empty_string() -> None:
+    """quick prompt must return a non-empty string."""
+    prompt = get_system_prompt("quick")
     assert isinstance(prompt, str)
     assert len(prompt.strip()) > 0
 
 
-def test_get_system_prompt_detailed_en_enforces_inline_comment_format() -> None:
-    """detailed/en must specify the inline comment output format after Phase 1."""
-    prompt = get_system_prompt("detailed", "en")
+def test_get_system_prompt_detailed_enforces_inline_comment_format() -> None:
+    """detailed must specify the inline comment output format after Phase 1."""
+    prompt = get_system_prompt("detailed")
     # Must instruct the LLM to return only inline comments
     assert "inline comments" in prompt.lower()
     # Must include the exact per-line format marker
     assert "Line <line_number>" in prompt
 
 
-def test_get_system_prompt_detailed_en_forbids_summary_sections() -> None:
-    """detailed/en must explicitly forbid summary sections after Phase 1."""
-    prompt = get_system_prompt("detailed", "en")
+def test_get_system_prompt_detailed_forbids_summary_sections() -> None:
+    """detailed must explicitly forbid summary sections after Phase 1."""
+    prompt = get_system_prompt("detailed")
     assert "Do NOT produce summary sections" in prompt
 
 
-def test_get_system_prompt_detailed_en_contains_no_focus_on_or_structured_review_language() -> None:
-    """detailed/en must NOT contain generic 'Focus on' or 'structured review' language after Phase 1."""
-    prompt = get_system_prompt("detailed", "en")
+def test_get_system_prompt_detailed_contains_no_focus_on_or_structured_review_language() -> None:
+    """detailed must NOT contain generic 'Focus on' or 'structured review' language after Phase 1."""
+    prompt = get_system_prompt("detailed")
     assert "focus on" not in prompt.lower()
     assert "structured review" not in prompt.lower()
 
 
-def test_get_system_prompt_detailed_pt_enforces_inline_comment_format() -> None:
-    """detailed/pt must specify the inline comment output format in Portuguese after Phase 1."""
-    prompt = get_system_prompt("detailed", "pt")
-    assert "inline" in prompt.lower()
-    # Must include the per-line format marker in Portuguese
-    assert "Linha" in prompt
-
-
-def test_get_system_prompt_detailed_pt_forbids_summary_sections() -> None:
-    """detailed/pt must explicitly forbid summary sections in Portuguese after Phase 1."""
-    prompt = get_system_prompt("detailed", "pt")
-    assert "NÃO produzas" in prompt
-    # The forbidden construct must mention summary sections
-    assert "sumário" in prompt.lower() or "secções" in prompt.lower()
-
-
-def test_get_system_prompt_detailed_pt_contains_no_focus_on_or_structured_review_language() -> None:
-    """detailed/pt must NOT contain generic 'Focus on' or 'structured review' language after Phase 1."""
-    prompt = get_system_prompt("detailed", "pt")
-    assert "focus on" not in prompt.lower()
-    assert "structured review" not in prompt.lower()
-
-
-def test_get_system_prompt_security_en_mentions_security_specific_terms() -> None:
-    """security/en must include core vulnerability types it is expected to check for."""
-    prompt = get_system_prompt("security", "en")
+def test_get_system_prompt_security_mentions_security_specific_terms() -> None:
+    """security must include core vulnerability types it is expected to check for."""
+    prompt = get_system_prompt("security")
     for term in ("SQL Injection", "XSS", "CSRF"):
         assert term in prompt, f"Security prompt missing expected term: '{term}'"
 
 
 def test_get_system_prompt_unknown_verbosity_falls_back_to_detailed() -> None:
     """An unrecognised verbosity level must silently fall back to the 'detailed' prompt."""
-    fallback = get_system_prompt("unknown_verbosity", "en")
-    expected = get_system_prompt("detailed", "en")
-    assert fallback == expected
-
-
-def test_get_system_prompt_unknown_language_falls_back_to_pt() -> None:
-    """An unrecognised language code must fall back to the Portuguese ('pt') prompt."""
-    fallback = get_system_prompt("detailed", "xx")
-    expected = get_system_prompt("detailed", "pt")
+    fallback = get_system_prompt("unknown_verbosity")
+    expected = get_system_prompt("detailed")
     assert fallback == expected
 
 
@@ -179,39 +163,35 @@ def test_get_system_prompt_unknown_language_falls_back_to_pt() -> None:
 # ---------------------------------------------------------------------------
 
 def test_get_scope_guidance_diff_only_references_full_file_context_markers() -> None:
-    """diff_only guidance must reference FULL_FILE_CONTEXT_START and _END for all language/mode combos."""
-    for lang in ("en", "pt"):
-        for structured in (False, True):
-            guidance = get_scope_guidance("diff_only", lang, structured=structured)
-            assert "FULL_FILE_CONTEXT_START" in guidance, f"lang={lang} structured={structured}"
-            assert "FULL_FILE_CONTEXT_END" in guidance, f"lang={lang} structured={structured}"
+    """diff_only guidance must reference FULL_FILE_CONTEXT_START and _END for both modes."""
+    for structured in (False, True):
+        guidance = get_scope_guidance("diff_only", structured=structured)
+        assert "FULL_FILE_CONTEXT_START" in guidance, f"structured={structured}"
+        assert "FULL_FILE_CONTEXT_END" in guidance, f"structured={structured}"
 
 
-@pytest.mark.parametrize("language", ["en", "pt"])
-def test_get_scope_guidance_diff_only_structured_demands_valid_line_number(language: str) -> None:
+def test_get_scope_guidance_diff_only_structured_demands_valid_line_number() -> None:
     """Structured diff_only guidance must instruct the LLM to supply a line number > 0."""
-    guidance = get_scope_guidance("diff_only", language, structured=True)
+    guidance = get_scope_guidance("diff_only", structured=True)
     assert "(>0)" in guidance
 
 
 def test_get_scope_guidance_diff_only_non_structured_focuses_on_changed_lines() -> None:
     """Non-structured diff_only guidance must tell the LLM to focus on changed/added lines."""
-    guidance_en = get_scope_guidance("diff_only", "en", structured=False)
-    guidance_pt = get_scope_guidance("diff_only", "pt", structured=False)
+    guidance_en = get_scope_guidance("diff_only", structured=False)
 
     assert "changed lines" in guidance_en.lower() or "added lines" in guidance_en.lower()
-    assert "alteradas" in guidance_pt.lower() or "adicionadas" in guidance_pt.lower()
 
 
 def test_get_scope_guidance_diff_only_structured_does_not_demand_line_in_non_structured() -> None:
     """Non-structured diff_only guidance must NOT mandate a minimum line number."""
-    guidance_en = get_scope_guidance("diff_only", "en", structured=False)
+    guidance_en = get_scope_guidance("diff_only", structured=False)
     assert "(>0)" not in guidance_en
 
 
 def test_get_scope_guidance_unknown_scope_falls_back_to_diff_only() -> None:
     """An unrecognised review_scope must fall through and return diff_only guidance."""
-    guidance = get_scope_guidance("unknown_scope", "en")
+    guidance = get_scope_guidance("unknown_scope")
 
     assert "diff_only" in guidance
     assert "FULL_FILE_CONTEXT_START" in guidance