code-review-ai-cli 1.3.2__tar.gz → 1.3.3__tar.gz

{code_review_ai_cli-1.3.2 → code_review_ai_cli-1.3.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-review-ai-cli
-Version: 1.3.2
+Version: 1.3.3
 Summary: Automated AI-powered code review CLI for Azure DevOps / TFS Pull Requests
 License: MIT
 Keywords: code-review,ai,azure-devops,tfs,pull-request,llm

{code_review_ai_cli-1.3.2 → code_review_ai_cli-1.3.3}/code_review_ai_cli.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-review-ai-cli
-Version: 1.3.2
+Version: 1.3.3
 Summary: Automated AI-powered code review CLI for Azure DevOps / TFS Pull Requests
 License: MIT
 Keywords: code-review,ai,azure-devops,tfs,pull-request,llm

{code_review_ai_cli-1.3.2 → code_review_ai_cli-1.3.3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "code-review-ai-cli"
-version = "1.3.2"
+version = "1.3.3"
 description = "Automated AI-powered code review CLI for Azure DevOps / TFS Pull Requests"
 readme = "README.md"
 requires-python = ">=3.10"

{code_review_ai_cli-1.3.2 → code_review_ai_cli-1.3.3}/src/llm_client.py

@@ -210,8 +210,8 @@ def get_scope_guidance(review_scope: str, language: str, structured: bool = Fals
     * Only added lines (``+``) appear in the diff section.
     * A ``### FULL_FILE_CONTEXT_START: <path> ###`` /
       ``### FULL_FILE_CONTEXT_END ###`` block is embedded in the payload for
-      each changed file, containing the complete new-version file content as
-      **read-only** background.
+      each changed file, containing the complete old-version (before changes)
+      file content as **read-only** background.
     * The review must focus **exclusively** on the changed lines (``+``); the
       full-file section exists only to prevent the model from hallucinating
       about the surrounding code.

{code_review_ai_cli-1.3.2 → code_review_ai_cli-1.3.3}/src/tfs_client.py

@@ -300,17 +300,17 @@ class TFSClient:
         Gets the diff of a specific Pull Request.
 
         For ``diff_only`` scope (default), builds a standard unified diff for
-        each changed file and appends the full new-version file content as a
-        clearly-marked read-only block::
+        each changed file and appends the full old-version (target branch) file
+        content as a clearly-marked read-only block::
 
             ### FULL_FILE_CONTEXT_START: /path/to/file ###
-            <full file content>
+            <full file content — before changes>
             ### FULL_FILE_CONTEXT_END ###
 
         This block is preserved by
         :py:meth:`GitUtils.filter_diff_additions_only` so that the LLM
-        receives the surrounding context without being asked to review
-        unchanged lines.
+        receives the pre-change context without treating already-changed lines
+        as established code.
 
         For ``full_code`` scope, only the new-version file content is sent
         (every line prefixed with ``+``), without a ``-`` baseline.
@@ -442,7 +442,7 @@ class TFSClient:
         from the source branch, then generates a standard unified diff with
         3 lines of context using :py:mod:`difflib`.
 
-        After the diff lines, the **full new-version file content** is
+        After the diff lines, the **full old-version (target branch) file content** is
         appended as a read-only context block bounded by sentinel markers::
 
             ### FULL_FILE_CONTEXT_START: /path/to/file ###
@@ -451,8 +451,8 @@ class TFSClient:
 
         These markers are recognised by
         :py:meth:`GitUtils.filter_diff_additions_only`, which preserves every
-        line inside the block.  This lets the LLM understand surrounding code
-        without being asked to review unchanged lines.
+        line inside the block.  This lets the LLM understand the surrounding
+        code before the changes without being asked to review unchanged lines.
 
         Args:
             repository: Repository name.
@@ -465,7 +465,7 @@ class TFSClient:
 
         Returns:
             List of diff strings for this file, including the
-            ``FULL_FILE_CONTEXT`` block when new content is available.
+            ``FULL_FILE_CONTEXT`` block when old content is available.
         """
         old_lines: list[str] = []
         new_lines: list[str] = []
@@ -518,13 +518,15 @@ class TFSClient:
         # so that filter_diff_by_extensions and _split_diff_sections work correctly.
         result = [f"diff --git a{original_path} b{file_path}"] + diff
 
-        # Include full file content as read-only context for the LLM.
-        # This section is preserved by filter_diff_additions_only and allows
-        # the model to understand the surrounding code without reviewing
-        # unchanged lines.
-        if new_lines:
+        # Include old-version file content as read-only context for the LLM.
+        # Using the pre-change (target branch) content ensures the diff is the
+        # sole source of "what is new", preventing the LLM from treating
+        # already-changed lines as established code.
+        # delete is excluded: the diff already contains the full removed content.
+        # add is excluded automatically because old_lines is empty for new files.
+        if old_lines and change_type != "delete":
             result.append(f"### FULL_FILE_CONTEXT_START: {file_path} ###")
-            result.extend(new_lines)
+            result.extend(old_lines)
             result.append("### FULL_FILE_CONTEXT_END ###")
 
         return result

{code_review_ai_cli-1.3.2 → code_review_ai_cli-1.3.3}/tests/test_tfs_client.py

@@ -354,7 +354,7 @@ def test_build_diff_parts_and_file_content(mocker) -> None:
 # ---------------------------------------------------------------------------
 
 def test_build_unified_diff_part_appends_full_file_context_block(mocker) -> None:
-    """_build_unified_diff_part must append FULL_FILE_CONTEXT markers with the new file content."""
+    """_build_unified_diff_part must append FULL_FILE_CONTEXT markers with the old (target branch) file content."""
     client = TFSClient(make_tfs_config())
     mocker.patch(
         "src.tfs_client.TFSClient._get_file_content",
@@ -368,13 +368,31 @@ def test_build_unified_diff_part_appends_full_file_context_block(mocker) -> None
     joined = "\n".join(result)
 
     assert "### FULL_FILE_CONTEXT_START: /src/app.py ###" in joined
-    assert "new line one" in joined
-    assert "new line two" in joined
+    assert "old line" in joined
+    assert "new line one" not in joined.split("### FULL_FILE_CONTEXT_START")[1]
     assert "### FULL_FILE_CONTEXT_END ###" in joined
     # Context block must appear after the diff headers
     assert joined.index("### FULL_FILE_CONTEXT_START") > joined.index("diff --git")
 
 
+def test_build_unified_diff_part_no_context_block_on_add(mocker) -> None:
+    """_build_unified_diff_part must NOT append a FULL_FILE_CONTEXT block for add (no old version exists)."""
+    client = TFSClient(make_tfs_config())
+    mocker.patch(
+        "src.tfs_client.TFSClient._get_file_content",
+        return_value="new content",
+    )
+
+    result = client._build_unified_diff_part(
+        "repo-a", "/src/new_file.py", "/src/new_file.py", "add",
+        "refs/heads/feature", "refs/heads/main",
+    )
+    joined = "\n".join(result)
+
+    assert "### FULL_FILE_CONTEXT_START" not in joined
+    assert "### FULL_FILE_CONTEXT_END" not in joined
+
+
 def test_build_unified_diff_part_no_context_block_on_delete(mocker) -> None:
     """_build_unified_diff_part must NOT append a FULL_FILE_CONTEXT block when change_type is delete."""
     client = TFSClient(make_tfs_config())