code-loader 1.0.165.dev3__tar.gz → 1.0.165.dev5__tar.gz

{code_loader-1.0.165.dev3 → code_loader-1.0.165.dev5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: code-loader
-Version: 1.0.165.dev3
+Version: 1.0.165.dev5
 Summary: 
 Home-page: https://github.com/tensorleap/code-loader
 License: MIT

{code_loader-1.0.165.dev3 → code_loader-1.0.165.dev5}/code_loader/inner_leap_binder/leapbinder_decorators.py

@@ -45,7 +45,6 @@ _PARAM_DEFAULT_FUNCS: DefaultDict[str, Set[str]] = defaultdict(set)
 # param_name -> default_value used (repr-able)
 _PARAM_DEFAULT_VALUE: Dict[str, Any] = {}
 _PARAM_DEFAULT_DOCS: Dict[str, str] = {}
-_PARAM_DEFAULT_MESSAGES: DefaultDict[str, Set[str]] = defaultdict(set)
 
 
 def get_entry_script_path() -> str:
@@ -68,7 +67,6 @@ def store_warning_by_param(
         user_func_name: str,
         default_value: Any,
         link_to_docs: str = None,
-        custom_message: Optional[str] = None,
 ) -> None:
     _PARAM_DEFAULT_FUNCS[param_name].add(user_func_name)
 
@@ -78,9 +76,6 @@ def store_warning_by_param(
     if link_to_docs and param_name not in _PARAM_DEFAULT_DOCS:
         _PARAM_DEFAULT_DOCS[param_name] = link_to_docs
 
-    if custom_message:
-        _PARAM_DEFAULT_MESSAGES[param_name].add(custom_message)
-
 
 def _get_param_default_warnings() -> Dict[str, Dict[str, Any]]:
     out: Dict[str, Dict[str, Any]] = {}
@@ -89,7 +84,6 @@ def _get_param_default_warnings() -> Dict[str, Dict[str, Any]]:
             "default_value": _PARAM_DEFAULT_VALUE.get(p, None),
             "funcs": set(funcs),
             "link_to_docs": _PARAM_DEFAULT_DOCS.get(p),
-            "messages": sorted(_PARAM_DEFAULT_MESSAGES.get(p, set())),
         }
     return out
 
@@ -536,6 +530,8 @@ def tensorleap_custom_metric(name: str,
             ConfusionMatrixCallableInterfaceMultiArgs]):
         nonlocal direction
 
+        direction_was_provided = direction is not _UNSET
+
         def _validate_decorators_signature():
             err_message = f"{user_function.__name__} validation failed.\n"
             if not isinstance(name, str):
@@ -694,26 +690,7 @@ def tensorleap_custom_metric(name: str,
                             (f'{user_function.__name__}() validation failed: '
                              f'Keys in the compute_insights mapping should be part of result keys. Got key {ci_key}.')
 
-                if direction is _UNSET:
-                    effective_direction = {}
-                elif isinstance(direction, dict):
-                    effective_direction = direction
-                else:
-                    effective_direction = {}
-                    if not _call_from_tl_platform:
-                        # TODO- remove this warning when engine supports high level direction setting for all submetrics
-                        store_warning_by_param(
-                            param_name="direction",
-                            user_func_name=user_function.__name__,
-                            default_value=MetricDirection.Downward,
-                            link_to_docs="https://docs.tensorleap.ai/tensorleap-integration/writing-integration-code/custom-metrics",
-                            custom_message=(
-                                f"'direction': expected Dict[str, MetricDirection] for dict output, "
-                                f"got {type(direction).__name__}; reverted to default per sub-metric "
-                                f"({MetricDirection.Downward.name})."
-                            )
-                        )
-
+                effective_direction = {} if direction is _UNSET else direction if isinstance(direction, dict) else {k:direction for k in result_keys}
                 defaulted_direction_keys = result_keys.difference(effective_direction.keys())
 
                 if defaulted_direction_keys:
@@ -727,83 +704,47 @@ def tensorleap_custom_metric(name: str,
                     elif isinstance(compute_insights, dict):
                         effective_compute_insights = compute_insights
                     else:
-                        effective_compute_insights = {}
+                        effective_compute_insights = {k: compute_insights for k in result_keys}
                     warning_keys = {key for key in defaulted_direction_keys if effective_compute_insights.get(key, True)}
                     if warning_keys:
                         store_warning_by_param(
-                            param_name=f"direction[{sorted(warning_keys)}]",
+                            param_name=f"direction[{warning_keys}]",
                             user_func_name=user_function.__name__,
                             default_value=MetricDirection.Downward,
                             link_to_docs="https://docs.tensorleap.ai/tensorleap-integration/writing-integration-code/custom-metrics"
                         )
 
-                if compute_insights is not None and not isinstance(compute_insights, dict) and not _call_from_tl_platform:
-                    # TODO- remove this warning when engine supports high level compute_insights setting for all submetrics
-                    store_warning_by_param(
-                        param_name="compute_insights",
-                        user_func_name=user_function.__name__,
-                        default_value=None,
-                        link_to_docs="https://docs.tensorleap.ai/tensorleap-integration/writing-integration-code/custom-metrics",
-                        custom_message=(
-                            f"'compute_insights': expected Dict[str, bool] for dict output, "
-                            f"got {type(compute_insights).__name__}; reverted to default (None)."
-                        )
-                    )
-
-                if compute_insights is None:
-                    effective_compute_insights_for_handler = None
-                elif isinstance(compute_insights, dict):
-                    effective_compute_insights_for_handler = compute_insights
-                else:
-                    effective_compute_insights_for_handler = None
-                leap_binder.setup_container.metrics[-1].metric_handler_data.compute_insights = effective_compute_insights_for_handler
-
             else:
                 _validate_single_metric(result)
 
-                if compute_insights is None or isinstance(compute_insights, bool):
-                    effective_single_compute_insights = compute_insights
-                else:
-                    effective_single_compute_insights = None
-                    if not _call_from_tl_platform:
-                        store_warning_by_param(
-                            param_name="compute_insights",
-                            user_func_name=user_function.__name__,
-                            default_value=None,
-                            link_to_docs="https://docs.tensorleap.ai/tensorleap-integration/writing-integration-code/custom-metrics",
-                            custom_message=(
-                                f"'compute_insights': expected bool for single-valued output, "
-                                f"got {type(compute_insights).__name__}; reverted to default (None)."
-                            )
-                        )
+                if compute_insights is not None and not isinstance(compute_insights, bool):
+                    warnings.warn(
+                        (f'{user_function.__name__}() unclear intention: '
+                         f'compute_insights should be boolean when using a single result. '
+                         f'Got {type(compute_insights)}. reverting to default behavior compute_insights={True}'),
+                        UserWarning
+                    )
+
+                if direction is not _UNSET and not isinstance(direction, MetricDirection):
+                    warnings.warn(
+                        (f'{user_function.__name__}() unclear intention: '
+                         f'direction should be a MetricDirection when using a single result. '
+                         f'Got {type(direction)}. reverting to default behavior {MetricDirection.Downward}.'),
+                        UserWarning
+                    )
+                    direction=MetricDirection.Downward
 
                 if direction is _UNSET:
-                    effective_single_direction = MetricDirection.Downward
-                    if not _call_from_tl_platform and effective_single_compute_insights is not False:
+                    direction = MetricDirection.Downward
+                    if not _call_from_tl_platform and compute_insights is not False:
                         store_warning_by_param(
                             param_name="direction",
                             user_func_name=user_function.__name__,
-                            default_value=effective_single_direction,
+                            default_value=MetricDirection.Downward,
                             link_to_docs="https://docs.tensorleap.ai/tensorleap-integration/writing-integration-code/custom-metrics"
                         )
-                elif isinstance(direction, MetricDirection):
-                    effective_single_direction = direction
-                else:
-                    effective_single_direction = MetricDirection.Downward
-                    if not _call_from_tl_platform and effective_single_compute_insights is not False:
-                        store_warning_by_param(
-                            param_name="direction",
-                            user_func_name=user_function.__name__,
-                            default_value=effective_single_direction,
-                            link_to_docs="https://docs.tensorleap.ai/tensorleap-integration/writing-integration-code/custom-metrics",
-                            custom_message=(
-                                f"'direction': expected MetricDirection for single-valued output, "
-                                f"got {type(direction).__name__}; reverted to default ({MetricDirection.Downward.name})."
-                            )
-                        )
 
-                leap_binder.setup_container.metrics[-1].metric_handler_data.direction = effective_single_direction
-                leap_binder.setup_container.metrics[-1].metric_handler_data.compute_insights = effective_single_compute_insights
+                leap_binder.setup_container.metrics[-1].metric_handler_data.direction = direction
 
         @functools.wraps(user_function)
         def inner_without_validate(*args, **kwargs):
@@ -1764,17 +1705,12 @@ def tensorleap_status_table():
             default_value = data[param_name]["default_value"]
             funcs = ", ".join(sorted(data[param_name]["funcs"]))
             dv = _format_default_value(default_value)
-            messages = data[param_name].get("messages", [])
 
             docs_link = data[param_name].get("link_to_docs")
             docs_part = f" {_link(docs_link)}" if docs_link else ""
-            if messages:
-                for msg in messages:
-                    print(f" ⚠️ {msg} (functions: [{funcs}]).")
-            else:
-                print(
-                    f" ⚠️ Parameter '{param_name}' defaults to {dv} in the following functions: [{funcs}]. "
-                    f"For more information, check {docs_part}")
+            print(
+                f" ⚠️ Parameter '{param_name}' defaults to {dv} in the following functions: [{funcs}]. "
+                f"For more information, check {docs_part}")
         print("\nIf this isn’t the intended behaviour, set them explicitly.")
 
     def _print_table():
@@ -1864,3 +1800,7 @@ def tensorleap_status_table():
 
 if not _call_from_tl_platform:
     set_current, update_env_params_func = tensorleap_status_table()
+
+
+
+

{code_loader-1.0.165.dev3 → code_loader-1.0.165.dev5}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "code-loader"
-version = "1.0.165.dev3"
+version = "1.0.165.dev5"
 description = ""
 authors = ["dorhar <doron.harnoy@tensorleap.ai>"]
 license = "MIT"