code-graph-rag 0.4.19__tar.gz → 0.5.0__tar.gz

{code_graph_rag-0.4.19/code_graph_rag.egg-info → code_graph_rag-0.5.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-graph-rag
-Version: 0.4.19
+Version: 0.5.0
 Summary: The ultimate RAG for your monorepo. Query, understand, and edit multi-language codebases with the power of AI and knowledge graphs
 License-Expression: MIT
 Keywords: rag,retrieval-augmented-generation,knowledge-graph,code-analysis,tree-sitter,mcp,mcp-server,llm,graph-database,semantic-search,codebase,memgraph,developer-tools,monorepo

{code_graph_rag-0.4.19 → code_graph_rag-0.5.0}/README.md

@@ -61,10 +61,9 @@ Code-Graph-RAG parses a multi-language codebase with Tree-sitter, sharpened by c
 ## Latest News 🔥
 
 <!-- SECTION:latest_news -->
-- **Quiet Mode Enhancement**: The `--quiet` flag for the CLI now suppresses the scanning line for dead code and duplicates, providing a cleaner output.
-- **Context Budget Fix**: The system now correctly handles cases where a target doesn't fit within the allocated budget, preventing unexpected behaviour.
-- **Code Quality**: Changes have been made to report decorator and modifier changes that affect method calls and to ensure submodule grammars are loaded correctly.
-- **CGR Prune Feature**: A new `cgr prune` functionality has been added to remove projects where the root no longer exists.
+- **Rust Upgrade**: Updated Rust to version 1.99.1-slim-trixie.
+- **Signature Functionality**: Added support for reading and writing JavaScript headers for change signatures, including the ability to change the signature of JavaScript functions or methods.
+- **macOS Compatibility**: The build now leaves macOS-14 support.
 <!-- /SECTION:latest_news -->
 
 See [NEWS.md](NEWS.md) for the full history.

{code_graph_rag-0.4.19 → code_graph_rag-0.5.0/code_graph_rag.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-graph-rag
-Version: 0.4.19
+Version: 0.5.0
 Summary: The ultimate RAG for your monorepo. Query, understand, and edit multi-language codebases with the power of AI and knowledge graphs
 License-Expression: MIT
 Keywords: rag,retrieval-augmented-generation,knowledge-graph,code-analysis,tree-sitter,mcp,mcp-server,llm,graph-database,semantic-search,codebase,memgraph,developer-tools,monorepo

{code_graph_rag-0.4.19 → code_graph_rag-0.5.0}/code_graph_rag.egg-info/SOURCES.txt

@@ -171,6 +171,8 @@ codebase_rag/editing/rename.py
 codebase_rag/editing/signature.py
 codebase_rag/editing/signature_bind.py
 codebase_rag/editing/signature_contract.py
+codebase_rag/editing/signature_js.py
+codebase_rag/editing/signature_js_bind.py
 codebase_rag/editing/signature_spec.py
 codebase_rag/editing/sites.py
 codebase_rag/editing/transaction.py

{code_graph_rag-0.4.19 → code_graph_rag-0.5.0}/codebase_rag/cli_help.py

@@ -201,7 +201,8 @@ HELP_RENAME_ALLOW_HEURISTIC = (
 )
 HELP_RENAME_DRY_RUN = "Print the plan and diff without writing anything."
 CMD_CHANGE_SIGNATURE = (
-    "Change a Python definition's parameter list and rewrite every call site "
+    "Change a Python or JavaScript definition's parameter list and rewrite "
+    "every call site "
     "the graph knows; sites the mapping cannot complete are listed, not touched; "
     "refuses on a graph a stopped sync left partial."
 )

{code_graph_rag-0.4.19 → code_graph_rag-0.5.0}/codebase_rag/config.py

@@ -48,8 +48,12 @@ def merge_dotenv(path: Path) -> dict[str, str]:
     # value, and a reference to it in the file reads that value too.
     values = DotEnv(path, encoding=cs.ENCODING_UTF8, override=False).dict()
     refused: dict[str, str] = {}
+    # The file may not set a waiver in any spelling: settings match names
+    # without regard to case, so `cgr_allow_sensitive_reads=true` beside an
+    # exported `CGR_ALLOW_SENSITIVE_READS=false` won (see load_settings).
+    environment_only = {name.upper() for name in cs.ENVIRONMENT_ONLY_SETTINGS}
     for name, value in values.items():
-        if value is None or name in os.environ:
+        if value is None or name in os.environ or name.upper() in environment_only:
             continue
         try:
             os.environ[name] = value
@@ -620,6 +624,14 @@ class AppConfig(BaseSettings):
         False, validation_alias="CGR_ALLOW_SENSITIVE_READS"
     )
 
+    # MCP write_file and surgical_replace_code refuse the same files: an
+    # overwrite destroys the secret, and an edit's refusals ("target not
+    # found", the lines of each match) let the client guess one character
+    # at a time. The CLI agent asks before every write instead.
+    ALLOW_SENSITIVE_WRITES: bool = Field(
+        False, validation_alias="CGR_ALLOW_SENSITIVE_WRITES"
+    )
+
     # A repository's .cgr.md loads only once the user approved its content
     # (issue #3456). True trusts every repository's file without asking:
     # for CI on repositories you control, never for code you did not write.
@@ -780,7 +792,10 @@ def load_settings(
     # when the user exported it: `.env` in the working directory is usually the
     # analysed repository's file, and could approve its own .cgr.md (Codex
     # review on PR #3471). Held at its default, silently, like an unset one.
-    exported = {name.upper() for name in inherited_env}
+    # An empty one counts as unset: settings skip an empty variable
+    # (env_ignore_empty) and read `.env` in its place, so it let the
+    # repository's file decide.
+    exported = {name.upper() for name in inherited_env if os.environ.get(name)}
     waivers = {
         name for name in cs.ENVIRONMENT_ONLY_SETTINGS if name.upper() not in exported
     }

{code_graph_rag-0.4.19 → code_graph_rag-0.5.0}/codebase_rag/constants/ast_js.py

@@ -534,3 +534,24 @@ CAPTURE_MODULE_OBJ = "module_obj"
 CAPTURE_EXPORTS_PROP = "exports_prop"
 CAPTURE_EXPORT_NAME = "export_name"
 CAPTURE_EXPORT_FUNCTION = "export_function"
+
+# Value nodes a call argument can be without running code, and the methods
+# through which a function is called with an explicit receiver, for
+# change_signature (issue #1908).
+TS_JS_NUMBER = "number"
+TS_JS_NULL = "null"
+TS_JS_UNDEFINED = "undefined"
+TS_JS_ACCESSOR_KEYWORDS = frozenset({"get", "set"})
+JS_RECEIVER_METHODS = frozenset({"call", "apply"})
+# `\u0061` and `\u{61}` both spell the identifier `a`, and a parameter name
+# written with escapes is refused; a direct `eval` reads locals named in a
+# string. For change_signature (issue #1908).
+JS_IDENTIFIER_ESCAPE = r"\\u\{([0-9a-fA-F]+)\}|\\u([0-9a-fA-F]{4})"
+JS_ESCAPE_MARK = "\\"
+JS_EVAL_NAME = "eval"
+# The argument passed for a default a call skips: undefined even where the
+# caller has bound the name `undefined` to something else.
+JS_SKIPPED_ARGUMENT = "void 0"
+# A function body opening with either of these, exactly as written, runs in
+# strict mode, and JavaScript then refuses a default among its parameters.
+JS_USE_STRICT_DIRECTIVES = frozenset({"'use strict'", '"use strict"'})

{code_graph_rag-0.4.19 → code_graph_rag-0.5.0}/codebase_rag/constants/cli.py

@@ -1074,9 +1074,9 @@ SIGNATURE_CLI_WRONG_ROOT = (
     "Project {project} was not indexed from {root}; "
     "pass the --repo-path it was indexed from"
 )
-SIGNATURE_NOT_PYTHON = (
-    "Cannot change the signature of {qn}: {path} is not Python, and only Python "
-    "definitions are supported for now (issue #{issue})"
+SIGNATURE_UNSUPPORTED_LANGUAGE = (
+    "Cannot change the signature of {qn}: {path} is in a language it does not "
+    "support yet; Python and JavaScript are supported (issue #{issue})"
 )
 SIGNATURE_DEFINITION_UNREADABLE = (
     "Cannot change the signature of {qn}: its file {path} cannot be read "
@@ -1157,7 +1157,7 @@ SIGNATURE_SITE_NO_LOCATION = "site carries no location ({resolution})"
 SIGNATURE_SITE_GUESSED = (
     "site was resolved by {resolution}; pass allow_heuristic to rewrite it"
 )
-SIGNATURE_SITE_NOT_PYTHON = "{path} is not Python"
+SIGNATURE_SITE_OTHER_LANGUAGE = "{path} is not in the definition's language"
 SIGNATURE_SITE_UNREADABLE_FILE = "file cannot be read ({error})"
 SIGNATURE_SITE_NO_CALL = "no call found at the recorded position"
 SIGNATURE_SITE_UNREADABLE = "arguments cannot be read positionally: `{text}`"
@@ -1176,6 +1176,70 @@ SIGNATURE_SITE_EXPLICIT_RECEIVER = (
     "reaches the method through its class and passes the receiver as an "
     "argument (`{text}`); rewrite it by hand"
 )
+SIGNATURE_SITE_REORDERS_EFFECTS = (
+    "its arguments run code, and the new order would run them in another "
+    "order: `{text}`"
+)
+SIGNATURE_JS_HEADER_PROBE = "function _{params} {{}}"
+SIGNATURE_JS_CALL_PROBE = "_({args});"
+SIGNATURE_JS_BAD_LITERAL = (
+    "The value `{literal}` mapped to {name} is not one JavaScript expression; "
+    "written into a call it would not be exactly one argument"
+)
+SIGNATURE_JS_UNSUPPORTED_PARAMS = (
+    "Cannot change the signature of {qn}: `{text}` is not a plain parameter "
+    "(a name, with or without a default), and only those can be remapped"
+)
+SIGNATURE_JS_BAD_PARAM = (
+    "Not one plain parameter: `{text}` (expected `name` or `name = default`)"
+)
+SIGNATURE_JS_INVALID_HEADER = (
+    "The new parameter list of {qn} is not valid JavaScript: `{text}`"
+)
+SIGNATURE_JS_CONSTRUCTOR = (
+    "Cannot change the signature of {qn}: a constructor is called through `new` "
+    "and `super(...)`, which are not listed as its call sites"
+)
+SIGNATURE_JS_ACCESSOR = (
+    "Cannot change the signature of {qn}: a getter or setter is read or "
+    "assigned, never called with arguments"
+)
+SIGNATURE_JS_CALLS_EVAL = (
+    "Cannot add or drop a parameter of {qn}: its body uses `eval`, which can "
+    "read any parameter through a name written in a string"
+)
+SIGNATURE_JS_READS_ARGUMENTS = (
+    "Cannot change the signature of {qn}: its body reads `arguments`, which "
+    "sees every value by position"
+)
+SIGNATURE_JS_RENAME = (
+    "Cannot rename parameter {old} of {qn} to {new}: renaming is not supported "
+    "for JavaScript yet (issue #{issue})"
+)
+SIGNATURE_JS_DROPPED_STILL_READ = (
+    "Cannot drop parameter {name} of {qn}: its body still uses `{name}`, which "
+    "would then reach an outer name or throw ReferenceError; remove that use by "
+    "hand first"
+)
+SIGNATURE_JS_DUPLICATE_PARAM = (
+    "Cannot change the signature of {qn}: it declares parameter {name} more "
+    "than once, and the body sees only the last of them"
+)
+SIGNATURE_JS_REORDERS_DEFAULTS = (
+    "Cannot change the signature of {qn}: the defaults of {first} and {second} "
+    "would run in the other order when a call leaves both out, and one of them "
+    "runs code the other can observe"
+)
+SIGNATURE_JS_DEFAULT_READS_LATER = (
+    "Cannot change the signature of {qn}: the default of {name} reads `{later}`, "
+    "which is not bound yet when that default runs, so a call leaving {name} "
+    "out would throw ReferenceError"
+)
+SIGNATURE_JS_STRICT_DEFAULTS = (
+    "Cannot change the signature of {qn}: its body opens with a 'use strict' "
+    "directive, and JavaScript refuses that directive in a function with a "
+    "default parameter, so the new header would not load"
+)
 SIGNATURE_PLANNED = "{count} site(s) would be rewritten, {skipped} left unmapped"
 SIGNATURE_PARSE_FAILED = "Signature change rolled back: {files} would no longer parse"
 SIGNATURE_CONTRACT_FAILED = (

{code_graph_rag-0.4.19 → code_graph_rag-0.5.0}/codebase_rag/constants/core.py

@@ -348,7 +348,11 @@ CGR_INSTRUCTIONS_SEPARATOR = "\n\n---\n\n"
 # Read only from the environment cgr starts with, never from `.env` in the
 # working directory, which usually belongs to the repository being analysed.
 ENVIRONMENT_ONLY_SETTINGS = frozenset(
-    {"CGR_TRUST_PROJECT_INSTRUCTIONS", "CGR_ALLOW_SENSITIVE_READS"}
+    {
+        "CGR_TRUST_PROJECT_INSTRUCTIONS",
+        "CGR_ALLOW_SENSITIVE_READS",
+        "CGR_ALLOW_SENSITIVE_WRITES",
+    }
 )
 # Every file cgr keeps about one checkout. They live in that checkout's
 # directory under CGR_HOME / CGR_STATE_DIRNAME rather than in the working

{code_graph_rag-0.4.19 → code_graph_rag-0.5.0}/codebase_rag/constants/mcp.py

@@ -116,6 +116,11 @@ MCP_READ_ONLY_REFUSED = (
 )
 
 
+# The HTTP transport serves plain HTTP; a Host header leaves port 80 out.
+HTTP_SCHEME = "http"
+HTTP_DEFAULT_PORT = 80
+
+
 class MCPTransport(StrEnum):
     STDIO = "stdio"
     HTTP = "http"
@@ -217,6 +222,10 @@ MCP_READ_SENSITIVE_REFUSED = (
     "{path} looks like a credential file, so it is not served over MCP. "
     "Export CGR_ALLOW_SENSITIVE_READS=true in the server's environment to serve it."
 )
+MCP_WRITE_SENSITIVE_REFUSED = (
+    "{path} looks like a credential file, so it is not changed over MCP. "
+    "Export CGR_ALLOW_SENSITIVE_WRITES=true in the server's environment to allow it."
+)
 # A `path:line` target whose line no source file can reach; sent on, it
 # overflows the 64-bit Bolt integer in the driver.
 MCP_RESOLVE_LINE_OUT_OF_RANGE = "Line {line} of {path} is out of range."

{code_graph_rag-0.4.19 → code_graph_rag-0.5.0}/codebase_rag/constants/security.py

@@ -1340,3 +1340,39 @@ SENSITIVE_PARENT_FILES = frozenset(
 )
 # Everything under these directories is key material.
 SENSITIVE_DIR_NAMES = frozenset({".ssh", ".gnupg"})
+# Windows drops trailing dots and spaces from a name, so `.git.` opens `.git`.
+WINDOWS_IGNORED_NAME_TAIL = ". "
+# A worktree's git directory names the shared one, which holds the config.
+GIT_COMMONDIR_FILENAME = "commondir"
+# What git looks for to take a folder for a git directory: a HEAD file beside
+# these folders, or beside a `commondir` file.
+GIT_HEAD_FILENAME = "HEAD"
+GIT_DIR_SUBDIRS = ("objects", "refs")
+# Asks git which git directory, and which shared one, it uses for a folder.
+# `rev-parse` runs nothing a config names, and fsmonitor is switched off on
+# top. The answer must not hang on settings the project can reach (its
+# `.env` reaches the environment): bare-repository discovery and the
+# ownership check are fixed here, on the command line, which outranks every
+# config file. Needs git 2.31 for `--path-format`; an older git falls back
+# to the rules that need no git.
+GIT_LOCATE_DIR_ARGS = (
+    "-c",
+    "core.fsmonitor=false",
+    "-c",
+    "safe.bareRepository=all",
+    "-c",
+    "safe.directory=*",
+    "rev-parse",
+    "--path-format=absolute",
+    "--git-dir",
+    "--git-common-dir",
+)
+GIT_LOCATE_DIR_TIMEOUT_S = 5
+GIT_CEILING_DIRECTORIES_ENV = "GIT_CEILING_DIRECTORIES"
+# Every variable git reads starts with this; none is passed on, so a
+# `GIT_DIR` or `GIT_CONFIG_PARAMETERS` the project set cannot steer or break
+# the answer. Only the repository's own config is read.
+GIT_ENV_PREFIX = "GIT_"
+GIT_CONFIG_NOSYSTEM_ENV = "GIT_CONFIG_NOSYSTEM"
+GIT_CONFIG_GLOBAL_ENV = "GIT_CONFIG_GLOBAL"
+GIT_ENV_ON = "1"

{code_graph_rag-0.4.19 → code_graph_rag-0.5.0}/codebase_rag/editing/signature.py

@@ -23,9 +23,9 @@ the structural delta and undone when its postcondition contract (issue
 #1531) fails: every site of the changed signature must read as mapped or
 be in the unmapped list.
 
-Python only for now: the header and the argument lists are read with the
-Python grammar, and a definition in any other language refuses (issue
-#1908).
+Headers and argument lists are read and written through a dialect per
+language: Python, and JavaScript (`signature_js.py`, `signature_js_bind.py`). A definition in any
+other language refuses (issue #1908).
 """
 
 from __future__ import annotations
@@ -49,17 +49,19 @@ from .signature_bind import (
     _find_definition,
     _params_of,
     _refuse_body_conflicts,
+    _render_arguments,
     _render_site,
     _take_receiver,
     _text,
 )
 from .signature_contract import enforce_contract
+from .signature_js_bind import JAVASCRIPT
 from .signature_spec import (
     _CALL,
     _DEFINITION,
-    _IDENTIFIER_RE,
     LANGUAGES_ISSUE,
     ParamSpec,
+    SignatureDialect,
     SignatureRefused,
     SignatureReport,
     SignatureSite,
@@ -69,6 +71,7 @@ from .signature_spec import (
     _Edit,
     _Header,
     _new_specs,
+    _parse_new_param,
     _resolve_sources,
     _Source,
     _Unmapped,
@@ -95,8 +98,7 @@ class SignatureChanger:
         # transaction undone when the contract fails.
         self.reingest = reingest
         parsers, _queries = load_parsers()
-        self._parsers = dict(parsers)
-        self._parser: Parser = self._parsers[cs.SupportedLanguage.PYTHON]
+        self._parsers: dict[cs.SupportedLanguage, Parser] = dict(parsers)
 
     # -- planning --
 
@@ -126,14 +128,17 @@ class SignatureChanger:
         patcher = Patcher(self.repo_root, parsers=self._parsers)
         members = hierarchy(self.fetch_all, self.project, qn).members
         headers = [self._header(member, patcher) for member in members]
+        dialect = _DIALECTS[headers[0].language]
         old = headers[0].params
         old_names = [p.name for p in old]
         _check_hierarchy(qn, headers, old_names)
-        new = _new_specs(new_params, old)
+        new = _new_specs(
+            new_params, old, dialect.parse_new_param, dialect.defaults_last
+        )
         sources = _resolve_sources(new, old, mapping or {})
         for spec, source in zip(new, sources, strict=True):
             if source is not None and source.literal is not None:
-                _check_literal(spec, source.literal)
+                dialect.check_literal(spec, source.literal)
         # A bare old name carries that parameter's own spelling over (each
         # override keeps its own); spelling a kept parameter out again
         # re-annotates it.
@@ -143,11 +148,10 @@ class SignatureChanger:
         # that happens to match the primary compared equal and counted as
         # carried -- leaving an override declaring `a: str` un-annotated,
         # which is the opposite of what was asked (Copilot, PR #1533).
-        carried = {
-            text.strip()
-            for text in new_params
-            if _IDENTIFIER_RE.fullmatch(text.strip()) and text.strip() in old_names
-        }
+        #
+        # An old name is a name in every dialect, so membership is the test:
+        # a Python identifier pattern would miss JavaScript's `$a`.
+        carried = {text.strip() for text in new_params if text.strip() in old_names}
         # An old parameter fed to a new one of another name is renamed, and
         # the body must follow or the definition would be broken.
         renamed = [
@@ -157,11 +161,11 @@ class SignatureChanger:
             and source.index is not None
             and old_names[source.index] != spec.name
         ]
-        _refuse_body_conflicts(headers, old_names, new, renamed)
+        dialect.refuse_body_conflicts(headers, old_names, new, renamed)
         sites: list[SignatureSite] = []
         edits: list[_Edit] = []
         for header in headers:
-            edits.extend(_definition_edits(header, new, carried, renamed))
+            edits.extend(dialect.definition_edits(header, new, carried, renamed))
             sites.append(
                 SignatureSite(
                     _DEFINITION,
@@ -197,9 +201,13 @@ class SignatureChanger:
         path = definition["path"]
         if not definition["found"] or not path:
             raise SignatureRefused(cs.RENAME_UNKNOWN.format(qn=qn))
-        if get_language_for_extension(Path(path).suffix) != cs.SupportedLanguage.PYTHON:
+        language = get_language_for_extension(Path(path).suffix)
+        dialect = _DIALECTS.get(language) if language is not None else None
+        if language is None or dialect is None:
             raise SignatureRefused(
-                cs.SIGNATURE_NOT_PYTHON.format(qn=qn, path=path, issue=LANGUAGES_ISSUE)
+                cs.SIGNATURE_UNSUPPORTED_LANGUAGE.format(
+                    qn=qn, path=path, issue=LANGUAGES_ISSUE
+                )
             )
         try:
             source = patcher.source(path)
@@ -210,13 +218,13 @@ class SignatureChanger:
         start = definition["start_line"] or 1
         end = definition["end_line"] or start
         name = definition["name"] or qn.rsplit(cs.SEPARATOR_DOT, 1)[-1]
-        root = self._parser.parse(source).root_node
-        node = _find_definition(root, name, start, end)
+        root = self._parsers[language].parse(source).root_node
+        node = dialect.find_definition(root, name, start, end)
         params = node.child_by_field_name(cs.FIELD_PARAMETERS) if node else None
         if node is None or params is None:
             raise SignatureRefused(cs.SIGNATURE_NO_HEADER.format(qn=qn, path=path))
-        specs = _params_of(params, source, qn)
-        receiver = _take_receiver(qn, definition["label"], specs, node, source)
+        specs = dialect.params_of(params, source, qn)
+        receiver = dialect.take_receiver(qn, definition["label"], specs, node, source)
         return _Header(
             qn,
             path,
@@ -227,6 +235,7 @@ class SignatureChanger:
             specs,
             node,
             source,
+            language,
         )
 
     def _collect_sites(
@@ -241,6 +250,7 @@ class SignatureChanger:
         edits: list[_Edit],
     ) -> list[UnmappedSite]:
         unmapped: list[UnmappedSite] = []
+        render = _DIALECTS[headers[0].language].render_arguments
         candidates = self._candidates(headers, old, allow_heuristic, patcher, unmapped)
         # Innermost first, so a site nested in another's arguments (or a
         # body rename inside a recursive call) is already planned when the
@@ -257,7 +267,7 @@ class SignatureChanger:
         for index in order:
             candidate = candidates[index]
             try:
-                edit = _render_site(candidate, new, sources, edits)
+                edit = _render_site(candidate, new, sources, edits, render)
             except _Unmapped as skip:
                 unmapped.append(
                     UnmappedSite(
@@ -350,8 +360,11 @@ class SignatureChanger:
             )
         if resolution in AMBIGUOUS and not allow_heuristic:
             raise _Unmapped(cs.SIGNATURE_SITE_GUESSED.format(resolution=resolution))
-        if get_language_for_extension(Path(path).suffix) != cs.SupportedLanguage.PYTHON:
-            raise _Unmapped(cs.SIGNATURE_SITE_NOT_PYTHON.format(path=path))
+        # A call from another language reaches the definition through some
+        # binding layer this operation cannot read.
+        if get_language_for_extension(Path(path).suffix) != header.language:
+            raise _Unmapped(cs.SIGNATURE_SITE_OTHER_LANGUAGE.format(path=path))
+        dialect = _DIALECTS[header.language]
         try:
             source = patcher.source(path)
         except PatcherError as error:
@@ -364,24 +377,12 @@ class SignatureChanger:
             if end_line is not None and end_col is not None
             else None
         )
-        root = self._parser.parse(source).root_node
+        root = self._parsers[header.language].parse(source).root_node
         call = call_node_at(root, line, col, recorded_end)
         if call is None:
             raise _Unmapped(cs.SIGNATURE_SITE_NO_CALL)
-        args = call.child_by_field_name(cs.FIELD_ARGUMENTS)
-        if args is None or args.type != cs.TS_ARGUMENT_LIST:
-            # `helper(x for x in xs)`: a generator, not a list of values.
-            raise _Unmapped(
-                cs.SIGNATURE_SITE_UNREADABLE.format(text=_text(args or call, source))
-            )
-        if _binds_its_receiver(header) and _passes_receiver(call, source, header.qn):
-            # `Base.f(obj, a)` passes `self` as its first argument: binding
-            # it to the first declared parameter would shift every value
-            # one slot. Left as written rather than guessed at.
-            raise _Unmapped(
-                cs.SIGNATURE_SITE_EXPLICIT_RECEIVER.format(text=_text(call, source))
-            )
-        bound = _bind_arguments(args, source, old)
+        args = dialect.site_arguments(header, call, source)
+        bound = dialect.bind_arguments(args, source, old)
         site = SignatureSite(_CALL, path, line, col, row["qualified_name"], resolution)
         return _Candidate(
             site, (args.start_byte, args.end_byte), _text(args, source), bound
@@ -487,6 +488,23 @@ class SignatureChanger:
         return report
 
 
+def _python_site_arguments(header: _Header, call: Node, source: bytes) -> Node:
+    args = call.child_by_field_name(cs.FIELD_ARGUMENTS)
+    if args is None or args.type != cs.TS_ARGUMENT_LIST:
+        # `helper(x for x in xs)`: a generator, not a list of values.
+        raise _Unmapped(
+            cs.SIGNATURE_SITE_UNREADABLE.format(text=_text(args or call, source))
+        )
+    if _binds_its_receiver(header) and _passes_receiver(call, source, header.qn):
+        # `Base.f(obj, a)` passes `self` as its first argument: binding
+        # it to the first declared parameter would shift every value
+        # one slot. Left as written rather than guessed at.
+        raise _Unmapped(
+            cs.SIGNATURE_SITE_EXPLICIT_RECEIVER.format(text=_text(call, source))
+        )
+    return args
+
+
 def _binds_its_receiver(header: _Header) -> bool:
     """An instance method: called through an instance, `self` is implicit.
 
@@ -566,6 +584,23 @@ def _imported_as(node: Node, source: bytes, alias: str) -> str | None:
     return None
 
 
+_DIALECTS: dict[cs.SupportedLanguage, SignatureDialect] = {
+    cs.SupportedLanguage.PYTHON: SignatureDialect(
+        find_definition=_find_definition,
+        params_of=_params_of,
+        take_receiver=_take_receiver,
+        parse_new_param=_parse_new_param,
+        check_literal=_check_literal,
+        refuse_body_conflicts=_refuse_body_conflicts,
+        definition_edits=_definition_edits,
+        site_arguments=_python_site_arguments,
+        bind_arguments=_bind_arguments,
+        render_arguments=_render_arguments,
+    ),
+    cs.SupportedLanguage.JS: JAVASCRIPT,
+}
+
+
 def change_signature(
     repo_root: Path,
     fetch_all: QueryFn,

{code_graph_rag-0.4.19 → code_graph_rag-0.5.0}/codebase_rag/editing/signature_bind.py

@@ -7,7 +7,7 @@ from __future__ import annotations
 
 import re
 import symtable
-from collections.abc import Iterable, Mapping, Sequence
+from collections.abc import Callable, Iterable, Mapping, Sequence
 from itertools import product
 
 from tree_sitter import Node
@@ -508,6 +508,9 @@ def _render_site(
     new: Sequence[ParamSpec],
     sources: Sequence[_Source | None],
     edits: list[_Edit],
+    render: Callable[
+        [Sequence[ParamSpec], Sequence[_Source | None], Mapping[int, _Binding]], str
+    ] = _render_arguments,
 ) -> _Edit | None:
     """The site's edit, with any edit planned inside its arguments folded in.
 
@@ -516,7 +519,7 @@ def _render_site(
     """
     bound, consumed = _fold(candidate, edits)
     _refuse_dropped_effects(sources, bound)
-    text = _render_arguments(new, sources, bound)
+    text = render(new, sources, bound)
     for edit in consumed:
         edits.remove(edit)
     if not consumed and text == candidate.text: