code-coordinator 0.5.754__tar.gz → 0.5.755__tar.gz

{code_coordinator-0.5.754 → code_coordinator-0.5.755}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.754
+Version: 0.5.755
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

{code_coordinator-0.5.754 → code_coordinator-0.5.755}/code_coordinator.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.754
+Version: 0.5.755
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

{code_coordinator-0.5.754 → code_coordinator-0.5.755}/code_coordinator.egg-info/scm_version.json

@@ -1,7 +1,7 @@
 {
-  "tag": "0.5.754",
+  "tag": "0.5.755",
   "distance": 0,
-  "node": "gca5c9c8d866fbdba07936a9b9e7e0facc4cf0c1e",
+  "node": "g7b46fbb3e62c0f7e3e7d877b23ebe7bbf4cfdf34",
   "dirty": false,
   "branch": "HEAD",
   "node_date": "2026-11-10"

{code_coordinator-0.5.754 → code_coordinator-0.5.755}/coord/agent.py

@@ -30,6 +30,7 @@ from typing import TYPE_CHECKING, Any, Callable, Iterable
 from coord import cargo_cache
 from coord.claude_setup_token import inject_setup_token
 from coord.config_reload import reload_config_if_stale
+from coord.decomposition_chat import is_size_triage_review_target
 from coord.models import DELIVERABLE_ANALYSIS_LABEL
 from coord.platform_paths import default_coord_dir
 from coord.smoke_tags import smoke_leg_capabilities
@@ -11971,7 +11972,20 @@ class AgentServer:
             # timeout (60 s) but MUST NOT let a hung push block the
             # status update — so we catch both _GitError *and*
             # subprocess.TimeoutExpired and treat both as non-fatal.
-            if assignment.worktree_path:
+            # #3975: a size-triage leg is read-only by its own system prompt
+            # (`build_size_triage_briefing` forbids commits) and its branch
+            # is cut fresh from the default branch's tip with zero commits
+            # of its own. Pushing that branch anyway gives #3376's
+            # issue-scoped `any_matching_branch_merged` fallback a
+            # zero-commit `issue-N-size-triage-*` branch to mis-read as
+            # "already merged" (it's an ancestor of the default branch),
+            # which refuses the very Work dispatch the triage verdict just
+            # unblocked. Skip the push entirely for this leg shape — there
+            # is nothing of this leg's own to push, so there's nothing lost.
+            _is_size_triage_leg = is_size_triage_review_target(
+                getattr(assignment.spec, "review_target", None)
+            )
+            if assignment.worktree_path and not _is_size_triage_leg:
                 wt_path = Path(assignment.worktree_path)
                 if wt_path.exists() and exit_code == 0:
                     # #3869: a history-rewrite leg (today, only

{code_coordinator-0.5.754 → code_coordinator-0.5.755}/coord/claim.py

@@ -478,7 +478,7 @@ def _default_branch_lookup(repo_github: str, issue_number: int) -> list[str]:
 # distinction has to be verified per-dispatcher, not assumed; see the
 # issue's suggested structural alternative (branch never had commits, ever)
 # for a fix that wouldn't require keeping this list exhaustive by hand.
-_OBSERVER_LEG_TAGS = ("review", "scoped-review", "smoke", "gate-b")
+_OBSERVER_LEG_TAGS = ("review", "scoped-review", "smoke", "gate-b", "size-triage")
 
 
 def _is_observer_leg_branch(branch: str, issue_number: int) -> bool:

{code_coordinator-0.5.754 → code_coordinator-0.5.755}/coord/gates.py

@@ -201,9 +201,24 @@ class GateReport:
 
 
 def _row_from_assignment(a: "Assignment") -> AssignmentGateRow:
+    from coord.decomposition_chat import is_size_triage_review_target  # noqa: PLC0415
+
+    # #3975: a size-triage leg is dispatched with `type="review"` only to
+    # reuse coord.agent's read-only deny-list for that type — it never
+    # produces a REVIEW_VERDICT and is not evidence toward the issue's
+    # review gate. Label the raw row "size-triage" instead of "review" so
+    # `coord gates`' row listing (and its `--json`/`report_to_dict` form)
+    # can't be mistaken for the issue's actual review stage — see
+    # `build_gate_report`'s `work_like` gate above, which already excludes
+    # this row from ever backing a "review" GateDecision.
+    row_type = (
+        "size-triage"
+        if a.type == "review" and is_size_triage_review_target(a.review_target)
+        else (a.type or "work")
+    )
     return AssignmentGateRow(
         assignment_id=a.assignment_id,
-        type=a.type or "work",
+        type=row_type,
         status=a.status,
         branch=a.branch,
         machine_name=a.machine_name,

{code_coordinator-0.5.754 → code_coordinator-0.5.755}/coord/stage_projection.py

@@ -34,6 +34,7 @@ from __future__ import annotations
 import dataclasses
 from typing import Any, Protocol, runtime_checkable
 
+from coord.decomposition_chat import is_size_triage_review_target
 from coord.models import CLOSES_ISSUE_TYPES, WORK_LIKE_TYPES, effective_issue_number
 # #3191: the two #3182 fan-out encodings this module has to PARSE to count
 # Test *rounds* rather than raw smoke rows — see `_test_stage_leg_count`.
@@ -167,6 +168,16 @@ def assignments_for_stage(
     ``require_plan`` and no ``type="plan"`` assignment for this issue),
     plan-typed assignments fold into "work" so a ``--plan-only`` dispatch
     without ``require_plan`` doesn't disappear from the Work stage.
+
+    #3975: a size-triage leg is dispatched with ``type="review"`` purely to
+    reuse ``coord.agent``'s read-only deny-list for that type (see
+    ``coord.decomposition_chat.dispatch_size_triage_review``'s own comment)
+    — it is not a code review and carries no ``review_verdict`` a real
+    review would. Counting it toward the "review" stage painted
+    quadraui#2304's board as "review" while Work hadn't even been
+    dispatched yet (a size-triage leg's ``status="running"`` trips the
+    ACTIVE check in ``stage_status_for`` before any work row exists). Drop
+    it here, once, rather than at every stage-status call site.
     """
     fold_plan_into_work = (
         stage == "work"
@@ -175,6 +186,8 @@ def assignments_for_stage(
     )
     out = []
     for a in assignments_for_issue:
+        if is_size_triage_review_target(getattr(a, "review_target", None)):
+            continue
         t = a.type or "work"
         if fold_plan_into_work:
             if t in ("work", "plan"):

{code_coordinator-0.5.754 → code_coordinator-0.5.755}/tests/test_agent_push_failure.py

@@ -22,6 +22,16 @@ history has actually been rewritten). `TestHistoryRewriteLegSafetyNetPush`
 below covers the `--force-with-lease` push this file's `_HISTORY_REWRITE_
 TYPES` leg now uses instead, and the promotion of a non-fast-forward/
 stale-lease rejection to the same FAILED outcome as an auth break.
+
+#3975: a size-triage leg (`coord.decomposition_chat.dispatch_size_triage_
+review`) is read-only by its own system prompt and its branch is cut fresh
+from the default branch's tip, so this reap-time safety-net push has
+nothing of the leg's own to push in the first place — and pushing the
+empty branch anyway hands #3376's `any_matching_branch_merged` fallback a
+zero-commit `issue-N-size-triage-*` branch to mis-read as "already
+merged", refusing the Work dispatch the triage verdict just unblocked
+(quadraui#2304). `test_size_triage_leg_reap_skips_the_push` below pins
+down that this reap-time push is never even attempted for that leg shape.
 """
 
 from __future__ import annotations
@@ -508,6 +518,52 @@ def test_successful_push_leaves_push_failure_reason_none(
     server.shutdown()
 
 
+def test_size_triage_leg_reap_skips_the_push(
+    tmp_path: Path, repo_with_rejecting_remote: tuple[Path, Path]
+) -> None:
+    """#3975: a size-triage leg's reap must never attempt the
+    belt-and-suspenders push at all — not even one that would otherwise
+    fail loudly. The rejecting remote proves the point: if reap attempted
+    the push, this leg would come back FAILED with an auth-shaped
+    `push_failure_reason`; since the leg is read-only, it must instead come
+    back DONE with no push attempted and no branch created on origin."""
+    clone, origin = repo_with_rejecting_remote
+    server = AgentServer(
+        machine_name="t",
+        repos=["api"],
+        repo_paths={"api": str(clone)},
+        state_dir=tmp_path / "state",
+        worker_command=lambda spec: ["/bin/sh", "-c", "true"],  # read-only, no commits
+    )
+    spec = AssignmentSpec(
+        repo_name="api",
+        repo_path=str(clone),
+        issue_number=2304,
+        issue_title="[size-triage] shared app layer 2a widgetid",
+        briefing="b",
+        branch="main",
+        type="review",
+        review_target="size-triage-2304",
+    )
+    a = server.assign(spec)
+    final = server.wait_for(a.id, timeout=15)
+
+    assert final.status == DONE
+    assert final.push_failure_reason is None
+    log_text = Path(final.log_path).read_text()
+    assert "# reap: push starting" not in log_text
+    assert "# reap: push completed" not in log_text
+    # The branch the agent would have minted (`issue-2304-size-triage-...`)
+    # must never reach origin — the whole bug was that empty branch landing
+    # there and being misread as "this issue's work already merged".
+    refs = subprocess.run(
+        ["git", "ls-remote", "--heads", str(origin)],
+        capture_output=True, text=True, check=True,
+    ).stdout
+    assert "size-triage" not in refs
+    server.shutdown()
+
+
 @pytest.fixture
 def repo_with_existing_branch(tmp_path: Path) -> tuple[Path, Path]:
     """A clone with `origin` configured and a `feature` branch already

{code_coordinator-0.5.754 → code_coordinator-0.5.755}/tests/test_claim.py

@@ -973,12 +973,37 @@ def test_any_matching_branch_merged_issue_scoped_ignores_gate_b_leg(
     assert claim_mod.any_matching_branch_merged("acme/vimcode", 900) is False
 
 
+def test_any_matching_branch_merged_issue_scoped_ignores_size_triage_leg(
+    monkeypatch,
+) -> None:
+    """#3975: quadraui#2304's exact shape — a zero-commit
+    `issue-{N}-size-triage-*` branch (cut from the default branch's tip by
+    the read-only size-triage leg) sitting at `ahead_by == 0`, with no real
+    work branch dispatched yet. `any_matching_branch_merged` with no
+    *branch* (the dispatch-liveness fallback a re-queued Work dispatch
+    hits right after the triage leg says `proceed`) must not read the
+    triage branch as "this issue's work already merged" — that misread is
+    exactly what refused the Work dispatch in the incident."""
+    import coord.claim as claim_mod
+
+    monkeypatch.setattr(
+        "coord.github_ops._gh",
+        _gh_stub_with_matching_refs(
+            ["issue-2304-size-triage-shared-app-layer-2a-widgetid"],
+            "develop",
+            {"issue-2304-size-triage-shared-app-layer-2a-widgetid": 0},
+        ),
+    )
+    assert claim_mod.any_matching_branch_merged("acme/vimcode", 2304) is False
+
+
 def test_is_observer_leg_branch_matches_review_scoped_review_smoke_and_gate_b() -> None:
-    """#3442: the exact prefixes review/smoke/gate-b legs mint, and nothing
-    else — a bare `issue-N-review` (no trailing content) and the slugified
-    `issue-N-review-...`/`issue-N-scoped-review-...`/`issue-N-smoke-...`/
-    `issue-N-gate-b-...` shapes all match; an unrelated branch, or one that
-    merely CONTAINS "review" past the issue-number prefix, must not."""
+    """#3442/#3975: the exact prefixes review/smoke/gate-b/size-triage legs
+    mint, and nothing else — a bare `issue-N-review` (no trailing content)
+    and the slugified `issue-N-review-...`/`issue-N-scoped-review-...`/
+    `issue-N-smoke-...`/`issue-N-gate-b-...`/`issue-N-size-triage-...` shapes
+    all match; an unrelated branch, or one that merely CONTAINS "review"
+    past the issue-number prefix, must not."""
     import coord.claim as claim_mod
 
     assert claim_mod._is_observer_leg_branch("issue-9-review", 9) is True
@@ -990,6 +1015,9 @@ def test_is_observer_leg_branch_matches_review_scoped_review_smoke_and_gate_b()
     assert claim_mod._is_observer_leg_branch(
         "issue-9-gate-b-ms-9-milestone-verdict", 9
     ) is True
+    assert claim_mod._is_observer_leg_branch(
+        "issue-9-size-triage-shared-app-layer", 9
+    ) is True
     assert claim_mod._is_observer_leg_branch("issue-9-real-work", 9) is False
     assert claim_mod._is_observer_leg_branch(
         "issue-9-reviewer-onboarding", 9

{code_coordinator-0.5.754 → code_coordinator-0.5.755}/tests/test_gates.py

@@ -295,6 +295,38 @@ class TestRows:
         assert report.decisions == []
         assert any("no work-like assignment" in n for n in report.notes)
 
+    def test_size_triage_only_assignment_reports_no_review_stage(
+        self, config: Config
+    ) -> None:
+        """#3975: a size-triage leg is dispatched with `type="review"` only
+        to reuse `coord.agent`'s read-only deny-list for that type — it is
+        not a code review. An issue with no work dispatched yet and only a
+        size-triage leg on the board must not have `coord gates` present
+        that leg as the issue's review stage: no "review" `GateDecision`
+        (already true — `review` isn't in `WORK_LIKE_TYPES`, so the
+        work-like gate above bails first) AND the raw row itself must not
+        render `[review]`, which is what actually misled quadraui#2304."""
+        triage = Assignment(
+            machine_name="precision",
+            repo_name="api",
+            issue_number=42,
+            issue_title="[size-triage] t",
+            assignment_id="triage-1",
+            type="review",
+            status="running",
+            review_target="size-triage-42",
+            branch="main",
+        )
+        board = Board(active=[triage], completed=[])
+        report = build_gate_report(board, config, "api", 42)
+        assert len(report.rows) == 1
+        assert report.rows[0].type == "size-triage"
+        assert report.decisions == []
+        assert not any(d.gate == "review" for d in report.decisions)
+        assert any("no work-like assignment" in n for n in report.notes)
+        assert "[review]" not in format_gate_report(report)
+        assert "[size-triage]" in format_gate_report(report)
+
     def test_winner_with_no_branch_leaves_decision_empty(self, config: Config) -> None:
         work = _work(branch=None)
         board = Board(active=[], completed=[work])

{code_coordinator-0.5.754 → code_coordinator-0.5.755}/tests/test_stage_projection.py

@@ -74,6 +74,28 @@ def test_stage_status_running_is_active():
     assert sp.stage_status_for(a, "review", stage_names=["work", "review"], is_closed=False, require_plan=False) == sp.ACTIVE
 
 
+def test_stage_status_review_ignores_size_triage_leg():
+    """#3975: a size-triage leg is dispatched `type="review"` only to reuse
+    coord.agent's read-only deny-list for that type — it is not evidence
+    toward the "review" stage. Before this fix, its `status="running"`
+    tripped the generic ACTIVE check and painted the board "review: active"
+    for an issue where Work hadn't even been dispatched yet (quadraui#2304:
+    "went straight to review, skipping Work and Test")."""
+    a = [
+        Assignment(
+            machine_name="laptop", repo_name="api", issue_number=1,
+            issue_title="[size-triage] t", type="review", status="running",
+            review_target="size-triage-1", dispatched_at=1.0,
+        )
+    ]
+    assert sp.stage_status_for(
+        a, "review", stage_names=["work", "review"], is_closed=False, require_plan=False
+    ) == sp.PENDING
+    assert sp.stage_status_for(
+        a, "work", stage_names=["work", "review"], is_closed=False, require_plan=False
+    ) == sp.PENDING
+
+
 def test_stage_status_review_approve_is_done():
     a = [_review(status="done", review_verdict="approve", dispatched_at=1.0)]
     assert sp.stage_status_for(a, "review", stage_names=["work", "review"], is_closed=False, require_plan=False) == sp.DONE