code-coordinator 0.5.69__tar.gz → 0.5.70__tar.gz

{code_coordinator-0.5.69 → code_coordinator-0.5.70}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.69
+Version: 0.5.70
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

{code_coordinator-0.5.69 → code_coordinator-0.5.70}/code_coordinator.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.69
+Version: 0.5.70
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

{code_coordinator-0.5.69 → code_coordinator-0.5.70}/code_coordinator.egg-info/scm_version.json

@@ -1,7 +1,7 @@
 {
-  "tag": "0.5.69",
+  "tag": "0.5.70",
   "distance": 0,
-  "node": "g9207e64664c53099584e448cecb53206429b6a9c",
+  "node": "g522a9f215942bd8d54b0906c6f672934c636ad73",
   "dirty": false,
   "branch": "HEAD",
   "node_date": "2026-08-14"

{code_coordinator-0.5.69 → code_coordinator-0.5.70}/coord/agent.py

@@ -1118,6 +1118,7 @@ def _worker_subprocess_env(
     prefix: str | None = None,
     base_prefix: str | None = None,
     cwd: "str | Path | None" = None,
+    assignment_id: str | None = None,
 ) -> dict[str, str]:
     """Environment for worker `claude -p` subprocesses, with the agent's own
     venv removed (#402).
@@ -1150,6 +1151,21 @@ def _worker_subprocess_env(
     ``provider.env()`` on top of this result may still override ``PWD``
     deliberately; that ordering is preserved since we only set it here, not
     after.
+
+    #2217: ``assignment_id``, when given, is written to
+    ``COORD_ASSIGNMENT_ID``. The headless worker prompt (built in
+    ``review.py`` and elsewhere) tells every worker that if this variable is
+    set it should call ``coord report-result --assignment
+    "$COORD_ASSIGNMENT_ID" ...`` directly as the *authoritative* verdict
+    path, with the transcript-parsed ``END_REVIEW`` block as a fallback only.
+    Before this, nothing in the headless ``claude -p`` dispatch lane (this
+    function is the only place that lane's subprocess environment is built)
+    ever set the variable, so that "primary" path was dead on arrival for
+    every headless review — the fragile transcript parse was silently the
+    *only* path, not a backup. Both spawn call sites below pass
+    ``assignment_id=assignment.id`` so it's set for every worker type (review,
+    smoke, work), matching what ``coord/commands/review.py`` already reads as
+    its ``--assignment`` default.
     """
     env = dict(os.environ if base_env is None else base_env)
     pfx = sys.prefix if prefix is None else prefix
@@ -1172,6 +1188,9 @@ def _worker_subprocess_env(
     if cwd is not None:
         env["PWD"] = str(cwd)
 
+    if assignment_id is not None:
+        env["COORD_ASSIGNMENT_ID"] = assignment_id
+
     return env
 
 
@@ -6494,7 +6513,7 @@ class AgentServer:
         # daemon happened to start in — worktree confinement for those
         # providers must not depend on `bash_wrap_spawn` recomputing PWD as
         # a side effect (see `_maybe_bash_wrap`).
-        _spawn_env = _worker_subprocess_env(cwd=repo_path)
+        _spawn_env = _worker_subprocess_env(cwd=repo_path, assignment_id=assignment.id)
         # #1402: shared per-repo cargo target dir (see coord.cargo_cache).
         # Must stay in sync with the PTY path in ``_spawn_pty``.
         _spawn_env.update(
@@ -6668,7 +6687,7 @@ class AgentServer:
             # docstring above), so unlike the headless path it never got an
             # incidental PWD correction — confinement here must not depend
             # on a provider trusting $PWD over getcwd() by accident.
-            env = _worker_subprocess_env(cwd=repo_path)
+            env = _worker_subprocess_env(cwd=repo_path, assignment_id=assignment.id)
             env.setdefault("TERM", "xterm-256color")
             # #1402: point cargo at this machine's shared per-repo target dir
             # so the build cache survives worktree cleanup and is reused by

{code_coordinator-0.5.69 → code_coordinator-0.5.70}/tests/test_agent.py

@@ -146,6 +146,36 @@ def test_worker_env_no_cwd_leaves_pwd_untouched() -> None:
     assert env["PWD"] == "/whatever"
 
 
+def test_worker_env_sets_coord_assignment_id() -> None:
+    """#2217: the headless worker prompt (review.py) tells every worker that
+    if $COORD_ASSIGNMENT_ID is set, it must report its verdict straight to
+    the coordinator board via `coord report-result` as the *authoritative*
+    path — with the transcript-parsed END_REVIEW block as a fallback only.
+    Nothing set the variable for the headless `claude -p` dispatch lane, so
+    that "primary" instruction was dead on arrival for every review and the
+    fragile transcript parse was silently the only path. Both `_spawn` call
+    sites must pass assignment_id= so this is set for every worker type."""
+    env = _worker_subprocess_env(
+        {"PATH": "/usr/bin"},
+        prefix="/usr",
+        base_prefix="/usr",
+        assignment_id="abc123",
+    )
+    assert env["COORD_ASSIGNMENT_ID"] == "abc123"
+
+
+def test_worker_env_no_assignment_id_leaves_var_unset() -> None:
+    """When assignment_id isn't passed, COORD_ASSIGNMENT_ID must not appear
+    at all (not even empty) — callers that don't have an assignment yet
+    (e.g. standalone helper use) shouldn't leak a stale/empty value."""
+    env = _worker_subprocess_env(
+        {"PATH": "/usr/bin"},
+        prefix="/usr",
+        base_prefix="/usr",
+    )
+    assert "COORD_ASSIGNMENT_ID" not in env
+
+
 def test_health_reports_machine(tmp_path: Path) -> None:
     server = _server(tmp_path)
     h = server.health()
@@ -431,6 +461,40 @@ def test_spawn_sets_pwd_to_worktree_bash_wrap_enabled(tmp_path: Path) -> None:
     server.shutdown()
 
 
+def test_spawn_sets_coord_assignment_id(tmp_path: Path) -> None:
+    """#2217: the headless `_spawn` path must set COORD_ASSIGNMENT_ID to the
+    assignment's own id — this is the variable the review prompt tells every
+    worker to use for `coord report-result --assignment "$COORD_ASSIGNMENT_ID"
+    ...`, the "authoritative" primary verdict path. Before #2217 nothing set
+    it anywhere in this dispatch lane, so that instruction was silently
+    unreachable for every headless review; only the fragile transcript-parsed
+    END_REVIEW fallback ever ran. This test must fail against pre-#2217 code.
+    """
+    import coord.agent as agent_mod
+
+    repo = _init_repo(tmp_path / "repo")
+    server = _server(tmp_path, repo_path=repo)
+
+    captured_env: list[dict[str, str]] = []
+    real_popen = agent_mod.subprocess.Popen
+
+    def recording_popen(spawn_argv, *args, **kwargs):
+        if kwargs.get("start_new_session"):
+            captured_env.append(dict(kwargs.get("env") or {}))
+        return real_popen(spawn_argv, *args, **kwargs)
+
+    agent_mod.subprocess.Popen = recording_popen  # type: ignore[assignment]
+    try:
+        a = server.assign(_spec(repo, type="review"))
+        final = server.wait_for(a.id)
+    finally:
+        agent_mod.subprocess.Popen = real_popen  # type: ignore[assignment]
+
+    assert captured_env, "Popen was not called"
+    assert captured_env[0]["COORD_ASSIGNMENT_ID"] == final.id == a.id
+    server.shutdown()
+
+
 def test_pty_spawn_sets_pwd_to_repo_path(tmp_path: Path) -> None:
     """#1783: the PTY spawn path (_spawn_pty) gets the same explicit-PWD
     treatment as the headless path.