code-coordinator 0.5.516__tar.gz → 0.5.517__tar.gz

{code_coordinator-0.5.516 → code_coordinator-0.5.517}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.516
+Version: 0.5.517
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

{code_coordinator-0.5.516 → code_coordinator-0.5.517}/code_coordinator.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.516
+Version: 0.5.517
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

code_coordinator-0.5.517/code_coordinator.egg-info/scm_version.json

@@ -0,0 +1,8 @@
+{
+  "tag": "0.5.517",
+  "distance": 0,
+  "node": "g2cc5b156d53fe993bfa01632f5a6070991c56383",
+  "dirty": false,
+  "branch": "HEAD",
+  "node_date": "2026-09-25"
+}

{code_coordinator-0.5.516 → code_coordinator-0.5.517}/coord/claim.py

@@ -454,6 +454,40 @@ def _default_branch_lookup(repo_github: str, issue_number: int) -> list[str]:
     return _drop_merged_branches(repo_github, branches)
 
 
+# #3442: bracket-tag issue_title prefixes (`f"[{tag}] {title}"`, see
+# `coord.review.dispatch_review` / `coord.review._dispatch_scoped_review` /
+# `coord.smoke.dispatch_pending_smoke` / `coord.gate_b`'s tracking-issue
+# dispatch) that a review/smoke/gate-b leg dispatch uses when it does NOT
+# pin `target_branch` to the real work branch — the agent then derives its
+# own throwaway branch name by slugifying that bracketed title
+# (`coord.agent._slugify`), landing on `issue-{N}-{tag}-...`. These legs
+# are read-only observers: a review posts a verdict comment, a smoke run
+# executes a command, gate-b posts a milestone verdict — none of them ever
+# commits to its own checkout, so that branch sits at `ahead_by == 0`
+# against the default branch from the moment it's created, forever,
+# regardless of whether the issue's REAL work has landed. It is not
+# evidence of anything. Every OTHER dispatcher that continues real work on
+# an issue (conflict-fix, retry, fix-N) pins `target_branch` to the actual
+# work branch instead of letting one of these get minted, so this list is
+# deliberately just the observer legs, not every bracket tag in the
+# codebase — though as #3442's own review round found for gate-b, that
+# distinction has to be verified per-dispatcher, not assumed; see the
+# issue's suggested structural alternative (branch never had commits, ever)
+# for a fix that wouldn't require keeping this list exhaustive by hand.
+_OBSERVER_LEG_TAGS = ("review", "scoped-review", "smoke", "gate-b")
+
+
+def _is_observer_leg_branch(branch: str, issue_number: int) -> bool:
+    """True when *branch* is a review/smoke leg's own throwaway checkout,
+    not a branch that could ever carry real work (see `_OBSERVER_LEG_TAGS`).
+    """
+    for tag in _OBSERVER_LEG_TAGS:
+        prefix = f"issue-{issue_number}-{tag}"
+        if branch == prefix or branch.startswith(prefix + "-"):
+            return True
+    return False
+
+
 def any_matching_branch_merged(
     repo_github: str, issue_number: int, *, branch: str | None = None
 ) -> bool:
@@ -476,17 +510,29 @@ def any_matching_branch_merged(
     merged" behaviour only when *branch* is `None` — a caller with nothing
     assigned yet (a pre-dispatch check before any branch exists) has no
     single branch to ask about, so the issue-scoped signal is the best one
-    available. Reuses the exact merge-detection `_drop_merged_branches`
-    already performs for claim detection (PR-merged OR `ahead_by == 0`
-    ancestry, survives squash merges — #3103): this is just "did filtering
-    drop anything", with the fail-open direction flipped to match a
-    REFUSAL predicate rather than a claim-signal — no matching branch at
-    all, or any lookup failure, returns `False` ("not merged, don't refuse
-    dispatch on this"), never `True`.
+    available. #3442: that fallback first drops every known
+    `_is_observer_leg_branch` candidate — #3436 only fixed the case where
+    the dispatch's OWN branch was already known; a plain `coord assign`
+    (or any other caller with no branch recorded yet, which is exactly when
+    this fallback runs) has no branch of its own to scope to, so without
+    this filter a single zero-commit `issue-{N}-review-*`/`issue-{N}-smoke-
+    *` leg branch still reads the WHOLE issue as merged and permanently
+    refuses dispatch — the same bug #3436 fixed for the branch-known case,
+    reopened for the branch-unknown one. Reuses the exact merge-detection
+    `_drop_merged_branches` already performs for claim detection (PR-merged
+    OR `ahead_by == 0` ancestry, survives squash merges — #3103): this is
+    just "did filtering drop anything", with the fail-open direction
+    flipped to match a REFUSAL predicate rather than a claim-signal — no
+    matching branch at all, or any lookup failure, returns `False` ("not
+    merged, don't refuse dispatch on this"), never `True`.
     """
     if branch is not None:
         return not _drop_merged_branches(repo_github, [branch])
-    branches = list_matching_remote_branches(repo_github, issue_number)
+    branches = [
+        b
+        for b in list_matching_remote_branches(repo_github, issue_number)
+        if not _is_observer_leg_branch(b, issue_number)
+    ]
     if not branches:
         return False
     unmerged = set(_drop_merged_branches(repo_github, branches))

{code_coordinator-0.5.516 → code_coordinator-0.5.517}/tests/test_claim.py

@@ -876,14 +876,15 @@ def test_any_matching_branch_merged_false_on_gh_error(monkeypatch) -> None:
 def test_any_matching_branch_merged_scoped_branch_ignores_merged_siblings(
     monkeypatch,
 ) -> None:
-    """#3436: reproduces vimcode#1156's shape — several MERGED, zero-commit
-    `issue-{N}-*` review-leg branches (cut from the default-branch tip,
-    never diverged) alongside the one real, unmerged work branch. The
-    issue-scoped (no ``branch=``) check is tripped by the merged siblings —
-    the documented fallback behaviour for a caller with nothing dispatched
-    yet — but a caller that names the ACTUAL branch in play must get an
+    """#3436/#3442: reproduces vimcode#1156's shape — several MERGED,
+    zero-commit `issue-{N}-*` review-leg branches (cut from the
+    default-branch tip, never diverged) alongside the one real, unmerged
+    work branch. A caller that names the ACTUAL branch in play must get an
     answer scoped to just that branch, not "did anything for this issue
-    ever merge"."""
+    ever merge" — and #3442: the issue-scoped fallback (no ``branch=``)
+    must ALSO see past a review-leg sibling now, since it's the fallback a
+    plain `coord assign` (nothing dispatched yet, no branch to scope to)
+    actually hits."""
     import coord.claim as claim_mod
 
     monkeypatch.setattr(
@@ -894,19 +895,107 @@ def test_any_matching_branch_merged_scoped_branch_ignores_merged_siblings(
             {"issue-1156-review-fix-1": 0, "issue-1156-real-work": 5},
         ),
     )
-    # No branch named: falls back to the issue-scoped check, which still
-    # trips on the merged sibling (unchanged pre-#3436 fallback behaviour).
-    assert claim_mod.any_matching_branch_merged("acme/api", 1156) is True
+    # No branch named: falls back to the issue-scoped check, which now
+    # excludes the review-leg sibling as not-evidence-of-anything (#3442)
+    # and finds the real work branch unmerged.
+    assert claim_mod.any_matching_branch_merged("acme/api", 1156) is False
     # Scoped to the real, unmerged work branch: must NOT report merged.
     assert claim_mod.any_matching_branch_merged(
         "acme/api", 1156, branch="issue-1156-real-work"
     ) is False
-    # Scoped to the merged sibling itself: correctly reports merged.
+    # Scoped to the merged sibling itself: correctly reports merged (an
+    # explicit ask about that exact branch is unaffected by the leg-branch
+    # exclusion the issue-scoped fallback applies).
     assert claim_mod.any_matching_branch_merged(
         "acme/api", 1156, branch="issue-1156-review-fix-1"
     ) is True
 
 
+def test_any_matching_branch_merged_issue_scoped_ignores_review_and_smoke_legs(
+    monkeypatch,
+) -> None:
+    """#3442: vimcode#523/#526's exact shape — an `issue-{N}-review-*` leg
+    branch (and an `issue-{N}-smoke-*` leg branch) at `ahead_by == 0`,
+    alongside the real, unmerged work branch. `any_matching_branch_merged`
+    with no *branch* (the `coord assign`/dispatch-liveness fallback that
+    trips before any branch is known) must refuse to treat either leg as
+    evidence the issue's real work merged."""
+    import coord.claim as claim_mod
+
+    monkeypatch.setattr(
+        "coord.github_ops._gh",
+        _gh_stub_with_matching_refs(
+            [
+                "issue-523-review-track-a-phase-0b-wire-board-actio",
+                "issue-523-smoke-track-a-phase-0b-wire-board-action",
+                "issue-523-track-a-phase-0b-wire-board-actions-to-p",
+            ],
+            "develop",
+            {
+                "issue-523-review-track-a-phase-0b-wire-board-actio": 0,
+                "issue-523-smoke-track-a-phase-0b-wire-board-action": 2,
+                "issue-523-track-a-phase-0b-wire-board-actions-to-p": 2,
+            },
+        ),
+    )
+    assert claim_mod.any_matching_branch_merged("acme/vimcode", 523) is False
+
+
+def test_any_matching_branch_merged_issue_scoped_ignores_gate_b_leg(
+    monkeypatch,
+) -> None:
+    """#3442 review follow-up: a milestone tracking issue with a completed
+    Gate B verdict (`coord.gate_b`'s dispatch is `type="review"`, doesn't
+    pin `target_branch`, and mints its own throwaway
+    `issue-{N}-gate-b-...` branch exactly like a `[review]`/`[smoke]`
+    leg) sitting at `ahead_by == 0` alongside the real, unmerged
+    milestone work branch. `any_matching_branch_merged` with no *branch*
+    (the `coord assign`/dispatch-liveness fallback that trips before any
+    branch is known — the exact path a fresh dispatch on a tracking issue
+    hits) must not treat the gate-b leg as evidence the real work
+    merged."""
+    import coord.claim as claim_mod
+
+    monkeypatch.setattr(
+        "coord.github_ops._gh",
+        _gh_stub_with_matching_refs(
+            [
+                "issue-900-gate-b-ms-900-milestone-verdict",
+                "issue-900-track-a-phase-1-milestone-work",
+            ],
+            "develop",
+            {
+                "issue-900-gate-b-ms-900-milestone-verdict": 0,
+                "issue-900-track-a-phase-1-milestone-work": 3,
+            },
+        ),
+    )
+    assert claim_mod.any_matching_branch_merged("acme/vimcode", 900) is False
+
+
+def test_is_observer_leg_branch_matches_review_scoped_review_smoke_and_gate_b() -> None:
+    """#3442: the exact prefixes review/smoke/gate-b legs mint, and nothing
+    else — a bare `issue-N-review` (no trailing content) and the slugified
+    `issue-N-review-...`/`issue-N-scoped-review-...`/`issue-N-smoke-...`/
+    `issue-N-gate-b-...` shapes all match; an unrelated branch, or one that
+    merely CONTAINS "review" past the issue-number prefix, must not."""
+    import coord.claim as claim_mod
+
+    assert claim_mod._is_observer_leg_branch("issue-9-review", 9) is True
+    assert claim_mod._is_observer_leg_branch("issue-9-review-fix-1", 9) is True
+    assert claim_mod._is_observer_leg_branch(
+        "issue-9-scoped-review-sealed-path", 9
+    ) is True
+    assert claim_mod._is_observer_leg_branch("issue-9-smoke-track-a", 9) is True
+    assert claim_mod._is_observer_leg_branch(
+        "issue-9-gate-b-ms-9-milestone-verdict", 9
+    ) is True
+    assert claim_mod._is_observer_leg_branch("issue-9-real-work", 9) is False
+    assert claim_mod._is_observer_leg_branch(
+        "issue-9-reviewer-onboarding", 9
+    ) is False
+
+
 # ── #1553: has_active_work_followup keys on the EFFECTIVE issue ─────────────
 
 

code_coordinator-0.5.516/code_coordinator.egg-info/scm_version.json

@@ -1,8 +0,0 @@
-{
-  "tag": "0.5.516",
-  "distance": 0,
-  "node": "g19a9eb87ca92b056b9d5bfed8273bb8f83a30fa0",
-  "dirty": false,
-  "branch": "HEAD",
-  "node_date": "2026-09-24"
-}