code-coordinator 0.5.512__tar.gz → 0.5.513__tar.gz

{code_coordinator-0.5.512 → code_coordinator-0.5.513}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.512
+Version: 0.5.513
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

{code_coordinator-0.5.512 → code_coordinator-0.5.513}/code_coordinator.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.512
+Version: 0.5.513
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

{code_coordinator-0.5.512 → code_coordinator-0.5.513}/code_coordinator.egg-info/SOURCES.txt

@@ -510,6 +510,7 @@ tests/test_cli_issue_comment.py
 tests/test_cli_issue_create_label.py
 tests/test_cli_issue_reopen.py
 tests/test_cli_issue_view_list.py
+tests/test_cli_issues.py
 tests/test_cli_merge.py
 tests/test_cli_milestone_assign.py
 tests/test_cli_milestone_capture.py

{code_coordinator-0.5.512 → code_coordinator-0.5.513}/code_coordinator.egg-info/scm_file_list.json

@@ -536,6 +536,7 @@
     "tests/test_cli_issue_create_label.py",
     "tests/test_cli_issue_reopen.py",
     "tests/test_cli_issue_view_list.py",
+    "tests/test_cli_issues.py",
     "tests/test_cli_merge.py",
     "tests/test_cli_milestone_assign.py",
     "tests/test_cli_milestone_capture.py",

{code_coordinator-0.5.512 → code_coordinator-0.5.513}/code_coordinator.egg-info/scm_version.json

@@ -1,7 +1,7 @@
 {
-  "tag": "0.5.512",
+  "tag": "0.5.513",
   "distance": 0,
-  "node": "g51bbafd70baf84cb0ed6d0a735815b56ea39f604",
+  "node": "g62d2f7e1d36394c598063480dfdc2028204abbf1",
   "dirty": false,
   "branch": "HEAD",
   "node_date": "2026-09-21"

{code_coordinator-0.5.512 → code_coordinator-0.5.513}/coord/commands/issues.py

@@ -418,7 +418,13 @@ def issue_comment_cmd(
         "instead of a single freeform paragraph, so a later contract.md "
         "author (hand or agent) doesn't have to re-derive them from prose. "
         "All four are required together, and mutually exclusive with "
-        "--body/--body-file."
+        "--body/--body-file.\n\n"
+        "--milestone (number or title, resolved the same way as `coord "
+        "milestone assign`) attaches the new issue to a milestone in the "
+        "same step, routed through the same daemon seam "
+        "(`POST /issue-milestone`) so the local issues cache is updated "
+        "immediately. An unresolvable milestone is reported *before* the "
+        "issue is created (#3432)."
     ),
 )
 @click.argument("repo")
@@ -436,6 +442,16 @@ def issue_comment_cmd(
     multiple=True,
     help="Label to add (repeatable). The label must already exist in the repo.",
 )
+@click.option(
+    "--milestone",
+    default=None,
+    help=(
+        "Milestone number or title to attach the new issue to. Resolved "
+        "before the issue is created — an unresolvable milestone (bad "
+        "number, unmatched or ambiguous title) is an error and no issue is "
+        "created."
+    ),
+)
 @click.option(
     "--expected", default=None,
     help="Bug-lane intake field: what should happen, in observable terms.",
@@ -462,6 +478,7 @@ def issue_create_cmd(
     body: str | None,
     body_file: Path | None,
     labels: tuple[str, ...],
+    milestone: str | None,
     expected: str | None,
     actual: str | None,
     repro: str | None,
@@ -496,6 +513,26 @@ def issue_create_cmd(
     slug = _resolve_repo_slug(cfg, repo)
     if body_file is not None:
         body = sys.stdin.read() if str(body_file) == "-" else Path(body_file).read_text()
+
+    # Resolve --milestone *before* creating the issue (#3432) — creating the
+    # issue and then failing to attach it would silently reproduce the bug
+    # this closes (an issue that looks healthy but is unreachable from
+    # `coord.plans.aggregate_repo_plans`, which keys on milestone
+    # membership).
+    milestone_number: int | None = None
+    milestone_title: str | None = None
+    if milestone is not None:
+        from coord.commands.milestone import (  # noqa: PLC0415
+            MilestoneResolutionError,
+            resolve_milestone_ref,
+        )
+
+        try:
+            milestone_number, milestone_title = resolve_milestone_ref(slug, milestone)
+        except MilestoneResolutionError as e:
+            click.echo(f"error: {e}", err=True)
+            sys.exit(1)
+
     from coord.state import create_issue as _create_issue  # noqa: PLC0415
 
     try:
@@ -509,6 +546,31 @@ def issue_create_cmd(
         sys.exit(1)
     click.echo(f"#{result['number']} ({slug}) created")
 
+    if milestone_number is not None:
+        from coord.state import assign_issue_milestone  # noqa: PLC0415
+
+        try:
+            assign_issue_milestone(
+                repo,
+                result["number"],
+                milestone_number,
+                milestone_title=milestone_title,
+                repo_github=slug,
+            )
+        except Exception as e:  # noqa: BLE001
+            click.echo(
+                f"error: issue #{result['number']} created but milestone "
+                f"assign failed: {e}",
+                err=True,
+            )
+            sys.exit(1)
+        ms_label = (
+            f"{milestone_title!r} (#{milestone_number})"
+            if milestone_title
+            else f"#{milestone_number}"
+        )
+        click.echo(f"#{result['number']} ({slug}) assigned to milestone {ms_label}")
+
 
 @issue_group.command(
     "label",

{code_coordinator-0.5.512 → code_coordinator-0.5.513}/coord/commands/milestone.py

@@ -165,6 +165,52 @@ def milestone_edit_cmd(
     click.echo(f"milestone #{number} updated ({repo_entry.github})")
 
 
+class MilestoneResolutionError(Exception):
+    """Raised by :func:`resolve_milestone_ref` when MILESTONE can't be
+    resolved to a number."""
+
+
+def resolve_milestone_ref(repo_github: str, milestone: str) -> tuple[int, str | None]:
+    """Resolve a milestone CLI argument (number or title) to ``(number,
+    title)`` against ``repo_github``'s open milestones.
+
+    Shared by `coord milestone assign` and `coord issue create --milestone`
+    (#3432) so there is exactly one place milestone-reference resolution
+    happens — raises :class:`MilestoneResolutionError` (never exits) on any
+    failure: an unfetchable numeric milestone, an unmatched title, or an
+    ambiguous title. Callers decide how to report/exit.
+    """
+    from coord import github_ops  # noqa: PLC0415
+
+    try:
+        milestone_number = int(milestone)
+    except ValueError:
+        try:
+            all_ms = github_ops.get_repo_milestones(repo_github)
+        except RuntimeError as e:
+            raise MilestoneResolutionError(f"could not list milestones: {e}") from e
+        matches = [m for m in all_ms if m.get("title") == milestone]
+        if not matches:
+            raise MilestoneResolutionError(
+                f"no open milestone with title {milestone!r} in {repo_github}"
+            )
+        if len(matches) > 1:
+            raise MilestoneResolutionError(
+                f"multiple open milestones match {milestone!r} — use the "
+                "milestone number instead"
+            )
+        return matches[0]["number"], matches[0].get("title")
+
+    # Resolve the title from the number so the cache can store it.
+    try:
+        ms_data = github_ops.get_milestone(repo_github, milestone_number)
+    except RuntimeError as e:
+        raise MilestoneResolutionError(
+            f"could not fetch milestone #{milestone_number}: {e}"
+        ) from e
+    return milestone_number, ms_data.get("title")
+
+
 @milestone_group.command(
     "assign",
     help=(
@@ -194,47 +240,15 @@ def milestone_assign_cmd(
         click.echo(f"error: unknown repo {repo!r}", err=True)
         sys.exit(2)
 
-    from coord import github_ops  # noqa: PLC0415
     from coord.state import assign_issue_milestone  # noqa: PLC0415
 
-    # Resolve milestone argument: numeric → number, string → title lookup.
-    milestone_number: int
-    milestone_title: str | None
-
     try:
-        milestone_number = int(milestone)
-        # Resolve the title from the number so the cache can store it.
-        try:
-            ms_data = github_ops.get_milestone(repo_entry.github, milestone_number)
-            milestone_title = ms_data.get("title")
-        except RuntimeError as e:
-            click.echo(
-                f"error: could not fetch milestone #{milestone_number}: {e}", err=True
-            )
-            sys.exit(1)
-    except ValueError:
-        # Treat the argument as a title and resolve to a number.
-        try:
-            all_ms = github_ops.get_repo_milestones(repo_entry.github)
-        except RuntimeError as e:
-            click.echo(f"error: could not list milestones: {e}", err=True)
-            sys.exit(1)
-        matches = [m for m in all_ms if m.get("title") == milestone]
-        if not matches:
-            click.echo(
-                f"error: no open milestone with title {milestone!r} in {repo_entry.github}",
-                err=True,
-            )
-            sys.exit(1)
-        if len(matches) > 1:
-            click.echo(
-                f"error: multiple open milestones match {milestone!r} — "
-                "use the milestone number instead",
-                err=True,
-            )
-            sys.exit(1)
-        milestone_number = matches[0]["number"]
-        milestone_title = matches[0].get("title")
+        milestone_number, milestone_title = resolve_milestone_ref(
+            repo_entry.github, milestone
+        )
+    except MilestoneResolutionError as e:
+        click.echo(f"error: {e}", err=True)
+        sys.exit(1)
 
     try:
         assign_issue_milestone(

code_coordinator-0.5.513/tests/test_cli_issues.py

@@ -0,0 +1,274 @@
+"""Black-box tests for `coord issue create --milestone` (#3432).
+
+Coverage targets (mirroring test_cli_issue_create_label.py /
+test_cli_milestone_assign.py):
+- --milestone by number: resolves title via github_ops.get_milestone, creates
+  the issue, then assigns it through state.assign_issue_milestone.
+- --milestone by title: resolves via github_ops.get_repo_milestones.
+- Unresolvable milestone (bad number, unmatched/ambiguous title) is an error
+  *before* the issue is created — github_ops.create_issue must never be
+  called.
+- --milestone composes with --label and with the bug-lane intake flags.
+- A milestone-assign failure *after* a successful create still surfaces as a
+  non-zero exit with the issue number in the message (the create already
+  happened and is not rolled back).
+"""
+
+from __future__ import annotations
+
+from pathlib import Path
+from unittest.mock import patch
+
+import pytest
+from click.testing import CliRunner
+
+from coord.cli import main
+from coord import state as state_mod
+
+
+CONFIG_YAML = """\
+repos:
+  - name: api
+    github: acme/api
+    default_branch: main
+machines:
+  - name: laptop
+    host: laptop.tailnet
+    repos: [api]
+    repo_paths:
+      api: /tmp/api
+"""
+
+
+@pytest.fixture
+def config_file(tmp_path: Path) -> Path:
+    p = tmp_path / "coordinator.yml"
+    p.write_text(CONFIG_YAML)
+    return p
+
+
+class TestIssueCreateWithMilestone:
+    def test_milestone_by_number_creates_and_assigns(self, config_file: Path) -> None:
+        with patch(
+            "coord.github_ops.get_milestone",
+            return_value={"number": 7, "title": "v1.0"},
+        ), patch(
+            "coord.github_ops.create_issue",
+            return_value={"number": 42, "url": "https://github.com/acme/api/issues/42"},
+        ) as mock_create, patch(
+            "coord.github_ops.assign_issue_milestone",
+        ) as mock_assign:
+            result = CliRunner().invoke(
+                main,
+                [
+                    "issue", "create", "api",
+                    "--title", "Needs a milestone",
+                    "--body", "body text",
+                    "--milestone", "7",
+                    "--config", str(config_file),
+                ],
+            )
+        assert result.exit_code == 0, result.output
+        assert "#42" in result.output
+        assert "v1.0" in result.output
+        mock_create.assert_called_once()
+        mock_assign.assert_called_once_with("acme/api", 42, 7)
+
+        # The daemon seam updates the local cache immediately (no `coord sync` wait).
+        row = state_mod.get_connection().execute(
+            "SELECT milestone_number, milestone_title FROM issues"
+            " WHERE repo_name='api' AND number=42"
+        ).fetchone()
+        assert row is not None
+        assert row["milestone_number"] == 7
+        assert row["milestone_title"] == "v1.0"
+
+    def test_milestone_by_title_resolves_number(self, config_file: Path) -> None:
+        with patch(
+            "coord.github_ops.get_repo_milestones",
+            return_value=[
+                {"number": 7, "title": "v1.0"},
+                {"number": 8, "title": "v2.0"},
+            ],
+        ), patch(
+            "coord.github_ops.create_issue",
+            return_value={"number": 43, "url": "https://github.com/acme/api/issues/43"},
+        ), patch(
+            "coord.github_ops.assign_issue_milestone",
+        ) as mock_assign:
+            result = CliRunner().invoke(
+                main,
+                [
+                    "issue", "create", "api",
+                    "--title", "By title",
+                    "--milestone", "v2.0",
+                    "--config", str(config_file),
+                ],
+            )
+        assert result.exit_code == 0, result.output
+        assert "#43" in result.output
+        mock_assign.assert_called_once_with("acme/api", 43, 8)
+
+    def test_unresolvable_milestone_number_blocks_creation(
+        self, config_file: Path
+    ) -> None:
+        """An unfetchable numeric milestone must fail *before* the issue is
+        created — create_issue must never be called (#3432)."""
+        with patch(
+            "coord.github_ops.get_milestone",
+            side_effect=RuntimeError("HTTP 404"),
+        ), patch(
+            "coord.github_ops.create_issue",
+        ) as mock_create:
+            result = CliRunner().invoke(
+                main,
+                [
+                    "issue", "create", "api",
+                    "--title", "Doomed",
+                    "--milestone", "999",
+                    "--config", str(config_file),
+                ],
+            )
+        assert result.exit_code == 1
+        assert "error" in result.output.lower()
+        mock_create.assert_not_called()
+
+    def test_unmatched_title_blocks_creation(self, config_file: Path) -> None:
+        with patch(
+            "coord.github_ops.get_repo_milestones",
+            return_value=[{"number": 7, "title": "v1.0"}],
+        ), patch(
+            "coord.github_ops.create_issue",
+        ) as mock_create:
+            result = CliRunner().invoke(
+                main,
+                [
+                    "issue", "create", "api",
+                    "--title", "Doomed",
+                    "--milestone", "nonexistent",
+                    "--config", str(config_file),
+                ],
+            )
+        assert result.exit_code == 1
+        assert "error" in result.output.lower()
+        mock_create.assert_not_called()
+
+    def test_ambiguous_title_blocks_creation(self, config_file: Path) -> None:
+        with patch(
+            "coord.github_ops.get_repo_milestones",
+            return_value=[
+                {"number": 3, "title": "dup"},
+                {"number": 4, "title": "dup"},
+            ],
+        ), patch(
+            "coord.github_ops.create_issue",
+        ) as mock_create:
+            result = CliRunner().invoke(
+                main,
+                [
+                    "issue", "create", "api",
+                    "--title", "Doomed",
+                    "--milestone", "dup",
+                    "--config", str(config_file),
+                ],
+            )
+        assert result.exit_code == 1
+        assert "multiple" in result.output.lower() or "error" in result.output.lower()
+        mock_create.assert_not_called()
+
+    def test_milestone_composes_with_label(self, config_file: Path) -> None:
+        with patch(
+            "coord.github_ops.get_milestone",
+            return_value={"number": 7, "title": "v1.0"},
+        ), patch(
+            "coord.github_ops.create_issue",
+            return_value={"number": 44, "url": "https://github.com/acme/api/issues/44"},
+        ) as mock_create, patch(
+            "coord.github_ops.assign_issue_milestone",
+        ) as mock_assign:
+            result = CliRunner().invoke(
+                main,
+                [
+                    "issue", "create", "api",
+                    "--title", "With label",
+                    "--label", "bug",
+                    "--milestone", "7",
+                    "--config", str(config_file),
+                ],
+            )
+        assert result.exit_code == 0, result.output
+        assert mock_create.call_args.kwargs.get("labels") == ["bug"]
+        mock_assign.assert_called_once_with("acme/api", 44, 7)
+
+    def test_milestone_composes_with_bug_lane_fields(self, config_file: Path) -> None:
+        with patch(
+            "coord.github_ops.get_milestone",
+            return_value={"number": 7, "title": "v1.0"},
+        ), patch(
+            "coord.github_ops.create_issue",
+            return_value={"number": 45, "url": "https://github.com/acme/api/issues/45"},
+        ) as mock_create, patch(
+            "coord.github_ops.assign_issue_milestone",
+        ) as mock_assign:
+            result = CliRunner().invoke(
+                main,
+                [
+                    "issue", "create", "api",
+                    "--title", "Bug with milestone",
+                    "--expected", "x", "--actual", "y", "--repro", "z", "--evidence", "w",
+                    "--milestone", "7",
+                    "--config", str(config_file),
+                ],
+            )
+        assert result.exit_code == 0, result.output
+        called_body = mock_create.call_args[0][2]
+        assert "## Expected behaviour" in called_body
+        mock_assign.assert_called_once_with("acme/api", 45, 7)
+
+    def test_assign_failure_after_create_exits_nonzero_and_mentions_issue(
+        self, config_file: Path
+    ) -> None:
+        """Assignment failing after a successful create is not silently
+        swallowed — it must surface as a non-zero exit naming the issue that
+        was created but left unattached (#3432)."""
+        with patch(
+            "coord.github_ops.get_milestone",
+            return_value={"number": 7, "title": "v1.0"},
+        ), patch(
+            "coord.github_ops.create_issue",
+            return_value={"number": 46, "url": "https://github.com/acme/api/issues/46"},
+        ), patch(
+            "coord.github_ops.assign_issue_milestone",
+            side_effect=RuntimeError("gh: network error"),
+        ):
+            result = CliRunner().invoke(
+                main,
+                [
+                    "issue", "create", "api",
+                    "--title", "Assign fails",
+                    "--milestone", "7",
+                    "--config", str(config_file),
+                ],
+            )
+        assert result.exit_code == 1
+        assert "#46" in result.output
+        assert "error" in result.output.lower()
+
+    def test_no_milestone_option_unchanged_behaviour(self, config_file: Path) -> None:
+        """Omitting --milestone entirely never touches the milestone seam."""
+        with patch(
+            "coord.github_ops.create_issue",
+            return_value={"number": 47, "url": "https://github.com/acme/api/issues/47"},
+        ), patch(
+            "coord.github_ops.assign_issue_milestone",
+        ) as mock_assign:
+            result = CliRunner().invoke(
+                main,
+                [
+                    "issue", "create", "api",
+                    "--title", "No milestone",
+                    "--config", str(config_file),
+                ],
+            )
+        assert result.exit_code == 0, result.output
+        mock_assign.assert_not_called()