code-coordinator 0.5.235__tar.gz → 0.5.236__tar.gz

{code_coordinator-0.5.235 → code_coordinator-0.5.236}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.235
+Version: 0.5.236
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

{code_coordinator-0.5.235 → code_coordinator-0.5.236}/code_coordinator.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.235
+Version: 0.5.236
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

code_coordinator-0.5.236/code_coordinator.egg-info/scm_version.json

@@ -0,0 +1,8 @@
+{
+  "tag": "0.5.236",
+  "distance": 0,
+  "node": "g5110d914da8b0140bb620fbe356079028f405900",
+  "dirty": false,
+  "branch": "HEAD",
+  "node_date": "2026-08-23"
+}

{code_coordinator-0.5.235 → code_coordinator-0.5.236}/coord/acceptance.py

@@ -838,6 +838,36 @@ def _issue_header_re(issue_number: int) -> re.Pattern[str]:
     return re.compile(rf"^(\s*)['\"]?{issue_number}['\"]?\s*:\s*(#.*)?$")
 
 
+def _parse_list_item_scalar(line: str) -> str | None:
+    """Resolve one YAML block-sequence item line (``- ...``) to its parsed
+    scalar value — the same value :func:`parse_manifest_text` would produce
+    for it — rather than the raw text as written. #2296: a Playwright test id
+    always starts with ``[chromium]``, so its manifest entry is *always*
+    quoted (an unquoted leading ``[`` is a YAML flow sequence, not a string);
+    comparing the raw scalar against the parsed id then never matches. Going
+    through :mod:`yaml` here instead handles double- and single-quoted
+    scalars (incl. the ``''`` embedded-quote escape) and, since YAML's own
+    comment rule applies, a ``#`` inside a quoted scalar is correctly treated
+    as data rather than truncated as a comment.
+
+    Returns ``None`` for anything that isn't a well-formed single-item
+    sequence line (blank/comment-only, flow-style, malformed YAML, or a
+    non-string value) so the caller leaves such lines untouched rather than
+    risk misclassifying them.
+    """
+    stripped = line.strip()
+    if not stripped.startswith("-"):
+        return None
+    try:
+        parsed = yaml.safe_load(stripped)
+    except yaml.YAMLError:
+        return None
+    if not isinstance(parsed, list) or len(parsed) != 1:
+        return None
+    value = parsed[0]
+    return value if isinstance(value, str) else None
+
+
 def _strip_cleared_ids_from_issue_block(
     body: "list[str]", issue_number: int, cleared_ids: "set[str]",
 ) -> "tuple[list[str], bool]":
@@ -871,9 +901,8 @@ def _strip_cleared_ids_from_issue_block(
             i += 1
         new_sub = []
         for sub_line in sub:
-            code = sub_line.split("#", 1)[0].strip()
-            item_m = re.match(r"^-\s*(.+?)\s*$", code)
-            if item_m and item_m.group(1) in cleared_ids:
+            item = _parse_list_item_scalar(sub_line)
+            if item is not None and item in cleared_ids:
                 changed = True
                 continue
             new_sub.append(sub_line)
@@ -1286,7 +1315,12 @@ def clear_expected_red_via_pr(
 
     new_text = clear_expected_red_entries(text, issue_number, ids)
     if new_text is None:
-        return "expected_red text unchanged (nothing matched)"
+        # #2296: ids were passed in and none matched — that's a defect in
+        # the text surgery (or a manifest that no longer has this issue's
+        # block), not a benign no-op. Prefix `warning:` so it's greppable
+        # and so `coord acceptance expected-red --clear` doesn't report a
+        # clean sweep over an operation that actually did nothing.
+        return "warning: expected_red text unchanged (nothing matched)"
 
     get_head = getattr(ops, "get_default_branch_head", None)
     create_branch = getattr(ops, "create_remote_branch", None)

{code_coordinator-0.5.235 → code_coordinator-0.5.236}/tests/test_acceptance.py

@@ -571,6 +571,94 @@ class TestClearExpectedRedEntries:
         assert clear_expected_red_entries("tests:\n  a: 1\n", 1, {"a"}) is None
 
 
+class TestClearExpectedRedEntriesQuotedIds:
+    """#2296: every Playwright manifest id is double-quoted (an unquoted
+    leading `[chromium]` would parse as a YAML flow sequence, not a string),
+    so the clearer must compare the *parsed* scalar, not the raw line text,
+    or it can never match a real web-playwright manifest."""
+
+    PLAYWRIGHT_ID = "[chromium] ms-1/84-front-door.spec.ts › placeholder"
+
+    def test_double_quoted_id_is_cleared(self) -> None:
+        text = (
+            "expected_red:\n"
+            f'  84:\n    - "{self.PLAYWRIGHT_ID}"\n'
+        )
+        result = clear_expected_red_entries(text, 84, {self.PLAYWRIGHT_ID})
+        assert result is not None
+        assert "expected_red" not in result
+        data = parse_manifest_text(text)
+        assert data.expected_red == {84: frozenset({self.PLAYWRIGHT_ID})}
+
+    def test_single_quoted_id_is_cleared(self) -> None:
+        text = "expected_red:\n  1:\n    - 'plain single quoted'\n"
+        result = clear_expected_red_entries(text, 1, {"plain single quoted"})
+        assert result is not None
+        assert "expected_red" not in result
+
+    def test_single_quoted_id_with_embedded_quote_escape_is_cleared(self) -> None:
+        # YAML's single-quote escape for an embedded `'` is `''`.
+        text = "expected_red:\n  1:\n    - 'it''s red'\n"
+        data = parse_manifest_text(text)
+        assert data.expected_red == {1: frozenset({"it's red"})}
+        result = clear_expected_red_entries(text, 1, {"it's red"})
+        assert result is not None
+        assert "expected_red" not in result
+
+    def test_plain_unquoted_id_still_clears(self) -> None:
+        """The unquoted case already worked before #2296 — must keep working."""
+        text = "expected_red:\n  1:\n    - plain_unquoted_id\n"
+        result = clear_expected_red_entries(text, 1, {"plain_unquoted_id"})
+        assert result is not None
+        assert "expected_red" not in result
+
+    def test_id_containing_a_hash_is_cleared_not_truncated_as_a_comment(self) -> None:
+        """Inside a quoted scalar, `#` is data, not a comment delimiter —
+        `sub_line.split("#", 1)` would truncate the id and miss it."""
+        id_with_hash = "issue #84 regression check"
+        text = f'expected_red:\n  1:\n    - "{id_with_hash}"\n'
+        data = parse_manifest_text(text)
+        assert data.expected_red == {1: frozenset({id_with_hash})}
+        result = clear_expected_red_entries(text, 1, {id_with_hash})
+        assert result is not None
+        assert "expected_red" not in result
+
+    def test_quoted_id_with_trailing_comment_is_still_cleared(self) -> None:
+        text = (
+            "expected_red:\n"
+            f'  84:\n    - "{self.PLAYWRIGHT_ID}"  # flaky, see #91\n'
+        )
+        result = clear_expected_red_entries(text, 84, {self.PLAYWRIGHT_ID})
+        assert result is not None
+        assert "expected_red" not in result
+
+    def test_mixed_quoted_and_plain_partial_clear_preserves_the_other(self) -> None:
+        text = (
+            "expected_red:\n"
+            "  84:\n"
+            f'    - "{self.PLAYWRIGHT_ID}"\n'
+            "    - plain_id_stays\n"
+        )
+        result = clear_expected_red_entries(text, 84, {self.PLAYWRIGHT_ID})
+        assert result is not None
+        assert "plain_id_stays" in result
+        data = parse_manifest_text(result)
+        assert data.expected_red == {84: frozenset({"plain_id_stays"})}
+
+    def test_playwright_manifest_reproduction(self) -> None:
+        """The exact reproduction from #2296: a manifest with several
+        double-quoted Playwright ids has ALL of them cleared and returns
+        updated (non-None) text."""
+        ids = [f"[chromium] ms-1/84-front-door.spec.ts › case {i}" for i in range(6)]
+        body = "\n".join(f'    - "{i}"' for i in ids)
+        text = f"expected_red:\n  84:\n{body}\n"
+        parsed_ids = parse_manifest_text(text).expected_red[84]
+        assert len(parsed_ids) == 6
+        result = clear_expected_red_entries(text, 84, parsed_ids)
+        assert result is not None
+        assert "expected_red" not in result
+
+
 class _FakeApiGhOps:
     """Stub for the GitHub-API-only surface #2164's post-merge clearing
     sweep needs — no `gh` subprocess, no local checkout. Mirrors
@@ -861,6 +949,26 @@ class TestClearExpectedRedViaPr:
         msg = clear_expected_red_via_pr("acme/x", "coord-tui", "main", 944, gh_ops=ops)
         assert "no expected_red entries found" in msg
 
+    def test_no_match_in_text_surgery_is_reported_as_a_warning(self) -> None:
+        """#2296: when ids were resolved from the parsed manifest but the
+        text-surgery pass finds nothing to remove (e.g. a flow-style
+        `944: [ms01::a]` entry the block-style-only text surgery doesn't
+        understand — see `_issue_header_re`'s docstring), that is a defect,
+        not a benign no-op, and must be `warning:`-prefixed so
+        `classify_expected_red_clear_result` reads it as "failed" rather
+        than a clean sweep."""
+        ops = _FakeApiGhOps({
+            "tests/acceptance/ms01/manifest.yml": (
+                "tests:\n  ms01::a: 944\n"
+                "expected_red:\n  944: [ms01::a]\n"
+            ),
+        })
+        msg = clear_expected_red_via_pr("acme/x", "coord-tui", "main", 944, gh_ops=ops)
+        assert msg.startswith("warning:")
+        assert "nothing matched" in msg
+        assert classify_expected_red_clear_result(msg) == "failed"
+        assert not ops.created_prs
+
     def test_clears_a_per_issue_fragment_file(self) -> None:
         """#2543: clearing an issue whose expected_red lives in its OWN
         manifest.d/<issue>.yml fragment edits exactly that file, and the
@@ -927,7 +1035,7 @@ class TestClassifyExpectedRedClearResult:
 
     def test_unchanged_text_is_a_failure(self) -> None:
         assert classify_expected_red_clear_result(
-            "expected_red text unchanged (nothing matched)"
+            "warning: expected_red text unchanged (nothing matched)"
         ) == "failed"
 
 

code_coordinator-0.5.235/code_coordinator.egg-info/scm_version.json

@@ -1,8 +0,0 @@
-{
-  "tag": "0.5.235",
-  "distance": 0,
-  "node": "g5e1480a48c81b0a8cba96e6b1a3f8efc68470379",
-  "dirty": false,
-  "branch": "HEAD",
-  "node_date": "2026-08-22"
-}