code-coordinator 0.5.181__tar.gz → 0.5.182__tar.gz

{code_coordinator-0.5.181 → code_coordinator-0.5.182}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.181
+Version: 0.5.182
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

{code_coordinator-0.5.181 → code_coordinator-0.5.182}/code_coordinator.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.181
+Version: 0.5.182
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

{code_coordinator-0.5.181 → code_coordinator-0.5.182}/code_coordinator.egg-info/SOURCES.txt

@@ -374,6 +374,7 @@ deploy/coord-web-dist-build.timer
 deploy/coord-web-rollback.sh
 deploy/coord-web.service
 deploy/node-shim.sh
+docs/ADR_COORD_WEB_ACCEPTANCE_SUITE.md
 docs/ADR_COORD_WEB_CI.md
 docs/ADR_COORD_WEB_DIST.md
 docs/AGENT_OPERATIONS.md

{code_coordinator-0.5.181 → code_coordinator-0.5.182}/code_coordinator.egg-info/scm_file_list.json

@@ -352,6 +352,7 @@
     "deploy/coord-web-rollback.sh",
     "deploy/coord-web.service",
     "deploy/node-shim.sh",
+    "docs/ADR_COORD_WEB_ACCEPTANCE_SUITE.md",
     "docs/ADR_COORD_WEB_CI.md",
     "docs/ADR_COORD_WEB_DIST.md",
     "docs/AGENT_OPERATIONS.md",

{code_coordinator-0.5.181 → code_coordinator-0.5.182}/code_coordinator.egg-info/scm_version.json

@@ -1,7 +1,7 @@
 {
-  "tag": "0.5.181",
+  "tag": "0.5.182",
   "distance": 0,
-  "node": "g5e005a43efabed403b960cdb0db1d15310b952ca",
+  "node": "gf9008e7df5c997f1a002cfc8a6060af0cfac95c1",
   "dirty": false,
   "branch": "HEAD",
   "node_date": "2026-08-20"

{code_coordinator-0.5.181 → code_coordinator-0.5.182}/coord/issue_store.py

@@ -1359,7 +1359,7 @@ def _post_result_local(record: ResultRecord) -> StoreOutcome:
         # pre-#1956 row.
         _persist_verdict_source(record)
     # #603: a request-changes verdict is durable context for EVERY future agent
-    # on the issue — record a short note in the per-issue digest (local writer;
+    # on the issue — record a note in the per-issue digest (local writer;
     # daemon-side on a thin client, so use the _local variant).
     #
     # #650: only when the findings write actually landed. When the clobber
@@ -1368,18 +1368,36 @@ def _post_result_local(record: ResultRecord) -> StoreOutcome:
     # for — adding another one was the second half of the #650 incident.
     if record.verdict == VERDICT_REQUEST_CHANGES and findings_written:
         try:
+            from coord.review import extract_blocking_section  # noqa: PLC0415
             from coord.state import _add_issue_context_entry_local  # noqa: PLC0415
 
-            summary = (record.findings_body or record.summary or "").strip()
-            if summary:
-                if len(summary) > 240:
-                    summary = summary[:240].rstrip() + "…"
+            findings_body = (record.findings_body or "").strip()
+            # #2466: carry the "## Blocking findings" section forward
+            # verbatim — a re-review round with more than one blocking
+            # finding used to lose everything past the first sentence to a
+            # blind body[:240] truncation, so later rounds silently stopped
+            # tracking all but the first-reported finding. Fall back to the
+            # old truncated-summary shape only when the body has no
+            # recognisable blocking heading (e.g. a short-form verdict).
+            blocking = extract_blocking_section(findings_body) if findings_body else ""
+            if blocking:
                 _add_issue_context_entry_local(
                     record.repo_name,
                     record.issue_number,
-                    f"Review requested changes: {summary}",
+                    f"Review requested changes — blocking findings:\n{blocking}",
                     source="review",
                 )
+            else:
+                summary = (findings_body or record.summary or "").strip()
+                if summary:
+                    if len(summary) > 240:
+                        summary = summary[:240].rstrip() + "…"
+                    _add_issue_context_entry_local(
+                        record.repo_name,
+                        record.issue_number,
+                        f"Review requested changes: {summary}",
+                        source="review",
+                    )
         except Exception:  # noqa: BLE001 — best-effort
             pass
     return StoreOutcome(

{code_coordinator-0.5.181 → code_coordinator-0.5.182}/coord/review.py

@@ -647,6 +647,39 @@ def blocking_findings_confirmed_absent(body: str) -> bool:
     return True
 
 
+def extract_blocking_section(body: str) -> str:
+    """Return the verbatim text of *body*'s "## Blocking findings" section(s).
+
+    Reuses the same section parser as `estimate_review_counts` /
+    `blocking_findings_confirmed_absent` (#1456), so this can never disagree
+    with them about where the blocking section starts and ends. Multiple
+    headings that map to the `blocking` bucket are joined in document order.
+
+    Returns "" when no blocking heading is found, or when the section reads
+    as an explicit "none" marker (`_is_no_findings_line` on every line) —
+    callers should not carry forward an empty section as if it were a real
+    finding.
+
+    #2466: replaces a blind `body[:240]` truncation that was silently
+    dropping every blocking finding past the first sentence from the #603
+    per-issue context digest — the mechanism meant to carry a review's
+    findings forward into the next re-review round.
+    """
+    chunks: list[str] = []
+    for bucket, lines in _iter_review_sections(body):
+        if bucket != "blocking":
+            continue
+        text = "\n".join(lines).strip("\n")
+        if text.strip():
+            chunks.append(text)
+    joined = "\n\n".join(chunks).strip()
+    if not joined:
+        return ""
+    if all(_is_no_findings_line(line.strip()) for line in joined.splitlines() if line.strip()):
+        return ""
+    return joined
+
+
 def _parse_review_text(text: str) -> ReviewFindings | None:
     """Extract the last ReviewFindings block from *text*, or None.
 

code_coordinator-0.5.182/docs/ADR_COORD_WEB_ACCEPTANCE_SUITE.md

@@ -0,0 +1,105 @@
+# ADR: Where the sealed ms-51 acceptance suite lives once the webapp is its own repo
+
+**Status:** Accepted
+**Date:** 2026-08-20
+**Issue:** #2007 (UX-5, Phase 1 of milestone #62, epic #2002). Depends on #2005
+(closed). UX-6 (#2008) depends on this decision; UX-7 (#2009) is gated on it
+too.
+
+## Context
+
+`tests/acceptance/ms-51/**` (`contract.md`, `mocks/`, the derived Playwright
+specs, `manifest.yml`) is the webapp's sealed oracle. Today it lives in
+`claude-coordinator`, at the repo root, alongside `coord/dashboard/webapp/**`
+— the code it pins — *and* alongside the machinery that runs it
+(`coord acceptance run/record/author/mock`, `coord/acceptance_drivers.py`,
+the `test-author` dispatch + Gate-A flow, `acceptance.drivers` routing in
+`coordinator.yml`). Once UX-7 deletes `coord/dashboard/webapp/**` from this
+repo, those two things — the code and the machinery — are no longer in the
+same place, and the suite has to pick a side.
+
+The invariant that must survive either way, from `CLAUDE.md`: the suite is
+delivered to workers **read-only / run-only**; a `type="work"` diff touching
+`tests/acceptance/**` (or a declared driver `entrypoint`) is an unconditional,
+mandatory `request-changes` in `coord/review.py`. #2007's framing worried that
+moving the suite into `coord-web` weakens this from a repo boundary to "just"
+review convention.
+
+**That framing doesn't hold up.** No sealed suite in this project has ever
+been protected by a repo boundary. `tests/acceptance/**` (the `cli-pytest`
+route) already seals `coord/` in the same repo it lives in. `tui/tests/acceptance.rs`
+already seals `tui/` in the same repo it lives in — CLAUDE.md calls this out
+explicitly: sealed "despite living nowhere near `tests/acceptance/`," enforced
+purely by the reviewer's mandatory-request-changes rule. Review-time
+enforcement, same-repo, is the only mechanism this project has ever used.
+Moving `ms-51` into `coord-web` doesn't introduce a weaker model — it matches
+the one every other driver already runs on. `AcceptanceConfig.sealed_paths()`
+is derived per `repo_name` for exactly this reason: it was never repo-boundary
+shaped to begin with.
+
+## Decision
+
+**Move `tests/acceptance/ms-51/**` into `coord-web`, at its repo root,
+alongside the webapp source it pins.** Concretely, once UX-7 lands:
+
+- `coord-web`'s repo root gains `tests/acceptance/ms-51/**`, satisfying
+  `AcceptanceConfig.SEALED_ACCEPTANCE_DIR` (`"tests/acceptance/"`,
+  repo-root-relative) with zero changes to the sealing code itself — sealing
+  activates automatically the moment `acceptance.drivers["coord-web"]` exists
+  (UX-6, #2008).
+- `acceptance.drivers["coord-web"]` becomes a **flat** entry (`kind:
+  web-playwright`, `run: npm run test:acceptance -- {ms}`, `mock: *.html`,
+  `capability: browser`) — no `routes:`, since `coord-web` doesn't need
+  `claude-coordinator`'s router split (that split exists there only because
+  `coord/dashboard/webapp/**` is one of several subpaths in a bigger repo).
+- The `cd coord/dashboard/webapp &&` indirection in today's `run`/`setup`
+  commands drops out — `coord-web`'s repo root *is* the webapp root, so
+  `npm run test:acceptance -- {ms}` runs directly.
+- `playwright.acceptance.config.ts` keeps resolving `tests/acceptance/{ms}`
+  the same way; the path just stops needing to walk up out of
+  `coord/dashboard/webapp/` to find it.
+- `claude-coordinator`'s `coord/dashboard/webapp/**` route in
+  `acceptance.drivers` is deleted as part of UX-7, not re-pointed — the
+  webapp source is gone from this repo, so there's nothing left to route.
+
+## Rejected alternative
+
+**Leave `tests/acceptance/ms-51/**` in `claude-coordinator`, next to the
+`coord` CLI machinery that runs it.** This keeps `coord acceptance run` able
+to find the suite without any cross-repo reach, but it means `coord-web`'s own
+CI (UX-4, #2006) — which needs to run the sealed suite as its `acceptance`
+job — can't do so from its own checkout. It would need `claude-coordinator`
+checked out alongside `coord-web` on the runner (sparse-checkout or
+submodule) just to see files that logically belong to `coord-web`'s own test
+tree, for a guarantee (repo-boundary sealing) this project doesn't rely on
+anywhere else. Rejected: real, ongoing plumbing cost for a property nothing
+else here provides either.
+
+Note the `coord` **package** (the machinery: `coord/acceptance_drivers.py`,
+`coord acceptance run`, etc.) is a different axis from the suite **files**
+and isn't actually blocked by this decision — UX-4 already has `coord-web`'s
+CI install `coord` from PyPI to boot `coord web --fixture` for the
+`web-playwright` driver's own web server. That install is needed either way;
+what changes is only where the *files* the installed `coord` runs against
+live.
+
+## What this doesn't solve
+
+#1950: the ms-51 slice has been red since #1547 and nobody noticed, because
+`test:acceptance` runs in no CI job and no Test lane today. Relocating the
+suite doesn't fix that by itself — UX-4 (#2006) is where an actual gate
+(`coord-web`'s `acceptance` CI job) has to start running it. This ADR settles
+*where the files live*, not whether anything executes them; #2006 owns the
+latter and should not treat this move as having already solved it.
+
+## Consequences
+
+- Sealing continues to work exactly as it does today for `coord/` and
+  `tui/**` — same mechanism, same enforcement point (`coord/review.py`), one
+  more repo added to the set it already covers.
+- `coord-web`'s CI can run its own acceptance suite from a single checkout,
+  no cross-repo fetch.
+- `claude-coordinator`'s `acceptance.drivers` config gets simpler after UX-7
+  (one less router route), not more complex.
+- The open exposure is #1950 (no automatic gate runs the suite yet), owned by
+  UX-4, not by this decision.

{code_coordinator-0.5.181 → code_coordinator-0.5.182}/tests/test_issue_store_seam.py

@@ -1000,6 +1000,59 @@ class TestPostResult:
             issue_context_block("api", 7)
         )
 
+    def test_multi_blocking_finding_review_carries_full_section_not_240_char_truncation(
+        self,
+    ) -> None:
+        """#2466: a request-changes review with more than one substantial
+        blocking finding used to write only `findings_body[:240]` into the
+        #603 context digest a later re-review round reads — losing every
+        finding past the first sentence. This pinned a real #2288 incident:
+        round 2 reported 3 blocking findings, and rounds 3/4 only ever
+        re-litigated the first because the other two never made it into the
+        carried-forward context. The digest must now hold the FULL blocking
+        section verbatim, and must exclude non-blocking/nits prose that
+        doesn't need to survive into the next round."""
+        from coord.state import get_connection
+
+        _seed_running_assignment("aid-multi-blocking", assignment_type="review")
+        first = "A" * 150 + " — the chord resolver never checks board_search.focused"
+        second = "B" * 150 + " — tabs.json persistence drops the unfocused pane's tabs"
+        findings = (
+            "## Blocking findings\n\n"
+            f"- {first}\n\n"
+            f"- {second}\n\n"
+            "## Non-blocking concerns\n\n"
+            "- PaneSet::set_ratio rebuilds the whole SplitTree on every drag\n\n"
+            "## Nits\n\n"
+            "- trailing whitespace at events.rs:42\n"
+        )
+        with patch("coord.github_ops.post_issue_comment"):
+            issue_store.post_result(
+                issue_store.ResultRecord(
+                    assignment_id="aid-multi-blocking",
+                    machine_name="laptop",
+                    repo_name="api",
+                    repo_github="acme/api",
+                    issue_number=7,
+                    status="done",
+                    verdict="request-changes",
+                    summary="two blocking findings",
+                    findings_body=findings,
+                )
+            )
+        row = get_connection().execute(
+            "SELECT body FROM issue_context WHERE repo_name=? AND issue_number=? "
+            "AND source='review'",
+            ("api", 7),
+        ).fetchone()
+        assert row is not None
+        stored = row["body"]
+        assert first in stored
+        assert second in stored
+        assert len(stored) > 240, "regression guard: must not be truncated to the old cap"
+        assert "SplitTree on every drag" not in stored
+        assert "trailing whitespace" not in stored
+
     def test_second_capture_with_allow_overwrite_replaces_findings(self) -> None:
         """#650: `allow_overwrite_findings=True` (the `--force` CLI flag) is the
         explicit-confirmation escape hatch — the write lands."""

{code_coordinator-0.5.181 → code_coordinator-0.5.182}/tests/test_review.py

@@ -3625,6 +3625,56 @@ class TestBlockingFindingsConfirmedAbsent:
         assert blocking_findings_confirmed_absent("") is False
 
 
+class TestExtractBlockingSection:
+    """#2466: the #603 per-issue context digest used to carry forward only
+    `body[:240]` on a request-changes verdict, which silently dropped every
+    blocking finding past the first sentence on any review with more than
+    one. `extract_blocking_section` replaces that with a verbatim pull of
+    just the "## Blocking findings" section, reusing the same
+    `_iter_review_sections` parser `estimate_review_counts` and
+    `blocking_findings_confirmed_absent` already rely on."""
+
+    def test_extracts_full_multi_paragraph_section_past_240_chars(self) -> None:
+        from coord.review import extract_blocking_section
+        first = "A" * 200 + " first finding, paragraph one."
+        second = "B" * 200 + " second finding, a completely different bug."
+        body = (
+            "## Blocking findings\n\n"
+            f"- {first}\n\n"
+            f"- {second}\n\n"
+            "## Non-blocking concerns\n\n"
+            "- some polish note that should NOT be carried forward\n\n"
+            "## Nits\n\n"
+            "- trailing whitespace\n"
+        )
+        out = extract_blocking_section(body)
+        assert first in out
+        assert second in out
+        assert len(out) > 240, "regression guard: must not be truncated to the old 240-char cap"
+        assert "should NOT be carried forward" not in out
+        assert "trailing whitespace" not in out
+
+    def test_returns_empty_when_no_blocking_heading(self) -> None:
+        from coord.review import extract_blocking_section
+        assert extract_blocking_section("Looks fine to me — approving.\n") == ""
+
+    def test_returns_empty_when_blocking_section_explicitly_empty(self) -> None:
+        from coord.review import extract_blocking_section
+        body = "## Blocking findings\nNone.\n## Nits\n- Trailing whitespace\n"
+        assert extract_blocking_section(body) == ""
+
+    def test_preserves_bulleted_findings_verbatim(self) -> None:
+        from coord.review import extract_blocking_section
+        body = (
+            "## Blocking findings\n"
+            "- `coord/cli.py:2616` — HUMAN_REQUIRED never persists\n"
+            "- retry cap not enforced (`coord/conflict_fix.py:161-167`)\n"
+        )
+        out = extract_blocking_section(body)
+        assert "HUMAN_REQUIRED never persists" in out
+        assert "retry cap not enforced" in out
+
+
 # ── Flood guard: dispatch_pending_reviews (incident 2026-06-08) ──────────────