code-coordinator 0.5.133__tar.gz → 0.5.134__tar.gz

{code_coordinator-0.5.133 → code_coordinator-0.5.134}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.133
+Version: 0.5.134
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

{code_coordinator-0.5.133 → code_coordinator-0.5.134}/code_coordinator.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: code-coordinator
-Version: 0.5.133
+Version: 0.5.134
 Summary: Coordinate Claude Code workers across multiple machines and repos.
 Author-email: John Donaghy <johnfdonaghy@gmail.com>
 License-Expression: LicenseRef-FSL-1.1-MIT

code_coordinator-0.5.134/code_coordinator.egg-info/scm_version.json

@@ -0,0 +1,8 @@
+{
+  "tag": "0.5.134",
+  "distance": 0,
+  "node": "g8e02ded460a307fc964b29480d89526f828fb9b9",
+  "dirty": false,
+  "branch": "HEAD",
+  "node_date": "2026-08-18"
+}

{code_coordinator-0.5.133 → code_coordinator-0.5.134}/coord/commands/portal.py

@@ -425,6 +425,32 @@ def portal_enqueue_design_round(submission_id: str, payload_json: str) -> None:
     )
 
 
+@portal_group.command("enqueue-preview")
+@click.argument("submission_id")
+@click.argument("preview_url")
+def portal_enqueue_preview(submission_id: str, preview_url: str) -> None:
+    """Queue a preview build URL for SUBMISSION_ID (#2359, coord-portal#107).
+
+    PREVIEW_URL is the PR's own Cloudflare Pages Preview deployment — never
+    the Production deployment for `main`, which must never show unapproved
+    work. Queue this, then `coord portal enqueue-status <id> quality-check`,
+    before waiting for the customer's `preview.approved` verdict.
+    """
+    _refuse_if_thin_client("enqueue-preview")
+
+    from coord.portal_sync import PortalSyncError, enqueue_preview  # noqa: PLC0415
+
+    try:
+        row = enqueue_preview(submission_id, preview_url)
+    except PortalSyncError as exc:
+        click.secho(str(exc), fg="red")
+        raise SystemExit(1) from exc
+    click.secho(
+        f"queued: {row.submission_id} seq={row.seq} rev={row.revision} preview",
+        fg="green",
+    )
+
+
 @portal_group.command("enqueue-question")
 @click.argument("submission_id")
 @click.argument("question")

{code_coordinator-0.5.133 → code_coordinator-0.5.134}/coord/db.py

@@ -572,6 +572,7 @@ def _ensure_schema(conn: sqlite3.Connection) -> None:
             last_status   TEXT    NOT NULL DEFAULT '',
             design_round  INTEGER NOT NULL DEFAULT 0,
             open_question TEXT    NOT NULL DEFAULT '',
+            preview_url   TEXT    NOT NULL DEFAULT '',
             customer_json TEXT    NOT NULL DEFAULT '{}',
             first_seen_at REAL    NOT NULL,
             updated_at    REAL    NOT NULL
@@ -918,6 +919,13 @@ def _migrate_add_columns(conn: sqlite3.Connection) -> None:
         # predating this column, same as the column's own default for a
         # freshly-enqueued entry.
         "ALTER TABLE merge_queue ADD COLUMN ci_unreadable_reruns INTEGER NOT NULL DEFAULT 0",
+        # #2359: the preview-approval gate's coord-owned preview URL, mirroring
+        # `design_round` — the highest-confirmed preview build's URL, written
+        # only by `coord.portal_store.mark_applied`'s `kind == "preview"`
+        # branch. '' for every row predating this migration and for a
+        # submission with no preview queued yet, same as `open_question`'s
+        # own default.
+        "ALTER TABLE portal_submissions ADD COLUMN preview_url TEXT NOT NULL DEFAULT ''",
     ]
     for sql in migrations:
         try:

{code_coordinator-0.5.133 → code_coordinator-0.5.134}/coord/portal_bridge.py

@@ -87,6 +87,7 @@ COORD_OWNED_FIELDS = (
     "design_round",
     "artifacts",
     "onhold_since",
+    "preview_url",
 )
 
 

{code_coordinator-0.5.133 → code_coordinator-0.5.134}/coord/portal_store.py

@@ -274,6 +274,7 @@ class SubmissionRecord:
     last_status: str
     design_round: int
     open_question: str
+    preview_url: str
     customer: dict[str, Any]
     first_seen_at: float
     updated_at: float
@@ -291,6 +292,7 @@ def _submission_from_row(row: sqlite3.Row) -> SubmissionRecord:
         last_status=row["last_status"],
         design_round=row["design_round"],
         open_question=row["open_question"],
+        preview_url=row["preview_url"],
         customer=customer if isinstance(customer, dict) else {},
         first_seen_at=row["first_seen_at"],
         updated_at=row["updated_at"],
@@ -529,6 +531,12 @@ def mark_applied(row: OutboxRow, *, now: float | None = None) -> None:
                 "WHERE submission_id = ?",
                 (str(row.fields.get("question", "")), stamp, row.submission_id),
             )
+        elif row.kind == "preview":
+            conn.execute(
+                "UPDATE portal_submissions SET preview_url = ?, updated_at = ? "
+                "WHERE submission_id = ?",
+                (str(row.fields.get("preview_url", "")), stamp, row.submission_id),
+            )
 
 
 def _round_number(fields: dict[str, Any]) -> int:

{code_coordinator-0.5.133 → code_coordinator-0.5.134}/coord/portal_sync.py

@@ -93,6 +93,11 @@ ANNOUNCING_STATUSES: dict[str, str] = {
     "awaiting-signoff": "design_round",
     # "we need an answer before we can carry on"
     "needs-input": "question",
+    # "here's a real preview build — approve it or tell us what to change"
+    # (#2359, coord-portal#107): the same #835 ordering rule applied to the
+    # preview-approval gate — a quality-check push must not summon the
+    # customer to a sign-off screen with no preview URL to look at.
+    "quality-check": "preview",
 }
 
 #: Outbox row kinds. The kind is not sent over the wire (the portal sees only
@@ -101,6 +106,7 @@ ANNOUNCING_STATUSES: dict[str, str] = {
 KIND_STATUS = "status"
 KIND_DESIGN_ROUND = "design_round"
 KIND_QUESTION = "question"
+KIND_PREVIEW = "preview"
 
 #: Event keys that are bookkeeping rather than customer-authored content —
 #: excluded from the mirror because they describe the envelope, not the
@@ -187,6 +193,26 @@ def enqueue_design_round(
     )
 
 
+def enqueue_preview(
+    submission_id: str, preview_url: str, *, now: float | None = None
+) -> portal_store.OutboxRow:
+    """Queue a preview build URL (#2359, coord-portal#107) for *submission_id*.
+
+    A real, pre-merge Cloudflare Pages Preview deployment for the PR — never
+    the Production deployment for ``main``, which must never show unapproved
+    work (see #107). What this function guarantees is the ordering — see
+    :func:`enqueue_status`.
+    """
+    if not isinstance(preview_url, str) or not preview_url.strip():
+        raise PortalSyncError("preview_url must be a non-empty string")
+    return portal_store.enqueue(
+        submission_id,
+        KIND_PREVIEW,
+        {"preview_url": preview_url},
+        now=now,
+    )
+
+
 def enqueue_question(
     submission_id: str, question: str, *, now: float | None = None
 ) -> portal_store.OutboxRow:

{code_coordinator-0.5.133 → code_coordinator-0.5.134}/coord/skills/portal-followup/SKILL.md

@@ -73,12 +73,79 @@ the same command there.
    underlying cause first, then `coord portal requeue <submission_id> <seq>`
    (find the seq with `coord portal outbox --all`) — also a daemon-host command.
 
+## Step 2 — per event kind
+
+`coord portal events` shows whatever `event_type` the portal reported,
+verbatim — there is no closed enum on this side (`coord/portal_bridge.py`'s
+`pull()` returns the JSON as-is), so a new event kind the portal starts
+sending shows up here for free, with no coord-side code change. What each
+kind means for what you do next:
+
+- **`signoff.approved`** — the customer accepted the design round. Move the
+  submission toward `planned`/`in-progress` as normal.
+- **`signoff.changes_requested`** — read the customer's comment, decide
+  whether it's a quick fix to the current round or needs a fresh design
+  round, then act (and `coord portal enqueue-design-round` again if it's a
+  new round).
+- **`preview.approved`** (#2359, coord-portal#107) — the customer approved
+  the real preview build. Read the comment/confirm it's really a go, then
+  `coord portal enqueue-status <id> shipped` **when actually ready** — same
+  manual discipline already used for `shipped` today. Nothing auto-fires off
+  this event; it is not wired into `coord merge` or the merge queue.
+- **`preview.changes_requested`** (#2359, coord-portal#107) — read the
+  customer's comment and decide whether it's a quick fix or a new round,
+  exactly like `signoff.changes_requested` above — no new logic, same manual
+  judgment call.
+
+## Pre-merge: queue the preview build (#2359)
+
+Before `shipped` meant "my wife looked at it and said it's fine." This gate
+replaces that with a real, tracked customer approval of an actual preview
+build. For any submission with a Cloudflare Pages preview deployment (most —
+skip this entirely for issues with no preview build; the gate is opt-in by
+construction, since a submission only enters `quality-check` if you queue a
+preview for it):
+
+1. **After Test and Review both pass, before running `coord merge` for the
+   issue**, fetch the PR's own **Preview** (never Production) deployment URL.
+   `cloudflare/pages-action` already creates a real GitHub Deployment per PR
+   (natal-chart's `deploy-cloudflare.yml` needs no changes for this):
+
+   ```
+   gh api repos/OWNER/REPO/deployments?ref=<branch> --jq '.[0].id'
+   gh api repos/OWNER/REPO/deployments/<id>/statuses --jq '.[0].environment_url'
+   ```
+
+   Confirm the deployment's `environment` reads `"<project> (Preview)"`, not
+   `"<project> (Production)"` — a `main`-branch deployment is Production and
+   must never be what the customer is shown for sign-off.
+
+2. **Queue it and announce it, in that order:**
+
+   ```
+   coord portal enqueue-preview <submission_id> <preview_url>
+   coord portal enqueue-status <submission_id> quality-check
+   ```
+
+   `quality-check` is now an announcing status (`ANNOUNCING_STATUSES` maps it
+   to `preview`), so the same #835 ordering guard that protects
+   `awaiting-signoff`/`design_round` applies here for free: the status push
+   HELDs until the preview row is confirmed applied, so the customer can never
+   land on a sign-off screen with nothing to look at.
+
+3. **Wait for `preview.approved`** (via `coord portal events`) before running
+   `coord merge` for the issue. This is operator discipline, not a mechanical
+   gate — `coord merge`/`coord.merge_queue` do not check for it and will
+   happily merge without it if you run them anyway. That's deliberate for this
+   pass (see the issue for why); treat skipping this wait the same as shipping
+   without your wife's verbal today.
+
 ## Rules
 
 - Never try to work around the "must run on the daemon host" error by editing
   `~/.coord/client.toml` to unset `board_service` on a thin client — that
   changes what *every other* `coord` command on that machine reads too, not
   just `portal`.
-- Prefer `coord portal enqueue-status`/`enqueue-design-round`/`enqueue-question`
+- Prefer `coord portal enqueue-status`/`enqueue-design-round`/`enqueue-question`/`enqueue-preview`
   over `coord portal push` for anything the customer will see — `push` bypasses
   the #835 ordering guard entirely.

{code_coordinator-0.5.133 → code_coordinator-0.5.134}/tests/test_cli_portal.py

@@ -92,7 +92,14 @@ def test_sync_loop_commands_are_registered():
     """#1982: the loop's operator surface."""
     result = run("portal", "--help")
     assert result.exit_code == 0
-    for sub in ("sync", "outbox", "events", "enqueue-status", "enqueue-design-round"):
+    for sub in (
+        "sync",
+        "outbox",
+        "events",
+        "enqueue-status",
+        "enqueue-design-round",
+        "enqueue-preview",
+    ):
         assert sub in result.output
 
 
@@ -289,6 +296,36 @@ def test_enqueue_design_round_rejects_invalid_json():
     assert "not valid JSON" in result.output
 
 
+def test_enqueue_status_refuses_quality_check_with_no_preview():
+    """#2359: same #835 discipline, for the preview-approval gate."""
+    result = run("portal", "enqueue-status", "sub_1", "quality-check")
+    assert result.exit_code != 0
+    assert "preview" in result.output
+
+
+def test_enqueue_preview_then_status_queues_both_in_order():
+    ok = run(
+        "portal", "enqueue-preview", "sub_1", "https://pr-42.natal-chart.pages.dev"
+    )
+    assert ok.exit_code == 0, ok.output
+    assert "seq=1" in ok.output
+
+    status = run("portal", "enqueue-status", "sub_1", "quality-check")
+    assert status.exit_code == 0, status.output
+    assert "seq=2" in status.output
+
+    listed = run("portal", "outbox")
+    assert listed.exit_code == 0
+    assert "preview" in listed.output
+    assert "HELD" in listed.output  # the announcement, until its preview applies
+
+
+def test_enqueue_preview_rejects_an_empty_url():
+    result = run("portal", "enqueue-preview", "sub_1", "")
+    assert result.exit_code != 0
+    assert "non-empty" in result.output
+
+
 def test_outbox_is_empty_by_default():
     result = run("portal", "outbox")
     assert result.exit_code == 0
@@ -326,6 +363,7 @@ def thin_client(monkeypatch):
         ("portal", "events"),
         ("portal", "enqueue-status", "sub_1", "shipped"),
         ("portal", "enqueue-design-round", "sub_1", "{}"),
+        ("portal", "enqueue-preview", "sub_1", "https://pr-1.example.pages.dev"),
         ("portal", "enqueue-question", "sub_1", "why?"),
         ("portal", "requeue", "sub_1", "1"),
     ],

{code_coordinator-0.5.133 → code_coordinator-0.5.134}/tests/test_portal_sync.py

@@ -18,6 +18,7 @@ from coord.portal_bridge import PortalBridgeError, PushResult
 from coord.portal_sync import (
     PortalSyncError,
     enqueue_design_round,
+    enqueue_preview,
     enqueue_question,
     enqueue_status,
     sync_tick,
@@ -544,6 +545,63 @@ def test_applied_rows_update_the_confirmed_record():
     assert record.last_status == "awaiting-signoff"
 
 
+# ── #2359: the preview-approval gate's ordering rule ────────────────────────
+
+
+def test_enqueue_status_refuses_quality_check_with_no_preview():
+    with pytest.raises(PortalSyncError) as exc:
+        enqueue_status(SUB, "quality-check")
+    assert "preview" in str(exc.value)
+    assert portal_store.pending_outbox() == []
+
+
+def test_enqueue_preview_refuses_an_empty_url():
+    with pytest.raises(PortalSyncError):
+        enqueue_preview(SUB, "")
+    with pytest.raises(PortalSyncError):
+        enqueue_preview(SUB, "   ")
+
+
+def test_preview_is_pushed_before_the_status_that_announces_it():
+    enqueue_preview(SUB, "https://pr-42.natal-chart.pages.dev")
+    enqueue_status(SUB, "quality-check")
+    client = FakeClient()
+
+    result = sync_tick(client=client)
+
+    assert client.pushed_kinds == ["preview_url", "status"]
+    assert result.applied == 2
+    assert result.held == 0
+
+
+def test_quality_check_announcement_is_held_while_its_preview_is_unconfirmed():
+    enqueue_preview(SUB, "https://pr-42.natal-chart.pages.dev")
+    enqueue_status(SUB, "quality-check")
+    client = FakeClient(push_outcomes={"preview_url": "rejected"})
+
+    result = sync_tick(client=client)
+
+    assert client.pushed_kinds == ["preview_url"]
+    assert result.rejected == 1
+    assert result.applied == 0
+
+    # ...and it stays held on every subsequent tick, rather than leaking out.
+    client2 = FakeClient()
+    result2 = sync_tick(client=client2)
+    assert client2.pushes == []
+    assert result2.held == 1
+
+
+def test_applied_preview_rows_update_the_confirmed_record():
+    enqueue_preview(SUB, "https://pr-42.natal-chart.pages.dev")
+    enqueue_status(SUB, "quality-check")
+    sync_tick(client=FakeClient())
+
+    record = portal_store.get_submission(SUB)
+    assert record.preview_url == "https://pr-42.natal-chart.pages.dev"
+    assert record.last_status == "quality-check"
+
+
 def test_summary_reports_a_failed_heartbeat_loudly():
     result = sync_tick(client=FakeClient(heartbeat_ok=False))
     assert "heartbeat=FAILED" in result.summary()

code_coordinator-0.5.133/code_coordinator.egg-info/scm_version.json

@@ -1,8 +0,0 @@
-{
-  "tag": "0.5.133",
-  "distance": 0,
-  "node": "g11401bbec03acc180366896ddd1ef16e06204073",
-  "dirty": false,
-  "branch": "HEAD",
-  "node_date": "2026-08-17"
-}