cloudconsolelink 4.1.1__tar.gz → 4.1.2__tar.gz

{cloudconsolelink-4.1.1/cloudconsolelink.egg-info → cloudconsolelink-4.1.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cloudconsolelink
-Version: 4.1.1
+Version: 4.1.2
 Summary: Generate console links for cloud resources
 Home-page: https://github.com/Cloudanix/cloud-console-links
 Maintainer: Cloudanix

{cloudconsolelink-4.1.1 → cloudconsolelink-4.1.2}/cloudconsolelink/clouds/aws/__init__.py

@@ -126,6 +126,10 @@ class AWSLinker:
         }
 
         resource_tokens = tokens[5:]
+        # API Gateway ARNs are paths: arn:aws:apigateway:us-east-1::/restapis/abc123. Drop the
+        # leading "/" so the first segment is the resource type, as in every other path-style ARN.
+        if resource_tokens and resource_tokens[0].startswith("/"):
+            resource_tokens[0] = resource_tokens[0][1:]
 
         console = get_console(str(data.get("partition", "")))
         if not console:

{cloudconsolelink-4.1.1 → cloudconsolelink-4.1.2}/cloudconsolelink/clouds/aws/links.py

@@ -983,7 +983,8 @@ def get_links() -> Dict:
             {data.get("resource", "")}',
             "trafficpolicyinstance": 'https://{data.get("console", "")}/route53/trafficflow/home#/\
             modify-records/edit/{data.get("resource", "")}',
-            "domains": 'https://{data.get("region", "")}.{data.get("console", "")}/route53/home#DomainListing:',
+            # Route 53 Domains is global: its ARNs carry no region, so the host has none.
+            "domains": 'https://{data.get("console", "")}/route53/home#DomainListing:',
         },
         "route53resolver": {  # Amazon Route 53 Resolver
             "resolver-endpoint": 'https://{data.get("region", "")}.{data.get("console", "")}/route53resolver/home?region={data.get("region", "")}#/endpoints/{data.get("resource", "")}',

{cloudconsolelink-4.1.1 → cloudconsolelink-4.1.2/cloudconsolelink.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cloudconsolelink
-Version: 4.1.1
+Version: 4.1.2
 Summary: Generate console links for cloud resources
 Home-page: https://github.com/Cloudanix/cloud-console-links
 Maintainer: Cloudanix

{cloudconsolelink-4.1.1 → cloudconsolelink-4.1.2}/tests/test_aws.py

@@ -172,6 +172,33 @@ def test_aws_apigateway_client_certificate():
     assert out_link == expected_link
 
 
+def test_aws_apigateway_documented_arns_with_leading_slash():
+    # AWS documents API Gateway ARNs as paths (::/restapis/...). Before: the "/" left an empty
+    # resource type, so every one fell back to the API Gateway home page.
+    home = "https://us-east-1.console.aws.amazon.com/apigateway/home?region=us-east-1"
+    cases = {
+        "arn:aws:apigateway:us-east-1::/restapis/abc123": f"{home}#/abc123/resources/",
+        "arn:aws:apigateway:us-east-1::/restapis/abc123/stages/prod": f"{home}#/abc123/stages/prod/resources/",
+        "arn:aws:apigateway:us-east-1::/apis/abc123": f"{home}#/abc123/resources/",
+        "arn:aws:apigateway:us-east-1::/clientcertificates/abc123": f"{home}#/client-certificates",
+    }
+    for arn, expected_link in cases.items():
+        assert aws.get_console_link(arn=arn) == expected_link
+        # Same link as the slash-less form callers send today.
+        assert aws.get_console_link(arn=arn.replace("::/", "::")) == expected_link
+
+
+def test_aws_route53_domain_has_no_region_host():
+    # Before: the empty region produced the host "https://.console.aws.amazon.com".
+    arn = "arn:aws:route53:::domains/example.com"
+
+    assert aws.get_console_link(arn=arn) == "https://console.aws.amazon.com/route53/home#DomainListing:"
+    assert (
+        aws.get_console_link(arn="arn:aws-us-gov:route53:::domains/example.com")
+        == "https://console.amazonaws-us-gov.com/route53/home#DomainListing:"
+    )
+
+
 def test_aws_cloudwatch_loggroup():
     arn = "arn:aws:logs:us-east-2:123456789012:log-group/LogGroupName-123"
     expected_link = 'https://us-east-2.console.aws.amazon.com/cloudwatch/home?region=us-east-2#logsV2:log-groups/log-group/LogGroupName-123'