clientwright 0.4.0__tar.gz → 0.4.1__tar.gz

{clientwright-0.4.0 → clientwright-0.4.1}/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.4.1](https://github.com/bedrock-python/clientwright/compare/clientwright-v0.4.0...clientwright-v0.4.1) (2026-09-14)
+
+
+### Bug Fixes
+
+* client_config_from_settings passes a BaseClientSettings through to to_config ([fc3af5e](https://github.com/bedrock-python/clientwright/commit/fc3af5e21821c8c506f10c43733aa4d66c563c39)), closes [#38](https://github.com/bedrock-python/clientwright/issues/38)
+
 ## [0.4.0](https://github.com/bedrock-python/clientwright/compare/clientwright-v0.3.0...clientwright-v0.4.0) (2026-09-14)
 
 

{clientwright-0.4.0 → clientwright-0.4.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: clientwright
-Version: 0.4.0
+Version: 0.4.1
 Summary: HTTP client platform: one resilience and observability core with adapters for httpx, aiohttp, requests, urllib3 and friends
 Project-URL: Repository, https://github.com/bedrock-python/clientwright
 Project-URL: Documentation, https://bedrock-python.github.io/clientwright/

{clientwright-0.4.0 → clientwright-0.4.1}/clientwright/__init__.py

@@ -55,6 +55,7 @@ from .core.contracts import (
     MaskerProtocol,
     RetrySettingsProtocol,
     SpanProtocol,
+    SupportsToConfig,
     TracerProtocol,
 )
 from .core.contracts.adapter import default_deps
@@ -158,6 +159,7 @@ __all__ = [
     "SeamGranularity",
     "SpanProtocol",
     "Support",
+    "SupportsToConfig",
     "TimeoutConfig",
     "TlsConfig",
     "TooManyRedirectsError",

clientwright-0.4.1/clientwright/__version__.py

@@ -0,0 +1 @@
+__version__ = "0.4.1"  # x-release-please-version

{clientwright-0.4.0 → clientwright-0.4.1}/clientwright/contrib/settings.py

@@ -283,7 +283,11 @@ class BaseClientSettings(BaseModel):
     )
 
     def to_config(self, service_name: str) -> ClientConfig:
-        """The ``ClientConfig`` these settings describe, labelled ``service_name``."""
+        """The ``ClientConfig`` these settings describe, labelled ``service_name``.
+
+        The one translation for the shipped models. ``client_config_from_settings``
+        is the flat legacy route and passes a ``BaseClientSettings`` straight here.
+        """
         return ClientConfig(
             service_name=service_name,
             base_url=self.base_url,

{clientwright-0.4.0 → clientwright-0.4.1}/clientwright/core/contracts/__init__.py

@@ -15,6 +15,7 @@ from .observability import TracerProtocol as TracerProtocol
 from .settings import CircuitBreakerSettingsProtocol as CircuitBreakerSettingsProtocol
 from .settings import ClientSettingsProtocol as ClientSettingsProtocol
 from .settings import RetrySettingsProtocol as RetrySettingsProtocol
+from .settings import SupportsToConfig as SupportsToConfig
 
 __all__ = [
     "AdapterDeps",
@@ -30,6 +31,7 @@ __all__ = [
     "ResponseView",
     "RetrySettingsProtocol",
     "SpanProtocol",
+    "SupportsToConfig",
     "SyncNormalizer",
     "TracerProtocol",
 ]

{clientwright-0.4.0 → clientwright-0.4.1}/clientwright/core/contracts/settings.py

@@ -4,6 +4,12 @@ Services keep their own settings models (pydantic or otherwise); anything with
 these read-only properties satisfies the contract - the org convention set by
 grpc-client-kit. ``client_config_from_settings`` converts the structural shape
 into a ``ClientConfig``.
+
+This is the flat, legacy shape. The shipped models in
+``clientwright.contrib.settings`` are the nested one and carry their own
+translation, ``BaseClientSettings.to_config(service_name)``; the converter
+passes anything with a ``to_config`` through to it, so either call builds
+the same config.
 """
 
 from __future__ import annotations
@@ -50,7 +56,12 @@ class CircuitBreakerSettingsProtocol(Protocol):
 
 @runtime_checkable
 class ClientSettingsProtocol(Protocol):
-    """Mirror of the legacy ``RestClientSettingsProtocol`` reachable surface."""
+    """Mirror of the legacy ``RestClientSettingsProtocol`` reachable surface.
+
+    Flat names for a settings model of your own. The shipped nested models
+    (``clientwright.contrib.settings.BaseClientSettings``) do not satisfy this
+    protocol; they carry ``to_config(service_name)`` instead.
+    """
 
     @property
     def base_url(self) -> str: ...
@@ -89,8 +100,26 @@ class ClientSettingsProtocol(Protocol):
     def circuit_breaker(self) -> CircuitBreakerSettingsProtocol | None: ...
 
 
-def client_config_from_settings(settings: ClientSettingsProtocol, service_name: str) -> ClientConfig:
-    """Build a ClientConfig from the structural settings shape used by services."""
+@runtime_checkable
+class SupportsToConfig(Protocol):
+    """Settings that build their own ``ClientConfig`` - the shape of ``BaseClientSettings``."""
+
+    def to_config(self, service_name: str) -> ClientConfig: ...
+
+
+def client_config_from_settings(settings: ClientSettingsProtocol | SupportsToConfig, service_name: str) -> ClientConfig:
+    """Build a ClientConfig from the structural settings shape used by services.
+
+    For a settings object that builds its own config - the shipped
+    ``clientwright.contrib.settings.BaseClientSettings`` - this is
+    ``settings.to_config(service_name)``, and that is what it returns: the
+    nested sections (pool, tls, proxy, headers, redirects, observability, ...)
+    all reach the config. Call ``to_config`` directly where you can; the flat
+    ``ClientSettingsProtocol`` route is for a model of your own that predates
+    the shipped ones.
+    """
+    if isinstance(settings, SupportsToConfig):
+        return settings.to_config(service_name)
     retry_settings = settings.retry
     retry = (
         RetryConfig(
@@ -136,5 +165,6 @@ __all__ = [
     "CircuitBreakerSettingsProtocol",
     "ClientSettingsProtocol",
     "RetrySettingsProtocol",
+    "SupportsToConfig",
     "client_config_from_settings",
 ]

{clientwright-0.4.0 → clientwright-0.4.1}/tests/unit/contrib/test_settings.py

@@ -27,6 +27,7 @@ from clientwright import (
     TlsConfig,
     UnsupportedPolicy,
     build_sync,
+    client_config_from_settings,
 )
 from clientwright.contrib import settings as settings_module
 from clientwright.contrib.settings import (
@@ -203,6 +204,27 @@ def test__bad_values__fail_at_load_with_the_field_path() -> None:
         BaseProxySettings(url="http://proxy:3128", from_env=True)
 
 
+# --- the legacy converter ---
+
+
+def test__the_legacy_converter__passes_a_base_client_settings_through_to_to_config() -> None:
+    settings = BaseClientSettings(
+        base_url="https://auth.example.com",
+        pool={"max_connections": 7},
+        retry={"multiplier": 3.0},
+        tls={"verify": False},
+        proxy={"url": "http://proxy:3128"},
+    )
+
+    config = client_config_from_settings(settings, "auth-orchestrator")
+
+    assert config == settings.to_config("auth-orchestrator")
+    assert config.pool.max_connections == 7
+    assert config.retry is not None and config.retry.multiplier == 3.0
+    assert config.tls == TlsConfig(verify=False)
+    assert config.proxy == ProxyConfig(url="http://proxy:3128")
+
+
 def test__a_config_from_settings__builds_the_native_client() -> None:
     httpx = pytest.importorskip("httpx", reason="requires the [httpx] extra")
     config = BaseClientSettings(base_url="https://api.example.com", pool={"http2": False}).to_config("api")

{clientwright-0.4.0 → clientwright-0.4.1}/tests/unit/core/test_settings.py

@@ -32,3 +32,13 @@ def test__structural_settings__mapped_into_config() -> None:
     assert config.retry is not None and config.retry.max_attempts == 5
     assert config.circuit_breaker is None
     assert config.observability.tracing is False
+
+
+def test__settings_with_to_config__are_passed_through_to_it() -> None:
+    class Settings:
+        def to_config(self, service_name: str) -> clientwright.ClientConfig:
+            return clientwright.ClientConfig(service_name=service_name, base_url="https://api.example.com")
+
+    config = clientwright.client_config_from_settings(Settings(), "svc")
+    assert config == clientwright.ClientConfig(service_name="svc", base_url="https://api.example.com")
+    assert isinstance(Settings(), clientwright.SupportsToConfig)

clientwright-0.4.0/clientwright/__version__.py

@@ -1 +0,0 @@
-__version__ = "0.4.0"  # x-release-please-version