civics-cdf-validator 1.61.dev4__tar.gz → 1.61.dev6__tar.gz

{civics_cdf_validator-1.61.dev4/civics_cdf_validator.egg-info → civics_cdf_validator-1.61.dev6}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: civics_cdf_validator
-Version: 1.61.dev4
+Version: 1.61.dev6
 Summary: Checks if an election feed follows best practices
 Home-page: https://github.com/google/civics_cdf_validator
 Author: Google Civics

{civics_cdf_validator-1.61.dev4 → civics_cdf_validator-1.61.dev6/civics_cdf_validator.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: civics_cdf_validator
-Version: 1.61.dev4
+Version: 1.61.dev6
 Summary: Checks if an election feed follows best practices
 Home-page: https://github.com/google/civics_cdf_validator
 Author: Google Civics

{civics_cdf_validator-1.61.dev4 → civics_cdf_validator-1.61.dev6}/rules.py

@@ -141,6 +141,13 @@ _WINNER_POST_ELECTION_STATUSES = frozenset([
 ])
 
 
+def _is_xml_true(element):
+  return (
+      element_has_text(element)
+      and element.text.strip().lower() in _XML_TRUE_VALUES
+  )
+
+
 def _get_office_roles(element, is_post_office_split_feed=False):
   if is_post_office_split_feed:
     return [element.text for element in element.findall("Role")]
@@ -1624,6 +1631,50 @@ class DuplicateContestNames(base.BaseRule):
       raise loggers.ElectionError(error_log)
 
 
+class DuplicateBallotTitleSeatPair(base.BaseRule):
+  """Checks that each English (BallotTitle, Seat) combination is unique.
+
+  Adds Warning/Error if duplicate English (BallotTitle, Seat) combinations are
+  found.
+  """
+
+  def elements(self):
+    return ["ContestCollection"]
+
+  def check(self, element):
+    error_log = []
+    contest_elements = element.findall("Contest")
+    contests_by_title_and_seat = collections.defaultdict(list)
+
+    for contest in contest_elements:
+      ballot_title_element = get_language_to_text_map(
+          contest.find("BallotTitle")
+      )
+      english_title = ballot_title_element.get("en")
+      seat_element = contest.find("Seat")
+
+      ballot_title = english_title[0].strip() if english_title else ""
+      seat = seat_element.text.strip() if element_has_text(seat_element) else ""
+
+      if not ballot_title:
+        continue
+
+      ballot_title_and_seat = (ballot_title, seat)
+      contests_by_title_and_seat[ballot_title_and_seat].append(contest)
+
+    for ballot_title_and_seat, contests in contests_by_title_and_seat.items():
+      if len(contests) > 1:
+        ballot_title, seat = ballot_title_and_seat
+        error_message = (
+            "Multiple Contests found with the same BallotTitle"
+            f" ('{ballot_title}') and Seat ('{seat}')."
+        )
+        error_log.append(loggers.LogEntry(error_message, contests))
+
+    if error_log:
+      raise loggers.ElectionError(error_log)
+
+
 class UniqueStableID(base.TreeRule):
   """Check that every stableID is unique.
 
@@ -4716,6 +4767,10 @@ class FeedInactiveDateIsLatestDate(base.BaseRule):
     return ["Feed"]
 
   def check(self, element):
+    # Skip this rule for test feeds.
+    if _is_xml_true(element.find("IsTest")):
+      return
+
     if element_has_text(element.find("FeedInactiveDate")):
       feed_inactive_date = base.PartialDate.init_partial_date(
           element.find("FeedInactiveDate").text
@@ -5404,11 +5459,7 @@ class ValidateIncludeInAggregationBallotSelections(base.BaseRule):
 
     included_selections = []
     for selection in all_selections:
-      included_in_aggregation_element = selection.find("IncludedInAggregation")
-      if (
-          element_has_text(included_in_aggregation_element)
-          and included_in_aggregation_element.text in _XML_TRUE_VALUES
-      ):
+      if _is_xml_true(selection.find("IncludedInAggregation")):
         included_selections.append(selection)
     if not included_selections:
       return
@@ -5531,6 +5582,7 @@ ELECTION_RULES = COMMON_RULES + (
     ContestStartDateContainsCorrespondingEndDate,
     CorrectCandidateSelectionCount,
     DateStatusMatches,
+    DuplicateBallotTitleSeatPair,
     DuplicateContestNames,
     DuplicatedPartyAbbreviation,
     DuplicatedPartyName,

{civics_cdf_validator-1.61.dev4 → civics_cdf_validator-1.61.dev6}/version.py

@@ -5,4 +5,4 @@ No dependencies should be added to this module.
 See https://packaging.python.org/guides/single-sourcing-package-version/
 """
 
-__version__ = '1.61.dev4'
+__version__ = '1.61.dev6'