civics-cdf-validator 1.55.dev4__tar.gz → 1.56.dev0__tar.gz

{civics_cdf_validator-1.55.dev4/civics_cdf_validator.egg-info → civics_cdf_validator-1.56.dev0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: civics_cdf_validator
-Version: 1.55.dev4
+Version: 1.56.dev0
 Summary: Checks if an election feed follows best practices
 Home-page: https://github.com/google/civics_cdf_validator
 Author: Google Civics

{civics_cdf_validator-1.55.dev4 → civics_cdf_validator-1.56.dev0/civics_cdf_validator.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: civics_cdf_validator
-Version: 1.55.dev4
+Version: 1.56.dev0
 Summary: Checks if an election feed follows best practices
 Home-page: https://github.com/google/civics_cdf_validator
 Author: Google Civics

{civics_cdf_validator-1.55.dev4 → civics_cdf_validator-1.56.dev0}/rules.py

@@ -409,7 +409,7 @@ class PercentSum(base.BaseRule):
 
 
 class EmptyText(base.BaseRule):
-  """Check that Text elements are not strictly whitespace."""
+  """Check that Text elements are not empty or strictly whitespace."""
 
   def elements(self):
     return ["Text"]
@@ -421,6 +421,38 @@ class EmptyText(base.BaseRule):
       raise loggers.ElectionError.from_message("Text is empty", element)
 
 
+class EmptyString(base.BaseRule):
+  """Check that string fields are not empty or strictly whitespace."""
+
+  def elements(self):
+    """Returns all elements of type xs:string from the schema."""
+    string_elements = []
+    for _, element in etree.iterwalk(self.schema_tree):
+      tag = self.strip_schema_ns(element)
+      if (
+          tag
+          and tag == "element"
+          and element.get("type") == "xs:string"
+          and element.get("name") is not None
+      ):
+        string_elements.append(element.get("name"))
+    return string_elements
+
+  # pylint: disable=g-explicit-length-test
+  def check(self, element):
+    if element.text is None or not element.text.strip() and not len(element):
+      # TODO(b/462777279): Remove this once once feeds are no longer setting
+      # this to an empty string.
+      if element.tag == "IssuerAbbreviation":
+        raise loggers.ElectionWarning.from_message(
+            "String field is empty", [element]
+        )
+      else:
+        raise loggers.ElectionError.from_message(
+            "String field is empty", [element]
+        )
+
+
 class DuplicateID(base.TreeRule):
   """Check that the file does not contain duplicate object IDs."""
 
@@ -4723,6 +4755,7 @@ COMMON_RULES = (
     DuplicateGpUnits,
     DuplicateID,
     DuplicatedGpUnitOcdId,
+    EmptyString,
     EmptyText,
     Encoding,
     ExecutiveOfficeShouldNotHaveGovernmentBody,

{civics_cdf_validator-1.55.dev4 → civics_cdf_validator-1.56.dev0}/version.py

@@ -5,4 +5,4 @@ No dependencies should be added to this module.
 See https://packaging.python.org/guides/single-sourcing-package-version/
 """
 
-__version__ = '1.55.dev4'
+__version__ = '1.56.dev0'