cicaddy-github 0.5.0__tar.gz → 0.6.0__tar.gz

{cicaddy_github-0.5.0 → cicaddy_github-0.6.0}/.agents/skills/cicaddy-action/SKILL.md

@@ -225,7 +225,7 @@ the `safe-to-review` label. The label is auto-removed on new pushes to prevent
 TOCTOU bypasses.
 
 ```yaml
-- uses: redhat-community-ai-tools/cicaddy-action@v0.5.0
+- uses: redhat-community-ai-tools/cicaddy-action@v0.6.0
   with:
     ai_provider: gemini
     ai_model: gemini-3-flash-preview

{cicaddy_github-0.5.0 → cicaddy_github-0.6.0}/.github/workflows/pr-review.yml

@@ -49,7 +49,7 @@ jobs:
           fi
 
       - name: AI Code Review
-        uses: ./
+        uses: redhat-community-ai-tools/cicaddy-action@v0.5.0
         id: review
         with:
           ai_provider: gemini
@@ -57,6 +57,7 @@ jobs:
           ai_api_key: ${{ secrets.AI_API_KEY }}
           task_file: tasks/pr_review.yml
           post_pr_comment: 'true'
+          delegation_mode: auto
           mcp_servers_config: ${{ steps.mcp.outputs.config }}
         env:
           ANALYSIS_FOCUS: "general"

{cicaddy_github-0.5.0 → cicaddy_github-0.6.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cicaddy-github
-Version: 0.5.0
+Version: 0.6.0
 Summary: GitHub Actions plugin for cicaddy AI agent framework
 Project-URL: Homepage, https://github.com/redhat-community-ai-tools/cicaddy-action
 Project-URL: Repository, https://github.com/redhat-community-ai-tools/cicaddy-action.git
@@ -9,7 +9,7 @@ Author: Wayne Sun
 License: Apache-2.0
 License-File: LICENSE
 Requires-Python: >=3.11
-Requires-Dist: cicaddy>=0.8.0
+Requires-Dist: cicaddy>=0.10.0
 Requires-Dist: detect-secrets>=1.4.0
 Requires-Dist: pygithub>=2.1.0
 Provides-Extra: test

{cicaddy_github-0.5.0 → cicaddy_github-0.6.0}/action.yml

@@ -78,4 +78,4 @@ runs:
   using: 'docker'
   image: 'Dockerfile'
   # After first GHCR publish, switch to pre-built image for faster startup:
-  # image: 'docker://ghcr.io/redhat-community-ai-tools/cicaddy-action:0.1.0'
+  # image: 'docker://ghcr.io/redhat-community-ai-tools/cicaddy-action:0.6.0'

{cicaddy_github-0.5.0 → cicaddy_github-0.6.0}/pyproject.toml

@@ -4,14 +4,14 @@ build-backend = "hatchling.build"
 
 [project]
 name = "cicaddy-github"
-version = "0.5.0"
+version = "0.6.0"
 description = "GitHub Actions plugin for cicaddy AI agent framework"
 readme = "README.md"
 requires-python = ">=3.11"
 license = {text = "Apache-2.0"}
 authors = [{name = "Wayne Sun"}]
 dependencies = [
-    "cicaddy>=0.8.0",
+    "cicaddy>=0.10.0",
     "PyGithub>=2.1.0",
     "detect-secrets>=1.4.0",
 ]

{cicaddy_github-0.5.0 → cicaddy_github-0.6.0}/src/cicaddy_github/__init__.py

@@ -1,3 +1,3 @@
 """cicaddy-github: GitHub Actions plugin for cicaddy AI agent framework."""
 
-__version__ = "0.1.0"
+__version__ = "0.6.0"

{cicaddy_github-0.5.0 → cicaddy_github-0.6.0}/src/cicaddy_github/github_integration/agents.py

@@ -173,9 +173,36 @@ class GitHubPRAgent(BaseAIAgent):
         self.pr_number = settings.github_pr_number if settings else os.getenv("GITHUB_PR_NUMBER")
         self.leak_detector = LeakDetector()
 
+    # Delegation hooks — forward to cicaddy core's BaseReviewAgent.
+    #
+    # This class inherits from BaseAIAgent (not BaseReviewAgent) because it
+    # handles GitHub platform integration inline. We forward review-specific
+    # delegation hooks as explicit unbound method calls to keep all delegation
+    # logic in cicaddy core.
+
     def _get_agent_type(self) -> str:
         """PR review agents use the 'review' delegation registry."""
-        return "review"
+        from cicaddy.agent.base_review_agent import (
+            BaseReviewAgent as _CoreReviewAgent,
+        )
+
+        return _CoreReviewAgent._get_agent_type(self)  # ty: ignore[invalid-argument-type]
+
+    def _get_delegation_context(self, context: dict[str, Any]) -> dict[str, Any]:
+        """Shape context for review delegation triage."""
+        from cicaddy.agent.base_review_agent import (
+            BaseReviewAgent as _CoreReviewAgent,
+        )
+
+        return _CoreReviewAgent._get_delegation_context(self, context)  # ty: ignore[invalid-argument-type]
+
+    def _post_process_plan(self, plan: Any, registry: dict[str, Any]) -> Any:
+        """Ensure general-reviewer is always included in review plans."""
+        from cicaddy.agent.base_review_agent import (
+            BaseReviewAgent as _CoreReviewAgent,
+        )
+
+        return _CoreReviewAgent._post_process_plan(self, plan, registry)  # ty: ignore[invalid-argument-type, unresolved-attribute]
 
     async def _setup_local_tools(self):
         """Setup local tools for PR review."""
@@ -433,9 +460,32 @@ class GitHubGoDepReviewAgent(BaseAIAgent):
         self.pr_number = getattr(settings, "github_pr_number", None) if settings else None
         self.leak_detector = LeakDetector()
 
+    # Delegation hooks — forward to cicaddy core's BaseReviewAgent.
+    # See GitHubPRAgent docstring for rationale.
+
     def _get_agent_type(self) -> str:
         """Dependency review agents use the 'review' delegation registry."""
-        return "review"
+        from cicaddy.agent.base_review_agent import (
+            BaseReviewAgent as _CoreReviewAgent,
+        )
+
+        return _CoreReviewAgent._get_agent_type(self)  # ty: ignore[invalid-argument-type]
+
+    def _get_delegation_context(self, context: dict[str, Any]) -> dict[str, Any]:
+        """Shape context for review delegation triage."""
+        from cicaddy.agent.base_review_agent import (
+            BaseReviewAgent as _CoreReviewAgent,
+        )
+
+        return _CoreReviewAgent._get_delegation_context(self, context)  # ty: ignore[invalid-argument-type]
+
+    def _post_process_plan(self, plan: Any, registry: dict[str, Any]) -> Any:
+        """Ensure general-reviewer is always included in review plans."""
+        from cicaddy.agent.base_review_agent import (
+            BaseReviewAgent as _CoreReviewAgent,
+        )
+
+        return _CoreReviewAgent._post_process_plan(self, plan, registry)  # ty: ignore[invalid-argument-type, unresolved-attribute]
 
     async def _setup_local_tools(self):
         """Setup local tools including git and dependency review tools."""

cicaddy_github-0.6.0/tests/unit/test_review_delegation_hooks.py

@@ -0,0 +1,146 @@
+"""Tests for review agent delegation hook forwarding to cicaddy core."""
+
+from unittest.mock import MagicMock
+
+import pytest
+from cicaddy.delegation.registry import SubAgentSpec
+from cicaddy.delegation.triage import DelegationEntry, DelegationPlan
+
+from cicaddy_github.github_integration.agents import (
+    GitHubGoDepReviewAgent,
+    GitHubPRAgent,
+)
+
+# _post_process_plan exists in cicaddy core >= 0.9.0 (PR #50).
+# CI may install an older release; skip tests that depend on it.
+_has_post_process = hasattr(
+    __import__("cicaddy.agent.base_review_agent", fromlist=["BaseReviewAgent"]).BaseReviewAgent,
+    "_post_process_plan",
+)
+_skip_no_post_process = pytest.mark.skipif(
+    not _has_post_process,
+    reason="cicaddy core missing _post_process_plan (needs >= 0.9.0)",
+)
+
+
+def _make_pr_agent():
+    """Create a minimal GitHubPRAgent with mocked settings."""
+    settings = MagicMock()
+    settings.github_pr_number = "123"
+    agent = GitHubPRAgent.__new__(GitHubPRAgent)
+    agent.settings = settings
+    agent.pr_number = "123"
+    return agent
+
+
+def _make_dep_review_agent():
+    """Create a minimal GitHubGoDepReviewAgent with mocked settings."""
+    settings = MagicMock()
+    agent = GitHubGoDepReviewAgent.__new__(GitHubGoDepReviewAgent)
+    agent.settings = settings
+    agent.pr_number = "456"
+    return agent
+
+
+class TestPRAgentDelegationHooks:
+    """Verify GitHubPRAgent delegation hooks forward to cicaddy core."""
+
+    def test_get_agent_type_returns_review(self):
+        agent = _make_pr_agent()
+        assert agent._get_agent_type() == "review"
+
+    def test_get_delegation_context_extracts_diff(self):
+        agent = _make_pr_agent()
+        context = {
+            "diff": ("diff --git a/main.go b/main.go\n+import fmt\n"),
+            "diff_lines": 2,
+            "analysis_type": "pull_request",
+            "pull_request": {"title": "Fix bug"},
+        }
+        result = agent._get_delegation_context(context)
+        assert "diff" in result
+        assert result["changed_files"] == ["main.go"]
+        assert result["analysis_type"] == "pull_request"
+
+    @_skip_no_post_process
+    def test_post_process_plan_injects_general_reviewer(self):
+        agent = _make_pr_agent()
+        plan = DelegationPlan(
+            entries=[
+                DelegationEntry(
+                    agent_name="security-reviewer",
+                    categories=["security"],
+                    rationale="test",
+                    priority=10,
+                )
+            ]
+        )
+        registry = {
+            "security-reviewer": SubAgentSpec(
+                name="security-reviewer",
+                persona="sec",
+                description="Security review",
+                categories=["security"],
+                priority=10,
+                agent_type="review",
+            ),
+            "general-reviewer": SubAgentSpec(
+                name="general-reviewer",
+                persona="eng",
+                description="General review",
+                categories=["code_quality"],
+                priority=100,
+                agent_type="review",
+            ),
+        }
+
+        result = agent._post_process_plan(plan, registry)
+        names = [e.agent_name for e in result.entries]
+        assert "general-reviewer" in names
+        assert len(result.entries) == 2
+
+    @_skip_no_post_process
+    def test_post_process_plan_no_duplicate(self):
+        agent = _make_pr_agent()
+        plan = DelegationPlan(
+            entries=[
+                DelegationEntry(
+                    agent_name="general-reviewer",
+                    categories=["code_quality"],
+                    rationale="test",
+                    priority=100,
+                )
+            ]
+        )
+        registry = {
+            "general-reviewer": SubAgentSpec(
+                name="general-reviewer",
+                persona="eng",
+                description="General review",
+                categories=["code_quality"],
+                priority=100,
+                agent_type="review",
+            ),
+        }
+
+        result = agent._post_process_plan(plan, registry)
+        assert len(result.entries) == 1
+
+
+class TestGoDepReviewAgentDelegationHooks:
+    """Verify GitHubGoDepReviewAgent delegation hooks forward to cicaddy core."""
+
+    def test_get_agent_type_returns_review(self):
+        agent = _make_dep_review_agent()
+        assert agent._get_agent_type() == "review"
+
+    def test_get_delegation_context_extracts_diff(self):
+        agent = _make_dep_review_agent()
+        context = {
+            "diff": ("diff --git a/go.mod b/go.mod\n+require example.com/pkg v1.2.0\n"),
+            "diff_lines": 2,
+            "analysis_type": "go_dependency_review",
+        }
+        result = agent._get_delegation_context(context)
+        assert result["changed_files"] == ["go.mod"]
+        assert result["analysis_type"] == "go_dependency_review"