cicaddy-github 0.3.2__tar.gz → 0.4.0__tar.gz

{cicaddy_github-0.3.2 → cicaddy_github-0.4.0}/.claude/skills/cicaddy-action/SKILL.md

@@ -225,7 +225,7 @@ the `safe-to-review` label. The label is auto-removed on new pushes to prevent
 TOCTOU bypasses.
 
 ```yaml
-- uses: redhat-community-ai-tools/cicaddy-action@v0.3.2
+- uses: redhat-community-ai-tools/cicaddy-action@v0.4.0
   with:
     ai_provider: gemini
     ai_model: gemini-3-flash-preview

{cicaddy_github-0.3.2 → cicaddy_github-0.4.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cicaddy-github
-Version: 0.3.2
+Version: 0.4.0
 Summary: GitHub Actions plugin for cicaddy AI agent framework
 Project-URL: Homepage, https://github.com/redhat-community-ai-tools/cicaddy-action
 Project-URL: Repository, https://github.com/redhat-community-ai-tools/cicaddy-action.git
@@ -57,7 +57,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - uses: redhat-community-ai-tools/cicaddy-action@v0.3.2
+      - uses: redhat-community-ai-tools/cicaddy-action@v0.4.0
         with:
           ai_provider: gemini
           ai_model: gemini-3-flash-preview
@@ -83,7 +83,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - uses: redhat-community-ai-tools/cicaddy-action@v0.3.2
+      - uses: redhat-community-ai-tools/cicaddy-action@v0.4.0
         with:
           ai_provider: gemini
           ai_model: gemini-3-flash-preview
@@ -104,6 +104,7 @@ jobs:
 | `mcp_servers_config` | No | JSON array of MCP server configs |
 | `slack_webhook_url` | No | Slack webhook URL for notifications |
 | `post_pr_comment` | No | Post results as PR comment (default: `false`) |
+| `submit_review` | No | Submit formal PR review with APPROVE/REQUEST_CHANGES (default: `false`) |
 | `github_token` | No | GitHub token (default: `${{ github.token }}`) |
 
 ## Outputs

{cicaddy_github-0.3.2 → cicaddy_github-0.4.0}/README.md

@@ -37,7 +37,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - uses: redhat-community-ai-tools/cicaddy-action@v0.3.2
+      - uses: redhat-community-ai-tools/cicaddy-action@v0.4.0
         with:
           ai_provider: gemini
           ai_model: gemini-3-flash-preview
@@ -63,7 +63,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - uses: redhat-community-ai-tools/cicaddy-action@v0.3.2
+      - uses: redhat-community-ai-tools/cicaddy-action@v0.4.0
         with:
           ai_provider: gemini
           ai_model: gemini-3-flash-preview
@@ -84,6 +84,7 @@ jobs:
 | `mcp_servers_config` | No | JSON array of MCP server configs |
 | `slack_webhook_url` | No | Slack webhook URL for notifications |
 | `post_pr_comment` | No | Post results as PR comment (default: `false`) |
+| `submit_review` | No | Submit formal PR review with APPROVE/REQUEST_CHANGES (default: `false`) |
 | `github_token` | No | GitHub token (default: `${{ github.token }}`) |
 
 ## Outputs

{cicaddy_github-0.3.2 → cicaddy_github-0.4.0}/action.yml

@@ -34,6 +34,10 @@ inputs:
     description: 'Post analysis results as PR comment (requires github-token with pull-requests: write)'
     required: false
     default: 'false'
+  submit_review:
+    description: 'Submit a formal PR review with APPROVE or REQUEST_CHANGES based on AI analysis (requires github-token with pull-requests: write)'
+    required: false
+    default: 'false'
   github_token:
     description: 'GitHub token for API access'
     required: false

{cicaddy_github-0.3.2 → cicaddy_github-0.4.0}/entrypoint.sh

@@ -54,6 +54,7 @@ export MCP_SERVERS_CONFIG="${INPUT_MCP_SERVERS_CONFIG:-[]}"
 export SLACK_WEBHOOK_URL="${INPUT_SLACK_WEBHOOK_URL}"
 export GITHUB_TOKEN="${INPUT_GITHUB_TOKEN:-$GITHUB_TOKEN}"
 export POST_PR_COMMENT="${INPUT_POST_PR_COMMENT:-false}"
+export SUBMIT_REVIEW="${INPUT_SUBMIT_REVIEW:-false}"
 
 # Extract PR number from GITHUB_REF (e.g. refs/pull/123/merge -> 123)
 if [[ "${GITHUB_REF}" =~ ^refs/pull/([0-9]+)/ ]]; then

{cicaddy_github-0.3.2 → cicaddy_github-0.4.0}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "cicaddy-github"
-version = "0.3.2"
+version = "0.4.0"
 description = "GitHub Actions plugin for cicaddy AI agent framework"
 readme = "README.md"
 requires-python = ">=3.11"

{cicaddy_github-0.3.2 → cicaddy_github-0.4.0}/src/cicaddy_github/config/settings.py

@@ -61,6 +61,11 @@ class Settings(CoreSettings):
         validation_alias=AliasChoices("POST_PR_COMMENT"),
         description="Whether to post analysis results as PR comment",
     )
+    submit_review: bool = Field(
+        default=False,
+        validation_alias=AliasChoices("SUBMIT_REVIEW"),
+        description="Whether to submit a formal PR review (APPROVE or REQUEST_CHANGES)",
+    )
 
 
 def load_settings() -> Settings:
@@ -95,6 +100,11 @@ def load_settings() -> Settings:
     if post_pr:
         env_data["post_pr_comment"] = post_pr.lower() in ("true", "1", "yes")
 
+    # Submit formal PR review flag
+    submit_review = os.getenv("SUBMIT_REVIEW", "").strip()
+    if submit_review:
+        env_data["submit_review"] = submit_review.lower() in ("true", "1", "yes")
+
     # AI provider configuration
     if os.getenv("AI_PROVIDER"):
         env_data["ai_provider"] = os.getenv("AI_PROVIDER")

{cicaddy_github-0.3.2 → cicaddy_github-0.4.0}/src/cicaddy_github/github_integration/agents.py

@@ -18,6 +18,14 @@ logger = get_logger(__name__)
 
 BOT_COMMENT_MARKER_PR_REVIEW = "<!-- cicaddy-action:pr-review -->"
 
+# Pattern to detect a review verdict in the AI analysis output.
+# The AI is instructed to include a line like "VERDICT: APPROVE" or
+# "VERDICT: REQUEST_CHANGES" in its output.
+_VERDICT_PATTERN = re.compile(
+    r"(?:^|\n)\s*(?:<!--\s*)?VERDICT:\s*(APPROVE|REQUEST_CHANGES)(?:\s*-->)?",
+    re.IGNORECASE,
+)
+
 # Pattern matches fenced code blocks (possibly indented by list nesting).
 _FENCED_CODE_BLOCK = re.compile(
     r"^([ \t]*(?:`{3,}|~{3,})[^\n]*)\n(.*?)\n([ \t]*(?:`{3,}|~{3,}))[ \t]*$",
@@ -50,6 +58,19 @@ _MARKDOWN_WRAPPER = re.compile(
 )
 
 
+def extract_review_verdict(ai_text: str) -> str:
+    """Extract the review verdict from AI analysis output.
+
+    Looks for a ``VERDICT: APPROVE`` or ``VERDICT: REQUEST_CHANGES`` line
+    (optionally wrapped in an HTML comment).  Defaults to ``COMMENT`` when
+    no explicit verdict is found.
+    """
+    m = _VERDICT_PATTERN.search(ai_text)
+    if m:
+        return m.group(1).upper()
+    return "COMMENT"
+
+
 def strip_markdown_wrapper(text: str) -> str:
     """Strip a wrapping ```markdown fence from the entire AI output.
 
@@ -223,11 +244,16 @@ class GitHubPRAgent(BaseAIAgent):
             pr_context = self._prepare_dspy_context(context)
             dspy_prompt = self.build_dspy_prompt(task_file, pr_context)
             if dspy_prompt:
+                if getattr(self.settings, "submit_review", False):
+                    dspy_prompt += self._verdict_instruction()
                 return dspy_prompt
 
         pr_data = context["pull_request"]
         diff_content = context["diff"]
 
+        submit_review = getattr(self.settings, "submit_review", False)
+        verdict_block = self._verdict_instruction() if submit_review else ""
+
         return f"""You are an AI agent performing pull request code review.
 
 Repository: {context.get("repository", "Unknown")}
@@ -249,7 +275,21 @@ Instructions:
 4. Provide actionable, specific feedback
 
 Please provide your comprehensive analysis in markdown format.
-"""
+{verdict_block}"""
+
+    @staticmethod
+    def _verdict_instruction() -> str:
+        """Return the prompt snippet that asks the AI to emit a verdict."""
+        return (
+            "\n\nIMPORTANT: At the very end of your analysis, you MUST include a verdict line "
+            "in an HTML comment with the format:\n"
+            "<!-- VERDICT: APPROVE -->\n"
+            "or\n"
+            "<!-- VERDICT: REQUEST_CHANGES -->\n\n"
+            "Use REQUEST_CHANGES when there are bugs, security issues, or significant problems "
+            "that must be fixed before merging. Use APPROVE when the changes look good overall "
+            "(minor suggestions are OK with APPROVE)."
+        )
 
     def _prepare_dspy_context(self, context: dict[str, Any]) -> dict[str, Any]:
         """Prepare context with PR-specific data for DSPy prompt building."""
@@ -265,7 +305,7 @@ Please provide your comprehensive analysis in markdown format.
         return pr_context
 
     async def send_notifications(self, report: dict[str, Any], analysis_result: dict[str, Any]):
-        """Send notifications via PR comment and Slack."""
+        """Send notifications via PR comment, formal review, and Slack."""
         # Sanitize outputs
         if "ai_analysis" in analysis_result:
             analysis_result["ai_analysis"] = self.leak_detector.sanitize_text(
@@ -287,9 +327,47 @@ Please provide your comprehensive analysis in markdown format.
                 )
                 logger.debug("PR comment post traceback:", exc_info=True)
 
+        # Submit formal PR review if enabled
+        submit_review = getattr(self.settings, "submit_review", False)
+        if submit_review and self.platform_analyzer and self.pr_number:
+            try:
+                ai_text = analysis_result.get("ai_analysis", "")
+                verdict = extract_review_verdict(ai_text)
+                review_body = self._format_review_body(analysis_result)
+                await self.platform_analyzer.submit_pr_review(
+                    int(self.pr_number), review_body, event=verdict
+                )
+                logger.info(f"Submitted {verdict} review on PR #{self.pr_number}")
+            except Exception as e:
+                logger.error(
+                    f"Failed to submit PR review: {self.leak_detector.sanitize_text(str(e))}"
+                )
+                logger.debug("PR review submit traceback:", exc_info=True)
+
         # Send Slack notification using parent class
         await super().send_notifications(report, analysis_result)
 
+    def _format_review_body(self, analysis_result: dict[str, Any]) -> str:
+        """Format analysis results as a PR review body.
+
+        Strips the VERDICT line from the output so it does not appear in
+        the rendered review.
+        """
+        body = ""
+        if "ai_analysis" in analysis_result:
+            cleaned = strip_markdown_wrapper(analysis_result["ai_analysis"])
+            cleaned = dedent_code_blocks(cleaned)
+            # Remove the VERDICT line from the review body
+            cleaned = _VERDICT_PATTERN.sub("", cleaned).strip()
+            body = cleaned
+
+        body += (
+            "\n\n---\n"
+            "*Generated with [cicaddy-action]"
+            "(https://github.com/redhat-community-ai-tools/cicaddy-action)*"
+        )
+        return body
+
     def _format_pr_comment(self, analysis_result: dict[str, Any]) -> str:
         """Format analysis results as a PR comment.
 

{cicaddy_github-0.3.2 → cicaddy_github-0.4.0}/src/cicaddy_github/github_integration/analyzer.py

@@ -276,6 +276,23 @@ class GitHubAnalyzer:
 
         return result
 
+    async def submit_pr_review(self, pr_number: int, body: str, event: str = "COMMENT") -> None:
+        """Submit a formal pull request review.
+
+        Args:
+            pr_number: Pull request number.
+            body: Review body text.
+            event: Review event type — one of ``APPROVE``, ``REQUEST_CHANGES``,
+                or ``COMMENT``.
+        """
+        valid_events = {"APPROVE", "REQUEST_CHANGES", "COMMENT"}
+        if event not in valid_events:
+            raise ValueError(f"Invalid review event '{event}', must be one of {valid_events}")
+
+        pr = self.repo.get_pull(pr_number)
+        pr.create_review(body=body, event=event)
+        logger.info(f"Submitted {event} review on PR #{pr_number}")
+
     def close(self):
         """Close the GitHub API connection."""
         self.github.close()

{cicaddy_github-0.3.2 → cicaddy_github-0.4.0}/src/cicaddy_github/security/leak_detector.py

@@ -90,7 +90,7 @@ class LeakDetector:
 
         try:
             if hasattr(secret, "secret_value"):
-                secret_value: str = secret.secret_value  # type: ignore[assignment]
+                secret_value = str(secret.secret_value)
                 start = 0
                 while True:
                     pos = line.find(secret_value, start)

{cicaddy_github-0.3.2 → cicaddy_github-0.4.0}/tests/unit/test_agents.py

@@ -1,6 +1,10 @@
-"""Tests for dedent_code_blocks and strip_markdown_wrapper in agents module."""
+"""Tests for dedent_code_blocks, strip_markdown_wrapper, and extract_review_verdict."""
 
-from cicaddy_github.github_integration.agents import dedent_code_blocks, strip_markdown_wrapper
+from cicaddy_github.github_integration.agents import (
+    dedent_code_blocks,
+    extract_review_verdict,
+    strip_markdown_wrapper,
+)
 
 
 class TestDedentCodeBlocks:
@@ -111,3 +115,37 @@ class TestStripMarkdownWrapper:
         """A ```python wrapper is NOT stripped."""
         text = "```python\nprint('hi')\n```"
         assert strip_markdown_wrapper(text) == text
+
+
+class TestExtractReviewVerdict:
+    """Test extraction of review verdict from AI analysis output."""
+
+    def test_extracts_approve(self):
+        text = "Analysis looks good.\n<!-- VERDICT: APPROVE -->"
+        assert extract_review_verdict(text) == "APPROVE"
+
+    def test_extracts_request_changes(self):
+        text = "Found bugs.\n<!-- VERDICT: REQUEST_CHANGES -->"
+        assert extract_review_verdict(text) == "REQUEST_CHANGES"
+
+    def test_extracts_plain_verdict(self):
+        """Verdict without HTML comment wrapper."""
+        text = "Analysis.\nVERDICT: APPROVE"
+        assert extract_review_verdict(text) == "APPROVE"
+
+    def test_case_insensitive(self):
+        text = "Analysis.\n<!-- verdict: request_changes -->"
+        assert extract_review_verdict(text) == "REQUEST_CHANGES"
+
+    def test_defaults_to_comment(self):
+        """No verdict line returns COMMENT."""
+        text = "Just some analysis text without a verdict."
+        assert extract_review_verdict(text) == "COMMENT"
+
+    def test_verdict_with_leading_whitespace(self):
+        text = "Analysis.\n  <!-- VERDICT: APPROVE -->"
+        assert extract_review_verdict(text) == "APPROVE"
+
+    def test_verdict_in_middle_of_text(self):
+        text = "Start.\n<!-- VERDICT: REQUEST_CHANGES -->\nEnd."
+        assert extract_review_verdict(text) == "REQUEST_CHANGES"

{cicaddy_github-0.3.2 → cicaddy_github-0.4.0}/tests/unit/test_analyzer.py

@@ -261,6 +261,49 @@ class TestPostPRComment:
         mock_pr.create_issue_comment.assert_called_once()
 
 
+class TestSubmitPRReview:
+    """Test formal PR review submission."""
+
+    @pytest.mark.asyncio
+    async def test_submits_approve_review(self, analyzer, mock_github):
+        """Submits an APPROVE review via PyGithub."""
+        _, mock_repo = mock_github
+        mock_pr = MagicMock()
+        mock_repo.get_pull.return_value = mock_pr
+
+        await analyzer.submit_pr_review(42, "LGTM!", event="APPROVE")
+
+        mock_pr.create_review.assert_called_once_with(body="LGTM!", event="APPROVE")
+
+    @pytest.mark.asyncio
+    async def test_submits_request_changes_review(self, analyzer, mock_github):
+        """Submits a REQUEST_CHANGES review."""
+        _, mock_repo = mock_github
+        mock_pr = MagicMock()
+        mock_repo.get_pull.return_value = mock_pr
+
+        await analyzer.submit_pr_review(42, "Please fix.", event="REQUEST_CHANGES")
+
+        mock_pr.create_review.assert_called_once_with(body="Please fix.", event="REQUEST_CHANGES")
+
+    @pytest.mark.asyncio
+    async def test_submits_comment_review_by_default(self, analyzer, mock_github):
+        """Default event is COMMENT."""
+        _, mock_repo = mock_github
+        mock_pr = MagicMock()
+        mock_repo.get_pull.return_value = mock_pr
+
+        await analyzer.submit_pr_review(42, "Some feedback.")
+
+        mock_pr.create_review.assert_called_once_with(body="Some feedback.", event="COMMENT")
+
+    @pytest.mark.asyncio
+    async def test_rejects_invalid_event(self, analyzer):
+        """Invalid review event raises ValueError."""
+        with pytest.raises(ValueError, match="Invalid review event"):
+            await analyzer.submit_pr_review(42, "body", event="INVALID")
+
+
 class TestBuildUpdatedBody:
     """Test the history collapsing logic."""
 

{cicaddy_github-0.3.2 → cicaddy_github-0.4.0}/tests/unit/test_settings.py

@@ -174,3 +174,31 @@ class TestSettingsValidation:
 
             settings = load_settings()
             assert settings.post_pr_comment is True
+
+    def test_submit_review_default_false(self):
+        """SUBMIT_REVIEW defaults to False."""
+        env = {
+            "AI_PROVIDER": "gemini",
+            "AI_MODEL": "gemini-2.5-flash",
+            "MCP_SERVERS_CONFIG": "[]",
+        }
+        with patch.dict(os.environ, env, clear=False):
+            os.environ.pop("SUBMIT_REVIEW", None)
+            from cicaddy_github.config.settings import load_settings
+
+            settings = load_settings()
+            assert settings.submit_review is False
+
+    def test_submit_review_true(self):
+        """SUBMIT_REVIEW=true sets field to True."""
+        env = {
+            "SUBMIT_REVIEW": "true",
+            "AI_PROVIDER": "gemini",
+            "AI_MODEL": "gemini-2.5-flash",
+            "MCP_SERVERS_CONFIG": "[]",
+        }
+        with patch.dict(os.environ, env, clear=False):
+            from cicaddy_github.config.settings import load_settings
+
+            settings = load_settings()
+            assert settings.submit_review is True