chellow 1719570651.0.0__tar.gz → 1720526317.0.0__tar.gz

{chellow-1719570651.0.0 → chellow-1720526317.0.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: chellow
-Version: 1719570651.0.0
+Version: 1720526317.0.0
 Summary: Web Application for checking UK energy bills.
 Project-URL: Homepage, https://github.com/WessexWater/chellow
 Classifier: License :: OSI Approved :: GNU General Public License v3 (GPLv3)

chellow-1720526317.0.0/VERSION

@@ -0,0 +1 @@
+__version__ = "1720526317.0.0"

{chellow-1719570651.0.0 → chellow-1720526317.0.0}/chellow/reports/report_231.py

@@ -36,6 +36,9 @@ def content(user_id, start_date, finish_date, contract_id):
                 "energisation_status",
                 "gsp_group",
                 "dno",
+                "era_start",
+                "pc",
+                "meter_type",
                 "site_code",
                 "imp_is_substation",
                 "imp_llfc_code",
@@ -46,7 +49,8 @@ def content(user_id, start_date, finish_date, contract_id):
             ]
 
             bill_titles = contract_func(caches, contract, "virtual_bill_titles")()
-            writer.writerow(header_titles + bill_titles)
+            titles = header_titles + bill_titles
+            writer.writerow(titles)
             vb_func = contract_func(caches, contract, "virtual_bill")
 
             for era in (
@@ -77,34 +81,31 @@ def content(user_id, start_date, finish_date, contract_id):
                     exp_llfc_description = supply_source.llfc.description
                     imp_is_substation = imp_llfc_code = imp_llfc_description = None
 
-                out = [
-                    era.imp_mpan_core,
-                    era.exp_mpan_core,
-                    chunk_start,
-                    chunk_finish,
-                    supply_source.energisation_status_code,
-                    supply_source.gsp_group_code,
-                    supply_source.dno_code,
-                    era.get_physical_site(sess).code,
-                    imp_is_substation,
-                    imp_llfc_code,
-                    imp_llfc_description,
-                    exp_is_substation,
-                    exp_llfc_code,
-                    exp_llfc_description,
-                ]
+                out = {
+                    "imp_mpan_core": era.imp_mpan_core,
+                    "exp_mpan_core": era.exp_mpan_core,
+                    "start_date": chunk_start,
+                    "finish_date": chunk_finish,
+                    "energisation_status": supply_source.energisation_status_code,
+                    "gsp_group": supply_source.gsp_group_code,
+                    "dno": supply_source.dno_code,
+                    "era_start": era.start_date,
+                    "pc": supply_source.pc_code,
+                    "meter_type": supply_source.meter_type_code,
+                    "site_code": era.get_physical_site(sess).code,
+                    "imp_is_substation": imp_is_substation,
+                    "imp_llfc_code": imp_llfc_code,
+                    "imp_llfc_description": imp_llfc_description,
+                    "exp_is_substation": exp_is_substation,
+                    "exp_llfc_code": exp_llfc_code,
+                    "exp_llfc_description": exp_llfc_description,
+                }
                 vb_func(supply_source)
                 bill = supply_source.mop_bill
                 for title in bill_titles:
                     if title in bill:
-                        out.append(bill[title])
-                        del bill[title]
-                    else:
-                        out.append("")
-                for k in sorted(bill.keys()):
-                    out.append(k)
-                    out.append(bill[k])
-                writer.writerow(csv_make_val(v) for v in out)
+                        out[title] = bill[title]
+                writer.writerow(csv_make_val(out.get(t)) for t in titles)
 
                 sess.rollback()  # Avoid long-running transactions
     except BadRequest as e:

{chellow-1719570651.0.0 → chellow-1720526317.0.0}/chellow/reports/report_429.py

@@ -102,6 +102,7 @@ def content(g_batch_id, g_bill_id, g_contract_id, start_date, finish_date, user_
                     _process_g_bill_ids(
                         sess,
                         report_context,
+                        g_contract,
                         g_bill_ids,
                         forecast_date,
                         bill_titles,
@@ -122,6 +123,7 @@ def content(g_batch_id, g_bill_id, g_contract_id, start_date, finish_date, user_
 def _process_g_bill_ids(
     sess,
     report_context,
+    g_contract,
     g_bill_ids,
     forecast_date,
     bill_titles,
@@ -132,15 +134,24 @@ def _process_g_bill_ids(
     g_bill_id = list(sorted(g_bill_ids))[0]
     g_bill_ids.remove(g_bill_id)
     g_bill = sess.query(GBill).filter(GBill.id == g_bill_id).one()
-    problem = ""
     g_supply = g_bill.g_supply
+    vals = {
+        "covered_vat_gbp": Decimal("0.00"),
+        "covered_net_gbp": Decimal("0.00"),
+        "covered_gross_gbp": Decimal("0.00"),
+        "covered_kwh": Decimal(0),
+        "covered_start": g_bill.start_date,
+        "covered_finish": g_bill.finish_date,
+        "covered_bill_ids": [],
+        "virtual_problem": "",
+    }
     read_dict = defaultdict(set)
     for g_read in g_bill.g_reads:
         if not all(
             g_read.msn == era.msn
             for era in g_supply.find_g_eras(sess, g_read.prev_date, g_read.pres_date)
         ):
-            problem += (
+            vals["virtual_problem"] += (
                 f"The MSN {g_read.msn} of the register read {g_read.id} doesn't match "
                 f"the MSN of all the relevant eras."
             )
@@ -152,17 +163,9 @@ def _process_g_bill_ids(
             typ_set = read_dict[str(dt) + "-" + g_read.msn]
             typ_set.add(typ)
             if len(typ_set) > 1:
-                problem += f" Reads taken on {dt} have differing read types."
-
-    vals = {
-        "covered_vat_gbp": Decimal("0.00"),
-        "covered_net_gbp": Decimal("0.00"),
-        "covered_gross_gbp": Decimal("0.00"),
-        "covered_kwh": Decimal(0),
-        "covered_start": g_bill.start_date,
-        "covered_finish": g_bill.finish_date,
-        "covered_bill_ids": [],
-    }
+                vals[
+                    "virtual_problem"
+                ] += f" Reads taken on {dt} have differing read types."
 
     covered_primary_bill = None
     enlarged = True
@@ -270,12 +273,19 @@ def _process_g_bill_ids(
             or_(GEra.finish_date == null(), GEra.finish_date >= vals["covered_start"]),
         )
     ).scalars():
+        if g_era.g_contract != g_contract:
+            vals[
+                "virtual_problem"
+            ] += "The contract of the bill is different from the contract of the era."
+            continue
         site = (
             sess.query(Site)
             .join(SiteGEra)
             .filter(SiteGEra.is_physical == true(), SiteGEra.g_era == g_era)
             .one()
         )
+        vals["site_code"] = site.code
+        vals["site_name"] = site.name
 
         chunk_start = hh_max(vals["covered_start"], g_era.start_date)
         chunk_finish = hh_min(vals["covered_finish"], g_era.finish_date)
@@ -314,8 +324,6 @@ def _process_g_bill_ids(
     vals["bill_finish_date"] = g_bill.finish_date
     vals["mprn"] = g_supply.mprn
     vals["supply_name"] = g_supply.name
-    vals["site_code"] = site.code
-    vals["site_name"] = site.name
 
     for k, v in vals.items():
         if k == "covered_bill_ids":
@@ -332,9 +340,7 @@ def _process_g_bill_ids(
             except KeyError:
                 vals[title] = None
 
-    csv_writer.writerow(
-        [(vals.get(k) if vals.get(k) is not None else "") for k in titles]
-    )
+    csv_writer.writerow([csv_make_val(vals.get(k)) for k in titles])
 
 
 def do_get(sess):

{chellow-1719570651.0.0 → chellow-1720526317.0.0}/chellow/reports/report_81.py

@@ -37,13 +37,16 @@ def content(user_id, contract_id, end_year, end_month, months):
 
             bill_titles = contract_func(caches, contract, "virtual_bill_titles")()
             header_titles = [
-                "Import MPAN Core",
-                "Export MPAN Core",
-                "Start Date",
-                "Finish Date",
+                "imp_mpan_core",
+                "exp_mpan_core",
+                "start_date",
+                "finish_date",
                 "energisation_status",
                 "gsp_group",
                 "dno",
+                "era_start",
+                "pc",
+                "meter_type",
                 "site_code",
                 "imp_is_substation",
                 "imp_llfc_code",
@@ -55,7 +58,8 @@ def content(user_id, contract_id, end_year, end_month, months):
 
             vb_func = contract_func(caches, contract, "virtual_bill")
 
-            writer.writerow(header_titles + bill_titles)
+            titles = header_titles + bill_titles
+            writer.writerow(titles)
 
             for era in (
                 sess.query(Era)
@@ -86,36 +90,33 @@ def content(user_id, contract_id, end_year, end_month, months):
                     exp_llfc_description = supply_source.llfc.description
                     imp_is_substation = imp_llfc_code = imp_llfc_description = None
 
-                vals = [
-                    era.imp_mpan_core,
-                    era.exp_mpan_core,
-                    chunk_start,
-                    chunk_finish,
-                    supply_source.energisation_status_code,
-                    supply_source.gsp_group_code,
-                    supply_source.dno_code,
-                    era.get_physical_site(sess).code,
-                    imp_is_substation,
-                    imp_llfc_code,
-                    imp_llfc_description,
-                    exp_is_substation,
-                    exp_llfc_code,
-                    exp_llfc_description,
-                ]
+                vals = {
+                    "imp_mpan_core": era.imp_mpan_core,
+                    "exp_mpan_core": era.exp_mpan_core,
+                    "start_date": chunk_start,
+                    "finish_date": chunk_finish,
+                    "energisation_status": supply_source.energisation_status_code,
+                    "gsp_group": supply_source.gsp_group_code,
+                    "dno": supply_source.dno_code,
+                    "era_start": era.start_date,
+                    "pc": supply_source.pc_code,
+                    "meter_type": supply_source.meter_type_code,
+                    "site_code": era.get_physical_site(sess).code,
+                    "imp_is_substation": imp_is_substation,
+                    "imp_llfc_code": imp_llfc_code,
+                    "imp_llfc_description": imp_llfc_description,
+                    "exp_is_substation": exp_is_substation,
+                    "exp_llfc_code": exp_llfc_code,
+                    "exp_llfc_description": exp_llfc_description,
+                }
 
                 vb_func(supply_source)
                 bill = supply_source.dc_bill
 
                 for title in bill_titles:
-                    vals.append(bill.get(title))
-                    if title in bill:
-                        del bill[title]
+                    vals[title] = bill.get(title)
 
-                for k in sorted(bill.keys()):
-                    vals.append(k)
-                    vals.append(bill[k])
-
-                writer.writerow(csv_make_val(v) for v in vals)
+                writer.writerow(csv_make_val(vals.get(t)) for t in titles)
 
                 # Avoid long-running transactions
                 sess.rollback()

{chellow-1719570651.0.0 → chellow-1720526317.0.0}/chellow/reports/report_87.py

@@ -83,37 +83,32 @@ def _process_era(
             exp_llfc_description = data_source.llfc.description
             imp_is_substation = imp_llfc_code = imp_llfc_description = None
 
-        vals = [
-            data_source.mpan_core,
-            site.code,
-            site.name,
-            data_source.supplier_account,
-            data_source.start_date,
-            data_source.finish_date,
-            data_source.energisation_status_code,
-            data_source.gsp_group_code,
-            data_source.dno_code,
-            imp_is_substation,
-            imp_llfc_code,
-            imp_llfc_description,
-            exp_is_substation,
-            exp_llfc_code,
-            exp_llfc_description,
-        ]
+        vals = {
+            "mpan_core": data_source.mpan_core,
+            "site_code": site.code,
+            "site_name": site.name,
+            "account": data_source.supplier_account,
+            "from": data_source.start_date,
+            "to": data_source.finish_date,
+            "energisation_status": data_source.energisation_status_code,
+            "gsp_group": data_source.gsp_group_code,
+            "dno": data_source.dno_code,
+            "era_start": era.start_date,
+            "pc": data_source.pc_code,
+            "meter_type": data_source.meter_type_code,
+            "imp_is_substation": imp_is_substation,
+            "imp_llfc_code": imp_llfc_code,
+            "imp_llfc_description": imp_llfc_description,
+            "exp_is_substation": exp_is_substation,
+            "exp_llfc_code": exp_llfc_code,
+            "exp_llfc_description": exp_llfc_description,
+        }
 
         vb_func(data_source)
         bill = data_source.supplier_bill
         for title in bill_titles:
             if title in bill:
-                val = bill[title]
-                del bill[title]
-            else:
-                val = ""
-            vals.append(val)
-
-        for k in sorted(bill.keys()):
-            vals.append(k)
-            vals.append(str(bill[k]))
+                vals[title] = bill[title]
 
         return vals
 
@@ -163,6 +158,9 @@ def create_csv(f, sess, start_date, finish_date, contract_id):
         "energisation_status",
         "gsp_group",
         "dno",
+        "era_start",
+        "pc",
+        "meter_type",
         "imp_is_substation",
         "imp_llfc_code",
         "imp_llfc_description",
@@ -170,7 +168,8 @@ def create_csv(f, sess, start_date, finish_date, contract_id):
         "exp_llfc_code",
         "exp_llfc_description",
     ]
-    writer.writerow(header_titles + bill_titles)
+    titles = header_titles + bill_titles
+    writer.writerow(titles)
     vb_func = contract_func(caches, contract, "virtual_bill")
 
     for month_start, month_finish in month_pairs:
@@ -201,7 +200,7 @@ def create_csv(f, sess, start_date, finish_date, contract_id):
                     period_finish,
                     era,
                 )
-                writer.writerow(csv_make_val(v) for v in vals)
+                writer.writerow(csv_make_val(vals.get(t)) for t in titles)
             except BadRequest as e:
                 raise BadRequest(
                     f"Problem with {chellow.utils.url_root}eras/{era.id}/edit "

chellow-1720526317.0.0/test/reports/test_report_231.py

@@ -0,0 +1,291 @@
+import csv
+from io import StringIO
+
+from utils import match_tables
+
+from chellow.models import (
+    Comm,
+    Contract,
+    Cop,
+    DtcMeterType,
+    EnergisationStatus,
+    GspGroup,
+    MarketRole,
+    MeterPaymentType,
+    MeterType,
+    Mtc,
+    MtcLlfc,
+    MtcParticipant,
+    Participant,
+    Pc,
+    Site,
+    Source,
+    User,
+    UserRole,
+    VoltageLevel,
+    insert_comms,
+    insert_cops,
+    insert_dtc_meter_types,
+    insert_energisation_statuses,
+    insert_sources,
+    insert_voltage_levels,
+)
+from chellow.reports.report_231 import content
+from chellow.utils import ct_datetime, to_utc
+
+
+def test_content_no_supplies(mocker, sess):
+    vf = to_utc(ct_datetime(2000, 1, 1))
+    market_role_Z = MarketRole.insert(sess, "Z", "Non-core")
+    participant = Participant.insert(sess, "CALB", "AK Industries")
+    participant.insert_party(sess, market_role_Z, "None core", vf, None, None)
+    bank_holiday_rate_script = {"bank_holidays": []}
+    Contract.insert_non_core(
+        sess,
+        "bank_holidays",
+        "",
+        {},
+        vf,
+        None,
+        bank_holiday_rate_script,
+    )
+    market_role_M = MarketRole.insert(sess, "M", "HH Mop")
+    participant.insert_party(sess, market_role_M, "Fusion MOP", vf, None, None)
+    mop_charge_script = """
+from chellow.utils import reduce_bill_hhs
+
+def virtual_bill_titles():
+    return ['net-gbp', 'problem']
+
+def virtual_bill(ds):
+    for hh in ds.hh_data:
+        hh_start = hh['start-date']
+        bill_hh = ds.supplier_bill_hhs[hh_start]
+
+        bill_hh['net-gbp'] = sum(
+            v for k, v in bill_hh.items() if k.endswith('gbp'))
+
+    ds.mop_bill = reduce_bill_hhs(ds.supplier_bill_hhs)
+"""
+    mop_contract = Contract.insert_mop(
+        sess, "Fusion MOP 2000", participant, mop_charge_script, {}, vf, None, {}
+    )
+    editor = UserRole.insert(sess, "editor")
+    user = User.insert(sess, "admin@example.com", "xxx", editor, None)
+    user_id = user.id
+    sess.commit()
+
+    f = StringIO()
+    f.close = mocker.Mock()
+    mocker.patch("chellow.reports.report_231.open_file", return_value=f)
+    start_date = to_utc(ct_datetime(2020, 1, 1))
+    finish_date = to_utc(ct_datetime(2020, 1, 5))
+    content(user_id, start_date, finish_date, mop_contract.id)
+
+    f.seek(0)
+    sheet = csv.reader(f)
+    actual_table = list(sheet)
+    expected_table = [
+        [
+            "imp_mpan_core",
+            "exp_mpan_core",
+            "start_date",
+            "finish_date",
+            "energisation_status",
+            "gsp_group",
+            "dno",
+            "era_start",
+            "pc",
+            "meter_type",
+            "site_code",
+            "imp_is_substation",
+            "imp_llfc_code",
+            "imp_llfc_description",
+            "exp_is_substation",
+            "exp_llfc_code",
+            "exp_llfc_description",
+            "net-gbp",
+            "problem",
+        ],
+    ]
+    match_tables(expected_table, actual_table)
+
+
+def test_content_one_supply(mocker, sess):
+    vf = to_utc(ct_datetime(2000, 1, 1))
+    site = Site.insert(sess, "CI017", "Water Works")
+    market_role_Z = MarketRole.insert(sess, "Z", "Non-core")
+    participant = Participant.insert(sess, "CALB", "AK Industries")
+    participant.insert_party(sess, market_role_Z, "None core", vf, None, None)
+    bank_holiday_rate_script = {"bank_holidays": []}
+    Contract.insert_non_core(
+        sess,
+        "bank_holidays",
+        "",
+        {},
+        vf,
+        None,
+        bank_holiday_rate_script,
+    )
+    market_role_M = MarketRole.insert(sess, "M", "HH Mop")
+    market_role_R = MarketRole.insert(sess, "R", "Distributor")
+    market_role_C = MarketRole.insert(sess, "C", "HH Dc")
+    market_role_X = MarketRole.insert(sess, "X", "Supplier")
+    participant.insert_party(sess, market_role_M, "Fusion MOP", vf, None, None)
+    participant.insert_party(sess, market_role_C, "Fusion DC", vf, None, None)
+    participant.insert_party(sess, market_role_X, "Fusion Ltc", vf, None, None)
+    mop_charge_script = """
+from chellow.utils import reduce_bill_hhs
+
+def virtual_bill_titles():
+    return ['net-gbp', 'problem']
+
+def virtual_bill(ds):
+    for hh in ds.hh_data:
+        hh_start = hh['start-date']
+        bill_hh = ds.supplier_bill_hhs[hh_start]
+
+        bill_hh['net-gbp'] = sum(
+            v for k, v in bill_hh.items() if k.endswith('gbp'))
+
+    ds.mop_bill = reduce_bill_hhs(ds.supplier_bill_hhs)
+"""
+    mop_contract = Contract.insert_mop(
+        sess, "Fusion MOP 2000", participant, mop_charge_script, {}, vf, None, {}
+    )
+    dc_contract = Contract.insert_dc(
+        sess, "Fusion DC 2000", participant, "", {}, vf, None, {}
+    )
+    imp_supplier_contract = Contract.insert_supplier(
+        sess, "Fusion Supplier 2000", participant, "", {}, vf, None, {}
+    )
+
+    pc = Pc.insert(sess, "00", "hh", vf, None)
+    insert_cops(sess)
+    cop = Cop.get_by_code(sess, "5")
+    insert_comms(sess)
+    comm = Comm.get_by_code(sess, "GSM")
+    dno = participant.insert_party(sess, market_role_R, "WPD", vf, None, "22")
+    Contract.insert_dno(sess, dno.dno_code, participant, "", {}, vf, None, {})
+    meter_type = MeterType.insert(sess, "C5", "COP 1-5", vf, None)
+    meter_payment_type = MeterPaymentType.insert(sess, "CR", "Credit", vf, None)
+    mtc = Mtc.insert(sess, "845", False, True, vf, None)
+    mtc_participant = MtcParticipant.insert(
+        sess,
+        mtc,
+        participant,
+        "HH COP5 And Above With Comms",
+        False,
+        True,
+        meter_type,
+        meter_payment_type,
+        0,
+        vf,
+        None,
+    )
+    insert_voltage_levels(sess)
+    voltage_level = VoltageLevel.get_by_code(sess, "HV")
+    llfc = dno.insert_llfc(
+        sess, "510", "PC 5-8 & HH HV", voltage_level, False, True, vf, None
+    )
+    MtcLlfc.insert(sess, mtc_participant, llfc, vf, None)
+    insert_sources(sess)
+    source = Source.get_by_code(sess, "net")
+    gsp_group = GspGroup.insert(sess, "_L", "South Western")
+    insert_energisation_statuses(sess)
+    energisation_status = EnergisationStatus.get_by_code(sess, "E")
+    insert_dtc_meter_types(sess)
+    dtc_meter_type = DtcMeterType.get_by_code(sess, "H")
+    site.insert_e_supply(
+        sess,
+        source,
+        None,
+        "Bob",
+        vf,
+        None,
+        gsp_group,
+        mop_contract,
+        "773",
+        dc_contract,
+        "ghyy3",
+        "hgjeyhuw",
+        dno,
+        pc,
+        "845",
+        cop,
+        comm,
+        None,
+        energisation_status,
+        dtc_meter_type,
+        "22 7867 6232 781",
+        "510",
+        imp_supplier_contract,
+        "7748",
+        361,
+        None,
+        None,
+        None,
+        None,
+        None,
+    )
+
+    editor = UserRole.insert(sess, "editor")
+    user = User.insert(sess, "admin@example.com", "xxx", editor, None)
+    user_id = user.id
+    sess.commit()
+
+    f = StringIO()
+    f.close = mocker.Mock()
+    mocker.patch("chellow.reports.report_231.open_file", return_value=f)
+    start_date = to_utc(ct_datetime(2020, 1, 1))
+    finish_date = to_utc(ct_datetime(2020, 1, 5))
+    content(user_id, start_date, finish_date, mop_contract.id)
+
+    f.seek(0)
+    sheet = csv.reader(f)
+    actual_table = list(sheet)
+    expected_table = [
+        [
+            "imp_mpan_core",
+            "exp_mpan_core",
+            "start_date",
+            "finish_date",
+            "energisation_status",
+            "gsp_group",
+            "dno",
+            "era_start",
+            "pc",
+            "meter_type",
+            "site_code",
+            "imp_is_substation",
+            "imp_llfc_code",
+            "imp_llfc_description",
+            "exp_is_substation",
+            "exp_llfc_code",
+            "exp_llfc_description",
+            "net-gbp",
+            "problem",
+        ],
+        [
+            "22 7867 6232 781",
+            "",
+            "2020-01-01 00:00",
+            "2020-01-05 00:00",
+            "E",
+            "_L",
+            "22",
+            "2000-01-01 00:00",
+            "00",
+            "C5",
+            "CI017",
+            "False",
+            "510",
+            "PC 5-8 & HH HV",
+            "",
+            "",
+            "",
+            "0",
+            "",
+        ],
+    ]
+    match_tables(expected_table, actual_table)

{chellow-1719570651.0.0 → chellow-1720526317.0.0}/test/reports/test_report_429.py

@@ -53,10 +53,12 @@ def test_process_g_bill_ids(mocker):
     vbf = mocker.Mock()
     titles = []
     csv_writer = mocker.Mock()
+    g_contract = mocker.Mock()
 
     chellow.reports.report_429._process_g_bill_ids(
         sess,
         report_context,
+        g_contract,
         g_bill_ids,
         forecast_date,
         bill_titles,