check-msdefender 1.1.13__tar.gz → 1.1.15__tar.gz

{check_msdefender-1.1.13 → check_msdefender-1.1.15}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: check-msdefender
-Version: 1.1.13
+Version: 1.1.15
 Summary: A Nagios plugin for monitoring Microsoft Defender API endpoints
 Keywords: nagios,monitoring,microsoft,graph,api,azure
 Author-Email: ldvchosal <ldvchosal@github.com>
@@ -10,16 +10,17 @@ Classifier: Intended Audience :: System Administrators
 Classifier: License :: OSI Approved :: MIT License
 Classifier: Operating System :: OS Independent
 Classifier: Programming Language :: Python :: 3
-Classifier: Programming Language :: Python :: 3.9
 Classifier: Programming Language :: Python :: 3.10
 Classifier: Programming Language :: Python :: 3.11
+Classifier: Programming Language :: Python :: 3.12
+Classifier: Programming Language :: Python :: 3.13
 Classifier: Topic :: System :: Monitoring
 Classifier: Topic :: System :: Systems Administration
 Project-URL: Homepage, https://github.com/lduchosal/check_msdefender
 Project-URL: Bug Reports, https://github.com/lduchosal/check_msdefender/issues
 Project-URL: Source, https://github.com/lduchosal/check_msdefender
 Project-URL: Documentation, https://github.com/lduchosal/check_msdefender/blob/main/README.md
-Requires-Python: >=3.9
+Requires-Python: >=3.10
 Requires-Dist: nagiosplugin>=1.4.0
 Requires-Dist: azure-identity>=1.12.0
 Requires-Dist: click<9.0,>=8.0
@@ -27,7 +28,7 @@ Description-Content-Type: text/markdown
 
 # 🛡️ Check MS Defender
 
-[![Python Version](https://img.shields.io/badge/python-3.9+-blue.svg)](https://python.org)
+[![Python Version](https://img.shields.io/badge/python-3.10+-blue.svg)](https://python.org)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
 [![Build Status](https://img.shields.io/badge/build-passing-brightgreen.svg)](https://github.com/lduchosal/check_msdefender)
 

{check_msdefender-1.1.13 → check_msdefender-1.1.15}/README.md

@@ -1,6 +1,6 @@
 # 🛡️ Check MS Defender
 
-[![Python Version](https://img.shields.io/badge/python-3.9+-blue.svg)](https://python.org)
+[![Python Version](https://img.shields.io/badge/python-3.10+-blue.svg)](https://python.org)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
 [![Build Status](https://img.shields.io/badge/build-passing-brightgreen.svg)](https://github.com/lduchosal/check_msdefender)
 

{check_msdefender-1.1.13 → check_msdefender-1.1.15}/check_msdefender/__init__.py

@@ -1,4 +1,4 @@
 """Check Microsoft Defender API endpoints and check values - Nagios plugin."""
-__version__ = "1.1.13"
+__version__ = "1.1.15"
 __author__ = "ldvchosal"
 __email__ = "ldvchosa@github.com"

{check_msdefender-1.1.13 → check_msdefender-1.1.15}/check_msdefender/core/nagios.py

@@ -129,12 +129,9 @@ class NagiosPlugin:
                 DefenderSummary(details),
             )
 
-            # Set verbosity
-            check.verbosity = verbose
-
             # Run check and return exit code instead of exiting
             try:
-                check.main()
+                check.main(verbose=verbose)
                 return 0  # If main() doesn't exit, it's OK
             except SystemExit as e:
                 return int(e.code) if e.code is not None else 0

{check_msdefender-1.1.13 → check_msdefender-1.1.15}/check_msdefender/services/products_service.py

@@ -6,6 +6,7 @@ from datetime import datetime
 from check_msdefender.core.exceptions import ValidationError
 from check_msdefender.core.logging_config import get_verbose_logger
 
+
 class DetailObject:
     def __init__(self, software: str, data: str, score: int):
         self.software = software
@@ -13,6 +14,7 @@ class DetailObject:
         self.score = score
         self.paths: list[str] = []
 
+
 class ProductsService:
     """Service for checking installed products on machines."""
 
@@ -55,7 +57,7 @@ class ProductsService:
             product for product in all_products if product.get("deviceId") == target_machine_id
         ]
 
-        self.logger.info(f"Found {len(products)} CVE vulnerabilities for machine {target_dns_name}")
+        self.logger.info(f"Found {len(products)} vulnerabilities for machine {target_dns_name}")
 
         # Group vulnerabilities by software
         software_vulnerabilities = {}
@@ -80,7 +82,7 @@ class ProductsService:
                     "paths": set(),
                     "registryPaths": set(),
                     "max_cvss": 0,
-                    "severities": set(),
+                    "severities": [],
                 }
 
             cve_info = {"cve_id": cve_id, "severity": severity}
@@ -90,7 +92,7 @@ class ProductsService:
             software_vulnerabilities[software_key]["max_cvss"] = max(
                 software_vulnerabilities[software_key]["max_cvss"], cvss_score
             )
-            software_vulnerabilities[software_key]["severities"].add(severity)
+            software_vulnerabilities[software_key]["severities"].append(severity)
 
         # Count vulnerabilities by severity
         critical_count = 0
@@ -119,11 +121,9 @@ class ProductsService:
         details = []
         total_score = 0
         if software_vulnerabilities:
-            summary_line = f"{len(products)} total CVEs (Critical: {critical_count}, High: {high_count}, Medium: {medium_count}, Low: {low_count}), {len(vulnerable_software)} vulnerable software"
-            details.append(summary_line)
 
             detail_objects = []
-            
+
             # Add software details
             for software in list(software_vulnerabilities.values()):
                 score = 0
@@ -131,7 +131,15 @@ class ProductsService:
                 cve_count = len(software["cves"])
                 unique_cves = list(set(cve["cve_id"] for cve in software["cves"]))
                 cve_list = ", ".join(unique_cves[:5])  # Show first 5 CVEs
-                severities = ", ".join(software["severities"])  # Show first 5 CVEs
+                severities = ""
+                # Count severities
+                severity_counts = {"Critical": 0, "High": 0, "Medium": 0, "Low": 0}
+                for sev in software["severities"]:
+                    severity_counts[sev] += 1
+                severities = ", ".join(
+                    f"{key}: {value}" for key, value in severity_counts.items() if value > 0
+                )
+
                 for cve in software["cves"]:
                     severity = cve["severity"].lower()
                     if severity == "critical":
@@ -148,8 +156,8 @@ class ProductsService:
 
                 detail_object = DetailObject(
                     software=f"{software['name']} {software['version']} ({software['vendor']})",
-                    data=f"{score} ({cve_count}: {severities}) weaknesses ({cve_list})",
-                    score=score
+                    data=f"Score: {score}, CVEs: {cve_count} ({severities}), ({cve_list})",
+                    score=score,
                 )
 
                 total_score += score
@@ -159,7 +167,7 @@ class ProductsService:
                     detail_object.paths.append(f" - {path}")
 
                 # Indicate if more paths exist
-                if (len(software["paths"]) > 4):
+                if len(software["paths"]) > 4:
                     detail_object.paths.append(f" - .. (+{len(software['paths']) - 4} more)")
 
                 # Add registry paths if available (limit to 4)
@@ -167,19 +175,26 @@ class ProductsService:
                     detail_object.paths.append(f" - {registry_path}")
 
                 # Indicate if more registry paths exist
-                if (len(software["registryPaths"]) > 4):
-                    detail_object.paths.append(f" - .. (+{len(software['registryPaths']) - 4} more)")
+                if len(software["registryPaths"]) > 4:
+                    detail_object.paths.append(
+                        f" - .. (+{len(software['registryPaths']) - 4} more)"
+                    )
 
                 # Collect detail objects for sorting
                 detail_objects.append(detail_object)
 
+            summary_line = f"{len(vulnerable_software)} vulnerable products, score: {total_score}"
+            details.append(summary_line)
+            details.append("")
+
             # Sort detail objects by score descending
             detail_objects.sort(key=lambda x: x.score, reverse=True)
-            
+
             # Limit to top 10
             for detail_object in detail_objects[:10]:
-                details.append(f"{detail_object.software} {detail_object.data}")
+                details.append(f"{detail_object.software} - {detail_object.data}")
                 details.extend(detail_object.paths)
+                details.append("")
 
         # Determine the value based on severity:
         # - Critical vulnerabilities trigger critical threshold
@@ -198,9 +213,7 @@ class ProductsService:
         }
 
         self.logger.info(
-            f"Products analysis complete: {len(products)} total CVEs "
-            f"(Critical: {critical_count}, High: {high_count}, Medium: {medium_count}, Low: {low_count}), "
-            f"{len(vulnerable_software)} vulnerable software"
+            f"Products analysis complete: {len(vulnerable_software)} vulnerable products, score: {total_score}"
         )
         self.logger.method_exit("get_result", result)
         return result

{check_msdefender-1.1.13 → check_msdefender-1.1.15}/pyproject.toml

@@ -12,16 +12,17 @@ authors = [
 ]
 description = "A Nagios plugin for monitoring Microsoft Defender API endpoints"
 readme = "README.md"
-requires-python = ">=3.9"
+requires-python = ">=3.10"
 classifiers = [
     "Development Status :: 5 - Production/Stable",
     "Intended Audience :: System Administrators",
     "License :: OSI Approved :: MIT License",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
+    "Programming Language :: Python :: 3.12",
+    "Programming Language :: Python :: 3.13",
     "Topic :: System :: Monitoring",
     "Topic :: System :: Systems Administration",
 ]
@@ -38,7 +39,7 @@ dependencies = [
     "azure-identity>=1.12.0",
     "click>=8.0,<9.0",
 ]
-version = "1.1.13"
+version = "1.1.15"
 
 [project.license]
 text = "MIT"
@@ -128,7 +129,7 @@ composite = [
 [tool.black]
 line-length = 100
 target-version = [
-    "py39",
+    "py310",
 ]
 
 [tool.mypy]

{check_msdefender-1.1.13 → check_msdefender-1.1.15}/tests/fixtures/test_detail_service.py

@@ -81,6 +81,7 @@ class TestDetailServiceFixtures:
         """Test that all expected machine detail fields are present."""
         self.service.get_result(machine_id="test-machine-3")
         details = self.service.get_machine_details_json()
+        assert details is not None
         details_dict = json.loads(details)
 
         # Verify all expected fields from the documentation are present
@@ -122,6 +123,7 @@ class TestDetailServiceFixtures:
         details = self.service.get_machine_details_json()
 
         # Should be valid JSON
+        assert details is not None
         details_dict = json.loads(details)
         assert isinstance(details_dict, dict)