certora-cli-beta-mirror 8.2.0__tar.gz → 8.2.2__tar.gz

{certora_cli_beta_mirror-8.2.0/certora_cli_beta_mirror.egg-info → certora_cli_beta_mirror-8.2.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.2
 Name: certora-cli-beta-mirror
-Version: 8.2.0
+Version: 8.2.2
 Summary: Runner for the Certora Prover
 Home-page: https://pypi.org/project/certora-cli-beta-mirror
 Author: Certora
@@ -39,4 +39,4 @@ Dynamic: requires-dist
 Dynamic: requires-python
 Dynamic: summary
 
-Commit 03cec31.                    Build and Run scripts for executing the Certora Prover on Solidity smart contracts.
+Commit 04cd39e.                    Build and Run scripts for executing the Certora Prover on Solidity smart contracts.

certora_cli_beta_mirror-8.2.2/README.md

@@ -0,0 +1 @@
+Commit 04cd39e.                    Build and Run scripts for executing the Certora Prover on Solidity smart contracts.

{certora_cli_beta_mirror-8.2.0 → certora_cli_beta_mirror-8.2.2}/certora_cli/CertoraProver/certoraBuild.py

@@ -203,11 +203,18 @@ class PresetImmutableReference(ImmutableReference):
 # this function is Solidity specific.
 # todo: create certoraBuildUtilsSol.py file, where such solidity specific functions will be.
 def generate_finder_body(f: Func, internal_id: int, sym: int, compiler_collector: CompilerCollectorSol,
-                         compressed: bool = False) -> Optional[Tuple[List[int], str]]:
+                         compressed: bool = False,
+                         should_generate_inlining: bool = True) -> Optional[Tuple[List[int], str]]:
     if compressed:
         return generate_compressed_finder(
             f, internal_id, sym, compiler_collector
         )
+    elif not should_generate_inlining:
+        # We should not generate inlining as reported in CERT-9399, only when compressed=False.
+        # used_symbols is being generated the exact same way as in generate_full_finder
+        used_symbols = [i for i in range(len(f.fullArgs))]
+        return used_symbols, ''
+
     else:
         return generate_full_finder(
             f, internal_id, sym, compiler_collector
@@ -403,8 +410,9 @@ def get_modifier_param_type_name(ind: int, def_node: Dict[str, Any], f: Func) ->
 
 def generate_modifier_finder(f: Func, internal_id: int, sym: int,
                              compiler_collector: CompilerCollectorSol, def_node: Dict[str, Any],
-                             compress: bool) -> Optional[Tuple[str, str]]:
-    compressed = generate_finder_body(f, internal_id, sym, compiler_collector, compressed=compress)
+                             compress: bool, should_generate_inlining: bool) -> Optional[Tuple[str, str]]:
+    compressed = generate_finder_body(f, internal_id, sym, compiler_collector, compressed=compress,
+                                      should_generate_inlining=should_generate_inlining)
     if compressed is None:
         return None
     modifier_name = f"logInternal{internal_id}"
@@ -427,9 +435,10 @@ def generate_modifier_finder(f: Func, internal_id: int, sym: int,
         return f'{modifier_name}({",".join(arg_strings)})', modifier_body
 
 
-def generate_inline_finder(f: Func, internal_id: int, sym: int,
-                           compiler_collector: CompilerCollectorSol, should_compress: bool) -> Optional[str]:
-    finder = generate_finder_body(f, internal_id, sym, compiler_collector, compressed=should_compress)
+def generate_inline_finder(f: Func, internal_id: int, sym: int, compiler_collector: CompilerCollectorSol,
+                           should_compress: bool, should_generate_inlining: bool) -> Optional[str]:
+    finder = generate_finder_body(f, internal_id, sym, compiler_collector, compressed=should_compress,
+                                  should_generate_inlining=should_generate_inlining)
     if finder is None:
         return None
     return finder[1]
@@ -2448,6 +2457,19 @@ class CertoraBuildGenerator:
                     # (deprecate this option later)
                     should_compress = self.context.function_finder_mode == Vf.FunctionFinderMode.DEFAULT.name
 
+                if self.context.solc_optimize and self.get_solc_via_ir_value(Path(contract_file)) and \
+                   any(param_name == "" for param_name in f.paramNames):
+                    # As reported in CERT-9399, we should not generate function finder for this edge case
+
+                    instrumentation_logger.warning(f"Failed to generate auto finder for {f.name} @ {f.where()}.")
+                    instrumentation_logger.warning(
+                        "Cannot apply summaries for internal functions with unnamed argument when compiling "
+                        "using solc_optimize and solc_via_ir"
+                    )
+                    should_generate_inlining = False
+                else:
+                    should_generate_inlining = True
+
                 if len(mods) > 0:
                     # we need to add the instrumentation in a modifer because solidity modifiers will (potentially)
                     # appear before any instrumentation we add to the literal source body, which will tank the detection
@@ -2459,8 +2481,10 @@ class CertoraBuildGenerator:
                     # where in the source such modifiers will go. In order to insert a modifier, we have to have at
                     # least one modifier already present, and then insert before the first modifier's location in the
                     # source code
-                    mod_inst = generate_modifier_finder(f, internal_id, function_symbol, sdc.compiler_collector,
-                                                        def_node, compress=should_compress)
+                    mod_inst = generate_modifier_finder(
+                        f, internal_id, function_symbol, sdc.compiler_collector, def_node,
+                        compress=should_compress, should_generate_inlining=should_generate_inlining
+                    )
                     if mod_inst is None:
                         instrumentation_logger.debug(f"Modifier generation for {f.name} @ {f.where()} failed")
                         return None
@@ -2494,8 +2518,8 @@ class CertoraBuildGenerator:
                     per_file_inst[first_mod_offset] = Instrumentation(expected=bytes(modifier_name[0:1], "utf-8"),
                                                                       to_ins=modifier_invocation, mut=InsertBefore())
                 else:
-                    finder_res = generate_inline_finder(f, internal_id, function_symbol,
-                                                        sdc.compiler_collector, should_compress)
+                    finder_res = generate_inline_finder(f, internal_id, function_symbol, sdc.compiler_collector,
+                                                        should_compress, should_generate_inlining)
                     if finder_res is None:
                         instrumentation_logger.debug(f"Generating auto finder for {f.name} @ {f.where()}"
                                                      f" failed, giving up generation")
@@ -2676,7 +2700,7 @@ class CertoraBuildGenerator:
                     Ctx.run_local_spec_check(False, context, ["-listCalls",  tmp_file.name], print_errors=False)
                     spec_calls = tmp_file.read().split("\n")
                 except Exception as e:
-                    instrumentation_logger.warning(f"Failed to get calls from spec\n{e}")
+                    instrumentation_logger.debug(f"Failed to get calls from spec\n{e}")
 
         self.context.remappings = []
         for i, build_arg_contract_file in enumerate(sorted(self.input_config.sorted_files)):
@@ -3938,7 +3962,7 @@ def build_from_cache_or_scratch(context: CertoraContext,
                 if output:
                     internal_calls = output.split("\n")
             except Exception as e:
-                instrumentation_logger.warning(f"Failed to get calls from spec\n{e}")
+                instrumentation_logger.debug(f"Failed to get calls from spec\n{e}")
 
             if internal_calls:
                 build_logger.info("Found new internal calls in the spec file, need to recompile anyway")
@@ -3989,9 +4013,6 @@ def build(context: CertoraContext, ignore_spec_syntax_check: bool = False) -> No
         if Cv.mode_has_spec_file(context) and not context.build_only and not ignore_spec_syntax_check:
             if Ctx.should_run_local_speck_check(context):
                 Ctx.run_local_spec_check(False, context)
-            else:
-                build_logger.warning(
-                    "Local checks of CVL specification files disabled. It is recommended to enable the checks.")
 
         should_save_cache, cached_files = build_from_cache_or_scratch(context,
                                                                       certora_build_generator,

{certora_cli_beta_mirror-8.2.0 → certora_cli_beta_mirror-8.2.2}/certora_cli/CertoraProver/certoraContext.py

@@ -523,7 +523,15 @@ def __rename_key(context: CertoraContext, old_key: str, new_key: str) -> None:
 
 
 def should_run_local_speck_check(context: CertoraContext) -> bool:
-    return not (context.disable_local_typechecking or Util.is_ci_or_git_action())
+    output = context.compilation_steps_only or not (context.disable_local_typechecking or Util.is_ci_or_git_action())
+    if not output:
+        if context.disable_local_typechecking:
+            context_logger.warning(
+                "Local checks of CVL specification files disabled. It is recommended to enable the checks."
+            )
+        else:
+            context_logger.info("Local checks of CVL specification files skipped in CI and will run remotely.")
+    return output
 
 
 def run_typechecker(typechecker_name: str, with_typechecking: bool, args: List[str], print_errors: bool) -> None:
@@ -550,18 +558,13 @@ def run_typechecker(typechecker_name: str, with_typechecking: bool, args: List[s
     context_logger.debug(f"typechecking cmd: {' '.join(cmd_str_list)}")
 
     exit_code = Util.run_jar_cmd(cmd_str_list, False,
-                                 custom_error_message="Failed to run Certora Prover locally. Please check the errors "
-                                                      "below for problems in the specifications (.spec files) or the "
-                                                      "prover_args defined in the .conf file.",
+                                 custom_error_message="Failed to run Certora Prover typechecker locally.\n"
+                                                      "Please check the errors below for problems in the specifications"
+                                                      " (.spec files) or the prover_args defined in the .conf file.",
                                  logger_topic="type_check",
                                  print_err=print_errors)
     if exit_code != 0:
-        raise Util.CertoraUserInputError(
-            "CVL syntax or type check failed.\n Please fix the issue. "
-            "Using --disable_local_typechecking to skip this check is strongly discouraged, "
-            "as simple syntax errors will only be detected during the cloud run."
-            "with --disable_local_typechecking is not recommended is not recommended as "
-            "simple syntax failures will be visible only on the cloud run.")
+        raise Util.CertoraUserInputError("CVL syntax or type check failed, please fix the issue.")
 
 
 def run_local_spec_check(with_typechecking: bool, context: CertoraContext, extra_args: List[str] = list(), print_errors: bool = True) -> None:

{certora_cli_beta_mirror-8.2.0 → certora_cli_beta_mirror-8.2.2}/certora_cli/Mutate/mutateValidate.py

@@ -69,10 +69,18 @@ class MutateValidator:
                 except Exception as e:
                     raise Util.CertoraUserInputError(f"Invalid file_to_mutate in manual mutant: {mutant[Constants.FILE_TO_MUTATE]}", e)
 
-                try:
-                    Vf.validate_dir(mutant[Constants.MUTANTS_LOCATION])
-                except Exception as e:
-                    raise Util.CertoraUserInputError(f"Invalid mutants location {mutant[Constants.MUTANTS_LOCATION]}", e)
+                mutants_location = mutant[Constants.MUTANTS_LOCATION]
+                if Path(mutants_location).is_dir():
+                    try:
+                        Vf.validate_dir(mutants_location)
+                    except Exception as e:
+                        raise Util.CertoraUserInputError(f"Invalid directory for mutants location {mutants_location}",
+                                                         e)
+                else:
+                    try:
+                        Vf.validate_readable_file(mutants_location, Util.SOL_EXT)
+                    except Exception as e:
+                        raise Util.CertoraUserInputError(f"Invalid file for mutants location {mutants_location}", e)
 
     def mutation_attribute_in_prover(self) -> None:
         gambit_attrs = ['filename', 'contract', 'functions', 'seed', 'num_mutants']

{certora_cli_beta_mirror-8.2.0 → certora_cli_beta_mirror-8.2.2}/certora_cli/certoraRun.py

@@ -132,10 +132,6 @@ def run_certora(args: List[str], app: Type[App.CertoraApp] = App.EvmApp,
                 Ctx.run_local_spec_check(True, context)
                 typechecking_end = time.perf_counter()
                 timings['typecheckingTime'] = round(typechecking_end - typechecking_start, 4)
-            else:
-                run_logger.warning(
-                    "Local checks of CVL specification files disabled. It is recommended to enable "
-                    "the checks.")
 
         # Remove debug logger and run remote verification
         logging_manager.remove_debug_logger()

{certora_cli_beta_mirror-8.2.0 → certora_cli_beta_mirror-8.2.2/certora_cli_beta_mirror.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.2
 Name: certora-cli-beta-mirror
-Version: 8.2.0
+Version: 8.2.2
 Summary: Runner for the Certora Prover
 Home-page: https://pypi.org/project/certora-cli-beta-mirror
 Author: Certora
@@ -39,4 +39,4 @@ Dynamic: requires-dist
 Dynamic: requires-python
 Dynamic: summary
 
-Commit 03cec31.                    Build and Run scripts for executing the Certora Prover on Solidity smart contracts.
+Commit 04cd39e.                    Build and Run scripts for executing the Certora Prover on Solidity smart contracts.

{certora_cli_beta_mirror-8.2.0 → certora_cli_beta_mirror-8.2.2}/certora_cli_beta_mirror.egg-info/SOURCES.txt

@@ -40,7 +40,6 @@ certora_cli/CertoraProver/certoraProjectScanner.py
 certora_cli/CertoraProver/certoraSourceFinders.py
 certora_cli/CertoraProver/certoraType.py
 certora_cli/CertoraProver/certoraVerifyGenerator.py
-certora_cli/CertoraProver/concordance.py
 certora_cli/CertoraProver/erc7201.py
 certora_cli/CertoraProver/splitRules.py
 certora_cli/CertoraProver/storageExtension.py

certora_cli_beta_mirror-8.2.2/certora_jars/CERTORA-CLI-VERSION-METADATA.json

@@ -0,0 +1 @@
+{"name": "certora-cli-beta-mirror", "tag": "8.2.2", "branch": "", "commit": "04cd39e", "timestamp": "20250904.12.49.982490", "version": "8.2.2"}

{certora_cli_beta_mirror-8.2.0 → certora_cli_beta_mirror-8.2.2}/setup.py

@@ -3,11 +3,11 @@ import setuptools
 
 setuptools.setup(
     name="certora-cli-beta-mirror",
-    version="8.2.0",
+    version="8.2.2",
     author="Certora",
     author_email="support@certora.com",
     description="Runner for the Certora Prover",
-    long_description="Commit 03cec31.                    Build and Run scripts for executing the Certora Prover on Solidity smart contracts.",
+    long_description="Commit 04cd39e.                    Build and Run scripts for executing the Certora Prover on Solidity smart contracts.",
     long_description_content_type="text/markdown",
     url="https://pypi.org/project/certora-cli-beta-mirror",
     packages=setuptools.find_packages(),

certora_cli_beta_mirror-8.2.0/README.md

@@ -1 +0,0 @@
-Commit 03cec31.                    Build and Run scripts for executing the Certora Prover on Solidity smart contracts.